will automatically issue a change MTU request.
Fix this by not processing fatal error reset if CRQ is passively
initialized after client-driven CRQ initialization fails.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
On 4/28/20 10:35 AM, Thomas Falcon wrote:
> On 4/27/20 12:33 PM, Juliet Kim wrote:
>> The maximum entries for H_SEND_SUB_CRQ_INDIRECT has increased on
>> some platforms from 16 to 128. If Live Partition Mobility is used
>> to migrate a running OS image from a newer source pl
queued.
Fix this by falling back to 16 entries if H_PARAMETER is returned
from the hcall().
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index
-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 24 ++--
drivers/net/ethernet/ibm/ibmvnic.h | 6 +-
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index c75239d8820f
-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 24 ++--
drivers/net/ethernet/ibm/ibmvnic.h | 6 +-
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index c75239d8820f
-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 24 ++--
drivers/net/ethernet/ibm/ibmvnic.h | 6 +-
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index c75239d8820f
This reverts commit 11d49ce9f7946dfed4dcf5dbde865c78058b50ab
(???net/ibmvnic: Fix EOI when running in XIVE mode.???) since that
has the unintended effect of changing the interrupt priority
and emits warning when running in legacy XICS mode.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm
for both XICS and
XIVE.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index 2b073a3..0686ded 100644
--- a/drivers/net/ethernet/ibm
XIVE mode
Juliet Kim (2):
net/ibmvnic: Revert "net/ibmvnic: Fix EOI when running in XIVE mode"
net/ibmvnic: Ignore H_FUNCTION return from H_EOI to tolerate XIVE mode
drivers/net/ethernet/ibm/ibmvnic.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
--
1.8.3.1
This reverts commit 11d49ce9f7946dfed4dcf5dbde865c78058b50ab
(???net/ibmvnic: Fix EOI when running in XIVE mode.???) since that
has the unintended effect of changing the interrupt priority
and emits warning when running in legacy XICS mode.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm
for both XICS and
XIVE.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index 2b073a3..0686ded 100644
--- a/drivers/net/ethernet/ibm
XIVE mode
Juliet Kim (2):
Revert "net/ibmvnic: Fix EOI when running in XIVE mode"
net/ibmvnic: Ignore H_FUNCTION return from H_EOI to tolerate XIVE mode
drivers/net/ethernet/ibm/ibmvnic.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
--
1.8.3.1
The current code allows more than one thread to run in reset. This can
corrupt struct adapter data. Check adapter->resetting before performing
a reset, if there is another reset running delay (100 msec) before trying
again.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvni
e to allow linkwatch_event to grab the RTNL lock
and run during the reset.
Fixes: a5681e20b541 ("net/ibmnvic: Fix deadlock problem in reset")
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 224 ++---
drivers/net/ethernet/ibm/ibmvni
- Remove setting wait_for_reset to false from __ibmvnic_reset(), this
is done in wait_for_reset()
- Move the check for force_reset_recovery from patch 1 to patch 2
v3:
- Restore reset’s successful return in open failure case
v4:
- Change resetting flag access to atomic
Juliet Kim (2):
net/ibmvnic
On 9/18/19 1:12 AM, Michael Ellerman wrote:
> Hi Juliet,
>
> Juliet Kim writes:
>> Signed-off-by: Juliet Kim
>> ---
>> drivers/net/ethernet/ibm/ibmvnic.c | 23 ++-
>> drivers/net/ethernet/ibm/ibmvnic.h | 3 +++
>> 2 file
I sent v3. Please disregard v2.
On 9/17/19 9:52 AM, Juliet Kim wrote:
> This series includes two fixes. The first improves reset code to allow
> linkwatch_event to proceed during reset. The second ensures that no more
> than one thread runs in reset at a time.
>
> v2:
>
setting wait_for_reset to false from __ibmvnic_reset(), this
is done in wait_for_reset()
- Move the check for force_reset_recovery from patch 1 to patch 2
v3:
- Restore reset’s successful return in open failure case
Juliet Kim (2):
net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can
e to allow linkwatch_event to grab the RTNL lock
and run during the reset.
Fixes: a5681e20b541 ("net/ibmnvic: Fix deadlock problem in reset")
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 224 ++---
drivers/net/ethernet/ibm/ibmvnic.h | 1 +
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 23 ++-
drivers/net/ethernet/ibm/ibmvnic.h | 3 +++
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index ba340aaff1b3
The current code allows more than one thread to run in reset. This can
corrupt struct adapter data. Check adapter->resetting before performing
a reset, if there is another reset running delay (100 msec) before trying
again.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvni
e to allow linkwatch_event to grab the RTNL lock
and run during the reset.
Fixes: a5681e20b541 ("net/ibmnvic: Fix deadlock problem in reset")
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 223 ++---
drivers/net/ethernet/ibm/ibmvni
- Remove setting wait_for_reset to false from __ibmvnic_reset(), this
is done in wait_for_reset()
- Move the check for force_reset_recovery from patch 1 to patch 2
Juliet Kim (2):
net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can run
net/ibmvnic: prevent more than one thread from
; queue")
> Signed-off-by: Michal Suchanek
Reviewed-by: Juliet Kim
> ---
> drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
> b/drivers/net/ethernet/ibm/ibmvnic.c
> index
ly.
Fixes: 36f1031c51a2 ("ibmnvic: Do not process reset during or after
device removal”)
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/
ly.
Fixes: 36f1031c51a2 ("ibmnvic: Do not process reset during or after
device removal”)
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/
e to allow linkwatch_event to grab the RTNL lock
and run during the reset.
Fixes: a5681e20b541 ("net/ibmnvic: Fix deadlock problem in reset")
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 144 +++--
1 file changed, 108 inserti
The current code allows more than one thread to run in reset. This can
corrupt struct adapter data. Check adapter->resetting before performing
a reset, if there is another reset running delay (100 msec) before trying
again.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvni
On 6/26/19 6:51 PM, Nathan Lynch wrote:
> Hi Juliet,
>
> Juliet Kim writes:
>> On 6/25/19 12:29 PM, Nathan Lynch wrote:
>>> Juliet Kim writes:
>>>> However, that fix failed to notify Hypervisor that the LPM attempted
>>>> had been abandoned whic
On 6/27/19 12:01 AM, Michael Ellerman wrote:
> Juliet Kim writes:
>> On 6/25/19 1:51 PM, Nathan Lynch wrote:
>>> Juliet Kim writes:
>>>
>>>> There's some concern this could retry forever, resulting in live lock.
>>> First of all the s
On 6/25/19 12:29 PM, Nathan Lynch wrote:
> Juliet Kim writes:
>> The commit
>> (“powerpc/rtas: Fix a potential race between CPU-Offline & Migration)
>> attempted to fix a hang in Live Partition Mobility(LPM) by abandoning
>> the LPM attempt if a race between LPM
On 6/25/19 1:51 PM, Nathan Lynch wrote:
> Juliet Kim writes:
>
>> There's some concern this could retry forever, resulting in live lock.
> First of all the system will make progress in other areas even if there
> are repeated retries; we're not indefinitely holding l
LPM attempted
had been abandoned which results in a system hang.
Fix this by sending a signal PHYP to cancel the migration, so that PHYP
can stop waiting, and clean up the migration.
Fixes: dfd718a2ed1f ("powerpc/rtas: Fix a potential race between CPU-Offline &
Migration")
Signed-
There's some concern this could retry forever, resulting in live lock.
Another approach would be to abandon the attempt and fail the LPM
request.
https://lists.ozlabs.org/pipermail/linuxppc-dev/2019-June/192531.html
On 6/24/19 12:23 PM, Nathan Lynch wrote:
Hi Mingming,
mmc writes:
On 2019
>From 1bd2bf7146876e099eafb292668f9a12dc22f526 Mon Sep 17 00:00:00 2001
From: Juliet Kim
Date: Mon, 24 Jun 2019 17:17:46 -0400
Subject: [PATCH 1/1] powerpc/rtas: Fix hang in race against concurrent cpu
offline
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encod
Hi Nathan,
On 5/6/19 12:14 PM, Nathan Lynch wrote:
Hi Juliet,
Juliet Kim writes:
Fix extending start/stop topology update scope during LPM
Commit 65b9fdadfc4d ("powerpc/pseries/mobility: Extend start/stop
topology update scope") made the change to the duration that
topology u
e property update notifier
unregistered until device tree update completes. This prevents
topology update during LPM.
Instead, use mutex_lock, which serializes LPM and PRRN operation
in pseries_devicetree_update.
Signed-off-by: Juliet Kim
arch/powerpc/platforms/pseries/mobil
e property update notifier
unregistered until device tree update completes. This prevents
topology update during LPM.
Instead, use mutex_lock, which serializes LPM and PRRN operation
in pseries_devicetree_update.
Signed-off-by: Juliet Kim
arch/powerpc/platforms/pseries/mobil
e property update notifier
unregistered until device tree update completes. This prevents
topology update during LPM.
Instead, use mutex_lock, which serializes LPM and PRRN operation
in pseries_devicetree_update.
Signed-off-by: Juliet Kim
arch/powerpc/platforms/pseries/mobil
now setting the number of tx/rx queues during a soft reset
for failover or LPM events.
Signed-off-by: Juliet Kim
---
drivers/net/ethernet/ibm/ibmvnic.c | 59 +---
drivers/net/ethernet/ibm/ibmvnic.h |2 +
2 files changed, 22 insertions(+), 39 deletions(-)
diff
Subject: [PATCH] net/ibmnvic: Fix deadlock problem in reset
From: Juliet Kim
This patch changes to use rtnl_lock only during a reset to avoid
deadlock that could occur when a thread operating close is holding
rtnl_lock and waiting for reset_lock acquired by another thread,
which is waiting for
41 matches
Mail list logo
