Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Jon Mason
On Mon, Oct 07, 2013 at 08:38:45PM +0200, Alexander Gordeev wrote: > On Mon, Oct 07, 2013 at 09:50:57AM -0700, Jon Mason wrote: > > On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > > > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > > &

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Jon Mason
On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > --- > > > dri

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-04 Thread Jon Mason
On Thu, Oct 03, 2013 at 10:46:21PM +0100, Ben Hutchings wrote: > On Wed, 2013-10-02 at 17:39 -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > > Since you ar

Re: [PATCH RFC 55/77] ntb: Update MSI/MSI-X interrupts enablement code

2013-10-04 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:11PM +0200, Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gorde

Re: [PATCH RFC 53/77] ntb: Fix missed call to pci_enable_msix()

2013-10-04 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:09PM +0200, Alexander Gordeev wrote: > Current MSI-X enablement code assumes MSI-Xs were successfully > allocated in case less than requested vectors were available. > That assumption is wrong, since MSI-Xs should be enabled with > a repeated call to pci_enable_msix().

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-04 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev Since you are changing the behavior of the msix_capability_init function on populate_msi_sysfs error, a comment describing why in this commit would be nice. > --- > drivers/pci/msi.c | 11 +++

Re: [PATCH RFC 77/77] vxge: Update MSI/MSI-X interrupts enablement code

2013-10-04 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:33PM +0200, Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gorde

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-04 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev > --- > drivers/ntb/ntb_hw.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index de2062c..eccd5e5 100644 > --- a/dr

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-05 Thread Jon Mason
On Tue, Jul 5, 2011 at 10:41 AM, Richard A Lary wrote: > On 7/1/2011 1:00 PM, Richard A Lary wrote: >> >> On 7/1/2011 12:02 PM, Jon Mason wrote: >>> >>> On Fri, Jul 1, 2011 at 1:30 PM, Richard A Lary >>> wrote: >>>> >>>> On 7/

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-01 Thread Jon Mason
On Fri, Jul 1, 2011 at 1:30 PM, Richard A Lary wrote: > On 7/1/2011 8:24 AM, Jon Mason wrote: >> >> I recently sent out a number of patches to migrate drivers calling >> `pci_find_capability(pdef, PCI_CAP_ID_EXP)` to pci_pcie_cap.  This >> function takes uses a PCI-E

pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-01 Thread Jon Mason
I recently sent out a number of patches to migrate drivers calling `pci_find_capability(pdef, PCI_CAP_ID_EXP)` to pci_pcie_cap. This function takes uses a PCI-E capability offset that was determined by calling pci_find_capability during the PCI bus walking. In response to one of the patches, Jame