- "Stephen Rothwell" wrote:
> Hi John,
>
> On Thu, 10 Jun 2010 13:03:00 +0200 John Kacur
> wrote:
> >
> > From: Amit Shah
> >
> > Alan pointed out a race in the code where hvc_remove is invoked.
> The
> > recent virtio_console wor
From: Amit Shah
Alan pointed out a race in the code where hvc_remove is invoked. The
recent virtio_console work is the first user of hvc_remove().
Alan describes it thus:
The hvc_console assumes that a close and remove call can't occur at the
same time.
In addition tty_hangup(tty) is problemat
On Wed, 21 Oct 2009, Frederic Weisbecker wrote:
> On Wed, Oct 21, 2009 at 11:33:17PM +0200, John Kacur wrote:
> > > Should we better pushdown default_llseek to every to every
> > > file operations that don't implement llseek?
> > > I don't know how many
On Wed, 21 Oct 2009, Frederic Weisbecker wrote:
> On Wed, Oct 21, 2009 at 11:07:18PM +0200, John Kacur wrote:
> > From 0c2b412cdccf73bdeb19bb866bfe556942eaeca2 Mon Sep 17 00:00:00 2001
> > From: John Kacur
> > Date: Wed, 21 Oct 2009 23:01:12 +0200
> > Subject: [PATCH
>From 0c2b412cdccf73bdeb19bb866bfe556942eaeca2 Mon Sep 17 00:00:00 2001
From: John Kacur
Date: Wed, 21 Oct 2009 23:01:12 +0200
Subject: [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd
Now that we've removed the BKL here, let's explicitly set lleek to no_llseek
On Sun, 11 Oct 2009, Alan Cox wrote:
> > There were 4 checkpatch errors on this patch, all of the type
> > ERROR: spaces required around that '=' (ctx:WxO)
> > #1466: FILE: drivers/macintosh/ans-lcd.c:112:
> > + ret =-EACCES;
>
> Here's a suggestion. If a few spaces bug you th
On Sat, 10 Oct 2009, Thomas Gleixner wrote:
> The ans-lcd driver got the cycle_kernel_lock() in anslcd_open() from
> the BKL pushdown and it still uses the locked ioctl.
>
> The BKL serialization in this driver is more than obscure and
> definitely does not cover all possible corner cases. Prot
