Re: [PATCH 2/2] [POWERPC] uprobes: powerpc port

2012-06-06 Thread Jim Keniston
On Wed, 2012-06-06 at 15:05 +0530, Ananth N Mavinakayanahalli wrote: > On Wed, Jun 06, 2012 at 11:27:02AM +0200, Peter Zijlstra wrote: > > On Wed, 2012-06-06 at 14:51 +0530, Ananth N Mavinakayanahalli wrote: > > > One TODO in this port compared to x86 is the uprobe abort_xol() logic. > > > x86 depe

Re: [PATCH] powerpc/nvram: Add spinlock to oops_to_nvram to prevent oops in compression code.

2011-12-01 Thread Jim Keniston
king up if the NVRAM > code oopses. This means we might miss multiple CPUs oopsing at exactly > the same time but I think it's best to play it safe for now. Once we > are happy with the reliability we can change it to a full spinlock. > > Signed-off-by: Anton Blanchard Acked-by

[PATCH] powerpc/nvram: Add compression to fit more oops output into NVRAM

2011-07-25 Thread Jim Keniston
Capture more than twice as much text from the printk buffer, and compress it to fit it in the lnx,oops-log NVRAM partition. You can view the compressed text using the new (as of July 20) --unzip option of the nvram command in the powerpc-utils package. Signed-off-by: Jim Keniston --- arch

[PATCH] nvram: Don't overwrite oops/panic report on normal shutdown

2011-03-25 Thread Jim Keniston
For normal halt, reboot, and poweroff events, refrain from overwriting the lnx,oops-log partition. Also, don't save the dmesg buffer on an emergency-restart event if we've already saved it earlier in panic(). Signed-off-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvra

Re: [PATCH 2/6] nvram: Capture oops/panic reports in ibm, oops-log partition

2011-02-09 Thread Jim Keniston
On Mon, 2011-02-07 at 16:01 +1100, Benjamin Herrenschmidt wrote: > On Sat, 2010-11-13 at 20:15 -0800, Jim Keniston wrote: > > Create the ibm,oops-log NVRAM partition, and capture the end of the printk > > buffer in it when there's an oops or panic. If we can't cr

Re: [PATCH 1/6] nvram: Generalize code for OS partitions in NVRAM

2011-02-09 Thread Jim Keniston
On Mon, 2011-02-07 at 15:57 +1100, Benjamin Herrenschmidt wrote: > On Sat, 2010-11-13 at 20:15 -0800, Jim Keniston wrote: > > Adapt the functions used to create and write to the RTAS-log partition > > to work with any OS-type partition. > > > > Signed-off-by: Jim Ken

Re: [PATCH 01/13] powerpc/nvram: Move things out of asm/nvram.h

2010-11-30 Thread Jim Keniston
nitions, they will be useful > > Signed-off-by: Benjamin Herrenschmidt I applied the whole 13-patch set, and built and booted the result. Seems fine. Tested-by: Jim Keniston Jim ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH] powerpc: fix call to subpage_protection()

2010-11-30 Thread Jim Keniston
On Tue, 2010-11-30 at 05:08 -0600, Milton Miller wrote: > [fixed Michael Neuling's address] > > On Fri Nov 19 about 07:06:19 EST in 2010, Benjamin Herrenschmidt wrote: > > On Thu, 2010-11-18 at 10:23 -0800, Jim Keniston wrote: > > > FWIW, this failure isn't

Re: [PATCH] powerpc: fix call to subpage_protection()

2010-11-18 Thread Jim Keniston
_SLAB, CONFIG_DEBUG_SLAB, CONFIG_PPC_64K_PAGES > CONFIG_PPC_SUBPAGE_PROT are enabled. > ... > > The following changes this subpage_protection() call. > > Reported-by: Jim Keniston > Signed-off-by: Michael Neuling > Tested-by: Jim Keniston > cc: David Gibson >

Re: Can't boot benh/powerpc.git kernel

2010-11-16 Thread Jim Keniston
On Tue, 2010-11-16 at 14:26 +1100, Michael Neuling wrote: > In message <1289520464.4752.12.ca...@localhost> you wrote: > > On Thu, 2010-11-11 at 09:06 +1100, Benjamin Herrenschmidt wrote: > > > On Wed, 2010-11-10 at 11:54 -0800, Jim Keniston wrote: > > > &g

Re: [RFC PATCH 0/6] nvram: Capture oops/panic reports in NVRAM

2010-11-13 Thread Jim Keniston
On Sat, 2010-11-13 at 20:15 -0800, Jim Keniston wrote: > This patch series enables p Series systems to capture oops and panic > reports from the printk buffer into NVRAM, where they can be examined > after reboot using the nvram command. > Here's a patch to the nvram command t

[PATCH 5/6] nvram: Slim down zlib_deflate workspace when possible

2010-11-13 Thread Jim Keniston
workspace is a win because our choices are to allocate the workspace when we need it (i.e., during an oops or panic) or allocate it at boot time. (We do the latter.) Signed-off-by: Jim Keniston --- include/linux/zlib.h| 14 -- lib/zlib_deflate/deflate.c | 33

[PATCH 6/6] nvram: Shrink our zlib_deflate workspace from 268K to 24K

2010-11-13 Thread Jim Keniston
Exploit zlib_deflate_workspacesize2() to create a much smaller zlib_deflate workspace when capturing oops/panic reports to NVRAM. Signed-off-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch

[PATCH 4/6] nvram: Add compression to fit more printk output into NVRAM

2010-11-13 Thread Jim Keniston
Capture more than twice as much text from the printk buffer, and compress it to fit it in the ibm,oops-log NVRAM partition. Signed-off-by: Jim Keniston --- arch/powerpc/include/asm/rtas.h|6 + arch/powerpc/platforms/pseries/nvram.c | 195 2 files

[PATCH 1/6] nvram: Generalize code for OS partitions in NVRAM

2010-11-13 Thread Jim Keniston
Adapt the functions used to create and write to the RTAS-log partition to work with any OS-type partition. Signed-off-by: Jim Keniston --- arch/powerpc/include/asm/nvram.h |3 - arch/powerpc/kernel/nvram_64.c | 31 ++- arch/powerpc/platforms/pseries/nvram.c | 138

[PATCH 3/6] nvram: Always capture start of oops report to NVRAM

2010-11-13 Thread Jim Keniston
If we don't have room to capture the entire oops report, capture as much as possible, starting 150 chars before the "Oops:" line. Signed-off-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c | 91 1 files changed, 91 insertions(

[RFC PATCH 0/6] nvram: Capture oops/panic reports in NVRAM

2010-11-13 Thread Jim Keniston
87009.html -- which in turn applies atop Ben Herrenschmidt's Aug. 2 patch set -- "[RFC] Clean up ppc64 nvram code" http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-August/084601.html My patches have been tested against 2.6.37-rc1. --- Jim Keniston (6): Shrink our zlib_defla

[PATCH 2/6] nvram: Capture oops/panic reports in ibm, oops-log partition

2010-11-13 Thread Jim Keniston
Create the ibm,oops-log NVRAM partition, and capture the end of the printk buffer in it when there's an oops or panic. If we can't create the ibm,oops-log partition, capture the oops/panic report in ibm,rtas-log. Signed-off-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvra

[PATCH 2/4] Fix nvram_create_partition() arg order

2010-11-11 Thread Jim Keniston
Use the correct arg order when calling nvram_create_partition(). Signed-off-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/pseries/nvram.c b/arch/powerpc/platforms/pseries/nvram.c

[PATCH 4/4] Handle partition names >= 12 chars

2010-11-11 Thread Jim Keniston
The name field in the nvram_header can be < 12 chars, null-terminated, or 12 chars without the null. Handle this safely. Signed-off-by: Jim Keniston --- arch/powerpc/kernel/nvram_64.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/nvram_64.

[PATCH 3/4] Fix NVRAM partition list setup

2010-11-11 Thread Jim Keniston
Simplify creation and use of the NVRAM partition list. Signed-off-by: Jim Keniston --- arch/powerpc/kernel/nvram_64.c | 26 -- 1 files changed, 8 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c index d467f8c

[PATCH 1/4] Fix powerpc nvram init order

2010-11-11 Thread Jim Keniston
Don't run pseries_nvram_init_log_partition() until after the partition list has been initialized. Fixes a boot-time crash. Signed-off-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/plat

[PATCH 0/4] More ppc64 nvram code cleanup

2010-11-11 Thread Jim Keniston
This series contains some fixups to Ben Herrenschmidt's Aug. 2 patch set, "[RFC] Clean up ppc64 nvram code" -- http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-August/084601.html These patches apply atop Ben's 11-patch series. --- Jim Keniston (4): Handle partiti

Re: Can't boot benh/powerpc.git kernel

2010-11-11 Thread Jim Keniston
On Thu, 2010-11-11 at 09:06 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2010-11-10 at 11:54 -0800, Jim Keniston wrote: > > I got Ben's linux/kernel/git/benh/powerpc.git source and built it > > (.config file attached*). It hangs on boot. When I boot it with > > logl

Re: [PATCH 0/8 userland!] systemtap: Add initial support for ppc32

2009-12-01 Thread Jim Keniston
pc64 work on this file. The *_arg and [u_]register functions are described in the stapfuncs man page (but not in the Language Reference doc). testsuite/systemtap.context/num_args.tcl tests some of these functions (or used to, at least). Jim Keniston __