Re: [PATCH] module: set __jump_table alignment to 8

2017-03-02 Thread Jason Baron
good to me. Reviewed-by: Jason Baron Thanks, -Jason

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-03-01 Thread Jason Baron
On 03/01/2017 11:40 AM, David Daney wrote: > On 02/28/2017 10:34 PM, Michael Ellerman wrote: >> Jason Baron writes: >> ... >>> I also checked all the other .ko files and they were properly aligned. >>> So I think this should hopefully work, and I lik

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 03:15 PM, David Daney wrote: On 02/28/2017 11:34 AM, Jason Baron wrote: On 02/28/2017 02:22 PM, David Daney wrote: On 02/28/2017 11:05 AM, David Daney wrote: On 02/28/2017 10:39 AM, Jason Baron wrote: [...] I suspect that the alignment of the __jump_table section in the

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 02:22 PM, David Daney wrote: > On 02/28/2017 11:05 AM, David Daney wrote: >> On 02/28/2017 10:39 AM, Jason Baron wrote: >>> > [...] >>>> I suspect that the alignment of the __jump_table section in the .ko >>>> files is not correct, a

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 01:16 PM, David Daney wrote: On 02/28/2017 08:21 AM, Steven Rostedt wrote: On Tue, 28 Feb 2017 10:25:46 +0530 Sachin Sant wrote: File: ./net/ipv4/xfrm4_input.o [12] __jump_table PROGBITS 000639 18 18 WAM 0 0 1 File: ./net/ipv4/udplite.o F

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-27 Thread Jason Baron
On 02/27/2017 05:45 PM, David Daney wrote: On 02/27/2017 02:36 PM, Steven Rostedt wrote: On Mon, 27 Feb 2017 14:21:21 -0800 David Daney wrote: See attached for mips. It seems to do the right thing. I leave it as an exercise to the reader to fix the other architectures. Consult your own

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-27 Thread Jason Baron
On 02/27/2017 01:57 PM, David Daney wrote: On 02/27/2017 10:49 AM, Jason Baron wrote: The core jump_label code makes use of the 2 lower bits of the static_key::[type|entries|next] field. Thus, ensure that the jump_entry table is at least 4-byte aligned. [...] diff --git a/arch/mips/include

[PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-27 Thread Jason Baron
: Michael Ellerman Cc: Anton Blanchard Cc: Rabin Vincent Cc: Russell King Cc: Ralf Baechle Cc: Chris Metcalf Cc: Zhigang Lu Cc: David Daney Signed-off-by: Jason Baron --- arch/arm/include/asm/jump_label.h | 2 ++ arch/mips/include/asm/jump_label.h| 2 ++ arch/powerpc/include/asm

Re: next-20170217 boot on POWER8 LPAR : WARNING @kernel/jump_label.c:287

2017-02-22 Thread Jason Baron
On 02/22/2017 12:38 AM, Michael Ellerman wrote: > Jason Baron writes: > >> On 02/20/2017 10:05 PM, Sachin Sant wrote: >>> >>>> On 20-Feb-2017, at 8:27 PM, Jason Baron >>> <mailto:jba...@akamai.com>> wrote: >>>> >>>> H

Re: next-20170217 boot on POWER8 LPAR : WARNING @kernel/jump_label.c:287

2017-02-21 Thread Jason Baron
On 02/20/2017 10:05 PM, Sachin Sant wrote: On 20-Feb-2017, at 8:27 PM, Jason Baron mailto:jba...@akamai.com>> wrote: Hi, On 02/19/2017 09:07 AM, Sachin Sant wrote: While booting next-20170217 on a POWER8 LPAR following warning is displayed. Reverting the following commit helps boot c

Re: next-20170217 boot on POWER8 LPAR : WARNING @kernel/jump_label.c:287

2017-02-20 Thread Jason Baron
Hi, On 02/19/2017 09:07 AM, Sachin Sant wrote: > While booting next-20170217 on a POWER8 LPAR following > warning is displayed. > > Reverting the following commit helps boot cleanly. > commit 3821fd35b5 : jump_label: Reduce the size of struct static_key > > [ 11.393008] [ cut here

[PATCH v3 1/7] powerpc: add explicit #include for jump label

2016-07-06 Thread Jason Baron
The stringify_in_c() macro may not be included. Make the dependency explicit. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Jason Baron --- arch/powerpc/include/asm/jump_label.h | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 2/4] powerpc: add explicit #include for jump label

2016-05-20 Thread Jason Baron
The stringify_in_c() macro may not be included. Make the dependency explicit. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Jason Baron --- arch/powerpc/include/asm/jump_label.h | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 3/3] powerpc: Include linux/jump_label.h to get HAVE_JUMP_LABEL define

2015-01-07 Thread Jason Baron
On 01/07/2015 05:35 AM, Anton Blanchard wrote: > Commit 1bc9e47aa8e4 ("powerpc/jump_label: Use HAVE_JUMP_LABEL") > converted uses of CONFIG_JUMP_LABEL to HAVE_JUMP_LABEL in > some assembly files. > > HAVE_JUMP_LABEL is defined in linux/jump_label.h, so we need to > include this or we always get the

Re: [PATCH 1/2] jump_label: Allow jump labels to be used in assembly

2015-01-06 Thread Jason Baron
e also need to add -DCC_HAVE_ASM_GOTO to KBUILD_AFLAGS. > > Signed-off-by: Anton Blanchard (adding Steven) Acked-by: Jason Baron The jump label stuff often gets picked up by Steve, but I guess this could go through the powerpc tree as well... Thanks, -Jason

[PATCH 3/3 v3] powerpc: cleanup panic_timeout

2013-11-25 Thread Jason Baron
ny case, if the user changes the default setting of 180 seconds, we honor that user setting. Signed-off-by: Jason Baron --- arch/powerpc/Kconfig | 4 arch/powerpc/include/asm/setup.h | 1 + arch/powerpc/kernel/setup_32.c | 3 --- arch/powerpc/kernel/setup_6

Re: [PATCH v2] panic: Make panic_timeout configurable

2013-11-21 Thread Jason Baron
On 11/21/2013 06:16 AM, Michael Ellerman wrote: > On Tue, Nov 19, 2013 at 05:04:14PM -0500, Jason Baron wrote: >> On 11/19/2013 02:09 AM, Ingo Molnar wrote: >>> >>> * Jason Baron wrote: >>> >>>> On 11/18/2013 05:30 PM, Andrew Morton wrote: >

Re: [PATCH v2] panic: Make panic_timeout configurable

2013-11-19 Thread Jason Baron
On 11/19/2013 02:09 AM, Ingo Molnar wrote: > > * Jason Baron wrote: > >> On 11/18/2013 05:30 PM, Andrew Morton wrote: >>> On Mon, 18 Nov 2013 21:04:36 + (GMT) Jason Baron >>> wrote: >>> >>>> The panic_timeout value can be set via the

Re: [PATCH 08/40] tracing: remove syscall bitmaps in preparation for compat support

2010-06-23 Thread Jason Baron
On Wed, Jun 23, 2010 at 03:14:54PM -0400, Jason Baron wrote: > On Wed, Jun 23, 2010 at 11:16:44AM -0400, Steven Rostedt wrote: > > On Wed, 2010-06-23 at 20:02 +1000, Ian Munsie wrote: > > > From: Jason Baron > > > > > > In preparation for compat syscall trac

Re: [PATCH 08/40] tracing: remove syscall bitmaps in preparation for compat support

2010-06-23 Thread Jason Baron
On Wed, Jun 23, 2010 at 11:16:44AM -0400, Steven Rostedt wrote: > On Wed, 2010-06-23 at 20:02 +1000, Ian Munsie wrote: > > From: Jason Baron > > > > In preparation for compat syscall tracing support, let's store the enabled > > syscalls, with the struct syscall_me

Re: [PATCH 39/40] trace syscalls: Clean confusing {s,r,}name and fix ABI breakage

2010-06-23 Thread Jason Baron
On Wed, Jun 23, 2010 at 08:03:20PM +1000, Ian Munsie wrote: > From: Ian Munsie > > This patch cleans up the preprocessor macros defining system calls by > standidising on the parameters passing around the system call name, with > and without it's prefix. > > Overall this makes the preprocessor c