Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-09-20 Thread Jan-Bernd Themann
Hi Milton, sorry for the delayed answer, was on vacation. linux-kernel-ow...@vger.kernel.org wrote on 21.05.2010 11:18:01: > linux-kernel-ow...@vger.kernel.org > > On Thu, 20 May 2010 at 10:21:36 +0200 (CEST) Thomas Gleixner wrote: > > On Thu, 20 May 2010, Michael Ellerman wrote: > > > On Wed, 2

[PATCH 2/2] ehea: Fix kernel deadlock in DLPAR-mem processing

2010-06-15 Thread Jan-Bernd Themann
Port reset operations and memory add/remove operations need to be serialized to avoid a kernel deadlock. The deadlock is caused by calling the napi_disable() function twice. Therefore we have to employ the dlpar_mem_lock in the ehea_reset_port function as well Signed-off-by: Jan-Bernd Themann

[PATCH 1/2] ehea: fix delayed packet processing

2010-06-15 Thread Jan-Bernd Themann
In the eHEA poll function an rmb() is required. Without that some packets on the receive queue are not seen and thus delayed until the next interrupt is handled for the same receive queue. Signed-off-by: Jan-Bernd Themann --- Patch created against 2.6.35-rc3 drivers/net/ehea/ehea_main.c

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Jan-Bernd Themann
Hi Thomas > Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) > > On Thu, 20 May 2010, Jan-Bernd Themann wrote: > > > > Thought more about that. The case at hand (ehea) is nasty: > > > > > > > > The driver does _NOT_ d

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Jan-Bernd Themann
Hi, Michael Ellerman wrote on 20.05.2010 03:34:08: > Subject: > > Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) > > On Wed, 2010-05-19 at 23:08 +0200, Thomas Gleixner wrote: > > On Wed, 19 May 2010, Thomas Gleixner wrote: > > > > I'm still not clear on why the ultim

[PATCH net-next-2.6] ehea: fix circular locking problem

2009-03-12 Thread Jan-Bernd Themann
This patch fixes the circular locking problem by changing the locking strategy concerning the logging of firmware handles. Signed-off-by: Jan-Bernd Themann --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c | 56 ++--- 2 files

Re: [PATCH] eHEA: Don't do memory allocation under lock if not necessary

2009-03-11 Thread Jan-Bernd Themann
Hi David, thanks for your patch. Coincidentally we have been working on a patch that does some locking rework and also touches this particular lock. So your patch finnally won't be required anymore. Thanks anyway for trying to improve the eHEA driver! I'm going to post our patch later today.

Re: [Powerpc / eHEA] Circular dependency with 2.6.29-rc6

2009-02-25 Thread Jan-Bernd Themann
Hi, yes, sorry for the funny wrapping... and thanks for your quick answer! Peter Zijlstra wrote: > On Wed, 2009-02-25 at 16:05 +0100, Jan-Bernd Themann wrote: > > >> - When "open" is called for a registered network device, port->port_lock >> is taken fir

Re: [Powerpc / eHEA] Circular dependency with 2.6.29-rc6

2009-02-25 Thread Jan-Bernd Themann
Hi, we have investigated this problem but didn't understand to root cause of this problem so far. The things we observed: - The warning is only shown when the ehea module is loaded while the machine is booting. - If you load the module later (modprobe) no warnings are shown - Machine never actuall

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-16 Thread Jan-Bernd Themann
Hi! Ira Snyder wrote on 15.01.2009 22:40:56: > On Thu, Jan 15, 2009 at 10:22:53PM +0100, Arnd Bergmann wrote: > > On Thursday 15 January 2009, Ira Snyder wrote: > > > I have another question for you Arnd. > > > > > > What did you use as the host and guest drivers when you ran virtio over > > >

Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption, eHCA is close

2008-09-23 Thread Jan-Bernd Themann
Hi, I think these are the "functional" changes that need to be included in the ibmebus driver. We'll add a RT flag in the final version to enable these changes only for RT-Linux for now. Ben, can you / your team look into the implementation of the set_irq_type functionality needed for XICS? Rega

Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption

2008-09-15 Thread Jan-Bernd Themann
Hi, we are a bit worried about putting this into the mainstream part of non real time linux. There interrupts work perfectly fine, and it was a bit of a challenge to get there for all cases / configurations / machines. Could you try to enable these changes only for RT-Linux via a real-time kco

Re: [BUG] 2.6.26-rc8-git2 - powerpc - circular locking dependency detected with net/ehea driver

2008-07-07 Thread Jan-Bernd Themann
Hi Kamalesh, where you able to reproduce this problem with the patches applied we posted on friday? Regards, Jan-Bernd On Tuesday 01 July 2008 14:38, Kamalesh Babulal wrote: > Hi, > > circular locking dependency is detected, while booting the > powerpc box with the 2.6.26-rc8-git2 kernel. > >

[PATCH 2/3] ehea: add MODULE_DEVICE_TABLE

2008-07-03 Thread Jan-Bernd Themann
Required to allow distros to easily detect when ehea module needs to be loaded Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.26-rc8/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c --- linux-2.6.26-rc8/drivers/ne

[PATCH 1/3] ehea: fix might sleep problem

2008-07-03 Thread Jan-Bernd Themann
A mutex has to be replaced by spinlocks as it can be called from a context which does not allow sleeping. The kzalloc flag GFP_KERNEL has to be replaced by GFP_ATOMIC for the same reason. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.26-rc8/d

[PATCH 3/3] ehea: fix race condition

2008-07-03 Thread Jan-Bernd Themann
When ehea_stop is called the function cancel_work_sync(&port->reset_task) is used to ensure that the reset task is not running anymore. We need an additional flag to ensure that it can not be scheduled after this call again for a certain time. Signed-off-by: Jan-Bernd Themann <[EMAIL

Re: [PATCH 1/2] ibmebus: Change ibmebus_request_irq() to optionally return irq number

2008-06-09 Thread Jan-Bernd Themann
powerpc/ibmebus.h b/include/asm-powerpc/ibmebus.h > index 1a9d9ae..3a2618a 100644 > --- a/include/asm-powerpc/ibmebus.h > +++ b/include/asm-powerpc/ibmebus.h > @@ -51,7 +51,7 @@ extern struct bus_type ibmebus_bus_type; > int ibmebus_register_driver(struct of_platform_driver *drv); > void ibmebus

[PATCH][2.6.26] ehea: set mac address fix

2008-06-09 Thread Jan-Bernd Themann
-Bernd Themann <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.26-rc4/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c --- linux-2.6.26-rc4/drivers/net/ehea/ehea_main.c 2008-05-26 20:08:11.0 +0200 +++ patched_kernel/drivers/net/ehea/ehea_main.c 2

Re: [PATCH 1/1] ehea: Fix use after free on reboot

2008-05-20 Thread Jan-Bernd Themann
t; To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > The patch looks good. Acked-by: Jan-Bernd Themann <[EMAIL PROTECTED]> Thanks, Jan-Bernd ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-18 Thread Jan-Bernd Themann
switching to proper mail client... Dave Hansen <[EMAIL PROTECTED]> wrote on 15.02.2008 17:55:38: > I've been thinking about that, and I don't think you really *need* to > keep a comprehensive map like that. > > When the memory is in a particular configuration (range of memory > present along wi

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-18 Thread Jan-Bernd Themann
Dave Hansen <[EMAIL PROTECTED]> wrote on 15.02.2008 17:55:38: > I've been thinking about that, and I don't think you really *need* to > keep a comprehensive map like that. > > When the memory is in a particular configuration (range of memory > present along with unique set of holes) you get a un

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-13 Thread Jan-Bernd Themann
Hi Dave, On Monday 11 February 2008 17:47, Dave Hansen wrote: > Also, just ripping down and completely re-doing the entire mass of cards > every time a 16MB area of memory is added or removed seems like an > awfully big sledgehammer to me. I would *HATE* to see anybody else > using this driver as

[PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann
Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Patch for eHEA memory hotplug support that uses these functions: http://www.spinics.net/lists/netdev/msg54484.html Signed-off-by: Jan-Bernd Themann

[PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann
Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- Hi, this is the modified version with EXPORT_SYMBOL_GPL Regards, Jan-Bernd driver

Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann
On Monday 11 February 2008 11:12, Dave Hansen wrote: > On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote: > > are you the right person to address this patch to? > > You might want to check the top of the file. ;) > > > --- a/drivers/base/memory.c > &g

[PATCH][RESEND] drivers/base: export (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann
Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- Hi Greg, are you the right person to address this patch to? Regards, Jan-Bernd driver

Re: [PATCH 2/2] ehea: add memory remove hotplug support

2008-02-04 Thread Jan-Bernd Themann
On Monday 04 February 2008 15:46, Michael Ellerman wrote: > On Mon, 2008-02-04 at 14:04 +0100, Jan-Bernd Themann wrote: > > Add memory remove hotplug support > > @@ -3559,6 +3578,10 @@ int __init ehea_module_init(void) > > if (ret) > > ehea_info("fa

[PATCH 2/2] ehea: add memory remove hotplug support

2008-02-04 Thread Jan-Bernd Themann
Add memory remove hotplug support Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- Comment: This patch depends on the following patch that exports the symbols register_memory_notifier() unregister_memory_notifier() http://lkml.org/lkml/2008/2/1/293 drivers/net/ehea/ehea_

[PATCH 1/2] ehea: kdump support

2008-02-04 Thread Jan-Bernd Themann
tored there. The arrays are kept up-to-date during normal runtime. The crash handler fn is triggered by the recently introduced PPC crash shutdown reg/unreg functions. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h | 34 +- drivers/net/ehea/ehea_ma

[PATCH 0/2] ehea: kdump & memory remove support

2008-02-04 Thread Jan-Bernd Themann
This patch set adds support for kdump and hotplug memory remove to the eHEA driver. The "memory remove" patch depends on the following patch that has been posted a few days ago. That patch exports the symbols  - register_memory_notifier()  - unregister_memory_notifier() http://lkml.org/lkml/2008

[PATCH] ehea: fix sysfs link compile problem

2008-02-01 Thread Jan-Bernd Themann
Due to changes in the struct device_driver there is no direct access to its kobj any longer. The kobj was used to create sysfs links between eHEA ethernet devices and the driver. This patch removes the affected sysfs links to resolve the build problems. Signed-off-by: Jan-Bernd Themann <[EM

[PATCH] ehea: add kexec support

2007-10-26 Thread Jan-Bernd Themann
eHEA resources that are allocated via H_CALLs have a unique identifier each. These identifiers are necessary to free the resources. A reboot notifier is used to free all eHEA resources before the indentifiers get lost, i.e before kexec starts a new kernel. Signed-off-by: Jan-Bernd Themann <[EM

[PATCH] ehea: fix port_napi_disable/enable

2007-10-24 Thread Jan-Bernd Themann
napi_disable / napi_enable must be applied on all ehea queues. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ehea/eh

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-09 Thread Jan-Bernd Themann
on't see anything objectionable in the infiniband parts of the > patch -- I don't have any way to test the changes but it all looks > like a straightforward conversion to a new platform API. So: > > Acked-by: Roland Dreier <[EM

[PATCH] ehea: use kernel event queue

2007-10-08 Thread Jan-Bernd Themann
eHEA recovery and DLPAR functions are called seldomly. The eHEA workqueues are replaced by the kernel event queue. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- The patch has been built against upstream git drivers/net/ehea/ehea.h |3 +-- drivers/net/ehea/ehea_main.c

Re: [PATCH] ehea: DLPAR memory add fix

2007-10-01 Thread Jan-Bernd Themann
Hi, On Monday 01 October 2007 16:44, Jeff Garzik wrote: > Jan-Bernd Themann wrote: > > Due to stability issues in high load situations the HW queue handling > > has to be changed. The HW queues are now stopped and restarted again instead > > of destroying and all

[PATCH] ehea: DLPAR memory add fix

2007-10-01 Thread Jan-Bernd Themann
Due to stability issues in high load situations the HW queue handling has to be changed. The HW queues are now stopped and restarted again instead of destroying and allocating new HW queues. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h

[PATCH net-2.6.24] eHEA: poll function update for new NAPI scheme

2007-09-19 Thread Jan-Bernd Themann
Update of ehea_poll function to work with new NAPI scheme. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- Hi David, this patch is built upon the patches provided by Mel Gorman (2.6.23-rc6-mm1: Build failure on ppc64 drivers/net/ehea/ehea_main.c) and Roland Dreier ([PATCH net-

[PATCH 2/2][RESEND] ehea: fix last_rx update

2007-09-07 Thread Jan-Bernd Themann
Update last_rx in registered device struct instead of in the dummy device. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_

[PATCH 1/2][RESEND] ehea: propagate physical port state

2007-09-07 Thread Jan-Bernd Themann
the physical port state is. Thus eHEA can be considered as a switch there. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |5 - drivers/net/ehea/ehea_main.c | 14 +- 2 files changed, 17 insertions(+), 2 deletions(-) diff -

Re: RFC: issues concerning the next NAPI interface

2007-08-29 Thread Jan-Bernd Themann
On Wednesday 29 August 2007 10:15, James Chapman wrote: > Jan-Bernd Themann wrote: > > What I'm trying to improve with this approach is interrupt > > mitigation for NICs where the hardware support for interrupt > > mitigation is limited. I'm not trying to improve t

Re: RFC: issues concerning the next NAPI interface

2007-08-29 Thread Jan-Bernd Themann
On Wednesday 29 August 2007 10:29, David Miller wrote: > From: Jan-Bernd Themann <[EMAIL PROTECTED]> > Date: Wed, 29 Aug 2007 09:10:15 +0200 > > > In the end I want to reduce the CPU utilization. And one way > > to do that is LRO which also works only well if there ar

Re: RFC: issues concerning the next NAPI interface

2007-08-29 Thread Jan-Bernd Themann
Hi David David Miller schrieb: > Interrupt mitigation only works if it helps you avoid interrupts. > This scheme potentially makes more of them happen. > > The hrtimer is just another interrupt, a cpu locally triggered one, > but it has much of the same costs nonetheless. > > So if you set this ti

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread Jan-Bernd Themann
On Tuesday 28 August 2007 11:22, James Chapman wrote: > > So in this scheme what runs ->poll() to process incoming packets? > > The hrtimer? > > No, the regular NAPI networking core calls ->poll() as usual; no timers > are involved. This scheme simply delays the napi_complete() from the > driver

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread Jan-Bernd Themann
Hi On Monday 27 August 2007 23:02, David Miller wrote: > But there are huger fish to fry for you I think. Talk to your > platform maintainers and ask for an interface for obtaining > a flat static distribution of interrupts to cpus in order to > support multiqueue NAPI better. > > In your previo

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread Jan-Bernd Themann
On Monday 27 August 2007 22:37, David Miller wrote: > From: Jan-Bernd Themann <[EMAIL PROTECTED]> > Date: Mon, 27 Aug 2007 11:47:01 +0200 > > > So the question is simply: Do we want drivers that need (benefit > > from) a timer based polling support to implement th

Re: RFC: issues concerning the next NAPI interface

2007-08-27 Thread Jan-Bernd Themann
On Monday 27 August 2007 17:51, James Chapman wrote: > In the second half of my previous reply (which seems to have been > deleted), I suggest a way to avoid this problem without using hardware > interrupt mitigation / coalescing. Original text is quoted below. > > >> I've seen the same and I'

[PATCH 2/2] ehea: fix last_rx update

2007-08-27 Thread Jan-Bernd Themann
Update last_rx in registered device struct instead of in the dummy device. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_

[PATCH 1/2] ehea: propagate physical port state

2007-08-27 Thread Jan-Bernd Themann
the physical port state is. Thus eHEA can be considered as a switch there. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |5 - drivers/net/ehea/ehea_main.c | 14 +- 2 files changed, 17 insertions(+), 2 deletions(-) diff -

Re: RFC: issues concerning the next NAPI interface

2007-08-27 Thread Jan-Bernd Themann
On Monday 27 August 2007 03:58, David Miller wrote: > From: James Chapman <[EMAIL PROTECTED]> > Date: Sun, 26 Aug 2007 20:36:20 +0100 > > > David Miller wrote: > > > From: James Chapman <[EMAIL PROTECTED]> > > > Date: Fri, 24 Aug 2007 18:16:45 +0100 > > > > > >> Does hardware interrupt mitigation

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread Jan-Bernd Themann
Linas Vepstas schrieb: > On Fri, Aug 24, 2007 at 09:04:56PM +0200, Bodo Eggert wrote: > >> Linas Vepstas <[EMAIL PROTECTED]> wrote: >> >>> On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote: >>> >>>> 3) On moder

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread Jan-Bernd Themann
James Chapman schrieb: > Stephen Hemminger wrote: >> On Fri, 24 Aug 2007 17:47:15 +0200 >> Jan-Bernd Themann <[EMAIL PROTECTED]> wrote: >> >>> Hi, >>> >>> On Friday 24 August 2007 17:37, [EMAIL PROTECTED] wrote: >>>>

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread Jan-Bernd Themann
Hi, On Friday 24 August 2007 17:37, [EMAIL PROTECTED] wrote: > On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote: > > ... > > 3) On modern systems the incoming packets are processed very fast. > > Especially > >    on SMP systems when we use multip

RFC: issues concerning the next NAPI interface

2007-08-24 Thread Jan-Bernd Themann
Hi, when I tried to get the eHEA driver working with the new interface, the following issues came up. 1) The current implementation of netif_rx_schedule, netif_rx_complete    and the net_rx_action have the following problem: netif_rx_schedule    sets the NAPI_STATE_SCHED flag and adds the NAPI in

[PATCH 4/4] ehea: show physical port state

2007-08-22 Thread Jan-Bernd Themann
the physical port state is. Thus eHEA can be considered as a switch there. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |5 - drivers/net/ehea/ehea_main.c | 14 +- 2 files changed, 17 insertions(+), 2 deletions(-) diff -

[PATCH 3/4] ehea: fix queue destructor

2007-08-22 Thread Jan-Bernd Themann
Includes hcp_epas_dtor in eq/cq/qp destructors to unmap HW register. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_qmr.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/ehea/ehea_qmr.c b/drivers/net/ehea/ehea_qmr.c

[PATCH 2/4] ehea: fix module parameter description

2007-08-22 Thread Jan-Bernd Themann
Update the module parameter description of "use_mcs" to show correct default value Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/

[PATCH 1/4] ehea: fix interface to DLPAR tools

2007-08-22 Thread Jan-Bernd Themann
Userspace DLPAR tool expects decimal numbers to be written to and read from sysfs entries. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/d

Re: [PATCH 1/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-06 Thread Jan-Bernd Themann
Hi Jörn On Friday 03 August 2007 15:41, Jörn Engel wrote: > On Fri, 3 August 2007 14:41:19 +0200, Jan-Bernd Themann wrote: > > > > This patch provides generic Large Receive Offload (LRO) functionality > > for IPv4/TCP traffic. > > > > LRO combines received t

Re: [PATCH] lro: eHEA example how to use LRO

2007-08-06 Thread Jan-Bernd Themann
Hi Auke, On Friday 03 August 2007 22:29, Kok, Auke wrote: > Jan-Bernd Themann wrote: > > This patch shows how the generic LRO interface is used for SKB mode > > > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > > > > --- > > drivers/net/

[PATCH] lro: eHEA example how to use LRO

2007-08-03 Thread Jan-Bernd Themann
This patch shows how the generic LRO interface is used for SKB mode Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 + drivers/net/ehea/ehea.h |9 - drivers/net/ehea/ehea_ethtool.c | 15 +++ drivers/net/ehea/ehea_

[PATCH 1/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-03 Thread Jan-Bernd Themann
either pass SKBs or fragment lists to the LRO engine. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- include/linux/inet_lro.h | 177 ++ net/ipv4/Kconfig |8 + net/ipv4/Makefile|1 + net/ipv4/inet_lro.c

[PATCH 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-03 Thread Jan-Bernd Themann
Hi, I think this patch could be the final version for now. It has been tested on two platforms (power and x86_64) and works very well. Apart from David Miller and Evgeniy Polaykov, we'd like to thank especially Andrew Gallatin for his great reviews and help to make that happen. After some discus

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-31 Thread Jan-Bernd Themann
Hi, Thanks for finding these bugs! I'll post an updated version soon (2 patches with no separate Kconfig patches, one LRO and one eHEA patch). See comments below. Thanks, Jan-Bernd On Monday 30 July 2007 22:32, Andrew Gallatin wrote: > I was working on testing the myri10ge patch, and I ran into

[PATCH 3/4][RFC] ehea: LRO support

2007-07-30 Thread Jan-Bernd Themann
Added LRO support using the "SKB aggregate" interface Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |9 - drivers/net/ehea/ehea_ethtool.c | 15 +++ drivers/net/ehea/ehea_main.c| 82 +++

[PATCH 4/4][RFC] ehea: Kconfig

2007-07-30 Thread Jan-Bernd Themann
Kconfig changes for LRO Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index f8a602c..fec4004 100644 --- a/drivers/net/Kconfig +++ b/drive

[PATCH 1/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jan-Bernd Themann
Generic Large Receive Offload for TCP traffic Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- include/linux/inet_lro.h | 173 ++ net/ipv4/inet_lro.c | 590 ++ 2 files changed, 763 insertions(+), 0 deletions(-) creat

[PATCH 2/4][RFC] lro: Kconfig and Makefile

2007-07-30 Thread Jan-Bernd Themann
Kconfig and Makefile for LRO Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- net/ipv4/Kconfig |8 net/ipv4/Makefile |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index fb79097..d894f61 100644 --- a/ne

[PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jan-Bernd Themann
Hi, this patch set contains the latest generic LRO code, a Kconfig / Makefile and an eHEA patch demonstrating how the "aggregate SKB" interface has to to be used. Drew, could you provide a patch for the myri10ge driver to show how the "receive in page" interface works? Please check the Kconfig /

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Jan-Bernd Themann
Hi Drew, thanks a lot for your good feedback. See comments below. I'll try to provide an updated version next week. It would be nice if you could post a patch for your driver once we have addressed the issues you mentioned. Then we would have the eHEA driver for the SKB interface, and your driver

[PATCH] eHEA: net_poll support

2007-07-23 Thread Jan-Bernd Themann
net_poll support for eHEA added Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c | 22 +- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/drive

[RFC 1/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-20 Thread Jan-Bernd Themann
Generic LRO patch Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- include/linux/inet_lro.h | 154 + net/ipv4/inet_lro.c | 549 ++ 2 files changed, 703 insertions(+), 0 deletions(-) create mode 100644 include

[RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-20 Thread Jan-Bernd Themann
Hi, Thanks a lot for your comments so far. This generic LRO patch differs from the last one in several points. A new interface for a "receive in pages" mode has been added and tested with an eHEA prototype. Seems to work well. Does this extended interface seem to be sufficient? Below some more e

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic (IPv6)

2007-07-18 Thread Jan-Bernd Themann
Hi, I suggest we keep the interface open for IPv6 support by adding an additional parameter but first just get IPv4 support only into the kernel. IPv6 support can then incrementially be added. Would that be ok? On Sunday 15 July 2007 11:40, David Miller wrote: > From: Christoph Hellwig <[EMAI

Re: [RFC 1/3] lro: Generic LRO for TCP traffic

2007-07-12 Thread Jan-Bernd Themann
Hi Evgeniy On Thursday 12 July 2007 10:01, Evgeniy Polyakov wrote: > > + > > + if (tcph->cwr || tcph->ece || tcph->urg || !tcph->ack || tcph->psh > > + || tcph->rst || tcph->syn || tcph->fin) > > + return -1; > > I think you do not want to break lro frame because of push flag -

[RFC 3/3] lro: LRO support for eHEA

2007-07-11 Thread Jan-Bernd Themann
LRO support for eHEA Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |9 +++- drivers/net/ehea/ehea_main.c | 102 +++--- 2 files changed, 104 insertions(+), 7 deletions(-) diff --git a/drivers/net/ehea/eh

[RFC 2/3] lro: Kconfig and Makefile

2007-07-11 Thread Jan-Bernd Themann
Kconfig and Makefile changes for LRO Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- net/ipv4/Kconfig |9 + net/ipv4/Makefile |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index 010fbb2..25279f4 100644

[RFC 1/3] lro: Generic LRO for TCP traffic

2007-07-11 Thread Jan-Bernd Themann
Large Receive Offload (tcp) Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- include/linux/inet_lro.h | 107 net/ipv4/inet_lro.c | 311 ++ 2 files changed, 418 insertions(+), 0 deletions(-) create mode 100644 i

[RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-11 Thread Jan-Bernd Themann
Generic Large Receive Offload proposal After some discussions on the mailing list concerning our LRO approach, we agreed to provide a generic LRO patch. The algorithm is based on the version we developed for eHEA. The performance improvements we observed were significant. The LRO functionality is

[PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-05 Thread Jan-Bernd Themann
improved throughput for small numbers of parallel TCP connections. As this feature is considered as experimental it is switched off by default and can be activated via a module parameter. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h | 30 drive

[PATCH 1/2] eHEA: Capability flag for DLPAR support

2007-07-05 Thread Jan-Bernd Themann
This patch introduces a capability flag that is used by the DLPAR userspace tool to check which DLPAR features are supported by the eHEA driver. Missing goto has been included. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |8 +++- drive

Re: [PATCH 1/2] eHEA: Capability flag for DLPAR support

2007-07-04 Thread Jan-Bernd Themann
Hi, good catch. Thanks On Wednesday 04 July 2007 14:53, Akinobu Mita wrote: > 2007/7/4, Jan-Bernd Themann <[EMAIL PROTECTED]>: > > > diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c > > index bdb5241..f8c0908 100644 > > --- a/drivers/

[PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-04 Thread Jan-Bernd Themann
improved throughput for small numbers of parallel TCP connections. As this feature is considered as experimental it is switched off by default and can be activated via a module parameter. Some additional security checks have been added since the last posting. Signed-off-by: Jan-Bernd Themann

[PATCH 1/2] eHEA: Capability flag for DLPAR support

2007-07-04 Thread Jan-Bernd Themann
This patch introduces a capability flag that is used by the DLPAR userspace tool to check which DLPAR features are supported by the eHEA driver. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |8 +++- drivers/net/ehea/ehea_main.c

[PATCH/RESENT] ehea: Whitespace cleanup

2007-07-02 Thread Jan-Bernd Themann
This patch fixes several whitespace issues. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h index c0f81b5..abaf3ac 100644 --- a/drivers/net/ehea/ehea.h +++ b/drivers/net/ehea/ehea.h @@ -39,7 +39,7 @@ #include #