Re: [PATCH RFC 51/77] mthca: Update MSI/MSI-X interrupts enablement code

2013-10-04 Thread Jack Morgenstein
On Wed, 2 Oct 2013 12:49:07 +0200 Alexander Gordeev wrote: > Subject: [PATCH RFC 51/77] mthca: Update MSI/MSI-X interrupts > enablement code Date: Wed, 2 Oct 2013 12:49:07 +0200 > Sender: linux-rdma-ow...@vger.kernel.org > X-Mailer: git-send-email 1.7.7.6 > > As result of recent re-design of t

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

2013-10-04 Thread Jack Morgenstein
On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gordeev

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

2013-10-04 Thread Jack Morgenstein
On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: UPDATING THIS REPLY. Your change log confused me. The change below is not from a "recent re-design", it is required due to an earlier patch in this patch set. >From the log, I assumed that the change you are talking about is already upst

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

2013-10-04 Thread Jack Morgenstein
On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: NACK. This change does not do anything logically as far as I can tell. pci_enable_msix in the current upstream kernel itself calls pci_msix_table_size. The current code yields the same results as the code suggested below. (i.e., the su