Re: [PATCH 1/1] IB/ehca: Disallow creating UC QP with SRQ

2008-10-13 Thread Hoang-Nam Nguyen
g: > > commit 0540bbbe455e123a1692d26205ad1a29983883b0 > Author: Hoang-Nam Nguyen <[EMAIL PROTECTED]> > Date: Fri Oct 10 14:40:39 2008 -0700 > > IB/ehca: Don't allow creating UC QP with SRQ > > This patch prevents a UC QP to be created attached to an SRQ, s

[PATCH 1/1] IB/ehca: Disallow creating UC QP with SRQ

2008-10-01 Thread Hoang-Nam Nguyen
IB/ehca: Disallow creating QP for UC with SRQ This patch prevents a UC QP to be created with SRQ, since current firmware does not support this feature. Signed-off-by: Michael Faath <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_qp.c |6 ++ 1 files changed, 6 insertions(+), 0 del

[PATCH 0/1] IB/ehca: handle creation of UC QP with SRQ

2008-10-01 Thread Hoang-Nam Nguyen
Hi Roland! Sending this patch on behalf of Michael F. It should apply cleanly against your git tree for-2.6.28. Thanks Nam Acked-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/m

IB/ehca: handle negative return value from ibmebus_request_irq() properly in ehca_create_eq()

2008-04-28 Thread Hoang-Nam Nguyen
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_eq.c | 35 - 1 files changed, 17 insertions(+), 18 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_eq.c b/drivers/infiniband/hw/ehca/ehca_eq.c index b

Re: [PATCH] IB/ehca: Forward event client-reregister-required to registered clients

2008-01-03 Thread Hoang-Nam Nguyen
Hi Roland, Just want to make sure you've seen this patch and if it looks ok for you. Thanks Nam On Thursday 20 December 2007 15:06, Hoang-Nam Nguyen wrote: > This patch allows ehca to forward event client-reregister-required to > registered clients. Such one event is generated by th

[PATCH] IB/ehca: Forward event client-reregister-required to registered clients

2007-12-20 Thread Hoang-Nam Nguyen
This patch allows ehca to forward event client-reregister-required to registered clients. Such one event is generated by the switch eg. after its reboot. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_irq.c | 12 1 files chang

Re: [PATCH] hugetlb: follow_hugetlb_page for write access

2007-11-19 Thread Hoang-Nam Nguyen
On Wednesday 07 November 2007 20:51, Adam Litke wrote: > > When calling get_user_pages(), a write flag is passed in by the caller to > indicate if write access is required on the faulted-in pages. Currently, > follow_hugetlb_page() ignores this flag and always faults pages for > read-only access.

Re: problem in follow_hugetlb_page on ppc64 architecture with get_user_pages

2007-11-06 Thread Hoang-Nam Nguyen
Hi Adam! On Tuesday 06 November 2007 16:05, aglitke wrote: > Please try this patch and see if it helps. Tested on 2.6.22 (don't have the system with 2.6.23 at the moment) and the testcase ran perfectly. Thanks! Nam ___ Linuxppc-dev mailing list Linuxppc-

Re: problem in follow_hugetlb_page on ppc64 architecture with get_user_pages

2007-11-06 Thread Hoang-Nam Nguyen
Hello Roland! > We currently see this when testing Infiniband on ppc64 with ehca + > hugetlbfs. > From reading the code this should also be an issue on other architectures. > Roland, Adam, are you aware of anything in this area with mellanox > Infiniband cards or other usages with I/O adapters? Bel

Re: [ofa-general] [PATCH 7/7] IB/ehca: Prevent overwriting QP init attributes given by caller

2007-08-16 Thread Hoang-Nam Nguyen
[EMAIL PROTECTED] wrote on 16.08.2007 18:17:22: > I don't understand this patch. says this about > ib_create_qp(): > > * @qp_init_attr: A list of initial attributes required to create the > * QP. If QP creation succeeds, then the attributes are updated to > * the actual capabilities of t

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-08 Thread Hoang-Nam Nguyen
rg. Thanks Nam On Friday 03 August 2007 10:36, Hoang-Nam Nguyen wrote: > From: Hoang-Nam Nguyen > Date: Fri, 3 Aug 2007 09:44:56 +0200 > Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space > This patch utilizes remap_4k_pfn() as introduced by Paul M., > for de

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-03 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen Date: Fri, 3 Aug 2007 09:44:56 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id=10281, to map ehca cq, qp firmware context

[PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-02 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen Date: Thu, 2 Aug 2007 10:08:30 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id=10281, to map ehca cq, qp firmware context

Re: [PATCH 2/5] ehca: Generate event when SRQ limit reached

2007-07-30 Thread Hoang-Nam Nguyen
Hi, > BTW, does your SRQ-capable hardware support generating the "last WQE > reached" event? There's not any reliable way to avoid problems when > destroying QPs attached to an SRQ without it, and the IB spec requires > CAs that support SRQs to generate it (o11-5.2.5 in chapter 11 of vol 1). > >

Re: [ofa-general] [PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

2007-07-30 Thread Hoang-Nam Nguyen
Hi Roland! > the patch looks fine except your mailer seems to have mangled > it... can you resend so I can apply it? Was going to recreate this patch, but then I saw that you probably have incorporated it (manually) in your latest git. Just want to make sure I'm seeing it right. Anyway, appreciate

[PATCH 2/2] ehca: correction include order according kernel coding style

2007-07-27 Thread Hoang-Nam Nguyen
>From a2794450cbee597cefd7b6e159257583c459d358 Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen Date: Fri, 27 Jul 2007 10:26:40 +0200 Subject: [PATCH] correction include order according kernel coding style Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniban

[PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

2007-07-27 Thread Hoang-Nam Nguyen
>From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen Date: Fri, 27 Jul 2007 10:24:49 +0200 Subject: [PATCH] remove checkpatch.pl's warnings "externs should be avoided in .c files" Signed-off-by: Hoang-Nam Nguyen <[EMAIL PRO

[PATCH 0/2] ehca: remove WARNING: externs should be avoided in .c files

2007-07-27 Thread Hoang-Nam Nguyen
Hello Roland! This small patch set fixes some coding-style related issues for ehca: [1/2] remove checkpatch.pl's warnings "externs should be avoided in .c files" [2/2] correction include order according kernel coding style Thanks Nam ___ Linuxppc-dev mai

Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

2007-07-21 Thread Hoang-Nam Nguyen
Hi Roland! > I applied this, but I agree with checkpatch.pl: > > > WARNING: externs should be avoided in .c files > > #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: > > +extern int ehca_mr_largepage; > > > > WARNING: externs should be avoided in .c files > > #949: FILE: drivers/infini

[PATCH 5/5] ehca: Support small QP queues

2007-07-20 Thread Hoang-Nam Nguyen
with firmware, this code needs to manage bite-sized chunks of kernel pages, making sure that no kernel page is shared between different protection domains. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_classes.h | 41 -- drivers/infiniband/h

[PATCH 4/5] ehca: Make internal_create/destroy_qp() static

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 21:40:00 +0200 Subject: [PATCH 4/5] IB/ehca: Make internal_{create,destroy}_qp() static They're only used in ehca_qp.c Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_qp.c | 17 +--

[PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 21:13:57 +0200 Subject: [PATCH 3/5] IB/ehca: Make ehca2ib_return_code() non-inline It's nowhere in the main path and making it non-inline saves ~1.5K of code. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/

[PATCH 2/5] ehca: Generate event when SRQ limit reached

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 20:51:43 +0200 Subject: [PATCH 2/5] IB/ehca: Generate event when SRQ limit reached Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_irq.c | 42 ++--- 1 files changed,

[PATCH 1/5] ehca: Supports large page MRs

2007-07-20 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 20:48:04 +0200 Subject: [PATCH 1/5] IB/ehca: Support large page MRs Add support for MR pages larger than 4K on eHCA2. This reduces firmware memory consumption. If enabled via the mr_largepage module parameter, the MR page siz

[PATCH 0/5] ehca: MR large page, small queue and fixes

2007-07-20 Thread Hoang-Nam Nguyen
Here is a patch set against Roland's git, branch for-2.6.23 for ehca. It adds support for MR large page and small queues. In addition of that it also contains various small fixes from previous comments and what we found. They are in details: [1/5] adds support for MR large page [2/5] generates eve

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-19 Thread Hoang-Nam Nguyen
Roland Dreier <[EMAIL PROTECTED]> wrote on 17.07.2007 19:52:55: > At a higher level, I'm left wondering why nobody talked about multiple > EQs during the last months of the 2.6.22 process and now all of a > sudden it becomes urgent in the last few days of the 2.6.23 merge > window. That's not real

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-16 Thread Hoang-Nam Nguyen
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 18:04:26: > Do you have any data on how well this round-robin assignment works? > It seems not quite right to me for the driver to advertise nr_eqs > completion vectors, but then if round-robin is turned on to ignore the > consumer's decision ab

Re: [PATCH] fix idr_get_new_above id alias bugs

2007-07-11 Thread Hoang-Nam Nguyen
> With this patch, idr.c should work as advertised allocating id > values in the range 0...0x7fff. Andrew had speculated that > it should allow the full range 0...0x to be used. I was > tempted to make changes to allow this, but it would require changes > to API, e.g. making the start

Re: idr_get_new_above() limitation?

2007-07-04 Thread Hoang-Nam Nguyen
On Tuesday 03 July 2007 02:31, Jim Houston wrote: > The problem is in idr_get_new_above_int() in the loop which > adds new layers to the top of the radix tree. It is failing > the "layers < (MAX_LEVEL - 1)" test. It doesn't allocate the > new layer but still calls sub_alloc() which relies on havi

idr_get_new_above() limitation?

2007-07-02 Thread Hoang-Nam Nguyen
Hello, For ehca device driver we're intending to utilize idr_get_new_above() and have written a test case, which I'm attaching at the end. Basically it tries to get an idr token above a lower boundary by calling idr_get_new_above() and then uses idr_find() to check if the returned token can be fo