Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-22 Thread Hans Zhang
On 2025/5/22 19:47, Manivannan Sadhasivam wrote: On Sat, May 17, 2025 at 12:55:14AM +0800, Hans Zhang wrote: The following series introduces a new kernel command-line option aer_panic to enhance error handling for PCIe Advanced Error Reporting (AER) in mission-critical environments. This

Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-22 Thread Hans Zhang
On 2025/5/22 00:17, Sathyanarayanan Kuppuswamy wrote: On 5/21/25 7:54 AM, Hans Zhang wrote: On 2025/5/21 00:09, Sathyanarayanan Kuppuswamy wrote: On 5/19/25 7:41 AM, Hans Zhang wrote: On 2025/5/19 22:21, Hans Zhang wrote: On 2025/5/17 02:10, Sathyanarayanan Kuppuswamy wrote: On

Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-21 Thread Hans Zhang
On 2025/5/21 00:09, Sathyanarayanan Kuppuswamy wrote: On 5/19/25 7:41 AM, Hans Zhang wrote: On 2025/5/19 22:21, Hans Zhang wrote: On 2025/5/17 02:10, Sathyanarayanan Kuppuswamy wrote: On 5/16/25 9:55 AM, Hans Zhang wrote: The following series introduces a new kernel command-line

Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-20 Thread Hans Zhang
On 2025/5/20 06:03, Bjorn Helgaas wrote: On Sat, May 17, 2025 at 12:55:14AM +0800, Hans Zhang wrote: The following series introduces a new kernel command-line option aer_panic to enhance error handling for PCIe Advanced Error Reporting (AER) in mission-critical environments. This feature

Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-19 Thread Hans Zhang
On 2025/5/19 22:21, Hans Zhang wrote: On 2025/5/17 02:10, Sathyanarayanan Kuppuswamy wrote: On 5/16/25 9:55 AM, Hans Zhang wrote: The following series introduces a new kernel command-line option aer_panic to enhance error handling for PCIe Advanced Error Reporting (AER) in mission

Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-19 Thread Hans Zhang
On 2025/5/19 22:21, Hans Zhang wrote: On 2025/5/17 02:10, Sathyanarayanan Kuppuswamy wrote: On 5/16/25 9:55 AM, Hans Zhang wrote: The following series introduces a new kernel command-line option aer_panic to enhance error handling for PCIe Advanced Error Reporting (AER) in mission

Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-19 Thread Hans Zhang
On 2025/5/17 02:10, Sathyanarayanan Kuppuswamy wrote: On 5/16/25 9:55 AM, Hans Zhang wrote: The following series introduces a new kernel command-line option aer_panic to enhance error handling for PCIe Advanced Error Reporting (AER) in mission-critical environments. This feature ensures

Re: [PATCH 3/4] PCI/AER: Expose AER panic state via pci_aer_panic_enabled()

2025-05-19 Thread Hans Zhang
On 2025/5/17 12:07, Sathyanarayanan Kuppuswamy wrote: On 5/16/25 9:55 AM, Hans Zhang wrote: From: Hans Zhang Add pci_aer_panic_enabled() to check if aer_panic is enabled system-wide. Export the function for use in error recovery logic. Signed-off-by: Hans Zhang ---   drivers/pci/pci.h

[PATCH 2/4] PCI/AER: Introduce aer_panic kernel command-line option

2025-05-16 Thread Hans Zhang
From: Hans Zhang Add a new "aer_panic" kernel parameter to force panic on unrecoverable PCIe errors. This prepares for handling fatal AER errors in systems where bus hangs require immediate reboot. Signed-off-by: Hans Zhang --- drivers/pci/pci.c | 2 ++ drivers/pci/pci.

[PATCH 2/2] PCI/AER: Use bool for AER disable state tracking

2025-05-16 Thread Hans Zhang
From: Hans Zhang Change pcie_aer_disable variable to bool and update pci_no_aer() to set it to true. Improves code readability and aligns with modern kernel practices. Signed-off-by: Hans Zhang --- drivers/pci/pcie/aer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 1/4] pci: implement "pci=aer_panic"

2025-05-16 Thread Hans Zhang
" on the kernel command line. It prepares for safer error handling in mission-critical environments by bypassing indefinite hangs and triggering controlled panic. Signed-off-by: Hans Zhang <18255117...@163.com> --- Documentation/admin-guide/kernel-parameters.txt | 7 +++ 1 file chan

[PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-16 Thread Hans Zhang
and other buses connected by PCIe do not have a design to prevent hanging. Once a FATAL error occurs in the PCIe link and cannot be restored, the system needs to be restarted. Dear Mani, I wonder if you know how other SoCs of qcom handle FATAL errors that occur in PCIe link. --- Hans Zhang (4

[PATCH 3/4] PCI/AER: Expose AER panic state via pci_aer_panic_enabled()

2025-05-16 Thread Hans Zhang
From: Hans Zhang Add pci_aer_panic_enabled() to check if aer_panic is enabled system-wide. Export the function for use in error recovery logic. Signed-off-by: Hans Zhang --- drivers/pci/pci.h | 2 ++ drivers/pci/pcie/aer.c | 12 2 files changed, 14 insertions(+) diff --git

[PATCH 4/4] PCI/AER: Trigger kernel panic on recovery failure if aer_panic is set

2025-05-16 Thread Hans Zhang
From: Hans Zhang Modify pcie_do_recovery() to panic the system when device recovery fails and aer_panic is enabled via kernel command-line. This addresses scenarios where PCIe link errors cause bus hangs requiring forced reboots. Signed-off-by: Hans Zhang --- drivers/pci/pcie/err.c | 8

[PATCH 0/2] PCI: Convert MSI and AER state tracking variables to bool type

2025-05-16 Thread Hans Zhang
bool type eliminates ambiguity between integer 1/0 and true/false. Follows modern kernel practices for state tracking with proper type semantics. No functional changes - pure code cleanup to enhance readability and maintainability. Hans Zhang (2): PCI/MSI: Use bool for MSI enable state tracking

[PATCH 1/2] PCI/MSI: Use bool for MSI enable state tracking

2025-05-16 Thread Hans Zhang
From: Hans Zhang Convert pci_msi_enable and pci_msi_enabled() to use bool type for clarity. No functional changes, only code cleanup. Signed-off-by: Hans Zhang --- drivers/pci/msi/api.c | 2 +- drivers/pci/msi/msi.c | 4 ++-- drivers/pci/msi/msi.h | 2 +- include/linux/pci.h | 4 ++-- 4

[PATCH] PCI/AER: Use pci_clear_and_set_config_dword() to simplify mask updates

2025-05-04 Thread Hans Zhang
Replace the manual read-modify-write sequences in pci_aer_unmask_internal_errors()with pci_clear_and_set_config_dword(). This function performs the read/write operations atomically and reduces code duplication. Signed-off-by: Hans Zhang <18255117...@163.com> --- drivers/pci/pcie/aer.