RE: [PATCH v2 07/10] PCI: layerscape: Modify the MSIX to the doorbell way

2019-11-06 Thread Gustavo Pimentel
On Wed, Nov 6, 2019 at 13:39:5, Kishon Vijay Abraham I wrote: Hi Kishon, > Gustavo, > > On 06/11/19 3:10 PM, Gustavo Pimentel wrote: > > On Thu, Aug 29, 2019 at 6:13:18, Kishon Vijay Abraham I > > wrote: > > > > Hi, this email slip away from my attention..

RE: [PATCH v2 07/10] PCI: layerscape: Modify the MSIX to the doorbell way

2019-11-06 Thread Gustavo Pimentel
On Thu, Aug 29, 2019 at 6:13:18, Kishon Vijay Abraham I wrote: Hi, this email slip away from my attention... > Gustavo, > > On 27/08/19 6:55 PM, Andrew Murray wrote: > > On Sat, Aug 24, 2019 at 12:08:40AM +, Xiaowei Bao wrote: > >> > >> > >>> -Original Message- > >>> From: Andrew M

RE: [PATCH v3 01/11] PCI: designware-ep: Add multiple PFs support for DWC

2019-09-26 Thread Gustavo Pimentel
On Thu, Sep 26, 2019 at 11:29:46, Andrew Murray wrote: > On Tue, Sep 03, 2019 at 03:43:15AM +, Xiaowei Bao wrote: > > > > > > > -Original Message- > > > From: Andrew Murray > > > Sent: 2019年9月3日 0:26 > > > To: Xiaowei Bao > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn.

RE: [PATCH v4 01/11] PCI: designware-ep: Add multiple PFs support for DWC

2019-09-26 Thread Gustavo Pimentel
_ENABLE BIT(31) > #define PCIE_ATU_BAR_MODE_ENABLE BIT(30) > +#define PCIE_ATU_FUNC_NUM_MATCH_EN BIT(19) > #define PCIE_ATU_LOWER_BASE 0x90C > #define PCIE_ATU_UPPER_BASE 0x910 > #define PCIE_ATU_LIMIT 0x914 > @@ -206,6 +208,14 @@ struct dw_pcie_ep_ops { > int (*raise_irq)(struct dw_pcie_ep *ep, u8 func_no, >enum pci_epc_irq_type type, u16 interrupt_num); > const struct pci_epc_features* (*get_features)(struct dw_pcie_ep *ep); > + /* > + * Provide a method to implement the different func config space > + * access for different platform, if different func have different > + * offset, return the offset of func. if use write a register way > + * return a 0, and implement code in callback function of platform > + * driver. > + */ > + unsigned int (*func_conf_select)(struct dw_pcie_ep *ep, u8 func_no); > }; > > struct dw_pcie_ep { > @@ -277,8 +287,12 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci); > void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, > int type, u64 cpu_addr, u64 pci_addr, > u32 size); > -int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, int index, int bar, > - u64 cpu_addr, enum dw_pcie_as_type as_type); > +void dw_pcie_prog_ep_outbound_atu(struct dw_pcie *pci, u8 func_no, int index, > + int type, u64 cpu_addr, u64 pci_addr, > + u32 size); > +int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, u8 func_no, int index, > + int bar, u64 cpu_addr, > + enum dw_pcie_as_type as_type); > void dw_pcie_disable_atu(struct dw_pcie *pci, int index, >enum dw_pcie_region_type type); > void dw_pcie_setup(struct dw_pcie *pci); > -- > 2.9.5 Acked-by: Gustavo Pimentel

RE: [PATCH v3 08/11] PCI: layerscape: Modify the MSIX to the doorbell mode

2019-09-16 Thread Gustavo Pimentel
On Sat, Sep 14, 2019 at 7:37:54, Xiaowei Bao wrote: > > > > -Original Message- > > From: Gustavo Pimentel > > Sent: 2019年9月12日 19:24 > > To: Andrew Murray ; Xiaowei Bao > > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn

RE: [PATCH v3 08/11] PCI: layerscape: Modify the MSIX to the doorbell mode

2019-09-12 Thread Gustavo Pimentel
Hi, Sorry for the delay I was in parental leave and I'm still trying not to drown in the mailing list emails... 😊 On Mon, Sep 2, 2019 at 13:1:47, Andrew Murray wrote: > On Mon, Sep 02, 2019 at 11:17:13AM +0800, Xiaowei Bao wrote: > > dw_pcie_ep_raise_msix_irq was never called in the exisitng