Hi Tony,
On Thu, Mar 13, 2008 at 08:20:05AM +1100, Tony Breeds wrote:
[..snip..]
> where pmu_sys_suspended is referenced and I'm having difficulty
> understanding how CONFIG_HIBERNATION is affecting that.
I mangled the filenames and didn't notice that you fixed the header file
instead of via-pmu.c
Hi Tony,
On Wed, Mar 12, 2008 at 10:48:48AM +1100, Tony Breeds wrote:
> pmu_sys_suspended is declared extern when:
> defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
> but only defined when:
> defined(CONFIG_SUSPEND) && defined(CONFIG_PPC32)
> which is wrong. Lets fix that.
As I wrote
Hi,
This is a resend, since it's still unfixed in current Linus git and I
didn't see any comments (please cc: me since I'm not subscribed):
Otherwise without CONFIG_SUSPEND we have:
ERROR: "pmu_batteries" [drivers/macintosh/apm_emu.ko] undefined!
ERROR: "pmu_battery_count" [drivers/macintosh/apm_
Hi,
This is a resend, since it's still unfixed in current Linus git and I
didn't see any comments (please cc: me since I'm not subscribed):
In current Linus git pmu_sys_suspended is only defined if
CONFIG_SUSPEND is set, so compilation fails with:
drivers/built-in.o: In function `pmu_led_set':
vi
In current Linus git pmu_sys_suspended is only defined if
CONFIG_SUSPEND is set, so compilation fails with:
drivers/built-in.o: In function `pmu_led_set':
via-pmu-led.c:(.text+0x48622): undefined reference to `pmu_sys_suspended'
via-pmu-led.c:(.text+0x48626): undefined reference to `pmu_sys_suspen
Otherwise without CONFIG_SUSPEND we have:
ERROR: "pmu_batteries" [drivers/macintosh/apm_emu.ko] undefined!
ERROR: "pmu_battery_count" [drivers/macintosh/apm_emu.ko] undefined!
ERROR: "pmu_power_flags" [drivers/macintosh/apm_emu.ko] undefined!
on PPC32. The variables aren't wrapped in '#if defined
