Re: [RFC PATCH 01/21] crypto: scomp - Revert "add support for deflate rfc1950 (zlib)"

2023-08-03 Thread Giovanni Cabiddu
On Thu, Aug 03, 2023 at 11:59:00AM +0200, Ard Biesheuvel wrote: > Any clue why zlib_deflate was chosen in this case? I believe it was done for integrity. The output of zlib_deflate is raw deflate with an header and a footer defined in rfc1950. The footer contains a checksum which gets calculated ov

Re: [RFC PATCH 01/21] crypto: scomp - Revert "add support for deflate rfc1950 (zlib)"

2023-08-03 Thread Giovanni Cabiddu
Hi Ard, On Tue, Jul 18, 2023 at 01:58:27PM +0100, Ard Biesheuvel wrote: > This reverts commit a368f43d6e3a001e684e9191a27df384fbff12f5. > > "zlib-deflate" was introduced 6 years ago, but it does not have any > users. So let's remove the generic implementation and the test vectors, > but retain th