Re: [PATCH 16/22] crypto: ccree - add check for xts input length equal to zero

2020-08-08 Thread Gilad Ben-Yossef
(aes) but also for cts(cbc(aes)) > and cts(cbc(paes)). > > Cc: Gilad Ben-Yossef > Signed-off-by: Andrei Botila > --- > drivers/crypto/ccree/cc_cipher.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/crypto/ccree/cc_cipher.c

[PATCH] crypto: reorder paes test lexicographically

2018-05-11 Thread Gilad Ben-Yossef
Due to a snafu "paes" testmgr tests were not ordered lexicographically, which led to boot time warnings. Reorder the tests as needed. Fixes: a794d8d ("crypto: ccree - enable support for hardware keys") Reported-by: Abdul Haleem Signed-off-by: Gilad Ben-Yossef --- c

Re: [next-20180509][bisected a794d8d] ppc boot warnings at crypto/testmgr.c:3720

2018-05-11 Thread Gilad Ben-Yossef
at the cipher test names are alphabetically ordered. I wonder why I didn't see this myself as I'm 100% sure booted this fix on 2 different platforms. Maybe because Khazad was not enabled in my test setup and I guess there are no other cipher starting in I, L,M,N,O ? Fix coming up shortly

Re: [RFC PATCH 0/9] Remove useless on_each_cpu return value

2012-01-08 Thread Gilad Ben-Yossef
On Fri, Jan 6, 2012 at 3:03 PM, Peter Zijlstra wrote: > On Tue, 2012-01-03 at 16:19 +0200, Gilad Ben-Yossef wrote: >> on_each_cpu() returns as its own return value the return value of >> smp_call_function(). smp_call_function() in turn returns a hard >> coded value of zero.

[RFC PATCH v2 8/9] smp: refactor on_each_cpu to void returning func

2012-01-08 Thread Gilad Ben-Yossef
on_each_cpu returns the retunr value of smp_call_function which is hard coded to 0. Refactor on_each_cpu to a void function and the few callers that check the return value to save compares and branches. Signed-off-by: Gilad Ben-Yossef Acked-by: Peter Zijlstra Reviewed-by: Michal Nazarewicz CC

[RFC PATCH v2 5/9] ppc: avoid using on_each_cpu hard coded ret value

2012-01-08 Thread Gilad Ben-Yossef
on_each_cpu always returns a hard coded return code of zero. Removing all tests based on this return value saves run time cycles for compares and code bloat for branches. Signed-off-by: Gilad Ben-Yossef Acked-by: Peter Zijlstra Reviewed-by: Michal Nazarewicz CC: Benjamin Herrenschmidt CC

[RFC PATCH v2 0/9] Remove useless on_each_cpu return value

2012-01-08 Thread Gilad Ben-Yossef
t git://github.com/gby/linux.git Signed-off-by: Gilad Ben-Yossef Acked-by: Peter Zijlstra Reviewed-by: Michal Nazarewicz CC: Michal Nazarewicz CC: David Airlie CC: dri-de...@lists.freedesktop.org CC: Benjamin Herrenschmidt CC: Paul Mackerras CC: Grant Likely CC: Rob Herring CC: linuxpp

Re: [RFC PATCH 0/9] Remove useless on_each_cpu return value

2012-01-03 Thread Gilad Ben-Yossef
2012/1/3 Michal Nazarewicz : > On Tue, 03 Jan 2012 15:19:04 +0100, Gilad Ben-Yossef > wrote: >> >> on_each_cpu() returns as its own return value the return value of >> smp_call_function(). smp_call_function() in turn returns a hard >> coded value of zero. >> &g

[RFC PATCH 8/9] smp: refactor on_each_cpu to void returning func

2012-01-03 Thread Gilad Ben-Yossef
on_each_cpu returns the retunr value of smp_call_function which is hard coded to 0. Refactor on_each_cpu to a void function and the few callers that check the return value to save compares and branches. CC: Michal Nazarewicz CC: David Airlie CC: dri-de...@lists.freedesktop.org CC: Benjamin Herr

[RFC PATCH 5/9] ppc: avoid using on_each_cpu hard coded ret value

2012-01-03 Thread Gilad Ben-Yossef
on_each_cpu always returns a hard coded return code of zero. Removing all tests based on this return value saves run time cycles for compares and code bloat for branches. CC: Michal Nazarewicz CC: Benjamin Herrenschmidt CC: Paul Mackerras CC: Grant Likely CC: Rob Herring CC: linuxppc-dev@lis

[RFC PATCH 0/9] Remove useless on_each_cpu return value

2012-01-03 Thread Gilad Ben-Yossef
Yu CC: linux-i...@vger.kernel.org CC: Will Deacon CC: Peter Zijlstra CC: Arnaldo Carvalho de Melo CC: Russell King CC: linux-arm-ker...@lists.infradead.org Gilad Ben-Yossef (9): arm: avoid using on_each_cpu hard coded ret value ia64: avoid using on_each_cpu hard coded ret value x86: avoid using o