Re: [PATCH 2/2] PCI: dwc: layerscape: Use syscon_regmap_lookup_by_phandle_args

2025-01-13 Thread Frank Li
phandle has arguments, so grepping for code would be easier. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-layerscape.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/con

Re: [PATCH 1/1] dt-bindings: soc: fsl: cpm_qe: convert network.txt to yaml

2024-08-12 Thread Frank Li
On Mon, Aug 12, 2024 at 12:50:35PM -0400, Frank Li wrote: > Convert binding doc newwork.txt to yaml format. > > HDLC part: > - Convert to "fsl,ucc-hdlc.yaml". > - Add missed reg and interrupt property. > - Update example to pass build. > > ethernet part: &g

[PATCH 1/1] dt-bindings: soc: fsl: cpm_qe: convert network.txt to yaml

2024-08-12 Thread Frank Li
o ethernet-controller.yaml mdio part: - Convert to net/fsl,cpm-mdio.yaml - Add 0x in example, which should be hex value - Add ref to mdio.yaml Signed-off-by: Frank Li --- This one is quite old. The detail informaiton is limited. --- .../devicetree/bindings/net/fsl,cpm-enet.yaml | 59 .../devicetre

Re: [PATCH] dt-bindings: fsl: fsl,rcpm: fix unevaluated fsl,rcpm-wakeup property

2024-08-11 Thread Frank Li
/schemas/serial/fsl-lpuart.yaml# > > Alternatively, this property could be added to LPUART binding > (fsl-lpuart.yaml), but it looks like none of in-tree DTS use it. > > Fixes: ad21e3840a88 ("dt-bindings: soc: fsl: Convert rcpm to yaml format") > Signed-off-by: Krzysztof Ko

[PATCH 1/1] dt-bindings: soc: fsl: cpm_qe: convert network.txt to yaml

2024-08-09 Thread Frank Li
o ethernet-controller.yaml mdio part: - Convert to net/fsl,cpm-mdio.yaml - Add 0x in example, which should be hex value - Add ref to mdio.yaml Signed-off-by: Frank Li --- This one is quite old. The detail informaiton is limited. --- .../devicetree/bindings/net/fsl,cpm-enet.yaml | 59 .../devicetre

[PATCH v2 1/1] dt-bindings: soc: fsl: add missed compatible string fsl,ls*-isc

2024-08-06 Thread Frank Li
Add compatible string, fsl,ls1088a-isc, fsl,ls2080a-isc, fsl,lx2160a-isc. Fix the below warning: arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dtb: /soc/syscon@1f7: failed to match any schema with compatible: ['fsl,ls2080a-isc', 'syscon'] Signed-off-by: Frank Li ---

[PATCH 1/1] dt-bindings: soc: fsl: add missed compatible string fsl,ls*-isc

2024-08-02 Thread Frank Li
Add compatible string, fsl,ls1088a-isc, fsl,ls2080a-isc, fsl,lx2160a-isc. Fix the below warning: arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dtb: /soc/syscon@1f7: failed to match any schema with compatible: ['fsl,ls2080a-isc', 'syscon'] Signed-off-by: Frank Li --- ...

[PATCH v4 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-08-02 Thread Frank Li
Convert dt-binding rcpm from txt to yaml format. Add fsl,ls1028a-rcpm compatible string. Additional changes: - Add missed compatible string fsl,-rcpm. - Remove map fsl,-rcpm to fsl,qoriq-rcpm-. Signed-off-by: Frank Li --- Change from v3 to v4 - Add missed fsl,ls1088a-rcpm, fsl,ls208xa-rcpm, fsl

[PATCH v3 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-08-01 Thread Frank Li
Convert dt-binding rcpm from txt to yaml format. Add fsl,ls1028a-rcpm compatible string. Additional changes: - Add missed compatible string fsl,-rcpm. - Remove map fsl,-rcpm to fsl,qoriq-rcpm-. Signed-off-by: Frank Li --- Chagne from v2 to v3 - fallback use const - order as fallback compatible

Re: [PATCH v2 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-07-31 Thread Frank Li
On Wed, Jul 31, 2024 at 11:04:20AM -0400, Frank Li wrote: > Convert dt-binding rcpm from txt to yaml format. > Add fsl,ls1028a-rcpm compatible string. > > Additional changes: > - Add missed compatible string fsl,-rcpm. > - Remove map fsl,-rcpm to fsl,qoriq-rcpm-. > >

[PATCH v2 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-07-31 Thread Frank Li
Convert dt-binding rcpm from txt to yaml format. Add fsl,ls1028a-rcpm compatible string. Additional changes: - Add missed compatible string fsl,-rcpm. - Remove map fsl,-rcpm to fsl,qoriq-rcpm-. Signed-off-by: Frank Li --- Change from v1 to v2 - add missed compatible string - Remove compatible

[PATCH 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-07-29 Thread Frank Li
Convert dt-binding rcpm from txt to yaml format. Add fsl,ls1028a-rcpm compatible string. Signed-off-by: Frank Li --- .../bindings/rtc/fsl,ls-ftm-alarm.yaml| 2 +- .../devicetree/bindings/soc/fsl/fsl,rcpm.yaml | 91 +++ .../devicetree/bindings/soc/fsl/rcpm.txt | 69

[PATCH 2/2] arm64: dts: fsl-ls1028a.dtsi: add fsl,ls1028-reset for syscon

2024-07-03 Thread Frank Li
x27; is not one of ['al,alpine-sysfabric-service', ... Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/

[PATCH 1/2] dt-bindings: soc: fsl: Add fsl,ls1028a-reset for reset syscon node

2024-07-03 Thread Frank Li
'syscon' is not one of ['al,alpine-sysfabric-service', ...] Signed-off-by: Frank Li --- .../bindings/soc/fsl/fsl,ls1028a-reset.yaml| 56 ++ 1 file changed, 56 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/fsl/fsl,ls1028

[PATCH 0/2] dt-bindings: soc: add reset syscon for reboot node

2024-07-03 Thread Frank Li
Add ls1028 reset syscon and fix below warnings. syscon@1e6: compatible: 'anyOf' conditional failed, one must be fixed: ['syscon'] is too short 'syscon' is not one of ['al,alpine-sysfabric-service', ... Signed-off-by: Frank Li

[PATCH 2/2] arm64: dts: fsl-ls1043a: change uqe to uqe-bus and remove #address-cells

2024-07-03 Thread Frank Li
yaml# arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: siram@1000: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe-siram.yaml# Signed-off-by: Frank Li

[PATCH 1/2] dt-bindings: soc: fsl: cpm_qe: convert to yaml format

2024-07-03 Thread Frank Li
4/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/uqe@240/qeic@80: failed to match any schema with compatible: ['fsl,qe-ic'] Signed-off-by: Frank Li --- .../bindings/soc/fsl/cpm_qe/fsl,qe-firmware.yaml | 48 ++ .../bindings/soc/fsl/cpm_qe/fsl,qe-ic.yaml | 47 ++

[PATCH 0/2] dt-bindings: soc: fsl: convert fsl,qe to yaml

2024-07-03 Thread Frank Li
Convert fsl,qe to yaml and fix ls1043 dtb check warnings. Signed-off-by: Frank Li --- Frank Li (2): dt-bindings: soc: fsl: cpm_qe: convert to yaml format arm64: dts: fsl-ls1043a: change uqe to uqe-bus and remove #address-cells .../bindings/soc/fsl/cpm_qe/fsl,qe-firmware.yaml

Re: [Patch v5 08/12] dmaengine: Add dma router for pl08x in LPC32XX SoC

2024-07-01 Thread Frank Li
On Thu, Jun 27, 2024 at 05:00:26PM +0200, Piotr Wojtaszczyk wrote: > LPC32XX connects few of its peripherals to pl08x DMA thru a multiplexer, ^^^ through? I google 'thru', most said it is informal spell of 'through'. > this driver allows to ro

[PATCH v2 1/1] dt-bindings: soc: fsl: Convert q(b)man-* to yaml format

2024-06-26 Thread Frank Li
part Signed-off-by: Frank Li --- Change from v1 to v2 - fix typo chang - fix typo porta - Add | for reg description - wrap to 80 for reg descritption - memory-region set maxItems: 2 - fix regex parttern - drop See clock-bindings.txt - "see reserved-memory.yaml" change to "see

[PATCH 1/1] dt-bindings: soc: fsl: Convert q(b)man-* to yaml format

2024-06-21 Thread Frank Li
part Signed-off-by: Frank Li --- .../bindings/soc/fsl/bman-portals.txt | 56 -- .../devicetree/bindings/soc/fsl/bman.txt | 137 - .../bindings/soc/fsl/fsl,bman-portal.yaml | 51 + .../devicetree/bindings/soc/fsl/fsl,bman.yaml | 83 .../bindings/soc

Re: [PATCH 2/5] PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers

2024-06-06 Thread Frank Li
ine and also cleanup any configuration that > got affected by the fundamental reset like BAR, DMA etc... > > This change also warrants skipping the cleanups in unbind() if already done > in epc_deinit(). > > Reviewed-by: Niklas Cassel > Signed-off-by: Manivannan Sadhasivam

Re: [PATCH 1/5] PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper

2024-06-06 Thread Frank Li
irectly from glue > drivers. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- > drivers/pci/controller/dwc/pci-imx6.c | 2 +- > drivers/pci/c

Re: [PATCH 5/5] PCI: layerscape-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event

2024-06-06 Thread Frank Li
rn Helgaas > Closes: https://lore.kernel.org/linux-pci/20240528195539.GA458945@bhelgaas/ > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH v12 8/8] PCI: endpoint: Remove "core_init_notifier" flag

2024-03-29 Thread Frank Li
an send the notification > before the EPF drivers bind() and in those cases the EPF drivers will miss > the event. To accommodate this, EPC core is now caching the state of the > EPC initialization in 'init_complete' flag and pci-ep-cfs driver sends the > notification

Re: [PATCH v12 7/8] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers

2024-03-29 Thread Frank Li
t(). > > With this change, the check for 'core_init_notifier' flag can now be > dropped from dw_pcie_ep_init() API. This will also allow us to remove the > 'core_init_notifier' flag completely in the later commits. > > Reviewed-by: Yoshihiro Shimoda > Reviewed-

[PATCH 1/1] PCI: layerscape(ep): Implement common 'dbi' reg-names for dbi_base

2024-02-29 Thread Frank Li
arning message. Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 ++- drivers/pci/controller/dwc/pci-layerscape.c| 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/cont

Re: [PATCH v8 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event

2024-02-27 Thread Frank Li
On Tue, Feb 27, 2024 at 06:02:30PM +0530, Manivannan Sadhasivam wrote: > On Mon, Feb 26, 2024 at 12:20:41PM -0500, Frank Li wrote: > > On Sat, Feb 24, 2024 at 12:24:15PM +0530, Manivannan Sadhasivam wrote: > > > Now that the API is available, let's make use of

Re: [PATCH v8 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers

2024-02-27 Thread Frank Li
On Tue, Feb 27, 2024 at 05:51:41PM +0530, Manivannan Sadhasivam wrote: > On Mon, Feb 26, 2024 at 12:04:33PM -0500, Frank Li wrote: > > On Sat, Feb 24, 2024 at 12:24:12PM +0530, Manivannan Sadhasivam wrote: > > > Currently, dw_pcie_ep_init_registers() API is directly

Re: [PATCH v8 08/10] PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event

2024-02-27 Thread Frank Li
On Tue, Feb 27, 2024 at 06:00:24PM +0530, Manivannan Sadhasivam wrote: > On Mon, Feb 26, 2024 at 12:18:18PM -0500, Frank Li wrote: > > On Sat, Feb 24, 2024 at 12:24:14PM +0530, Manivannan Sadhasivam wrote: > > > The PCIe link can go to LINK_DOWN state in one of the f

Re: [PATCH v8 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs

2024-02-26 Thread Frank Li
On Sat, Feb 24, 2024 at 12:24:16PM +0530, Manivannan Sadhasivam wrote: > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pcie-desig

Re: [PATCH v8 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event

2024-02-26 Thread Frank Li
On Sat, Feb 24, 2024 at 12:24:15PM +0530, Manivannan Sadhasivam wrote: > Now that the API is available, let's make use of it. It also handles the > reinitialization of DWC non-sticky registers in addition to sending the > notification to EPF drivers. > > Signed-off-by: Manivannan Sadhasivam > ---

Re: [PATCH v8 08/10] PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event

2024-02-26 Thread Frank Li
On Sat, Feb 24, 2024 at 12:24:14PM +0530, Manivannan Sadhasivam wrote: > The PCIe link can go to LINK_DOWN state in one of the following scenarios: > > 1. Fundamental (PERST#)/hot/warm reset > 2. Link transition from L2/L3 to L0 >From L0 to L2/l3 > > In those cases, LINK_DOWN causes some non-st

Re: [PATCH v8 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag

2024-02-26 Thread Frank Li
is that, the drivers requiring refclk from host will > send the notification once refclk is received, while others will send it > during probe time itself. > > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-dra7xx.c

Re: [PATCH v8 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers

2024-02-26 Thread Frank Li
On Sat, Feb 24, 2024 at 12:24:12PM +0530, Manivannan Sadhasivam wrote: > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > drivers requiring active refclk from host. But for the other drivers, it is > getting called implicitly by dw_pcie_ep_init(). This is due to the fact

Re: [PATCH v8 05/10] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers()

2024-02-26 Thread Frank Li
causes confusion. So, > let's rename it to dw_pcie_ep_init_registers() to make it clear that it > initializes the DWC specific registers. > > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 6 +

Re: [PATCH v8 04/10] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host

2024-02-26 Thread Frank Li
ing > 'core_init_notifier' flag once refclk is received from host. For the rest > of the drivers that gets the refclk locally, this API will be called > within dw_pcie_ep_init(). > > Fixes: e966f7390da9 ("PCI: dwc: Refactor core initialization code for E

Re: [PATCH v8 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST#

2024-02-26 Thread Frank Li
nup() API that could be called by these > drivers to cleanup the DWC specific resources. Currently, it just removes > eDMA. > > Reported-by: Niklas Cassel > Closes: https://lore.kernel.org/linux-pci/ZWYmX8Y%2F7Q9WMxES@x1-carbon > Signed-off-by: Manivannan Sadhasivam Review

Re: [PATCH v8 02/10] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit()

2024-02-26 Thread Frank Li
() to make the > purpose of this API clear. This also aligns with the DWC host driver. > > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++-- > drivers/pci/controller/dwc/pcie-designware.h| 4 ++-- &g

Re: [PATCH v8 01/10] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops

2024-02-26 Thread Frank Li
API in rcar_gen4_remove_dw_pcie_ep(). > > This simplifies the DWC layer. > > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 9 + > drivers/pci/controller/dwc/pcie-designware.h| 1 -

[PATCH 4/4] powerpc: dts: fsl: rename ifc node name to be memory-controller

2024-01-19 Thread Frank Li
From: Li Yang Update the node name to be align with binding document. Signed-off-by: Li Yang Signed-off-by: Frank Li --- arch/powerpc/boot/dts/fsl/bsc9131rdb.dts| 2 +- arch/powerpc/boot/dts/fsl/bsc9132qds.dts| 2 +- arch/powerpc/boot/dts/fsl/c293pcie.dts | 2 +- arch/powerpc

[PATCH 3/4] powerpc: dts: mpc85xx: remove "simple-bus" compatible from ifc node

2024-01-19 Thread Frank Li
From: Li Yang Update dts to match dts binding document. Signed-off-by: Li Yang Signed-off-by: Frank Li --- arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 2 +- arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi | 2 +- arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi | 2 +- arch/powerpc/boot/dts

[PATCH 2/4] powerpc: dts: p1010rdb: fix INTx interrupt issue on P1010RDB-PB

2024-01-19 Thread Frank Li
0RDB-PB do not work because of the pcie@0 node fixup will be overwrited by p1010si-post.dtsi file, so we move the pcie@0 node fixup to p1010rdb-pb.dts and p1010rdb-pb_36b.dts. Signed-off-by: Xiaowei Bao Signed-off-by: Li Yang Signed-off-by: Frank Li --- arch/powerpc/boot/dts/fsl/p1010rdb-pb.dt

[PATCH 1/4] powerpc: dts: add power management nodes to FSL chips

2024-01-19 Thread Frank Li
From: Ran Wang Enable Power Management feature on device tree, including MPC8536, MPC8544, MPC8548, MPC8572, P1010, P1020, P1021, P1022, P2020, P2041, P3041, T104X, T1024. Signed-off-by: Zhao Chenhui Signed-off-by: Ran Wang Signed-off-by: Frank Li --- arch/powerpc/boot/dts/fsl/mpc8536si

Re: [PATCH v6 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-12-11 Thread Frank Li
On Mon, Dec 04, 2023 at 11:08:29AM -0500, Frank Li wrote: > Add suspend/resume support for Layerscape LS1043a. > > In the suspend path, PME_Turn_Off message is sent to the endpoint to > transition the link to L2/L3_Ready state. In this SoC, there is no way to > check if the

[PATCH v6 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-12-04 Thread Frank Li
. Acked-by: Roy Zang Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- Notes: Chagne from v5 to v6 - none Change from v4 to v5 - update commit message - use comments /* Reset the PEX wrapper to bring the link out of L2 */ Change from v3 to v4

[PATCH v6 3/4] PCI: layerscape(ep): Rename pf_* as pf_lut_*

2023-12-04 Thread Frank Li
'pf' and 'lut' is just difference name in difference chips, but basic it is a MMIO base address plus an offset. Rename it to avoid duplicate pf_* and lut_* in driver. Reviewed-by: Manivannan Sadhasivam Acked-by: Roy Zang Signed-off-by: Frank Li --- Notes: pf_lut is

[PATCH v6 2/4] PCI: layerscape: Add suspend/resume for ls1021a

2023-12-04 Thread Frank Li
. Acked-by: Roy Zang Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- Notes: Change from v5 to v6 - remove reduntant pci->pp.ops = &ls_pcie_host_ops; Change from v4 to v5 - update comit message - remove a empty line - use comments /* Reset

[PATCH v6 1/4] PCI: layerscape: Add function pointer for exit_from_l2()

2023-12-04 Thread Frank Li
xit resume flow. Acked-by: Roy Zang Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- Notes: Change from v4 to v6 - none Change from v3 to v4 - update commit message Add mani's review by tag Change from v2 to v3 - fixed according to mani's feedba

[PATCH v6 0/4] PCI: layerscape: Add suspend/resume support for ls1043 and ls1021

2023-12-04 Thread Frank Li
Add suspend/resume support for ls1043 and ls1021. Change log see each patch Frank Li (4): PCI: layerscape: Add function pointer for exit_from_l2() PCI: layerscape: Add suspend/resume for ls1021a PCI: layerscape(ep): Rename pf_* as pf_lut_* PCI: layerscape: Add suspend/resume for ls1043a

[PATCH v5 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-12-01 Thread Frank Li
. Signed-off-by: Frank Li --- Notes: Change from v4 to v5 - update commit message - use comments /* Reset the PEX wrapper to bring the link out of L2 */ Change from v3 to v4 - Call scfg_pcie_send_turnoff_msg() shared with ls1021a - update commit message

[PATCH v5 3/4] PCI: layerscape(ep): Rename pf_* as pf_lut_*

2023-12-01 Thread Frank Li
'pf' and 'lut' is just difference name in difference chips, but basic it is a MMIO base address plus an offset. Rename it to avoid duplicate pf_* and lut_* in driver. Signed-off-by: Frank Li --- Notes: pf_lut is better than pf_* or lut* because some chip use 'pf

[PATCH v5 2/4] PCI: layerscape: Add suspend/resume for ls1021a

2023-12-01 Thread Frank Li
. Signed-off-by: Frank Li --- Notes: Change from v4 to v5 - update comit message - remove a empty line - use comments /* Reset the PEX wrapper to bring the link out of L2 */ - pci->pp.ops = pcie->drvdata->ops, ls_pcie_host_ops to the "ops" member of

[PATCH v5 1/4] PCI: layerscape: Add function pointer for exit_from_l2()

2023-12-01 Thread Frank Li
xit resume flow. Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- Notes: Change from v4 to v5 - none Change from v3 to v4 - update commit message Add mani's review by tag Change from v2 to v3 - fixed according to mani's feedback 1. upda

[PATCH v5 0/4] PCI: layerscape: Add suspend/resume support for ls1043 and ls1021

2023-12-01 Thread Frank Li
Add suspend/resume support for ls1043 and ls1021. Change log see each patch Frank Li (4): PCI: layerscape: Add function pointer for exit_from_l2() PCI: layerscape: Add suspend/resume for ls1021a PCI: layerscape(ep): Rename pf_* as pf_lut_* PCI: layerscape: Add suspend/resume for ls1043a

Re: [PATCH v4 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-11-30 Thread Frank Li
On Thu, Nov 30, 2023 at 03:17:39PM -0500, Frank Li wrote: > On Thu, Nov 30, 2023 at 10:21:00PM +0530, Manivannan Sadhasivam wrote: > > On Wed, Nov 29, 2023 at 04:44:12PM -0500, Frank Li wrote: > > > In the suspend path, PME_Turn_Off message is sent to the endpoint to > >

Re: [PATCH v4 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-11-30 Thread Frank Li
On Thu, Nov 30, 2023 at 10:21:00PM +0530, Manivannan Sadhasivam wrote: > On Wed, Nov 29, 2023 at 04:44:12PM -0500, Frank Li wrote: > > In the suspend path, PME_Turn_Off message is sent to the endpoint to > > transition the link to L2/L3_Ready state. In this SoC, there is no way to &

[PATCH v4 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-11-29 Thread Frank Li
PCIE_PME_TO_L2_TIMEOUT_US before asserting the SoC specific PMXMTTURNOFF bit to complete the PME_Turn_Off handshake. This link would then enter L2/L3 state depending on the VAUX supply. In the resume path, the link is brought back from L2 to L0 by doing a software reset. Signed-off-by: Frank Li --- Notes: Change

[PATCH v4 3/4] PCI: layerscape: Rename pf_* as pf_lut_*

2023-11-29 Thread Frank Li
'pf' and 'lut' is just difference name in difference chips, but basic it is a MMIO base address plus an offset. Rename it to avoid duplicate pf_* and lut_* in driver. Signed-off-by: Frank Li --- Notes: pf_lut is better than pf_* or lut* because some chip use 'pf

[PATCH v4 2/4] PCI: layerscape: Add suspend/resume for ls1021a

2023-11-29 Thread Frank Li
-by: Frank Li --- Notes: Change from v3 to v4 - update commit message. - it is reset a glue logic part for PCI controller. - use regmap_write_bits() to reduce code change. Change from v2 to v3 - update according to mani's feedback change from v1 to v2 - c

[PATCH v4 1/4] PCI: layerscape: Add function pointer for exit_from_l2()

2023-11-29 Thread Frank Li
xit resume flow. Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- Notes: Change from v3 to v4 - update commit message Add mani's review by tag Change from v2 to v3 - fixed according to mani's feedback 1. update commit message 2. move dw_pc

[PATCH v4 0/4] dwc general suspend/resume functionality

2023-11-29 Thread Frank Li
Add a API for dwc suspend/resume. In layerscape platform call this api. Frank Li (4): PCI: layerscape: Add function pointer for exit_from_l2() PCI: layerscape: Add suspend/resume for ls1021a PCI: layerscape: Rename pf_* as pf_lut_* PCI: layerscape: Add suspend/resume for ls1043a drivers

Re: [PATCH v3 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-11-02 Thread Frank Li
On Thu, Nov 02, 2023 at 11:09:00PM +0530, Manivannan Sadhasivam wrote: > On Tue, Oct 17, 2023 at 03:31:45PM -0400, Frank Li wrote: > > ls1043a add suspend/resume support. > > Implement ls1043a_pcie_send_turnoff_msg() to send PME_Turn_Off message. > > Implement ls1043a_pcie_e

Re: [PATCH v3 3/4] PCI: layerscape: Rename pf_* as pf_lut_*

2023-11-02 Thread Frank Li
On Thu, Nov 02, 2023 at 11:03:14PM +0530, Manivannan Sadhasivam wrote: > On Tue, Oct 17, 2023 at 03:31:44PM -0400, Frank Li wrote: > > 'pf' and 'lut' is just difference name in difference chips, but basic it is > > a MMIO base address plus an offset. > >

Re: [PATCH v3 2/4] PCI: layerscape: Add suspend/resume for ls1021a

2023-11-02 Thread Frank Li
On Thu, Nov 02, 2023 at 10:58:09PM +0530, Manivannan Sadhasivam wrote: > On Tue, Oct 17, 2023 at 03:31:43PM -0400, Frank Li wrote: > > ls1021a add suspend/resume support. > > > > Implement callback ls1021a_pcie_send_turnoff_msg(), which write scfg's > > SCFG

Re: [PATCH v3 1/4] PCI: layerscape: Add function pointer for exit_from_l2()

2023-11-02 Thread Frank Li
On Thu, Nov 02, 2023 at 10:28:08PM +0530, Manivannan Sadhasivam wrote: > On Tue, Oct 17, 2023 at 03:31:42PM -0400, Frank Li wrote: > > Since difference SoCs require different sequence for exiting L2, let's add > > a separate "exit_from_l2()" callback. This callback

Re: [PATCH v3 0/4] PCI: layerscape: Add suspend/resume support for ls1043 and ls1021

2023-10-27 Thread Frank Li
On Tue, Oct 17, 2023 at 03:31:41PM -0400, Frank Li wrote: > Add suspend/resume support for ls1043 and ls1021. > Change log see each patch > > Frank Li (4): > PCI: layerscape: Add function pointer for exit_from_l2() > PCI: layerscape: Add suspend/resume for ls1021a > PC

[PATCH v3 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-10-17 Thread Frank Li
ls1043a add suspend/resume support. Implement ls1043a_pcie_send_turnoff_msg() to send PME_Turn_Off message. Implement ls1043a_pcie_exit_from_l2() to exit from L2 state. Signed-off-by: Frank Li --- Notes: Change from v2 to v3 - Remove ls_pcie_lut_readl(writel) function Change

[PATCH v3 3/4] PCI: layerscape: Rename pf_* as pf_lut_*

2023-10-17 Thread Frank Li
'pf' and 'lut' is just difference name in difference chips, but basic it is a MMIO base address plus an offset. Rename it to avoid duplicate pf_* and lut_* in driver. Signed-off-by: Frank Li --- Notes: change from v1 to v3 - new patch at v3 drivers/pci/controller/

[PATCH v3 2/4] PCI: layerscape: Add suspend/resume for ls1021a

2023-10-17 Thread Frank Li
ls1021a add suspend/resume support. Implement callback ls1021a_pcie_send_turnoff_msg(), which write scfg's SCFG_PEXPMWRCR to issue PME_Turn_off message. Implement ls1021a_pcie_exit_from_l2() to let controller exit L2 state. Signed-off-by: Frank Li --- Notes: Change from v2

[PATCH v3 1/4] PCI: layerscape: Add function pointer for exit_from_l2()

2023-10-17 Thread Frank Li
Since difference SoCs require different sequence for exiting L2, let's add a separate "exit_from_l2()" callback. This callback can be used to execute SoC specific sequence. Signed-off-by: Frank Li --- Notes: Change from v2 to v3 - fixed according to mani's feed

[PATCH v3 0/4] PCI: layerscape: Add suspend/resume support for ls1043 and ls1021

2023-10-17 Thread Frank Li
Add suspend/resume support for ls1043 and ls1021. Change log see each patch Frank Li (4): PCI: layerscape: Add function pointer for exit_from_l2() PCI: layerscape: Add suspend/resume for ls1021a PCI: layerscape: Rename pf_* as pf_lut_* PCI: layerscape: Add suspend/resume for ls1043a

Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a

2023-10-16 Thread Frank Li
On Mon, Oct 16, 2023 at 10:28:24PM +0530, Manivannan Sadhasivam wrote: > On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote: > > ls1021a add suspend/resume support. > > > > Please add what the driver is doing during suspend/resume. > > > Signed-off-by: Fran

Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a

2023-10-16 Thread Frank Li
On Mon, Oct 16, 2023 at 11:25:12AM -0500, Bjorn Helgaas wrote: > On Mon, Oct 16, 2023 at 12:11:04PM -0400, Frank Li wrote: > > On Mon, Oct 16, 2023 at 10:22:11AM -0500, Bjorn Helgaas wrote: > > > > Obviously Lorenzo *could* edit all your subject lines on your behal

[PATCH v2 3/3] PCI: layerscape: Add suspend/resume for ls1043a

2023-10-16 Thread Frank Li
ls1043a add suspend/resume support. Signed-off-by: Frank Li --- Notes: Change from v1 to v2 - Change subject 'a' to 'A' drivers/pci/controller/dwc/pci-layerscape.c | 91 - 1 file changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/pc

[PATCH v2 2/3] PCI: layerscape: Add suspend/resume for ls1021a

2023-10-16 Thread Frank Li
ls1021a add suspend/resume support. Signed-off-by: Frank Li --- Notes: change from v1 to v2 - change subject 'a' to 'A' drivers/pci/controller/dwc/pci-layerscape.c | 88 - 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/drivers/pc

[PATCH v2 1/3] PCI: layerscape: Add function pointer for exit_from_l2()

2023-10-16 Thread Frank Li
Difference layerscape chip have not difference exit_from_l2() method. Using function pointer for ls1028. It prepare for other layerscape suspend/resume support. Signed-off-by: Frank Li --- Notes: Change from v1 to v2 - change subject 'a' to 'A' drivers/pc

Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a

2023-10-16 Thread Frank Li
On Mon, Oct 16, 2023 at 10:22:11AM -0500, Bjorn Helgaas wrote: > On Mon, Oct 16, 2023 at 10:45:25AM -0400, Frank Li wrote: > > On Tue, Oct 10, 2023 at 06:02:36PM +0200, Lorenzo Pieralisi wrote: > > > On Tue, Oct 10, 2023 at 10:20:12AM -0400, Frank Li wrote: > > > >

Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a

2023-10-16 Thread Frank Li
On Tue, Oct 10, 2023 at 06:02:36PM +0200, Lorenzo Pieralisi wrote: > On Tue, Oct 10, 2023 at 10:20:12AM -0400, Frank Li wrote: > > On Wed, Oct 04, 2023 at 10:23:51AM -0400, Frank Li wrote: > > > On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote: > > > > ls10

Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-10-10 Thread Frank Li
On Tue, Oct 10, 2023 at 05:44:23PM +0200, Lorenzo Pieralisi wrote: > On Tue, 26 Sep 2023 10:04:45 -0400, Frank Li wrote: > > Set DMA mask and coherent DMA mask to enable 64-bit addressing. > > > > > > Read this: > https://lore.kernel.org/linux-pci/2

Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a

2023-10-10 Thread Frank Li
On Wed, Oct 04, 2023 at 10:23:51AM -0400, Frank Li wrote: > On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote: > > ls1021a add suspend/resume support. > > > > Signed-off-by: Frank Li > > --- > > ping > > Frank Ping Frank > > >

Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-10-10 Thread Frank Li
On Wed, Sep 27, 2023 at 02:46:21PM +0200, Manivannan Sadhasivam wrote: > On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote: > > From: Guanhua Gao > > > > Set DMA mask and coherent DMA mask to enable 64-bit addressing. > > > > Signed-off-by: Guanhua Gao

Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a

2023-10-04 Thread Frank Li
On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote: > ls1021a add suspend/resume support. > > Signed-off-by: Frank Li > --- ping Frank > drivers/pci/controller/dwc/pci-layerscape.c | 88 - > 1 file changed, 87 insertions(+), 1 deletion(-) > &

[PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-26 Thread Frank Li
From: Guanhua Gao Set DMA mask and coherent DMA mask to enable 64-bit addressing. Signed-off-by: Guanhua Gao Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li --- Notes: change from v2 to v3 - remove check return value of dma_set_mask_and_coherent. 64bit mask always return

Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-26 Thread Frank Li
On Tue, Sep 26, 2023 at 12:27:32AM -0700, Christoph Hellwig wrote: > > + /* set 64-bit DMA mask and coherent DMA mask */ > > + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); > > The comment is a bit silly :) > > > + if (ret) > > + return ret; > > Also no need to check th

[PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-21 Thread Frank Li
From: Guanhua Gao Set DMA mask and coherent DMA mask to enable 64-bit addressing. Signed-off-by: Guanhua Gao Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li --- Notes: change from v1 to v2 - Remove 32bit DMA mask set. drivers/pci/controller/dwc/pci-layerscape-ep.c | 5 + 1

Re: [PATCH 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-21 Thread Frank Li
On Thu, Sep 21, 2023 at 10:04:31PM +0200, Christophe JAILLET wrote: > Le 21/09/2023 à 20:35, Frank Li a écrit : > > On Thu, Sep 21, 2023 at 07:59:51PM +0200, Christophe JAILLET wrote: > > > Le 21/09/2023 à 17:37, Frank Li a écrit : > > > > From: Guanhua Gao >

Re: [PATCH 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-21 Thread Frank Li
On Thu, Sep 21, 2023 at 07:59:51PM +0200, Christophe JAILLET wrote: > Le 21/09/2023 à 17:37, Frank Li a écrit : > > From: Guanhua Gao > > > > Set DMA mask and coherent DMA mask to enable 64-bit addressing. > > > > Signed-off-by: Guanhua Gao > > Signed-

[PATCH 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-21 Thread Frank Li
From: Guanhua Gao Set DMA mask and coherent DMA mask to enable 64-bit addressing. Signed-off-by: Guanhua Gao Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-layerscape-ep.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/pci/controller

[PATCH 3/3] PCI: layerscape: add suspend/resume for ls1043a

2023-09-15 Thread Frank Li
ls1043a add suspend/resume support. Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-layerscape.c | 91 - 1 file changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c index

[PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a

2023-09-15 Thread Frank Li
ls1021a add suspend/resume support. Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-layerscape.c | 88 - 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c index

[PATCH 1/3] PCI: layerscape: add function pointer for exit_from_l2()

2023-09-15 Thread Frank Li
Difference layerscape chip have not difference exit_from_l2() method. Using function pointer for ls1028. It prepare for other layerscape suspend/resume support. Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-layerscape.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

Re: [PATCH v4 1/2] PCI: layerscape: Add support for Link down notification

2023-08-23 Thread Frank Li
On Wed, Aug 16, 2023 at 11:53:16AM -0400, Frank Li wrote: > On Mon, Jul 31, 2023 at 11:06:31AM -0400, Frank Li wrote: > > On Thu, Jul 20, 2023 at 09:58:33AM -0400, Frank Li wrote: > > > Add support to pass Link down notification to Endpoint function driver > > > so that

Re: [PATCH v4 1/2] PCI: layerscape: Add support for Link down notification

2023-08-16 Thread Frank Li
On Mon, Jul 31, 2023 at 11:06:31AM -0400, Frank Li wrote: > On Thu, Jul 20, 2023 at 09:58:33AM -0400, Frank Li wrote: > > Add support to pass Link down notification to Endpoint function driver > > so that the LINK_DOWN event can be processed by the function. > > >

Re: [PATCH v4 1/2] PCI: layerscape: Add support for Link down notification

2023-07-31 Thread Frank Li
On Thu, Jul 20, 2023 at 09:58:33AM -0400, Frank Li wrote: > Add support to pass Link down notification to Endpoint function driver > so that the LINK_DOWN event can be processed by the function. > > Acked-by: Manivannan Sadhasivam > Signed-off-by: Frank Li > --- @Lorenzo

[PATCH v4 2/2] PCI: layerscape: Add the workaround for lost link capabilities during reset.

2023-07-20 Thread Frank Li
event. Fixes: a805770d8a22 ("PCI: layerscape: Add EP mode support") Acked-by: Manivannan Sadhasivam Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li --- change from v3 to v4 - fix wrong commit a debug code, change pr_err to pr_dbg change from v2 to v3 - f

[PATCH v4 1/2] PCI: layerscape: Add support for Link down notification

2023-07-20 Thread Frank Li
Add support to pass Link down notification to Endpoint function driver so that the LINK_DOWN event can be processed by the function. Acked-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- Change from v2 to v4 - none Change from v1 to v2 drivers/pci/controller/dwc/pci-layerscape-ep.c | 1

Re: [PATCH v3 2/2] PCI: layerscape: Add the workaround for lost link capabilities during reset.

2023-07-19 Thread Frank Li
On Wed, Jul 19, 2023 at 11:57:07AM -0400, Frank Li wrote: > From: Xiaowei Bao > > A workaround for the issue where the PCI Express Endpoint (EP) controller > loses the values of the Maximum Link Width and Supported Link Speed from > the Link Capabilities Register, which initiall

Re: [v3 1/2] PCI: layerscape: Add support for Link down notification

2023-07-19 Thread Frank Li
On Wed, Jul 19, 2023 at 10:08:16PM +0200, Markus Elfring wrote: > > Cover letter just annoise people here. > > How do you think about advices from another information source? > > See also: > https://kernelnewbies.org/PatchSeries "You may like to include a cover letter with your patch series." G

Re: [PATCH v3 1/2] PCI: layerscape: Add support for Link down notification

2023-07-19 Thread Frank Li
On Wed, Jul 19, 2023 at 09:27:23PM +0200, Markus Elfring wrote: > > Add support to pass … > > Why did you omit a cover letter for the discussed patch series once more? Your comments is "Will a cover letter become helpful also for the presented small patch series?" According to my understand it

  1   2   >