On Thu, Nov 21, 2024 at 10:50 PM Shengjiu Wang wrote:
>
> As the snd_soc_card_get_kcontrol() is updated to use
> snd_ctl_find_id_mixer() in
> commit 897cc72b0837 ("ASoC: soc-card: Use
> snd_ctl_find_id_mixer() instead of open-coding")
> which make the iface fix to be IFACE_MIXER.
Should this have
On Tue, Sep 24, 2024 at 10:58 AM Mark Brown wrote:
>
> Several of the NXP drivers use regmaps with a rbtree register cache. Since
> the maple tree cache is uisng a generally more modern data structure which
Typo: using.
Reviewed-by: Fabio Estevam
On Mon, Dec 18, 2023 at 7:10 AM Shengjiu Wang wrote:
>
> When flag mclk_with_tere and mclk_direction_output enabled,
> The SAI transmitter or receiver will be enabled in very early
> stage, that if FSL_SAI_xMR is set by previous case,
> for example previous case is one channel, current case is
> t
still contain data on resume it can cause channel
> shifting on e.g. XRUNS. A Software Reset will reset the FIFO's and make
> sure channels are aligned.
>
> Fixes: 269f399dc19f ("ASoC: fsl_sai: Disable bit clock with transmitter")
> Signed-off-by: Emil Svendsen
Reviewed-by: Fabio Estevam
On Sat, Jul 22, 2023 at 9:38 AM Yuanjun Gong wrote:
>
> check the return value of clk_prepare_enable(), and if
> clk_prepare_enable() gets an unexpected return value,
> imx_audmux_suspend() and imx_audmux_resume() should return
> the error value.
>
> Signed-off-by: Yuanjun Gong
> ---
> sound/soc
On Wed, Jul 19, 2023 at 1:48 PM Matus Gajdos wrote:
>
> Clear TX registers on stop to prevent the SPDIF interface from sending
> last written word over and over again.
>
> Fixes: a2388a498ad2 ("ASoC: fsl: Add S/PDIF CPU DAI driver")
> Signed-off-by: Matus Gajdos
Reviewed-by: Fabio Estevam
On Wed, Jul 19, 2023 at 1:32 PM Matus Gajdos wrote:
>
> Add support for 22.05 kHz sample rate for TX.
>
> Signed-off-by: Matus Gajdos
Reviewed-by: Fabio Estevam
On Mon, Jul 17, 2023 at 9:55 AM Mark Brown wrote:
> I'll just put a non-specific Cc stable tag on it, that should be enough
> to get it backported.
Sounds good. Thanks, Mark.
On Wed, Jul 12, 2023 at 9:53 AM Matus Gajdos wrote:
>
> Otherwise bit clock remains running writing invalid data to the DAC.
>
> Signed-off-by: Matus Gajdos
Should this contain a Fixes tag so that it could be backported to
stable kernels?
On Thu, Jul 6, 2023 at 8:19 AM Shengjiu Wang wrote:
> The clean way for fixing is to remove the code in fsl_sai_set_bclk()
> and add "fsl,sai-mclk-direction-output;" property in dts for some
> node.
Yes, after thinking more about it, I agree.
So what you are proposing is basically a revert of t
Hi Andreas,
On Thu, Jul 6, 2023 at 9:34 AM Andreas Henriksson wrote:
> I think your initial review comment was spot on Fabio. There probably
> needs to be a(n imx8mm) specific flag that says when this workaround
> should be applied and gate the code in bclk function on that.
> Atleast that's the
On Thu, Jul 6, 2023 at 8:19 AM Shengjiu Wang wrote:
> No, this is the code in probe().
> The code with the issue is in fsl_sai_set_bclk().
Yes, I put it in the wrong place.
> The clean way for fixing is to remove the code in fsl_sai_set_bclk()
> and add "fsl,sai-mclk-direction-output;" property
Hi Andreas,
On Thu, Jul 6, 2023 at 5:47 AM Andreas Henriksson wrote:
> We've been working on an i.MX8MP where MCLK needs to be input and found
> that this enables the MCLK as output despite not having set the
> `fsl,sai-mclk-direction-output;` devicetree property in our DT.
> Reverting the patch
Hi Shengjiu,
On Wed, Jun 28, 2023 at 11:10 PM Shengjiu Wang wrote:
>
> ASRC can be used on memory to memory case, define several
> functions for m2m usage and export them as function pointer.
>
> Signed-off-by: Shengjiu Wang
Could you please explain what is the benefit of using M2M in the EASRC
: 99c1e74f25d4 ("ASoC: fsl_sai: store full version instead of
> major/minor")
> Signed-off-by: Shengjiu Wang
Reviewed-by: Fabio Estevam
ould take console
> probe times back to how they were before the deferred_probe_timeout
> clean up series[2].
>
> Fabio/Ahmad/Sascha,
>
> Can you give this a shot please?
This series works fine for me (with and without stdout-path), thanks:
Tested-by: Fabio Estevam
00 clock support for imx-sgtl5000")
> Signed-off-by: Miaoqian Lin
Reviewed-by: Fabio Estevam
On Tue, Sep 21, 2021 at 6:36 PM Mark Brown wrote:
>
> As part of moving to remove the old style defines for the bus clocks update
> the eureka-tlv320 driver to use more modern terminology for clocking.
>
> Signed-off-by: Mark Brown
For the whole series:
Reviewed-by: Fabio Estevam
On Tue, Sep 21, 2021 at 6:11 PM Mark Brown wrote:
>
> As part of moving to remove the old style defines for the bus clocks update
> the fsl-audmix driver to use more modern terminology for clocking.
>
> Signed-off-by: Mark Brown
> ---
> sound/soc/fsl/fsl_audmix.c | 8
> 1 file changed,
> remnants.
>
> Signed-off-by: Li Yang
Thanks for the fix:
Reviewed-by: Fabio Estevam
Hi Wang,
On Sat, Mar 13, 2021 at 5:25 AM Wang Qing wrote:
>
> As THIS_MODULE has been set in module_platform_driver(), so remove it.
>
> Signed-off-by: Wang Qing
Thanks for the patch, but someone else has already sent the same.
Hi Yang,
On Thu, Mar 4, 2021 at 6:08 AM Yang Li wrote:
>
> ./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core
> will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang
Hi Yang,
On Wed, Mar 3, 2021 at 5:54 AM Yang Li wrote:
>
> ./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core
> will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
The patch looks good, but
Hi Michael,
On Fri, Nov 20, 2020 at 3:25 AM Michael Ellerman wrote:
> I'd rather not have to carry this in arch code just for one driver.
Fair enough.
> Can't the driver just use ioread/write32be() on all platforms?
Yes, this is a better approach. I have just a patch doing that.
Thanks
by: Geert Uytterhoeven
[fabio: adapt to mainline]
Signed-off-by: Fabio Estevam
---
arch/powerpc/include/asm/io.h| 14 ++
drivers/media/platform/fsl-viu.c | 5 +++--
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/inclu
On Thu, Jul 2, 2020 at 4:31 PM Nicolin Chen wrote:
>
> Add Shengjiu who's actively working on the latest fsl/nxp audio drivers.
>
> Signed-off-by: Nicolin Chen
> Cc: Shengjiu Wang
Reviewed-by: Fabio Estevam
; distortion.
>
> Add function fsl_asrc_select_clk() to find proper clock source for
> internal ratio mode, if the clock source is available then internal
> ratio mode will be selected.
>
> With change, the ideal ratio mode is not the only option for user.
>
> Signed-off-by: Shengjiu Wang
Reviewed-by: Fabio Estevam
Hi Shengjiu,
On Mon, Jun 29, 2020 at 11:10 AM Shengjiu Wang wrote:
> +/**
"/**" notation may confuse 'make htmldocs". Since this is a single
line comment you could do:
/* Select proper clock source for internal ratio mode */
> + * Select proper clock source for internal ratio mode
> + */
> +
On Wed, Feb 12, 2020 at 1:35 AM Shengjiu Wang wrote:
>
> EASRC (Enhanced Asynchronous Sample Rate Converter) is a new
> IP module found on i.MX815.
i.MX815 in an internal terminology. Please avoid it on the commit log.
>
> Signed-off-by: Shengjiu Wang
> ---
> .../devicetree/bindings/sound/fsl,
On Mon, Dec 2, 2019 at 8:56 AM Shengjiu Wang wrote:
> - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
> + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
> + "fsl,imx8qm-asrc", "fsl,imx8qxp-asrc"
You missed the word "or" as in
Hi Michael,
On Thu, Nov 28, 2019 at 7:38 PM Michael Walle wrote:
>
> The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use
> IRQF_SHARED to be able to use these SAIs simultaneously.
On i.MX8M SAI5 and SAI6 share the same interrupt number too:
Reviewed-by: Fabio Estevam
Thanks
On Wed, Sep 25, 2019 at 9:17 AM Adam Ford wrote:
> I tried cma=256M and noticed the cma dump at the beginning didn't
> change. Do we need to setup a reserved-memory node like
> imx6ul-ccimx6ulsom.dtsi did?
I don't think so.
Were you able to identify what was the exact commit that caused such r
Hi Adam,
On Wed, Sep 25, 2019 at 6:38 AM Adam Ford wrote:
> I know it's rather late, but this patch broke the Etnaviv 3D graphics
> in my i.MX6Q.
>
> When I try to use the 3D, it returns some errors and the dmesg log
> shows some memory allocation errors too:
> [3.682347] etnaviv etnaviv: bo
Hi Shengjiu,
On Wed, Aug 28, 2019 at 2:21 AM Shengjiu Wang wrote:
>
> The test case is
> arecord -Dhw:0 -d 10 -f S16_LE -r 48000 -c 2 temp.wav &
> aplay -Dhw:0 -d 30 -f S16_LE -r 48000 -c 2 test.wav
>
> There will be error after end of arecord:
> aplay: pcm_write:2051: write error: Input/output e
On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu wrote:
>
> As the file had no other license notice/reference, it falls under the
> project license and therefore the proper SPDX id is: GPL-2.0-only
>
> Cc: Daniel Baluta
> Fixes: 1edfc2485d8dc ("ASoC: mpc5200_dma: Switch to SPDX identifier")
> Reporte
On Wed, Apr 10, 2019 at 8:06 AM Viorel Suman wrote:
>
> Release the reference to the underlying device taken
> by of_find_device_by_node() call.
>
> Signed-off-by: Viorel Suman
> Reported-by: Julia Lawall
> Acked-by: Nicolin Chen
Please provide a Fixes tag.
On Wed, Apr 10, 2019 at 8:06 AM Viorel Suman wrote:
>
> Remove "model" attribute from fsl_audmix DT document.
Please provide the reasoning.
On Fri, Apr 5, 2019 at 10:24 AM Mukesh Ojha wrote:
> you mean all lines to start with //, does not it look to noisy to eyes ?
Mark Brown's recommendation is to use // in all the initial block
lines instead of only in the SPDX one.
On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha wrote:
> Don't change entire thing with //. only above line with the license is
> enough.
>
> Please apply this rule every patch of yours.
Not really. This is the style preferred in this subsystem.
On Thu, Apr 4, 2019 at 9:07 AM Andra Danciu wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Andra Danciu
> ---
> sound/soc/fsl/imx-pcm.h | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/sound/soc/fsl/im
d Cc stable.
> Signed-off-by: Shengjiu Wang
Reviewed-by: Fabio Estevam
Thanks
Hi Shengjiu,
On Fri, Feb 15, 2019 at 9:04 AM S.j. Wang wrote:
>
> The ESAI_xCR_xWA is xCR's bit, not the xCCR's bit, driver set it to
> wrong register, correct it.
>
> Signed-off-by: Shengjiu Wang
Reviewed-by: Fabio Estevam
Please add a Fixes tag and Cc stable.
On Wed, Nov 7, 2018 at 4:57 PM Yangtao Li wrote:
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li
Reviewed-by: Fabio Estevam
From: Fabio Estevam
Structure platform_driver does not need to set the owner field, as this
will be populated by the driver core.
Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci.
Signed-off-by: Fabio Estevam
---
arch/powerpc/sysdev/cpm_gpio.c | 1 -
1 file changed, 1 deletion
asut
Thanks for the fix:
Reviewed-by: Fabio Estevam
Hi Nicolin,
On Sun, Apr 8, 2018 at 8:57 PM, Nicolin Chen wrote:
> When the desired ratio is less than 256, the savesub (tolerance)
> in the calculation would become 0. This will then fail the loop-
> search immediately without reporting any errors.
>
> But if the ratio is smaller enough, there is
check to fix it.
>
> Signed-off-by: Nicolin Chen
Reviewed-by: Fabio Estevam
From: Fabio Estevam
devm_kasprintf() may fail, so we should better add a NULL check
and propagate an error on failure.
Signed-off-by: Fabio Estevam
---
drivers/soc/fsl/guts.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
index
Hi Michael,
On Mon, Dec 4, 2017 at 2:45 AM, Michael Ellerman wrote:
> Will pick it up for 4.16.
Just realized that there is already a fix for this in linux-next:
commit 3d2d4339cc326c427638daa67e264dd455ee1899
Author: Geert Uytterhoeven
Date: Fri Jun 2 14:38:47 2017 +0200
powerpc: dts:
Hi Michael,
On Tue, Oct 17, 2017 at 11:01 AM, Fabio Estevam wrote:
> 'interrupts-parent' property does not exist. Fix the typo.
>
> Fixes: 00f3ca740a9c26 ("powerpc/40x: AMCC PowerPC 405EZ Acadia DTS")
> Signed-off-by: Fabio Estevam
> ---
> arch/powerp
'interrupts-parent' property does not exist. Fix the typo.
Fixes: 00f3ca740a9c26 ("powerpc/40x: AMCC PowerPC 405EZ Acadia DTS")
Signed-off-by: Fabio Estevam
---
arch/powerpc/boot/dts/acadia.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc
On Tue, Sep 5, 2017 at 6:13 PM, Łukasz Majewski wrote:
> &i2c1 {
> clock-frequency = <40>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_i2c1>;
> status = "okay";
>
> codec: tfa9879@6C {
> #sound-dai-cells = <0>;
>
Hi Lukasz,
On Tue, Sep 5, 2017 at 5:35 AM, Łukasz Majewski wrote:
> Note:
> [*] - I could workaround this problem by setting:
>
> system-clock-frequency = <0> in
>
> dailink_master: cpu {
> sound-dai = <&ssi2>;
> };
>
W
gt;
> 66MHz * 5 > 66 MHz.
>
>
>
> The culprit IMHO is the ssi_private->bitclk_freq = freq; in the
> fsl_ssi_set_dai_sysclk(), since we _should_ set SSI's IP block clock
> (ssi_private->clk), not the bit clock (BCLK).
>
>
> This patch just quits early if
his properly taking care of the clock restriction?
From: Lukasz Majewski
Sent: Sunday, September 3, 2017 8:05:01 AM
To: Timur Tabi; Nicolin Chen; Xiubo Li; Fabio Estevam; Liam Girdwood; Mark
Brown; Jaroslav Kysela; Takashi Iwai
Cc: alsa-de...@alsa-project.org; li
On Tue, Aug 29, 2017 at 9:37 AM, Rob Herring wrote:
> dma_object.path is unused, so rather than fix it to work with DT
> full_name changes, just remove it.
>
> Signed-off-by: Rob Herring
Reviewed-by: Fabio Estevam
On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur wrote:
> A previous commit inserted a dependency on DMA API that requires
> HAS_DMA to be added in Kconfig.
It would be nice to specify the commit that caused this.
is the type expected by
> dmaengine_prep_dma_cyclic().
>
> Replace DMA_TO_DEVICE with DMA_MEM_TO_DEV and DMA_FROM_DEVICE with
> DMA_DEV_TO_MEM to fix this type mismatch issue.
>
> Signed-off-by: Nicolas Iooss
Reviewed-by: Fabio Estevam
have not tested.
>
> Signed-off-by: Caleb Crome
Reviewed-by: Fabio Estevam
On Wed, Dec 28, 2016 at 9:06 AM, Harisangam, Sharvari (S.)
wrote:
> Corrected the condition to check if ssi is configured for AC97
> mode. Other modes like dsp_a also satisfy the ANDing condition.
>
> Signed-off-by: Sharvari Harisangam
This has been fixed in 4.3 kernel by commit:
5b64c173cdea
On Wed, Aug 31, 2016 at 2:49 PM, Xavi Drudis Ferran wrote:
> Thank you amd feel free to suggest more tests, but it is good enough
> as it is for me.
Ok, thanks for trying. So let's keep the SPDIF parent clock as is.
Hi Xavi,
On Wed, Aug 31, 2016 at 10:47 AM, Xavi Drudis Ferran wrote:
> If it's easy for you to send it yourself, I would prefer so and I'm
> grateful. If not, it'll be an exercise for me, no problem.
I have just submitted the patch with you on Cc.
If you could reply to it with your Tested-by t
Xavi,
On Wed, Aug 31, 2016 at 10:11 AM, Fabio Estevam wrote:
> Xavi,
>
> Care to send a formal patch with your change?
If you prefer, I can send this change to the ARM kernel mailing list.
Please let me know what you prefer.
Thanks
o get more accurate SPDIF clock rates.
Could you please try the untested change?
--- a/drivers/clk/imx/clk-imx6q.c
+++ b/drivers/clk/imx/clk-imx6q.c
@@ -623,7 +623,7 @@ static void __init imx6q_clocks_init(struct
device_node *ccm_node)
pr_warn("failed to set up CLKO: %d\n", ret);
/* Audio-related clocks configuration */
- clk_set_parent(clk[IMX6QDL_CLK_SPDIF_SEL],
clk[IMX6QDL_CLK_PLL3_PFD3_454M]);
+ clk_set_parent(clk[IMX6QDL_CLK_SPDIF_SEL],
clk[IMX6QDL_CLK_PLL4_AUDIO_DIV]);
/* All existing boards with PCIe use LVDS1 */
if (IS_ENABLED(CONFIG_PCI_IMX6))
Regards,
Fabio Estevam
On Mon, Aug 29, 2016 at 7:51 AM, Winter Wang wrote:
> These patches support sgtl5000 to be attached to other non-ssi cpu-dais like
> SAI.
Do we really need this?
We can use SAI with sgtl5000 just fine via simple card. Take a look at:
https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.g
quire the channels to be in the right slots.
>
> Signed-off-by: Caleb Crome
> Suggested-by: Arnaud Mouiche
Reviewed-by: Fabio Estevam
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Mon, Feb 1, 2016 at 7:30 PM, Maciej S. Szmigiero
wrote:
> So can regcache initialization be changed to use register by register read
> in case raw read fails?
>
> Since other option for drivers like SSI which are memory mapped and
> don't offer ability to reset their register values to default
Hi Maciej,
On Mon, Feb 1, 2016 at 10:07 AM, Maciej S. Szmigiero
wrote:
> Is regmap patch from
> http://www.spinics.net/lists/kernel/msg2161934.html
> applied to the tested tree?
Yes, linux-next 20160201 contains this patch.
___
Linuxppc-dev mailing lis
Hi Maciej,
On Mon, Jan 18, 2016 at 5:07 PM, Maciej S. Szmigiero
wrote:
> There is no guarantee that on fsl_ssi module load
> SSI registers will have their power-on-reset values.
>
> In fact, if the driver is reloaded the values in
> registers will be whatever they were set to previously.
>
> Howe
on fsl_ssi module reload,
> at least in AC'97 mode.
>
> Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support
> MEGA Fast")
>
> Signed-off-by: Maciej S. Szmigiero
Tested-by: Fabio Estevam
___
Linuxp
Tested-by: Fabio Estevam
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Tue, Jan 12, 2016 at 4:13 PM, Lothar Waßmann
wrote:
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 14dfdee..c128823 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -258,7 +258,8 @@ config SND_SOC_IMX_SGTL5000
> select SND_SOC_SGTL5000
>
Hi Maciej,
On Mon, Jan 11, 2016 at 11:57 AM, Maciej S. Szmigiero
wrote:
> Hi Fabio,
> This will disable register cache so it isn't right.
> Could you try REGCACHE_FLAT instead, please?
Yes, with REGCACHE_FLAT I don't get the warning.
Rega
On Mon, Jan 11, 2016 at 10:04 AM, Fabio Estevam wrote:
> This patch causes the following issue in linux-next:
>
> [2.526984] [ cut here ]
> [2.531632] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:2755
> lockdep_trace_alloc+0xf4/0x124()
Hi Maciej,
On Sun, Dec 20, 2015 at 6:33 PM, Maciej S. Szmigiero
wrote:
> There is no guarantee that on fsl_ssi module load
> SSI registers will have their power-on-reset values.
>
> In fact, if the driver is reloaded the values in
> registers will be whatever they were set to previously.
>
> This
Timur,
On Thu, Dec 24, 2015 at 2:12 PM, Timur Tabi wrote:
> On Sun, Dec 20, 2015 at 2:30 PM, Maciej S. Szmigiero
> wrote:
>> SACNT register should be marked volatile since
>> its WR and RD bits are cleared by SSI after
>> completing the relevant operation.
>> This unbreaks AC'97 register access.
> This fixes hard lockup on fsl_ssi module reload,
> at least in AC'97 mode.
>
> Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support
> MEGA Fast")
>
> Signed-off-by: Maciej S. Szmigiero
Reviewed-by: Fabio Estevam
___
On Sun, Dec 20, 2015 at 6:31 PM, Maciej S. Szmigiero
wrote:
> Mark some registers precious since their
> reads have side effects (like clearing flags).
>
> Signed-off-by: Maciej S. Szmigiero
Reviewed-by: Fabio Estevam
___
Linuxppc-dev
_ssi: Add driver suspend and resume to support
> MEGA Fast")
>
> Signed-off-by: Maciej S. Szmigiero
Reviewed-by: Fabio Estevam
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Hi Maciej,
On Thu, Jul 30, 2015 at 11:33 AM, Maciej S. Szmigiero
wrote:
> static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97,
> @@ -1151,6 +1160,14 @@ static unsigned short fsl_ssi_ac97_read(struct
> snd_ac97 *ac97,
> unsigned short val = -1;
> u32 reg_val;
>
On Mon, Jul 6, 2015 at 6:50 AM, Zidan Wang wrote:
> For i.MX6 SoloX, there is a mode of the SoC to shutdown all power source of
> modules during system suspend and resume procedure. Thus, SAI needs to save
s/SAI/SPDIF
___
Linuxppc-dev mailing list
Linux
On Mon, Jul 6, 2015 at 6:50 AM, Zidan Wang wrote:
> For i.MX6 SoloX, there is a mode of the SoC to shutdown all power source of
> modules during system suspend and resume procedure. Thus, SAI needs to save
You meant ESAI, not SAI.
___
Linuxppc-dev maili
On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero
wrote:
> +
> + ret = clk_prepare_enable(fsl_ac97_data->clk);
> + if (ret) {
> + pr_err("ac97 read clk_prepare_enable failed: %d\n",
> + ret);
> + return -1;
'return ret' would be be
Hi Maciej,
On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero
wrote:
> Currently the AC'97 mode in fsl_ssi driver isn't functional.
Thanks for the fix. I look forward to test it on my udoo board.
> This patch implements the following changes to make it work
> properly:
> * IPG clock have to b
even though this change seems to make sense.
I currently don't have access to a SPDIF receiver to test it.
Regards,
Fabio Estevam
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Hi Zidan,
On Tue, Jan 20, 2015 at 10:21 AM, Zidan Wang wrote:
> Add sai master mode support.
> Add tdm slots support.
> Add Right-J mode support.
>
> Zidan Wang (3):
> SoC: fsl_sai: add sai master mode support
> ASoC: fsl_sai: Add support for tdm slots operation
> ASoC: fsl_sai: Add support
On Mon, Jan 5, 2015 at 1:12 PM, Michael Tessier
wrote:
> If sound is ok when using only 1 codec and becomes choppy when adding a
> second codec, then it means that this issue is still in the 3.x kernel. This
> answer will tell me if it is worth working on using a newer kernel or not.
> I have to
patch:
http://www.spinics.net/lists/arm-kernel/msg385739.html
Regards,
Fabio Estevam
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Mon, Dec 1, 2014 at 6:42 PM, Timur Tabi wrote:
> Would the mapping continue to exist after the driver is unloaded? Can you
> try multiple loads/unloads and see if interrupts still work?
I tried multiple loads/unloads and audio works fine with those changes.
About the ssi irq we have:
- Wit
On Mon, Dec 1, 2014 at 6:30 PM, Lars-Peter Clausen wrote:
> On 12/01/2014 09:11 PM, Timur Tabi wrote:
>>
>> On 12/01/2014 02:01 PM, Arnd Bergmann wrote:
>Does this mean that fsl_ssi.c should not be calling
>irq_of_parse_and_map? How else should it get the IRQ?
>>>
>>> platform_get_
the preferred style', so I thought
> it shouldn't be quite bother.
Yes, net and drivers/net are different and checkpatch reports it accordingly.
Regards,
Fabio Estevam
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
+* cases like I2S mode to call the extra set_tdm_slot() any more.
> +*/
Incorrect style for multi-line comment.
Regards,
Fabio Estevam
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
>
> Reported-by: kbuild test robot
> Signed-off-by: Alexander Shiyan
I have sent the same fix as well as I haven't seen your patch before I
submitted mine.
It is usually a good idea to specify in the commit log what was the
commit that caused the warning.
Regards,
Fabio Estev
On Tue, Aug 13, 2013 at 2:58 PM, Fabio Estevam wrote:
> On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote:
>> +Required properties:
>> +
>> + - compatible : Compatible list, contains "fsl,-spdif". Using general
>
> Can't we just use "fsl,fsl-spd
On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote:
> +Required properties:
> +
> + - compatible : Compatible list, contains "fsl,-spdif". Using general
Can't we just use "fsl,fsl-spdif" instead?
> + "fsl,fsl-spdif" will get the default SoC type -- imx6q-spdif.
> +
I think this is not the us
On Sun, Feb 17, 2013 at 4:43 AM, Shawn Guo wrote:
> On Sun, Feb 17, 2013 at 11:03:35AM +0800, Shawn Guo wrote:
>> On Fri, Jan 18, 2013 at 01:40:00AM +, Grant Likely wrote:
>> > This allows platform_device_add a chance to call insert_resource on all
>> > of the resources from OF. At a minimum t
On Thu, Jan 17, 2013 at 9:25 AM, Lothar Waßmann
wrote:
> The equivalent of !cpu_is_mx51() would be
> strcmp(pdev->id_entry->name, "imx-udc-mx51") (without the '!') meaning
> id_entry->name is different from "imx-udc-mx51".
Yes, agree.
strcmp(pdev->id_entry->name, "imx-udc-mx51") is also better
On Thu, Jan 17, 2013 at 8:01 AM, Peter Chen wrote:
> /* make sure USB_CLK is running at 60 MHz +/- 1000 Hz */
> - if (!cpu_is_mx51()) {
> + if (!strcmp(pdev->id_entry->name, "imx-udc-mx27")) {]]
Shouldn't this be:
if (!strcmp(pdev->id_entry->name, "imx-udc-mx51"))
__
x27;t have
a mx35 handy.
>
> Currently I can't investigate this further, not because of a bug - but a
> flu.
Hope you get better soon.
Regards,
Fabio Estevam
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Hi Christoph,
On Mon, Jun 4, 2012 at 8:37 AM, Christoph Fritz
wrote:
> After that, I stumbled upon this dmesg:
>
> Freescale High-Speed USB SOC Device Controller driver (Apr 20, 2007)
> fsl-usb2-udc fsl-usb2-udc: clk_get("usb") failed
> fsl-usb2-udc: probe of fsl-usb2-udc failed with error -2
>
100 matches
Mail list logo
