Re: WARNING: CPU: 12 PID: 44394 at arch/powerpc/kernel/process.c:437 giveup_all+0x90/0x1d0 (v6.14.8, Talos II)

2025-06-01 Thread Erhard Furtner
On Thu, 29 May 2025 10:41:22 +0530 Srikar Dronamraju wrote: > * Erhard Furtner [2025-05-27 20:47:28]: > > > On Tue, 27 May 2025 14:19:13 +0530 > > Srikar Dronamraju wrote: > > > > > > Getting these from time to time when I run the machine

Re: WARNING: CPU: 12 PID: 44394 at arch/powerpc/kernel/process.c:437 giveup_all+0x90/0x1d0 (v6.14.8, Talos II)

2025-05-27 Thread Erhard Furtner
On Tue, 27 May 2025 14:19:13 +0530 Srikar Dronamraju wrote: > > Getting these from time to time when I run the machine for longer periods > > building: > > > > [...] > > [ cut here ] > > WARNING: CPU: 12 PID: 44394 at arch/powerpc/kernel/process.c:437 > > giveup_all+0x9

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2025-04-11 Thread Erhard Furtner
On Tue, 8 Apr 2025 07:55:30 +0200 Christophe Leroy wrote: > Hi Erhard, > > Le 29/09/2023 à 13:27, Erhard Furtner a écrit : > > Kernel 6.5.5 boots fine on my PowerMac G5 11,2 but kernel 6.6-rc3 fails to > > boot with following dmesg shown on the OpenFirmware console (transc

Re: Missing '#size-cells' in /ht@0,f2000000/pci@8/mac-io@7/i2s@0 on G5/G4 (kernel 6.13-rc3)

2025-02-27 Thread Erhard Furtner
On Thu, 27 Feb 2025 09:00:06 +0530 Madhavan Srinivasan wrote: > On 2/27/25 3:44 AM, Erhard Furtner wrote: > > On Mon, 23 Dec 2024 23:58:26 +1100 > > Michael Ellerman wrote: > > > >> Erhard Furtner writes: > >>> Greetin

Re: vmalloc_node_range for size 4198400 failed: Address range restricted to 0xf1000000 - 0xf5110000 (kernel 6.14-rc4, ppc32)

2025-02-27 Thread Erhard Furtner
On Thu, 27 Feb 2025 10:42:44 +0530 Ritesh Harjani (IBM) wrote: > Since only the swapon failed, I think you might still have the console > up right? So this is mostly a vmalloc allocation failure report? Correct. The machine stays usable via VNC in my case, even after the vmalloc allocation fail

Re: Missing '#size-cells' in /ht@0,f2000000/pci@8/mac-io@7/i2s@0 on G5/G4 (kernel 6.13-rc3)

2025-02-26 Thread Erhard Furtner
On Mon, 23 Dec 2024 23:58:26 +1100 Michael Ellerman wrote: > Erhard Furtner writes: > > Greetings! > > > > I am aware there is commit cf89c9434af122f28a3552e6f9cc5158c33ce50a > > (already merged in v6.13-rc3) which fixes some of the "Missing > > &

Re: BUG: KASAN: vmalloc-out-of-bounds in copy_to_kernel_nofault+0xd8/0x1c8 (v6.13-rc6, PowerMac G4)

2025-02-02 Thread Erhard Furtner
On Sun, 2 Feb 2025 09:44:20 +0100 Christophe Leroy wrote: > This time the problem is a mixture of commit 465cabc97b42 > ("powerpc/code-patching: introduce patch_instructions()") and commit > c28c15b6d28a ("powerpc/code-patching: Use temporary mm for Radix MMU") > which is revealed by commit e4

Re: BUG: KASAN: vmalloc-out-of-bounds in copy_to_kernel_nofault+0xd8/0x1c8 (v6.13-rc6, PowerMac G4)

2025-01-23 Thread Erhard Furtner
On Wed, 22 Jan 2025 19:23:00 +0100 Christophe Leroy wrote: > Le 22/01/2025 à 16:32, Christophe Leroy a écrit : > > > > > > Le 22/01/2025 à 00:21, Erhard Furtner a écrit : > >> On Tue, 21 Jan 2025 23:07:25 +0100 > >> Christophe Leroy wrote: >

Re: Missing '#size-cells' in /ht@0,f2000000/pci@8/mac-io@7/i2s@0 on G5/G4 (kernel 6.13-rc3)

2024-12-27 Thread Erhard Furtner
On Mon, 23 Dec 2024 23:58:26 +1100 Michael Ellerman wrote: > Erhard Furtner writes: > > Greetings! > > > > I am aware there is commit cf89c9434af122f28a3552e6f9cc5158c33ce50a > > (already merged in v6.13-rc3) which fixes some of the "Missing > > &

Re: OVERFLOW_KUNIT_TEST fails with BUG: KASAN: stack-out-of-bounds in string_nocheck+0x168/0x1c8 (kernel 6.11-rc2, PowerMac G4 DP)

2024-08-14 Thread Erhard Furtner
On Mon, 12 Aug 2024 11:54:11 -0700 Kees Cook wrote: > On Fri, Aug 09, 2024 at 11:15:37PM +0200, Erhard Furtner wrote: > > Greetings! > > > > When KASAN is enabled the Overflow KUnit test fails: > > > > [...] > > ok 16 shift_nonsense_test > >

Re: Kernel build failure with MEM_ALLOC_PROFILING=y set (Talos II, v6.10-rc5)

2024-07-20 Thread Erhard Furtner
On Sat, 29 Jun 2024 15:31:28 +0200 Erhard Furtner wrote: > I get a build failure on v6.10-rc5 on my Talos II when MEM_ALLOC_PROFILING=y > is enabled: > > [...] > LD [M] fs/xfs/xfs.o > LD [M] fs/bcachefs/bcachefs.o > AR built-in.a > AR vmlinux

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-06 Thread Erhard Furtner
On Thu, 6 Jun 2024 09:24:56 +0200 "Vlastimil Babka (SUSE)" wrote: > Besides the zpool commit which might have just pushed the machine over the > edge, but it was probably close to it already. I've noticed a more general > problem that there are GFP_KERNEL allocations failing from kswapd. Those >

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-06 Thread Erhard Furtner
On Wed, 5 Jun 2024 16:58:11 -0700 Yosry Ahmed wrote: > On Wed, Jun 5, 2024 at 4:53 PM Yu Zhao wrote: > > > > On Wed, Jun 5, 2024 at 5:42 PM Yosry Ahmed wrote: > > > > > > On Wed, Jun 5, 2024 at 4:04 PM Erhard Furtner > > > wrote: > &g

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-05 Thread Erhard Furtner
On Tue, 4 Jun 2024 20:03:27 -0700 Yosry Ahmed wrote: > Could you check if the attached patch helps? It basically changes the > number of zpools from 32 to min(32, nr_cpus). Thanks! The patch does not fix the issue but it helps. Means I still get to see the 'kswapd0: page allocation failure' in

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-04 Thread Erhard Furtner
On Tue, 4 Jun 2024 11:18:25 -0600 Yu Zhao wrote: > Hi Erhard, > > If it's not too much trouble, could you "grep nr_zspages /proc/vmstat" > on kernels before and after the bad commit? It'd be great if you could > run the grep command right before the OOM kills. > > The overall internal fragmenta

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-04 Thread Erhard Furtner
On Tue, 4 Jun 2024 11:01:39 -0700 Yosry Ahmed wrote: > How many CPUs does this machine have? I am wondering if 32 can be an > overkill for small machines, perhaps the number of pools should be > max(nr_cpus, 32)? This PowerMac G4 DP got 2 CPUs. Not much for a desktop machine by todays standards

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-03 Thread Erhard Furtner
On Sun, 2 Jun 2024 20:03:32 +0200 Erhard Furtner wrote: > On Sat, 1 Jun 2024 00:01:48 -0600 > Yu Zhao wrote: > > > The OOM kills on both kernel versions seem to be reasonable to me. > > > > Your system has 2GB memory and it uses zswap with zsmalloc (which is >

Re: WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c at boot when netconsole is enabled (kernel v6.9-rc5, v6.8.7, sungem, PowerMac G4 DP)

2024-05-08 Thread Erhard Furtner
On Mon, 6 May 2024 18:10:20 -0700 Jakub Kicinski wrote: > Excellent! Do you want to submit that as an official patch? > The explanation is that we can't call disable_irq() from atomic > context (which which netpoll runs). But the callback is no longer > necessary as we can depend on NAPI to do th

Re: WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c at boot when netconsole is enabled (kernel v6.9-rc5, v6.8.7, sungem, PowerMac G4 DP)

2024-05-06 Thread Erhard Furtner
On Mon, 6 May 2024 07:26:45 -0700 Jakub Kicinski wrote: > On Sun, 5 May 2024 23:27:13 +0200 Erhard Furtner wrote: > > > On Sun, 28 Apr 2024 12:53:06 +0200 Erhard Furtner wrote: > > > > With netconsole enabled I get this "WARNING: CPU: 1 PID: 1 at &

Re: WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c at boot when netconsole is enabled (kernel v6.9-rc5, v6.8.7, sungem, PowerMac G4 DP)

2024-05-04 Thread Erhard Furtner
On Mon, 29 Apr 2024 18:36:30 -0700 Jakub Kicinski wrote: > On Sun, 28 Apr 2024 12:53:06 +0200 Erhard Furtner wrote: > > With netconsole enabled I get this "WARNING: CPU: 1 PID: 1 at > > net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c" and "WARNING: > > CPU

Re: BUG: Bad page map in process init pte:c0ab684c pmd:01182000 (on a PowerMac G4 DP)

2024-03-04 Thread Erhard Furtner
On Thu, 29 Feb 2024 17:11:28 + Christophe Leroy wrote: > Interesting. > > I guess 0xe000 is where linear RAM starts to be mapped with pages ? > Can you confirm with a dump of > /sys/kernel/debug/powerpc/block_address_translation ? # cat /sys/kernel/debug/powerpc/block_address_transla

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2024-02-28 Thread Erhard Furtner
On Thu, 14 Sep 2023 04:54:17 + Christophe Leroy wrote: > Le 12/09/2023 à 19:39, Christophe Leroy a écrit : > > > > > > Le 12/09/2023 à 17:59, Erhard Furtner a écrit : > >> > >> printk: bootconsole [udbg0] enabled > >> Total memory = 2048MB

Re: "BUG: Kernel NULL pointer dereference on read at 0x00000000" at running drm_gem_shmem_test on a Talos II, kernel 6.8-rc5

2024-02-23 Thread Erhard Furtner
On Fri, 23 Feb 2024 02:42:22 +0100 Erhard Furtner wrote: > Greetings! > > Looks like my Talos II (running a BE kernel+system) fails some of the kernels > internal unit tests. At running drm_gem_shmem_test via 'modprobe -v > drm_gem_shmem_test' I get: KASAN gets so

Re: "test_ip_fast_csum: ASSERTION FAILED at lib/checksum_kunit.c:589" at boot with CONFIG_CHECKSUM_KUNIT=y enabled on a Talos II, kernel 6.8-rc5

2024-02-23 Thread Erhard Furtner
On Fri, 23 Feb 2024 09:06:56 + Christophe Leroy wrote: > Yes, with second patch is magically works, meaning the patch description > is not correct because the problem for powerpc it not at all related to > memory alignment but to endianness. And endianness should have been > fixed by patch

Fail to boot KCSAN-enabled kernel (Kernel panic - not syncing: Fatal exception, Unrecoverable FP Unavailable Exception 800 at c0000000022cafe0) on a PowerMac G5, kernel 6.6.1

2023-11-13 Thread Erhard Furtner
Greetings! Both my PowerMac G5 and my Talos II (running a BE kernel+system) fail to boot a KCSAN-enabled kernel. Same kernel without KSCAN enabled boots just fine. I tried to dig a little deeper with a stripped down .config on the G5 with CONFIG_KCSAN=y, CONFIG_KCSAN_STRICT=y and finally got so

Re: Several kmemleak reports + "refcount_t: underflow; use-after-free" at boot when OF_UNITTEST + OF_OVERLAY is set (Kernel v6.6-rc6, PowerMac G5 11,2)

2023-10-31 Thread Erhard Furtner
On Mon, 30 Oct 2023 11:26:48 -0500 Rob Herring wrote: > The test tells you to expect a use-after-free... > > > ---[ end trace <> ]--- ### dt-test ### pass > > of_unittest_lifecycle():3209 > > [ cut here ] > > refcount_t: underflow; use-after-free. > > Then you get a u

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2023-10-18 Thread Erhard Furtner
On Wed, 18 Oct 2023 16:45:04 +1100 Michael Ellerman wrote: > Thanks. Yeah text is generally better, it archives better and can be > grepped etc. but in this case I was going a bit mad trying to make sense > of the oops :) > > In hindsight the bug is an obvious boot time ordering problem, can you

Re: [PATCH 0/2] Allow nesting of lazy MMU mode

2023-10-17 Thread Erhard Furtner
On Tue, 17 Oct 2023 11:34:23 +0530 "Aneesh Kumar K.V" wrote: > ie, we can do something like below. The change also make sure we call > set_pte_filter on all the ptes we are setting via set_ptes(). I haven't > sent this as a proper patch because we still are not able to fix the > issue Erhard repo

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2023-10-12 Thread Erhard Furtner
On Thu, 12 Oct 2023 10:47:51 +1100 Michael Ellerman wrote: > I don't see this crash on my quad G5. > > I notice that your config has CONFIG_FLATMEM=y. Can you try switching to > SPARSEMEM and see if that helps? It might help us narrow down the bug at > least. Your assumption was right, interest

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2023-10-06 Thread Erhard Furtner
On Fri, 06 Oct 2023 17:38:14 +0530 "Aneesh Kumar K.V" wrote: > Sorry that I shared a change without build testing. Here is the updated > change > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index 3ba9fe411604..e563e13ffd88 100644 > --- a/arch/powerpc/mm/pgtable.c > +

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2023-10-06 Thread Erhard Furtner
On Fri, 06 Oct 2023 11:04:15 +0530 "Aneesh Kumar K.V" wrote: > Can you check this change? > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index 3ba9fe411604..6d144fedd557 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -187,8 +187,8 @@ sta

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-09-14 Thread Erhard Furtner
On Thu, 14 Sep 2023 04:54:17 + Christophe Leroy wrote: > Le 12/09/2023 à 19:39, Christophe Leroy a écrit : > > > > > > Le 12/09/2023 à 17:59, Erhard Furtner a écrit : > >> > >> printk: bootconsole [udbg0] enabled > >> Total memory = 2048MB

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-09-12 Thread Erhard Furtner
On Tue, 12 Sep 2023 17:39:10 + Christophe Leroy wrote: > Ah ok, maybe your CPU only has 4 BATs and they are all used, following > change would tell us. > > diff --git a/arch/powerpc/mm/book3s32/mmu.c b/arch/powerpc/mm/book3s32/mmu.c > index 850783cfa9c7..bd26767edce7 100644 > --- a/arch/pow

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-09-12 Thread Erhard Furtner
On Tue, 12 Sep 2023 07:47:50 + Christophe Leroy wrote: > I suspect something wrong when we set the BATs. > > Can you try with the following additional traces: > > diff --git a/arch/powerpc/mm/kasan/book3s_32.c > b/arch/powerpc/mm/kasan/book3s_32.c > index 450a67ef0bbe..9954b7a3b7ae 100644

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-09-03 Thread Erhard Furtner
On Fri, 1 Sep 2023 07:43:34 + Christophe Leroy wrote: > >> Can you try what happens when you remove the call to kasan_init() at the > >> start of setup_arch() in arch/powerpc/kernel/setup-common.c > > > > Ok, so I left the other patches in place + btext_map() instead of > > btext_unmap()

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-31 Thread Erhard Furtner
On Thu, 31 Aug 2023 05:32:46 + Christophe Leroy wrote: > Ok so there is some corrupted memory somewhere. > > Can you try what happens when you remove the call to kasan_init() at the > start of setup_arch() in arch/powerpc/kernel/setup-common.c Ok, so I left the other patches in place + bte

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-27 Thread Erhard Furtner
On Thu, 24 Aug 2023 21:36:26 +1000 Michael Ellerman wrote: > > printk: bootconsole [udbg0] enabled > > Total memory = 2048MB; using 4096kB for hash table > > mapin_ram:125 > > mmu_mapin_ram:169 0 3000 140 200 > > __mmu_mapin_ram:146 0 140 > > __mmu_mapin_ram:155 140 > > __mmu_

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-23 Thread Erhard Furtner
On Tue, 22 Aug 2023 07:31:54 + Christophe Leroy wrote: > Le 18/08/2023 à 18:23, Erhard Furtner a écrit : > > On Fri, 18 Aug 2023 15:47:38 + > > Christophe Leroy wrote: > > > >> I'm wondering if the problem is just linked to the kernel being built &

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-18 Thread Erhard Furtner
On Fri, 18 Aug 2023 15:47:38 + Christophe Leroy wrote: > I'm wondering if the problem is just linked to the kernel being built > with CONFIG_SMP or if it is the actual startup of a secondary CPU that > cause the freeze. > > Please leave the btext_unmap() in place because I think it is impo

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-18 Thread Erhard Furtner
On Fri, 18 Aug 2023 09:13:21 +1000 Michael Ellerman wrote: > Try just removing the call to btext_unmap() entirely and see how far it goes? > > cheers Ok, I commented out btext_unmap() in MMU_init() and the freeze just happens before the "Linux version 6.5.0-rc6-PMacG4-dirty [...]"-line: [

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-17 Thread Erhard Furtner
On Wed, 16 Aug 2023 15:56:26 + Christophe Leroy wrote: > Not sure this is the reason of the crash. Just that it disables bootx > console here and doesn't re-enable any console before the crash. > > Could you move the call to btext_unmap() after the call to > memblock_set_current_limit(lowm

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-15 Thread Erhard Furtner
On Tue, 15 Aug 2023 17:25:13 + Christophe Leroy wrote: > I just sent a patch with additional pr_info() in order to help locate > the issue, please provide output with that patch. > > Thanks > Christophe Thanks for your efforts Christophe! With the patch applied I get this output + a blank

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-14 Thread Erhard Furtner
On Mon, 14 Aug 2023 09:40:44 + Christophe Leroy wrote: > Interesting. That means we get stuck somewhere around MMU_init() > > We know that MMU_init_hw() is called and runs at least until: > > pr_info("Total memory = %lldMB; using %ldkB for hash table\n", > (unsigned lon

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-13 Thread Erhard Furtner
On Fri, 11 Aug 2023 06:45:14 + Christophe Leroy wrote: > Le 11/08/2023 à 01:48, Erhard Furtner a écrit : > > I wanted to fire up my PowerMac G4 MDD (Dual CPU) with a KASAN debug build > > of kernel 6.5-rc5 for testing purposes. But the kernel fails to boot at a > > ver

Re: WARNING: CPU: 0 PID: 756 at arch/powerpc/kernel/exceptions-64s.S:2863 masked_interrupt+0xc/0xe4 with kernel Hard LOCKUP and reboot afterwards (kernel 6.2, PowerMac G5 11,2)

2023-02-22 Thread Erhard Furtner
On Wed, 22 Feb 2023 00:42:48 +0100 Erhard Furtner wrote: > Got this now the 2nd time in row on my G5 11.2 trying to copy a btrfs > partition via gparted: Also happens on kernel 6.1.12: [...] [ cut here ] WARNING: CPU: 1 PID: 34 at arch/powerpc/kernel/exceptions

[PATCH v2] of: unittest: fix memory leak in attach_node_and_children

2019-11-25 Thread Erhard Furtner
It looks like the leak was introduced by this commit: Fixes: 5babefb7f7ab ("of: unittest: allow base devicetree to have symbol metadata") Signed-off-by: Erhard Furtner Reviewed-by: Michael Ellerman Reviewed-by: Tyrel Datwyler --- Changes in v2: - Make the commit message mo

[PATCH] of: unittest: fix memory leak in attach_node_and_children

2019-11-14 Thread Erhard Furtner
In attach_node_and_children memory is allocated for full_name via kasprintf. If the condition of the 1st if is not met the function returns early without freeing the memory. Add a kfree() to fix that. Signed-off-by: Erhard Furtner --- drivers/of/unittest.c | 4 +++- 1 file changed, 3 insertions