Jessica Yu and Rusty Russell be
CCed on things like this in the future?
On Wed, 1 Mar 2017 14:04:53 -0800
David Daney wrote:
For powerpc the __jump_table section in modules is not aligned, this
causes a WARN_ON() splat when loading a module containing a
__jump_table.
Strict alignment
h uses the two least significant bits of pointers to
__jump_table elements.
Fix by forcing __jump_table to 8, which is the same alignment used for
this section in the kernel proper.
Signed-off-by: David Daney
Tested-by: Sachin Sant
---
scripts/module-common.lds | 2 ++
1 file changed, 2 insertion
On 03/01/2017 12:02 PM, Jason Baron wrote:
On 03/01/2017 11:40 AM, David Daney wrote:
On 02/28/2017 10:34 PM, Michael Ellerman wrote:
Jason Baron writes:
...
I also checked all the other .ko files and they were properly aligned.
So I think this should hopefully work, and I like that its
On 02/28/2017 10:34 PM, Michael Ellerman wrote:
Jason Baron writes:
...
I also checked all the other .ko files and they were properly aligned.
So I think this should hopefully work, and I like that its not a
per-arch fix.
Sachin, sorry to bother you again, but I'm hoping you can try David's
la
On 02/28/2017 11:34 AM, Jason Baron wrote:
On 02/28/2017 02:22 PM, David Daney wrote:
On 02/28/2017 11:05 AM, David Daney wrote:
On 02/28/2017 10:39 AM, Jason Baron wrote:
[...]
I suspect that the alignment of the __jump_table section in the .ko
files is not correct, and you are seeing
On 02/28/2017 11:05 AM, David Daney wrote:
On 02/28/2017 10:39 AM, Jason Baron wrote:
[...]
I suspect that the alignment of the __jump_table section in the .ko
files is not correct, and you are seeing some sort of problem due to
that.
Hi,
Yes, if you look at the trace that Sachin sent
On 02/28/2017 10:39 AM, Jason Baron wrote:
On 02/28/2017 01:16 PM, David Daney wrote:
On 02/28/2017 08:21 AM, Steven Rostedt wrote:
On Tue, 28 Feb 2017 10:25:46 +0530
Sachin Sant wrote:
File: ./net/ipv4/xfrm4_input.o
[12] __jump_table PROGBITS 000639
18
On 02/28/2017 08:21 AM, Steven Rostedt wrote:
On Tue, 28 Feb 2017 10:25:46 +0530
Sachin Sant wrote:
File: ./net/ipv4/xfrm4_input.o
[12] __jump_table PROGBITS 000639 18 18 WAM
0 0 1
File: ./net/ipv4/udplite.o
File: ./net/ipv4/xfrm4_output.o
[ 9] __jump_
On 02/27/2017 02:50 PM, Jason Baron wrote:
On 02/27/2017 05:45 PM, David Daney wrote:
On 02/27/2017 02:36 PM, Steven Rostedt wrote:
On Mon, 27 Feb 2017 14:21:21 -0800
David Daney wrote:
See attached for mips. It seems to do the right thing.
I leave it as an exercise to the reader to fix
On 02/27/2017 02:36 PM, Steven Rostedt wrote:
On Mon, 27 Feb 2017 14:21:21 -0800
David Daney wrote:
See attached for mips. It seems to do the right thing.
I leave it as an exercise to the reader to fix the other architectures.
Consult your own binutils experts to verify that what I say is
On 02/27/2017 02:09 PM, Steven Rostedt wrote:
On Mon, 27 Feb 2017 13:41:13 -0800
David Daney wrote:
On 02/27/2017 01:06 PM, Steven Rostedt wrote:
On Mon, 27 Feb 2017 11:59:50 -0800
David Daney wrote:
For me the size is not the important issue, it is the alignment of the
struct jump_entry
On 02/27/2017 01:06 PM, Steven Rostedt wrote:
On Mon, 27 Feb 2017 11:59:50 -0800
David Daney wrote:
For me the size is not the important issue, it is the alignment of the
struct jump_entry entries in the table. I don't understand how your
patch helps, and I cannot Acked-by unl
On 02/27/2017 11:18 AM, Jason Baron wrote:
On 02/27/2017 01:57 PM, David Daney wrote:
On 02/27/2017 10:49 AM, Jason Baron wrote:
The core jump_label code makes use of the 2 lower bits of the
static_key::[type|entries|next] field. Thus, ensure that the jump_entry
table is at least 4-byte
already properly aligned, this change will add
padding, which is probably not what we want.
Have you ever seen a problem with misalignment in the real world?
If so, I think a better approach might be to set properties on the
__jump_table section to force the proper alignment, or do something in
the linker script.
David Daney
From: Ganapatrao Kulkarni
NODE_DATA is defined across multiple asm header files.
Moving generic definition to asm-generic/mmzone.h to
remove redundant definitions.
Reviewed-by: Robert Richter
Signed-off-by: Ganapatrao Kulkarni
Signed-off-by: David Daney
---
arch/arm64/include/asm/mmzone.h
Signed-off-by: David Daney
---
arch/arm64/include/asm/topology.h | 3 ---
arch/ia64/include/asm/topology.h| 4
arch/metag/include/asm/topology.h | 3 ---
arch/powerpc/include/asm/topology.h | 4
arch/s390/include/asm/pci.h | 2 +-
arch/s390/include/asm/topology.h| 1
From: David Daney
Refactor many architectures' cpumask_of_pcibus and NODE_DATA definitions
by moving them to asm-generic.
Tested on arm64.
Build tested on ia64, m32r, powerpc, s390, sh, sparc(64), tile, x86
This patch set (arm64 portion) depends on this one:
https://lkml.org/lkml/2016
ging these files, and removing
the likewise useless thunder-88xx.dts thunder-88xx.dtsi
David Daney
[...]
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On 01/18/2016 08:36 AM, Ganapatrao Kulkarni wrote:
update numa_node of device associated with pci bus.
moved down devm_kzalloc to allocate from node memory.
Signed-off-by: Ganapatrao Kulkarni
---
drivers/pci/host/pci-host-generic.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(
On 02/26/2015 02:38 PM, Andrew Morton wrote:
[...]
From: Andrew Morton
Subject: fix-offset2lib-issue-for-x86-arm-powerpc-and-mips-fix
Consolidate randomize_et_dyn() implementations into fs/binfmt_elf.c.
There doesn't seem to be a compile-time way of making randomize_et_dyn()
go away on archite
that, although
documented in the kernel source tree, cannot be changed in incompatible
ways as time progresses.
David Daney
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
("gpio: removing gpiochip with gpios still
requested\n");
panic?
NACK to the patch for this reason. The strongest thing you should do
here is WARN.
That said, I am not sure why we need this whole patch set in the first
place.
David Daney
Is this likely to happen?
Gr{o
On 05/29/2014 02:54 PM, abdoulaye berthe wrote:
Did you forget a changelog explaining why this is either needed, or even
a good idea? I joined the conversation late and don't know why you are
doing this.
Thanks,
David Daney
Signed-off-by: abdoulaye berthe
---
arch/arm/common/sc
e patch eliminates, is avoided?
I doubt it.
As far as the patch goes:
Acked-by: David Daney
David Daney
Honestly, I don't know. Let's CC the author of that code (David Daney).
I wonder why get_maintainer.pl didn't generate his name for this file,
even though the entire fil
re it is needed.
David Daney
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
te of each CPU. */
-DEFINE_PER_CPU(int, cpu_state);
-
extern void fixup_irqs(void);
static DEFINE_SPINLOCK(smp_reserve_lock);
The Octeon bit:
Acked-by: David Daney
FWIW, the rest looks good too.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.
On 05/24/2012 12:03 PM, Timur Tabi wrote:
David Daney wrote:
Well, the MDIO bus must have an associated device tree node.
For my OCTEON code, the MDIO bus device is created as a result of the
call to of_platform_bus_probe(), which takes care of filling in all the
device tree nodes of the
On 05/24/2012 11:28 AM, Timur Tabi wrote:
David Daney wrote:
Yes. You may note in the DTS file I attached in the parent (sorry for
the fubar mime types), that there are two, almost identical, MDIO
masters. smi0 has two directly attached PHYs. smi1 goes to the mux,
and each child of the mux
On 05/22/2012 01:09 PM, Grant Likely wrote:
On Tue, May 22, 2012 at 1:45 PM, David Daney wrote:
On 05/19/2012 11:08 PM, Grant Likely wrote:
On Sat, 19 May 2012 23:54:36 -0600, Grant
Likelywrote:
On Fri, 11 May 2012 15:05:21 -0700, David Daney
wrote:
From: David Daney
When
On 05/19/2012 11:08 PM, Grant Likely wrote:
On Sat, 19 May 2012 23:54:36 -0600, Grant Likely
wrote:
On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote:
From: David Daney
When generating MODALIASes, it is convenient to add things like "spi:"
or "i2c:" to the front o
On 05/18/2012 03:09 PM, Timur Tabi wrote:
David Daney wrote:
I'm not sure what the "parent" MDIO bus node is supposed to represent.
Is that that device that actually controls the muxing hardware
No. It is the device that implements the master 802.3 clause {22,45}
MDIO Sta
On 05/18/2012 02:42 PM, Tabi Timur-B04825 wrote:
On Wed, May 2, 2012 at 8:16 PM, David Daney wrote:
From: David Daney
This code has been working well for about six months on a couple of
different configurations (boards), so I thought it would be a good
time to send it out again, and I hope
From: David Daney
When generating MODALIASes, it is convenient to add things like "spi:"
or "i2c:" to the front of the strings. This allows the standard
modprobe to find the right driver when automatically populating bus
children from the device tree structure.
Add a p
On 05/11/2012 08:47 AM, Bjørn Mork wrote:
CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use
IS_ENABLED macro to prevent build error:
ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!
Reported-by: Randy Dunlap
Cc: David Daney
Signed-off-by: Bjørn Mork
etting the
dependencies right. :-/
Indeed, how embarrassing.
It looks like Bjørn may have already posted a fix. I will try to verify
that it works, and take appropriate action.
Sorry about the screw up,
David Daney
___
Linuxppc-dev mailing list
Li
/297
So just for the hell of it...
Acked-by: David Daney
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On 01/27/2011 12:04 PM, Scott Wood wrote:
On Thu, 27 Jan 2011 09:57:39 -0800
David Daney wrote:
On 01/27/2011 04:12 AM, Coly Li wrote:
diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h
index 065c590..10889a6 100644
--- a/arch/powerpc/include/asm/bug.h
+++ b/arch
, any feedback
of this patch is welcome.
Signed-off-by: Coly Li
Cc: Jeremy Fitzhardinge
Cc: David Daney
Cc: Wang Cong
Cc: Yong Zhang
diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h
index 065c590..10889a6 100644
--- a/arch/powerpc/include/asm/bug.h
+++ b/arch/powerpc/in
will also have to patch the mailbox_interrupt() function in
arch/mips/cavium-octeon/smp.c
David Daney.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Oh, you mean things like:
of_{,un}register_platform_driver vs. platform_driver_{,un}register
That one is particularly annoying to me.
David Daney
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
the other, but for consistency you
should change all these directory and file names as well.
David Daney
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On 11/16/2010 10:14 PM, Dirk Brandewie wrote:
On 11/16/2010 06:58 PM, Grant Likely wrote:
On Tue, Nov 16, 2010 at 7:21 PM, Dirk Brandewie
wrote:
On 11/16/2010 04:39 PM, David Daney wrote:
Thanks for doing this. However I have a few comments...
On 11/16/2010 02:41 PM, dirk.brande
@
+ @echo '.balign DTB_ALIGNMENT'>> $@
+
+DTC = $(objtree)/scripts/dtc/dtc
+
+quiet_cmd_dtc = DTC$@
+ cmd_dtc = $(DTC) -O dtb -o $(obj)/$*.dtb -b 0 $(DTS_FLAGS)
$(src)/dts/$*.dts
+
+$(obj)/%.dtb: $(src)/dts/%.dts
+ $(call if_changed,dtc)
Do all the gene
There are two identical implementations of of_get_mac_address(), one
each in arch/powerpc/kernel/prom_parse.c and
arch/microblaze/kernel/prom_parse.c. Move this function to a new
common file of_net.{c,h} and adjust all the callers to include the new
header.
Signed-off-by: David Daney
Cc: Michal
nfig variables below as well.
Perhaps they could be rearranged in a similar manner.
David Daney
+ select NOP_USB_XCEIV
+ select USB_OTG_UTILS
+ tristate "Synopsys DWC OTG Controller"
+ default USB_GADGET
+ help
+ This driver provides USB Device Controlle
all see the patch?
Thanks,
David Daney
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
used with the
original Synopsys license, without tacking on this GPL bit?
David Daney
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
See: http://marc.info/?l=linux-mips&m=125502126531841&w=2
Thanks,
David Daney
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
eeded for chips
not targeted by the initial patch set.
David Daney
arch/powerpc/boot/dts/kilauea.dts | 15 +
Also, please provide a clean patch that only
includes the driver, and split PPC hooks into
a separate patch.
--
To unsubscribe from this list: send the line "unsubscribe
hy are you posting this old driver version without trying to sync
against our tree which includes a number of fixes - you should know
about these.
This could be a question with an obvious answer, but which tree are you
referring to when you say 'our tree'
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney
CC: Benjamin Herrenschmidt
CC: Paul Mackerras
CC: linuxppc-...@ozlabs.org
---
arch/powerpc/include/asm/bug.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/include/asm/bug.h
, they
seem plausible.
I don't plan on pushing these things out any more, so if you
like them please merge them via your architecture trees.
I will reply with the 5 patches.
David Daney (5):
mn10300: Convert BUG() to use unreachable()
parisc: Convert BUG() to use unreachable()
po
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney
CC: Benjamin Herrenschmidt
CC: Paul Mackerras
CC: linuxppc-...@ozlabs.org
---
arch/powerpc/include/asm/bug.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/include/asm/bug.h
!CONFIG_BUG case. This
one may be a little controversial as it will end up making code
slightly larger when !CONFIG_BUG and you are using a pre-GCC-4.5
compiler.
I will reply with the 11 patches.
David Daney (11):
Add support for GCC-4.5's __builtin_unreachable() to compiler.h (v2)
Geert Uytterhoeven wrote:
On Fri, Sep 11, 2009 at 17:58, David Daney wrote:
Michael Buesch wrote:
On Friday 11 September 2009 01:56:42 David Daney wrote:
+/* Unreachable code */
+#ifndef unreachable
+# define unreachable() do { for (;;) ; } while (0)
+#endif
# define unreachable() do
Michael Buesch wrote:
On Friday 11 September 2009 01:56:42 David Daney wrote:
+/* Unreachable code */
+#ifndef unreachable
+# define unreachable() do { for (;;) ; } while (0)
+#endif
# define unreachable() do { } while (1)
? :)
Clearly I was not thinking clearly when I wrote that part
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney
CC: Benjamin Herrenschmidt
CC: Paul Mackerras
CC: linuxppc-...@ozlabs.org
---
arch/powerpc/include/asm/bug.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/include/asm/bug.h
nreachable()' that will expand to either
__builtin_unreachable() or an endless loop depending on the compiler
version.
Signed-off-by: David Daney
CC: Thomas Gleixner
CC: Ingo Molnar
CC: "H. Peter Anvin"
CC: x...@kernel.org
CC: r...@linux-mips.org
CC: linux-m...@linux-mips.org
CC: Mart
macros to use it instead of for(;;) or
while(1) loops.
I will reply with the 10 patches.
The architecture specific patches I will send to a smaller set of
people.
David Daney (10):
Add support for GCC-4.5's __builtin_unreachable() to compiler.h
x86: Convert BUG() to use unreachable()
59 matches
Mail list logo
