[PATCH net-next] net: ibmveth: Refactored veth_pool_store for better maintainability

Make veth_pool_store detect requested pool changes, close device if necessary, update pool, and reopen device. Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/ibmveth.c | 111 + 1 file changed, 67 insertions(+), 44 deletions(-) diff --git a/drivers/net

[PATCH v4 1/3] net: ibmveth: Indented struct ibmveth_adapter correctly

Made struct ibmveth_adapter follow indentation rules Signed-off-by: Dave Marquardt Reviewed-by: Michal Swiatkowski Reviewed-by: Simon Horman --- drivers/net/ethernet/ibm/ibmveth.h | 64 +++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/net

[PATCH v4 3/3] net: ibmveth: added KUnit tests for some buffer pool functions

Added KUnit tests for ibmveth_remove_buffer_from_pool and ibmveth_rxq_get_buffer under new IBMVETH_KUNIT_TEST config option. Signed-off-by: Dave Marquardt Reviewed-by: Simon Horman --- drivers/net/ethernet/ibm/Kconfig | 13 +++ drivers/net/ethernet/ibm/ibmveth.c | 129

[PATCH v4 2/3] net: ibmveth: Reset the adapter when unexpected states are detected

Reset the adapter through new function ibmveth_reset, called in WARN_ON situations. Removed conflicting and unneeded forward declaration. Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/ibmveth.c | 118 - drivers/net/ethernet/ibm/ibmveth.h | 1 + 2 files

[PATCH v4 0/3] net: ibmveth: Make ibmveth use new reset function and new KUnit testsg

th_adapter as a separate patch before ibmveth_reset and WARN_ON changes v2: Addressed Michal Swiatkowski's review comments - Split into multiple patches - Used a more descriptive label Dave Marquardt (3): net: ibmveth: Indented struct ibmveth_adapter correctly net: ibmveth: Reset t

[PATCH net-next v3 3/3] net: ibmveth: added KUnit tests for some buffer pool functions

Added KUnit tests for ibmveth_remove_buffer_from_pool and ibmveth_rxq_get_buffer under new IBMVETH_KUNIT_TEST config option. Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/Kconfig | 13 +++ drivers/net/ethernet/ibm/ibmveth.c | 125 + 2 files changed

[PATCH net-next v3 0/3] net: ibmveth: Make ibmveth use new reset function and new KUnit tests

ski's review comments - Split into multiple patches - Used a more descriptive label Dave Marquardt (3): net: ibmveth: Indented struct ibmveth_adapter correctly net: ibmveth: Reset the adapter when unexpected states are detected net: ibmveth: added KUnit tests for some buffer pool

[PATCH net-next v3 1/3] net: ibmveth: Indented struct ibmveth_adapter correctly

Made struct ibmveth_adapter follow indentation rules Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/ibmveth.h | 64 +++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.h b/drivers/net/ethernet/ibm/ibmveth.h

[PATCH net-next v3 2/3] net: ibmveth: Reset the adapter when unexpected states are detected

Reset the adapter through new function ibmveth_reset, called in WARN_ON situations. Removed conflicting and unneeded forward declaration. Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/ibmveth.c | 116 - drivers/net/ethernet/ibm/ibmveth.h | 1 + 2 files

Re: [PATCH net-next v2 1/2] net: ibmveth: make ibmveth use WARN_ON instead of BUG_ON

Simon Horman writes: > On Mon, Apr 14, 2025 at 02:40:15PM -0500, Dave Marquardt wrote: >> Replaced BUG_ON calls with WARN_ON calls with error handling, with >> calls to a new ibmveth_reset routine, which resets the device. Removed >> conflicting and unneeded forward decla

Re: [PATCH net-next] ibmveth: Use WARN_ON with error handling rather than BUG_ON

Michal Swiatkowski writes: > On Thu, Apr 10, 2025 at 01:39:18PM -0500, Dave Marquardt wrote: >> - Replaced BUG_ON calls with WARN_ON calls with error handling, >> with calls to a new ibmveth_reset routine, which resets the device. >> - Added KUnit tests for ibmveth_remove

[PATCH net-next v2 2/2] net: ibmveth: added KUnit tests for some buffer pool functions

Added KUnit tests for ibmveth_remove_buffer_from_pool and ibmveth_rxq_get_buffer under new IBMVETH_KUNIT_TEST config option. Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/Kconfig | 13 +++ drivers/net/ethernet/ibm/ibmveth.c | 125 + 2 files changed

[PATCH net-next v2 1/2] net: ibmveth: make ibmveth use WARN_ON instead of BUG_ON

Replaced BUG_ON calls with WARN_ON calls with error handling, with calls to a new ibmveth_reset routine, which resets the device. Removed conflicting and unneeded forward declaration. Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/ibmveth.c | 116

[PATCH net-next v2 0/2] net: ibmveth: Make ibmveth use WARN_ON instead of BUG_ON and added KUnit tests

Michal Swiatkowski's comments - Split into multiple patches - Used a more descriptive label *** BLURB HERE *** Dave Marquardt (2): net: ibmveth: make ibmveth use WARN_ON instead of BUG_ON net: ibmveth: added KUnit tests for some buffer pool functions drivers/net/ethernet/ibm/Kconfig

[PATCH net-next] ibmveth: Use WARN_ON with error handling rather than BUG_ON

declaration of ibmveth_rxq_harvest_buffer. Signed-off-by: Dave Marquardt --- drivers/net/ethernet/ibm/Kconfig | 13 ++ drivers/net/ethernet/ibm/ibmveth.c | 242 ++--- drivers/net/ethernet/ibm/ibmveth.h | 65 3 files changed, 269 insertions(+), 51 deletions(-) diff

[PATCH net v2] net: ibmveth: make veth_pool_store stop hanging

y result in crashes, deadlocks, or race conditions. For example, calling napi_disable() multiple times in a row will deadlock. In the normal open and close paths, rtnl_mutex is acquired to prevent other callers. This is missing from veth_pool_store. Use rtnl_mutex in veth_pool_store fixes these ha

Re: [PATCH net] net: ibmveth: make veth_pool_store stop hanging

Paolo Abeni writes: > On 3/31/25 11:23 PM, davem...@linux.ibm.com wrote: >> From: Dave Marquardt >> >> Use rtnl_mutex to synchronize veth_pool_store with itself, >> ibmveth_close and ibmveth_open, preventing multiple calls in a row to >> napi_disable. >