Hi,
Static analysis with cppcheck has found an issue in the following commit:
commit 047e6575aec71d75b765c22111820c4776cd1c43
Author: Aneesh Kumar K.V
Date: Tue Sep 24 09:22:53 2019 +0530
powerpc/mm: Fixup tlbie vs mtpidr/mtlpidr ordering issue on POWER9
The issue in tools/testing/self
From: Colin Ian King
There is a spelling mistake in the Kconfig text. Fix it.
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/ps3/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/ps3/Kconfig
b/arch/powerpc/platforms/ps3/Kconfig
index
From: Colin Ian King
A previous cleanup commit removed the ininitialization of st2_mem_alloc.
Fix this by restoring the original behaviour by initializing it to zero.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: e80382fe721f ("ASoC: fsl: fsl_easrc: remove useless assignments")
Si
From: Colin Ian King
There is a spelling mistake in a ibmvfc_dbg debug message. Fix it.
Signed-off-by: Colin Ian King
---
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 1db
From: Colin Ian King
There is a spelling mistake in the Kconfig help text. Fix it.
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/44x/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/44x/Kconfig
b/arch/powerpc/platforms/44x/Kconfig
i
From: Colin Ian King
There is a spelling mistake in the help text of the Kconfig. Fix it.
Signed-off-by: Colin Ian King
---
arch/powerpc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 8fb61a285c76..4010bae52351 1006
From: Colin Ian King
There are spelling mistakes in two debug messages. As recommended
by Wolfram Sang, these can be removed as there is plenty of debug
in the driver core.
Signed-off-by: Colin Ian King
---
V2: remove the debug rather than fixing the spelling
---
drivers/macintosh/windfarm_l
From: Colin Ian King
There is a spelling mistake in a literal string. Fix it.
Signed-off-by: Colin Ian King
---
drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c
b/drivers/usb/gadget/udc/fsl_udc_core
From: Colin Ian King
There are spelling mistakes in DBG messages. Fix them.
Signed-off-by: Colin Ian King
---
drivers/macintosh/windfarm_lm75_sensor.c | 2 +-
drivers/macintosh/windfarm_lm87_sensor.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/macintosh/windf
From: Colin Ian King
There is a spelling mistake in a pr_debug message. Fix it.
Signed-off-by: Colin Ian King
---
arch/powerpc/oprofile/cell/spu_task_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/oprofile/cell/spu_task_sync.c
b/arch/powerpc/oprofile/c
From: Colin Ian King
There is a spelling mistake in a deb_dbg message, fix it.
Signed-off-by: Colin Ian King
---
sound/soc/fsl/fsl_easrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c
index 233f26ff885c..97658e1f4989
From: Colin Ian King
There is a statement that not indented correctly, remove the
extraneous space.
Signed-off-by: Colin Ian King
---
drivers/soc/fsl/qe/ucc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/qe/ucc.c b/drivers/soc/fsl/qe/ucc.c
index d6c93970d
From: Colin Ian King
Pointer p is currently being dereferenced before it is null
checked on a memory allocation failure check. Fix this by
checking if p is null before dereferencing it.
Addresses-Coverity: ("Dereference before null check")
Fixes: 3b2abda7d28c ("soc: fsl: dpio: Replace QMAN array
From: Colin Ian King
Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements
however up to UCC_MAX_NUM (8) elements are potentially being written
to it. Currently we have an array out-of-bounds write error on the
last 4 elements. Fix this by making utdm_info UCC_MAX_NUM elements in
From: Colin Ian King
The variable bdp is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/tty/serial/ucc_uart.c |
From: Colin Ian King
There is a spelling mistake in a pr_err message. Fix it.
Signed-off-by: Colin Ian King
---
drivers/soc/fsl/dpaa2-console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c
index 9168d8ddc9
From: Colin Ian King
There is a spelling mistake in a pr_err message, fix it.
Signed-off-by: Colin Ian King
---
arch/powerpc/kvm/book3s_xive_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_xive_native.c
b/arch/powerpc/kvm/book3s_xive_native
From: Colin Ian King
There are several identical spelling mistakes in warning messages,
fix these.
Signed-off-by: Colin Ian King
---
arch/powerpc/mm/hash_utils_64.c | 4 ++--
arch/powerpc/mm/pgtable-hash64.c | 2 +-
arch/powerpc/mm/pgtable-radix.c | 6 +++---
arch/powerpc/mm/pgtable_64.c
From: Colin Ian King
There is a spelling mistake in a dev_err message. Fix this.
Signed-off-by: Colin Ian King
---
sound/soc/fsl/imx-audmix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx-audmix.c
index 72e37ca6cfbb..7983bd33
From: Colin Ian King
Currently variable fndit is not initialized and contains a
garbage value, later it is set to 1 if a drc entry is found.
Ensure fndit is not containing garbage by initializing it to
zero. Also remove an extraneous space at the end of an
sprintf call.
Detected by static analys
From: Colin Ian King
Passing the struct ptp_clock_info caps by parameter is passing over 130 bytes
of data by value on the stack. Optimize this by passing it by reference instead.
Also shinks the object code size:
Before:
textdata bss dec hex filename
125962160 64
From: Colin Ian King
Currently the error check for a null reg leaks a struct qbman
that was allocated earlier. Fix this by kfree'ing p on the error exit
path.
Signed-off-by: Colin Ian King
---
drivers/soc/fsl/dpio/qbman-portal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/f
From: Colin Ian King
Trivial fix to a spelling mistake of the error access name EACCESS,
rename to EACCES
Signed-off-by: Colin Ian King
---
Documentation/filesystems/spufs.txt | 2 +-
Documentation/gpu/drm-uapi.rst | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/D
From: Colin Ian King
Pointer 'priv' is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
variable 'priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King
---
drivers/soc/fsl/dpio/dpio-driver.c | 3 ---
1 file changed,
From: Colin Ian King
Trivial fix to spelling mistake in bootx_printf message text.
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/powermac/bootx_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powermac/bootx_init.c
b/arch/powerpc/pla
From: Colin Ian King
Trivial fix to spelling mistake in hmi_error_types text
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/powernv/opal-hmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-hmi.c
b/arch/powerpc/platforms/power
From: Colin Ian King
Trivial fix to spelling mistake in battery_charging array
Signed-off-by: Colin Ian King
---
arch/powerpc/kernel/rtas-proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/rtas-proc.c b/arch/powerpc/kernel/rtas-proc.c
index d49063d0b
From: Colin Ian King
Trivial fix to spelling mistake in debug messages of a structure
field name
Signed-off-by: Colin Ian King
---
drivers/macintosh/windfarm_pm121.c | 2 +-
drivers/macintosh/windfarm_pm81.c | 2 +-
drivers/macintosh/windfarm_pm91.c | 2 +-
3 files changed, 3 insertions(+),
From: Colin Ian King
Trivial fix to spelling mistake in CSB_ERR error message text
Signed-off-by: Colin Ian King
---
drivers/crypto/nx/nx-842-powernv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx-842-powernv.c
b/drivers/crypto/nx/nx-842-powernv.c
i
From: Colin Ian King
Trivial fix to spelling mistake in tx_fw_stat_gstrings text
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/freescale/ucc_geth_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
b/drivers/
From: Colin Ian King
Trivial fix to spelling mistake in bootx_printf message text
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/powermac/bootx_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powermac/bootx_init.c
b/arch/powerpc/plat
From: Colin Ian King
Currently the comparison of used < 0 is always false because
uses is a size_t. Fix this by making used a ssize_t type.
Detected by Coccinelle:
drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression
compared with zero: used < 0
Fixes: 5ef3166e8a32 ("ocxl: Driver cod
From: Colin Ian King
Use the ARRAY_SIZE macro on several arrays to determine their size.
Improvement suggested by coccinelle.
Signed-off-by: Colin Ian King
---
arch/powerpc/xmon/ppc-opc.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc/xmon/ppc-opc
From: Colin Ian King
Trival fix to spelling mistake in ERR message
Signed-off-by: Colin Ian King
---
drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c
b/drivers/usb/gadget/udc/fsl_udc_core.c
index d6
From: Colin Ian King
Trivial fix to spelling mistake in pr_err error message text. Also
fix spelling mistake in proceeding comment.
Signed-off-by: Colin Ian King
---
drivers/crypto/nx/nx-842-powernv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/nx/nx-
From: Colin Ian King
Trivial fix to spelling mistake in pr_err error message text
Signed-off-by: Colin Ian King
---
drivers/crypto/nx/nx-842-powernv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx-842-powernv.c
b/drivers/crypto/nx/nx-842-powernv.c
in
From: Colin Ian King
Don't populate the const arrays rate on the stack, instead make them
static. Makes the object code smaller by 220 bytes:
Before:
textdata bss dec hex filename
243859776 128 3428985f1 sound/soc/fsl/fsl_spdif.o
After:
textdata bss
From: Colin Ian King
Trivial fix to spelling mistake in pr_debug message
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c
b/arch/powerpc/platforms/pse
From: Colin Ian King
Trivial fix to spelling mistake in seq_printf text
Signed-off-by: Colin Ian King
---
drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c
b/drivers/usb/gadget/udc/fsl_udc_core.c
ind
From: Colin Ian King
Trivial fix to spelling mistake in printk message
Signed-off-by: Colin Ian King
---
drivers/tty/hvc/hvcs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
index 7823d6d998cf..2113c64d565d 100644
--- a/dr
From: Colin Ian King
Trivial fix to spelling mistake in pr_info message.
Signed-off-by: Colin Ian King
---
arch/powerpc/sysdev/xive/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/xive/common.c
b/arch/powerpc/sysdev/xive/common.c
index d9cd7f70
From: Colin Ian King
Trivial fix to spelling mistake "unmached" to "unmatched" in
debug message.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wirele
From: Colin Ian King
Trivial fix to spelling mistake "uncommited" to "uncommitted" in
critical error messages.
Signed-off-by: Colin Ian King
---
drivers/soc/fsl/qbman/bman.c | 2 +-
drivers/soc/fsl/qbman/qman.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/
From: Colin Ian King
trivial fix to spelling mistake in pr_debug message
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c
b/arch/powerpc/platforms/pse
From: Colin Ian King
Trival fix, dev_dbg message is missing a \n, so add it.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/t
From: Colin Ian King
The message is missing a \n, add it.
Signed-off-by: Colin Ian King
---
arch/powerpc/mm/init_32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
index 448685f..b532dd9 100644
--- a/arch/powerpc/mm/in
From: Colin Ian King
Trivial fix to spelling mistakes in dev_dbg messages
Signed-off-by: Colin Ian King
---
sound/soc/fsl/fsl_esai.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index 26a90e1..e927955 100644
--- a
From: Colin Ian King
Trivial fix to spelling mistake in dev_warn message.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/freescale/ucc_geth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
b/drivers/net/ethernet/freescale/
From: Colin Ian King
Trivial fix to spelling mistake in dev_warn message and remove
extraneous trailing whitespace at end of the message.
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/ps3/device-init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/
From: Colin Ian King
Trivial fix to spelling mistake in dev_err message.
Signed-off-by: Colin Ian King
---
drivers/net/wan/fsl_ucc_hdlc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 6f04445..5fbf83d 1
From: Colin Ian King
trivial fix to spelling mistake in dev_err message
Signed-off-by: Colin Ian King
---
sound/soc/fsl/fsl_spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 151849f..beec793 100644
--- a/soun
From: Colin Ian King
Fix trivial spelling mistake "rgistration". Also use pr_err
instead of printk and unsplit the string to keep it all on one
line.
Signed-off-by: Colin Ian King
---
arch/powerpc/kernel/fadump.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/po
From: Colin Ian King
trivial fix to spelling mistake "rgistration" and minor clean up
of the printk error message
Signed-off-by: Colin Ian King
---
arch/powerpc/kernel/fadump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kerne
From: Colin Ian King
trivial fix to spelling mistake in pr_debug message
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/powernv/opal-memory-errors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-memory-errors.c
b/arch/powerpc
From: Colin Ian King
pi_buff is being memset before it is sanity checked. Move the
memset after the null pi_buff sanity check to avoid an oops.
Signed-off-by: Colin Ian King
---
arch/powerpc/platforms/pseries/hvcserver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/
From: Colin Ian King
On the unlikely event that drv is null, the current code will
perform a null pointer dereference with it when printing a dev_dbg
message. Instead, the BUG_ON check on drv should be performed
before we emit the dev_dbg message.
Signed-off-by: Colin Ian King
---
drivers/ps3
From: Colin Ian King
Recent commit 80fa93fce37d3490f
("cxl: Name interrupts in /proc/interrupt") introduced a
redundant increment of hwirq which is not used or even
initialised at the point it is incremented. Detected by
cppcheck:
[drivers/misc/cxl/irq.c:439]: (error) Uninitialized
variable: h
From: Colin Ian King
hwirq has not been initialized, however it is being incremented
and also not being referenced in a loop. This error was detected with
cppcheck:
[drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: hwirq
Commit 80fa93fce37d ("cxl: Name interrupts in /proc/interrupt
58 matches
Mail list logo