Thank you for the comments.
I'll refine this part.
Sent by Android device.
Timur Tabi wrote:
Nicolin Chen wrote:
> + if (ssi_private->use_dual_fifo) {
> + write_ssi_mask(&ssi->srcr, 0, CCSR_SSI_SRCR_RFEN1);
> + write_ssi_mask(&ssi->stcr, 0, CCSR_SSI_STCR_TFEN1);
> +
As you wish, sir.
Sent by Android device.
Timur Tabi wrote:
Chen Guangyu-B42378 wrote:
> I mean there is a possibility.
>
> I'm sorry if my patch is kinda annoying and it really bother you, sir. I
> also want to make things better.
It does not bother me. I'm glad pe
Thank you, sir. And sorry for taking your time.
Sent by Android device.
Timur Tabi wrote:
Chen Guangyu-B42378 wrote:
> Without dual fifo support, handware underrun would occasionally
> occur and then two audio channels would physically swap. This could
> be easily reproduced i
I mean there is a possibility.
I'm sorry if my patch is kinda annoying and it really bother you, sir. I also
want to make things better.
If you really don't like it, we can drop it. It's all your call.
And thank you for reviewing.
Sent by Android device.
Timur Tabi wrote:
Nicolin Chen wro
Without dual fifo support, handware underrun would occasionally occur and then
two audio channels would physically swap. This could be easily reproduced in
low bus frequency situation, while it would be better if we enable dual fifo.
Sent by Android device.
Timur Tabi wrote:
Nicolin Chen wr
Oh, I didn't mean to push this. Sorry that I wasn't aware of it.
I'll be more patient next time.
Best regards,
Nicolin Chen
From: Mark Brown [broo...@kernel.org]
Sent: Tuesday, August 27, 2013 10:50 PM
To: Chen Guangyu-B42378
Cc: Stephen Wa
Hi Lars
Thank you for the sage advices.
I'll revise the patch and send the v2.
From: Lars-Peter Clausen [l...@metafoo.de]
Sent: Wednesday, July 31, 2013 8:16 PM
To: Chen Guangyu-B42378
Cc: broo...@kernel.org; ti...@tabi.org; alsa-de...@alsa-projec
On Wed, Jul 31, 2013, Mark Brown wrote:
> Applied, thanks. Please check the mailing lists you're posting to -
> you've got the DT list wrong here and you shouldn't post non-binding
> reviews there anyway.
Sorry that I forgot to update the DT list addr but using an old one.
I'll pay attention to i