Re: [PATCH v3 1/1] x86/elf: Add a new .note section containing xfeatures buffer layout info to x86 core files

On 7/13/2024 4:12 PM, Thomas Gleixner wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Fri, Jul 12 2024 at 15:16, Vignesh Balasubramanian wrote: diff --git a/arch/x86/include/asm/elf.h b/arch/x86/

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

Apologies for the delay. I am sending the new version patch with below changes. On 5/31/2024 4:28 PM, Borislav Petkov wrote: p type, size, offset and flag values for every xfeature that is present. + */ +static int dump_xsave_layout_desc(struct coredump_params *cprm) +{ + int num_records

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

On 5/26/2024 2:35 PM, Borislav Petkov wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Sun, May 26, 2024 at 10:24:41AM +0530, Balasubrmanian, Vignesh wrote: If we can add a new enum only when we

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

On 5/22/2024 9:04 PM, Borislav Petkov wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Wed, May 22, 2024 at 06:42:55PM +0530, Balasubrmanian, Vignesh wrote

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

On 5/8/2024 6:32 PM, Thomas Gleixner wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Tue, May 07 2024 at 15:23, Vignesh Balasubramanian wrote: +enum custom_feature { + FEATURE_XSAVE_FP = 0, +

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

On 5/23/2024 8:15 PM, Borislav Petkov wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Thu, May 23, 2024 at 11:57:00AM +0530, Balasubrmanian, Vignesh wrote: Currently, this enum is the same as

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

On 5/8/2024 6:32 PM, Thomas Gleixner wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Tue, May 07 2024 at 15:23, Vignesh Balasubramanian wrote: +struct xfeat_component { + u32 xfeat_type; +

Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

On 3/14/2024 10:09 PM, Dave Hansen wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On 3/14/24 09:29, Borislav Petkov wrote: That argument breaks down a bit on the flags though: xc.xfeat_flags

Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

IMHO you should split the changes to replace ARCH_HAVE_EXTRA_ELF_NOTES with CONFIG_ARCH_HAVE_EXTRA_ELF_NOTES into a lead-up patch. cheers Thanks for the input and i will take care in next version. regards, vigneshbalu.

Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

Otherwise looks reasonable, though I see Dave has feedback to address too. :) Thanks for working on this! -Kees Thank you for the review. I will address all this on next version. thanks, vigneshbalu. -- Kees Cook