Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-20 Thread Arnaud Mouiche
On 19/12/2017 01:25, Caleb Crome wrote: On Mon, Dec 18, 2017 at 3:02 PM, Nicolin Chen wrote: On Mon, Dec 18, 2017 at 02:19:08PM -0800, Caleb Crome wrote: Acked-by: Timur Tabi --- To Mark --- Mark, can you still take these changes first? Since this failed test that Caleb reported here is

Re: [PATCH] ASoC: fsl_ssi: Override bit clock rate based on slot number

2017-09-13 Thread Arnaud Mouiche
On 12/09/2017 23:32, Nicolin Chen wrote: On Tue, Sep 12, 2017 at 04:35:13PM +0200, Arnaud Mouiche wrote: - * freq: Output BCLK frequency = samplerate * 32 (fixed) * channels - * dir: SND_SOC_CLOCK_OUT -> TxBCLK, SND_SOC_CLOCK_IN -> RxBCLK. + * freq: Output BCLK frequency = samplerat

Re: [PATCH] ASoC: fsl_ssi: Override bit clock rate based on slot number

2017-09-12 Thread Arnaud Mouiche
Hello Nicolin On 08/09/2017 07:23, Nicolin Chen wrote: The set_sysclk() now is used to override the output bit clock rate. But this is not a common way to implement a set_dai_sysclk(). And this creates a problem when a general machine driver (simple-card for example) tries to do set_dai_sysclk()

Re: [PATCH] ASoC: fsl_ssi: Override bit clock rate based on slot number

2017-09-08 Thread Arnaud Mouiche
On 08/09/2017 07:42, Nicolin Chen wrote: On Thu, Sep 07, 2017 at 10:23:43PM -0700, Nicolin Chen wrote: The set_sysclk() now is used to override the output bit clock rate. But this is not a common way to implement a set_dai_sysclk(). And this creates a problem when a general machine driver (simp