Re: [PATCH 1/2] adb: create class devices for each adb device

2007-07-16 Thread Aristeu Rozanski
Hi Benjamin, > I don't think class device is the right approach. Classes are supposed > to be a functional binding, ie, in this case, input devices. ADB is a > bus, and as such, you should create an adb bus type and and adb_device > that is an extension of struct device, not struct class device. ok

[PATCH 2/2] adbhid: make sysrq key configurable on adb keyboards

2007-07-16 Thread Aristeu Rozanski
This patch adds an sysfs attribute to each handled ADB keyboard in order to support runtime sysrq key configuration. This is needed because some machines don't have the default sysrq key (0x69). The key will be configurable by /sys/class/adb/keyboard/sysrq_key. Signed-of-by: Aristeu Roz

[PATCH 1/2] adb: create class devices for each adb device

2007-07-16 Thread Aristeu Rozanski
: Aristeu Rozanski <[EMAIL PROTECTED]> --- linus-2.6.orig/drivers/macintosh/adb.c 2007-05-11 10:09:13.0 -0400 +++ linus-2.6/drivers/macintosh/adb.c 2007-05-11 10:09:36.0 -0400 @@ -102,11 +102,21 @@ static void adbdev_init(void); static int try_handler_change(in

[PATCH 0/2] adb: make sysrq key configurable at runtime

2007-07-16 Thread Aristeu Rozanski
These two patches make possible to configure the sysrq key on ADB based machines where the default sysrq key (0x69) is not present. The first patch creates a class device for each handled device. The second one adds an attribute to ADB keyboards that makes possible to configure the sysrq key for ea

[PATCH] adbhid: enable KEY_FN key reporting

2007-07-16 Thread Aristeu Rozanski
use button. Other applications may use the KEY_FN as a modifier aswell. I've been updating and using this patch for months without problems. Signed-off-by: Aristeu Rozanski <[EMAIL PROTECTED]> --- linus-2.6.orig/drivers/macintosh/adbhid.c 2007-05-11 10:09:13.0 -0400 +++ linus-

[RFC][PATCH] therm_adt746x: fix behaviour on !ADT7460

2007-07-16 Thread Aristeu Rozanski
Hi, this bug exists since I began using a powerbook 12". When the system gets hot, therm_adt746x begins to oscillate between two fan speeds every one or two seconds. The result is very annoying not optimal: while switching between two speeds, the machine takes a long time to get cold again.