On Fri, Feb 14, 2025 at 02:11:07PM +0800, xiaopei...@foxmail.com wrote:
> From: Pei Xiao
>
> sparse warning:
> sparse: symbol 'ugeth_mac_ops' was not declared. Should it be
> static.
>
> Add static to fix sparse warnings.
While you are touching it, can it also be made const?
struct phylink
On Fri, Jan 03, 2025 at 02:06:01PM +0800, Wei Fang wrote:
> ENETC's MAC filter consists of hash MAC filter and exact MAC filter. Hash
> MAC filter is a 64-entry hash table consisting of two 32-bit registers.
> Exact MAC filter is implemented by configuring MAC address filter table
> through command
> +#define NTMP_FILL_CRD(crd, tblv, qa, ua) \
> +({ \
> + typeof(crd) _crd = (crd); \
> + (_crd)->update_act = cpu_to_le16(ua); \
> + (_crd)->tblv_qact = NTMP_TBLV_QACT(tblv, qa); \
> +})
> +
> +#define NTMP_FILL_CRD_EID(req, tblv, qa, ua, eid) \
> +({ \
> + typeof(req) _req = (req)
On Wed, Dec 04, 2024 at 09:22:32AM +0100, Maxime Chevallier wrote:
> Hello Andrew,
>
> On Wed, 4 Dec 2024 03:15:52 +0100
> Andrew Lunn wrote:
>
> > > +static bool phy_interface_mode_is_reduced(phy_interface_t interface)
> > > +{
> > > + re
> needs to me moved around in the process. To make the phylink port
> clearer, this commit moves the function without any feature change.
>
> Signed-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
> +static bool phy_interface_mode_is_reduced(phy_interface_t interface)
> +{
> + return phy_interface_mode_is_rgmii(interface) ||
> +interface == PHY_INTERFACE_MODE_RMII ||
> +interface == PHY_INTERFACE_MODE_RTBI;
> +}
I wounder if this is useful anywhere else? Did you
r
Reviewed-by: Andrew Lunn
Andrew
ence.
>
> Signed-off-by: Maxime Chevallier
This at least looks sensible.
Reviewed-by: Andrew Lunn
I don't think we are going to get a perfect implementation until we
move most of the logic into phylink. We need the MAC to declare a
bitmap of what WoL options it supports. And we need
ACCFG2 register gets
> initialized, and remove the code to configure that value altogether.
>
> Signed-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
FG2
> register upon accessing it for other MAC configuration operations.
>
> Signed-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
On Thu, Nov 07, 2024 at 06:02:51PM +0100, Maxime Chevallier wrote:
> The get/set_wol ethtool ops rely on querying the PHY for its WoL
> capabilities, checking for the presence of a PHY and a PHY interrupts
> isn't enough. Address that by cleaning up the WoL configuration
> sequence.
>
> Signed-off
gt; dts files")
>
> 17 years later, there's no users of that property left and I hope it's
> safe to say we can remove support from that in the ucc_geth driver,
> making the probe() function a bit simpler.
17 years seems reasonable.
> Signed-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
On Thu, Nov 07, 2024 at 06:02:50PM +0100, Maxime Chevallier wrote:
> As this driver pre-dates phylib, it uses a private pointer to get a
> reference to the attached phy_device. Drop that pointer and use the
> netdev's pointer instead.
>
> Signed-off-by: Maxime Chevallier
On Thu, Nov 07, 2024 at 06:02:49PM +0100, Maxime Chevallier wrote:
> Preparing the phylink conversion, split the adjust_link callbaclk, by
> clearly separating the mac configuration, link_up and link_down phases.
>
> Signed-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
On Wed, Sep 04, 2024 at 10:27:11AM +0200, Maxime Chevallier wrote:
> Hi Andrew,
>
> On Fri, 30 Aug 2024 23:06:08 +0200
> Andrew Lunn wrote:
>
> > > --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> > > +++ b/drivers/net/ethernet/freescale/fs_ene
ned-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
On Thu, Aug 29, 2024 at 06:15:29PM +0200, Maxime Chevallier wrote:
> devm_clock_get_enabled() can be used to simplify clock handling for the
> PER register clock.
>
> Signed-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
y
> Signed-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
On Thu, Aug 29, 2024 at 06:15:27PM +0200, Maxime Chevallier wrote:
> There's no user of the struct phy_info, the 'phy' field and the
> mii_if_info in the fs_enet driver, probably dating back when phylib
> wasn't as widely used. Drop these from the driver code.
There might be an include of linux/m
t;
> Acked-by: Christophe Leroy
> Reviewed-by: Christophe Leroy
> Signed-off-by: Maxime Chevallier
Reviewed-by: Andrew Lunn
Andrew
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> @@ -649,12 +649,7 @@ static void fs_adjust_link(struct net_device *dev)
> unsigned long flags;
>
> spin_lock_irqsave(&fep->lock, flags);
> -
> - if (fep->o
tion level here suggest refactoring into helpers might be
nice. But not a prerequisite for merging.
Reviewed-by: Andrew Lunn
Andrew
On Mon, Aug 07, 2023 at 03:06:42PM +0200, Linus Walleij wrote:
> On Mon, Aug 7, 2023 at 3:05 PM Linus Walleij wrote:
>
> > > Signed-off-by: Herve Codina
> >
> > So it is a bridge chip? Please use that terminology since Linux
> > DRM often talks about bridges.
>
> Replying to self: no it's not a
> > > +static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr,
> > > u8 isr)
> > > +{
> > > + dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr);
> > > +}
> >
> > Should this be rate limited? It is going to be very noise if it gets
> > called once per frame time.
>
> The generic framer has:
> - 2 consumers (QMC HDLC drv and codec)
> - 1 provider (PEF2256)
>
> So, the design is the following:
> +--+ +-+
> | QMC | <- TDM -> | PEF2256 | <-> E1
> +-+
On Wed, Jul 26, 2023 at 05:02:22PM +0200, Herve Codina wrote:
> The framer codec interracts with a framer.
> It allows to use some of the framer timeslots as audio channels to
> transport audio data over the framer E1/T1/J1 lines.
> It also reports line carrier detection events through the ALSA jac
> +static inline u8 pef2256_read8(struct pef2256 *pef2256, int offset)
> +{
> + int val;
> +
> + regmap_read(pef2256->regmap, offset, &val);
> + return val;
> +}
> +
> +static inline void pef2256_write8(struct pef2256 *pef2256, int offset, u8
> val)
> +{
> + regmap_write(pef2256->r
> + clocks:
> +items:
> + - description: Master clock
> + - description: Receive System Clock
> + - description: Transmit System Clock
> +
> + clock-names:
> +items:
> + - const: mclk
> + - const: sclkr
> + - const: sclkx
Nit pick, but "Receive System Clock"
> +int framer_pm_runtime_get(struct framer *framer)
> +{
> + int ret;
> +
> + if (!framer)
> + return 0;
Can framer be a NULL pointer? This sort of test often covers up
bugs. So either let it dereference the NULL pointer and opps, or
return -EINVAL.
Andrew
> +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set)
> +{
> + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set);
> +}
> +
Please don't use inline in .c files. Let the compiler decide.
Andrew
On Wed, Jul 26, 2023 at 05:02:04PM +0200, Herve Codina wrote:
> Available timeslots masks define timeslots available for the related
> channel. These timeslots are defined by the QMC binding.
>
> Timeslots used are initialized to available timeslots but can be a
> subset of available timeslots.
>
> +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device *netdev)
> +{
> + return (struct qmc_hdlc *)dev_to_hdlc(netdev)->priv;
priv is a void *, so you don't need the cast.
Andrew
On Mon, Jul 10, 2023 at 02:39:33PM +0800, Su Hui wrote:
> From: wuych
>
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: wuych
> ---
> drivers/net/wan/fsl_ucc_hdlc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wan/f
> Hi, Hao Lan,
>
> Sorry for that, I just compiled these patches in the mainline branch.
> I know now, it's also necessary to compile patches in net and net-next
> branch.
> Thanks for your reply!
net-next is also closed at the moment due to the merge window. Please
wait two weeks before repostin
On Wed, Jun 28, 2023 at 04:37:43PM +0200, Andrew Lunn wrote:
> > Hi, Hao Lan,
> >
> > Sorry for that, I just compiled these patches in the mainline branch.
> > I know now, it's also necessary to compile patches in net and net-next
> > branch.
> > Tha
ur plan is that each architecture maintainer merges one patch?
That is fine, but it is good to be explicit, otherwise patches will
fall through the cracks because nobody picks them up. I generally use
To: to indicate who i expect to merge a patch, and everybody else in
the Cc:
Reviewed-by: Andrew Lunn
Andrew
On Thu, Nov 10, 2022 at 03:29:26PM +, Vladimir Oltean wrote:
> On Thu, Nov 10, 2022 at 09:55:32AM -0500, Sean Anderson wrote:
> > On 11/9/22 17:41, Vladimir Oltean wrote:
> > > On Thu, Nov 03, 2022 at 05:06:39PM -0400, Sean Anderson wrote:
> > >> Several (later) patches in this series cannot be
On Fri, Sep 09, 2022 at 02:29:59PM +0800, Gaosheng Cui wrote:
> fs_mii_disconnect and fs_mii_connect have been removed since
> commit 5b4b8454344a ("[PATCH] FS_ENET: use PAL for mii management"),
> so remove them.
>
> Signed-off-by: Gaosheng Cui
Reviewed-by: Andrew Lunn
Andrew
On Mon, Jan 17, 2022 at 08:24:22AM +0100, Tobias Waldekranz wrote:
> On Sun, Jan 16, 2022 at 23:02, Andrew Lunn wrote:
> > On Sun, Jan 16, 2022 at 10:15:26PM +0100, Tobias Waldekranz wrote:
> >> Once an MDIO read transaction is initiated, we must read back the data
> >
dded?
Reviewed-by: Andrew Lunn
Andrew
On Sun, Jan 16, 2022 at 10:15:29PM +0100, Tobias Waldekranz wrote:
> As reported by sparse: In the remove path, the driver would attempt to
> unmap its own priv pointer - instead of the io memory that it mapped
> in probe.
Hi Tobias
The change itself is O.K.
Reviewed-by: Andrew Lunn
On Sun, Jan 16, 2022 at 10:15:27PM +0100, Tobias Waldekranz wrote:
> Update FMan binding documentation with the newly added workaround for
> erratum A-009885.
>
> Signed-off-by: Tobias Waldekranz
Reviewed-by: Andrew Lunn
Andrew
On Mon, May 24, 2021 at 09:07:01AM +0800, YueHaibing wrote:
> Issue identified with Coccinelle.
>
> Signed-off-by: YueHaibing
Reviewed-by: Andrew Lunn
Andrew
On Sun, May 23, 2021 at 03:29:37PM +0200, Christophe Leroy wrote:
> YueHaibing a écrit :
>
> > Issue identified with Coccinelle.
> >
> > Signed-off-by: YueHaibing
> > ---
> > drivers/net/ethernet/freescale/ucc_geth.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff -
associated with that device.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
; - else {}
>
> @@
> identifier a.x;
> expression e;
> @@
> - if (<+... x ...+>@e)
> - {}
> - else
> + if (!(e))
> {...}
>
> @@
> expression x, y, z;
> @@
> - x = of_get_mac_address(y, z);
> + of_get_mac_address(y, z);
> ... when != x
>
>
> All drivers, except drivers/net/ethernet/aeroflex/greth.c, were
> compile-time tested.
>
> Suggested-by: Andrew Lunn
> Signed-off-by: Michael Walle
I cannot say i looked at all the changes, but the ones i did exam
seemed O.K.
Reviewed-by: Andrew Lunn
Andrew
On Tue, Apr 06, 2021 at 03:19:11AM +0800, kernel test robot wrote:
> Hi Michael,
>
> I love your patch! Yet something to improve:
Looks correct. You missed the #else case for #ifdef CONFIG_OF in
stmmac_platform.c
Lets see what else 0-day finds before i start reviewing.
Andrew
eescale/fs_enet/mii-fec.o
> ERROR: modpost: missing MODULE_LICENSE() in
> drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o
>
> Add the missing MODULE_LICENSEs to fix the build. Both files include a
> copyright header indicating they are GPL v2.
>
> Signed-off-by: Michael Ellerman
Reviewed-by: Andrew Lunn
Andrew
> Hi Andrew
>
> I found here:
> https://patchwork.kernel.org/project/netdevbpf/patch/20201218105538.30563-2-rasmus.villem...@prevas.dk/
>
> Seem to be underway but stable isn't included, I think it should be.
Stable should happen, since this was posted with [net,v2,3/3]. David
or Jakub handles
On Tue, Jan 05, 2021 at 02:17:42PM +, Joakim Tjernlund wrote:
> On Thu, 2020-12-10 at 02:25 +0100, Andrew Lunn wrote:
> > On Sat, Dec 05, 2020 at 08:17:24PM +0100, Rasmus Villemoes wrote:
> > > All the buffers and registers are already set up appropriately for an
> > &
On Tue, Jan 05, 2021 at 01:22:29PM +1100, Michael Ellerman wrote:
> Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE()
> into error") the ppc32_allmodconfig build fails with:
>
> ERROR: modpost: missing MODULE_LICENSE() in
> drivers/net/ethernet/freescale/fs_enet/mii-fec.o
> E
On Sat, Dec 05, 2020 at 08:17:30PM +0100, Rasmus Villemoes wrote:
> This removes the explicit NULL checks, and allows us to stop storing
> at least some of the _offset values separately.
>
> Signed-off-by: Rasmus Villemoes
This seems to rely on one of the missing patches. Please don't split
patc
to
> the CPU port supports an MTU of 1500+the tagging overhead.
>
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Cc: Vladimir Oltean
> Signed-off-by: Rasmus Villemoes
Reviewed-by: Andrew Lunn
Andrew
On Thu, Nov 26, 2020 at 01:38:53PM +, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> from drivers/net/ethernet/ibm/ibmvnic.c:35:
> inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3:
> drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Functio
er"
> Cc: Jakub Kicinski
> Cc: Michael Ellerman
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: Utz Bacher
> Cc: Jens Osterkamp
> Cc: net...@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Lee Jones
Reviewed-by: Andrew Lunn
Andrew
Hi Lee
> /**
> * build_hdr_data - creates L2/L3/L4 header data buffer
> - * @hdr_field - bitfield determining needed headers
> - * @skb - socket buffer
> - * @hdr_len - array of header lengths
> - * @tot_len - total length of data
> + * @hdr_field: bitfield determining needed headers
> + * @skb
On Thu, Nov 05, 2020 at 12:33:55PM +, Lee Jones wrote:
> As per the vendor's request.
>
> Lee Jones (2):
> tty: Remove redundant synclink driver
> tty: Remove redundant synclinkmp driver
Hi Lee
What exactly do you mean by redundant? That some other driver can be
used? Or that nobody uses
er"
> Cc: Jakub Kicinski
> Cc: Michael Ellerman
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: Utz Bacher
> Cc: Jens Osterkamp
> Cc: net...@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Lee Jones
Reviewed-by: Andrew Lunn
Andrew
ter or
> member 'adapter' not described in 'do_reset'
> drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or
> member 'rwi' not described in 'do_reset'
> drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or
> member 'reset_state' not described in 'do_reset'
>
> Cc: Dany Madden
> Cc: Lijun Pan
> Cc: Sukadev Bhattiprolu
> Cc: Michael Ellerman
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: Santiago Leon
> Cc: Thomas Falcon
> Cc: John Allen
> Cc: net...@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Lee Jones
Reviewed-by: Andrew Lunn
Andrew
On Thu, Oct 01, 2020 at 04:20:12PM +0300, Vladimir Oltean wrote:
> Add the description of the embedded L2 switch inside the SoC dtsi file
> for NXP T1040.
>
> Signed-off-by: Vladimir Oltean
> Reviewed-by: Maxim Kochetkov
Reviewed-by: Andrew Lunn
Andrew
el of the board and not with the hardware
> numbers of the switch chip ports. The 2 numbering schemes are
> shifted by 8.
>
> Signed-off-by: Vladimir Oltean
> Reviewed-by: Maxim Kochetkov
Reviewed-by: Andrew Lunn
Andrew
On Tue, Sep 29, 2020 at 07:39:54PM +, Vladimir Oltean wrote:
> On Tue, Sep 29, 2020 at 09:11:53PM +0200, Andrew Lunn wrote:
> > > +&seville_port0 {
> > > + managed = "in-band-status";
> > > + phy-handle = <&phy_qsgmii_0>;
> >
> +&seville_port0 {
> + managed = "in-band-status";
> + phy-handle = <&phy_qsgmii_0>;
> + phy-mode = "qsgmii";
> + /* ETH4 written on chassis */
> + label = "swp4";
If ETH4 is on the chassis why not use ETH4?
Andrew
On Tue, May 26, 2020 at 01:03:10PM +0200, Emanuele Giuseppe Esposito wrote:
> There is currently no common way for Linux kernel subsystems to expose
> statistics to userspace shared throughout the Linux kernel; subsystems have
> to take care of gathering and displaying statistics by themselves, for
> I don't really know a lot about the networking subsystem, and as it was
> pointed out in another email on patch 7 by Andrew, networking needs to
> atomically gather and display statistics in order to make them consistent,
> and currently this is not supported by stats_fs but could be added in
> f
On Tue, May 26, 2020 at 01:03:17PM +0200, Emanuele Giuseppe Esposito wrote:
> Apply stats_fs on the networking statistics subsystem.
>
> Currently it only works with disabled network namespace
> (CONFIG_NET_NS=n), because multiple namespaces will have the same
> device name under the same root sou
On Wed, Apr 29, 2020 at 03:55:28PM +0200, Christian Zigotzky wrote:
> Hi Andrew,
>
> You can find some dtb and source files in our kernel package.
>
> Download: http://www.xenosoft.de/linux-image-5.7-rc3-X1000_X5000.tar.gz
I have the tarball. Are we talking about
linux-image-5.7-rc3-X1000_X5000/
> Maybe we have to modify the dtb file.
Hi Christian
Could you point me at the DT file.
Thanks
Andrew
On Fri, Apr 24, 2020 at 11:29:38PM +0100, Darren Stevens wrote:
> Since cbb961ca271e ("Use random MAC address when none is given")
> Varisys Cyrus P5020 boards have been listing 5 ethernet ports instead of
> the 2 the board has.This is because we were preventing the adding of the
> unused ports by
On Thu, Jun 27, 2019 at 12:09:13PM -0500, Thomas Falcon wrote:
> This patch resolves an issue with sensitive bonding modes
> that require valid speed and duplex settings to function
> properly. Currently, the adapter will report that device
> speed and duplex is unknown if the communication link
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet.txt
> b/Documentation/devicetree/bindings/net/ethernet.txt
> index 2974e63..1e2bc9a 100644
> --- a/Documentation/devicetree/bindings/net/ethernet.txt
> +++ b/Documentation/devicetree/bindings/net/ethernet.txt
> @@ -10,6 +10,8 @@ Documen
> diff --git a/Documentation/devicetree/bindings/net/macb.txt
> b/Documentation/devicetree/bindings/net/macb.txt
> index 8b80515..92c5642 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -26,15 +26,15 @@ Required properties:
On Tue, Oct 23, 2018 at 04:49:59PM +, Joakim Tjernlund wrote:
> SPI (and others) has a way to define bus number in a aliases:
> aliases {
> ethernet4 = &enet4;
> ethernet0 = &enet0;
> ethernet1 = &enet1;
> ethernet2 = &enet2;
>
On Wed, Feb 07, 2018 at 10:00:45PM +0100, mad skateman wrote:
> Hi,
>
> I just found out that something goes wrong within the ARP table (well thats
> what i think). I hope someone has a clue..
This looks like 'normal' behaviour. It has been reported that the
device runs out of buffers. That means
On Mon, Feb 05, 2018 at 10:38:34AM +0100, Christian Zigotzky wrote:
> Hello Andrew,
>
> Many thanks for your patch. I compiled the latest git kernel today and the
> PA Semi PWRficient Gigabit Ethernet works with your patch.
Great.
Can i add a tested-by:
Thanks
Andrew
iod_flags dflags,
const char *label)
{
return ERR_PTR(-ENOSYS);
}
So rather than just deleting all this code, breaking other platforms
that need this gpio, lets try a real fix. Please try this. If it
works, i will formally submit it.
Andrew
&g
> > commit 4d8ee1935bcd666360311dfdadeee235d682d69a
> > Author: Florian Fainelli
> > Date: Tue Aug 22 15:24:47 2017 -0700
> > fsl/man: Inherit parent device and of_node
> >
> > and was later addressed by this patch set:
> >
> > http://patchwork.ozlabs.org/project/netdev/list/?series=8462&state=*
> That doesn't work really, having users to hit the bug, debug it, fix it and
> then
> find it fixed already in upstream, then specifically request it to be
> backported to stable.
> I don't need this fix to be backported, already got it. Someone else might
> though.
The "someone else might th
> *Given this if we disable that bit, we get the matching "Universally
> Administered Address" 0100 (Binary), 04 (Hex) -> "04:00:00", hence my
> question:"*
>
> This has something to do with the MAC adresses being locally administered
> .. and since whe can use Uboot and choose any Mac addr we
> > You appear to be using an old kernel. Take a look at:
>
> Not really, I am using 4.14.x and I don't think that is old.
Development for 4.14 stopped somewhere around the beginning of
September. So there has been over 4 months of work since then. We are
clearly interested in fixing bugs in tha
he of_mdiobus_register_phy()
call will return -ENODEV. When a missing device is encountered the
registration of the remaining PHYs is stopped and the MDIO bus will
fail to register. Propagate all errors except ENODEV to avoid it.
Signed-off-by: Madalin Bucur
Reviewed-by: Andre
> When i use mii-tool too Kick the tranceiver... it comes alive.. i can
> ping the eth0 itself
>
> root@X5000LNX:/home/skateman# mii-tool -R eth0
> resetting the transceiver...
> root@X5000LNX:/home/skateman# ping 192.168.22.44
> PING 192.168.22.44 (192.168.22.44) 56(84) bytes of data.
> 64 bytes
> > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
> > b/drivers/net/ethernet/ibm/ibmvnic.c
> > index d0cff28..120f3c0 100644
> > --- a/drivers/net/ethernet/ibm/ibmvnic.c
> > +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> > @@ -107,6 +107,9 @@ static union sub_crq *ibmvnic_next_scrq(struct
> > ibmvn
> The reason I mentioned maybe I should put the backplane property in
> fsl's binding is because the backplane implementation is really
> vendor specific, it's heavily relay how hardware implements the
> feature, maybe another vendor's hardware only needs a boolean
> property for driver to tell it
On Tue, Jan 19, 2016 at 05:00:35AM +, Shaohui Xie wrote:
> > -Original Message-
> > From: Andrew Lunn [mailto:and...@lunn.ch]
> > Sent: Monday, January 18, 2016 11:15 PM
> > To: Shaohui Xie
> > Cc: Sebastian Hesselbarth; Florian Fainelli;
> [S.H] the fsl backplane, e.g. 10GBASE-KR, needs software to handle link
> training,
> It's to train link partner, and trained by link partner parallel.
>
> But if media type is not copper, e.g. optical module, we won't need this.
So what we actually need to know is copper vs fibre?
Andrew
On Thu, Jan 14, 2016 at 04:23:59PM +0800, shh@gmail.com wrote:
> From: Shaohui Xie
>
> This commit adds necessary definitions for the PHY layer to recognize
> backplane Ethernet 1000BASE-KX and 10GBASE-KR as valid PHY interfaces,
> "1000base-kx" for 1000BASE-KX, "10gbase-kr" for 10GBASE-KR.
>
> > Originally the interrupt is used for detecting the link has gone
> > down. That would of also been bogus before. Have you tried this? If
>
> Haven't tried it, but chances are you are right.
>
> > that is also broken, maybe you need to add a fixes: tag so that it
> > gets back ported?
>
> No
On Tue, Dec 08, 2015 at 05:44:02PM -0500, Paul Gortmaker wrote:
> This file was originally cloned off of the MPC8641D-HPCN reference
> platform, which actually had a PHY IRQ line connected. However
> this board does not. The bogus entry was largely inert and went
> undetected until commit 321beec
> Thanks for testing. Please could you confirm whether the same behaviour
> is observed without the patches, just to make absolutely sure that isn't
> a regression.
So i tested this now.
I have two FEC interfaces. One i my main access interface, and the
second is used by DSA to access switches.
On Thu, Sep 24, 2015 at 03:15:54PM -0700, David Miller wrote:
> From: Andrew Lunn
> Date: Thu, 24 Sep 2015 23:57:31 +0200
>
> > I built the FEC driver as a module, and it won't unload:
> >
> > kernel:unregister_netdevice: waiting for eth1 to b
;ve not tried a fully module
build, DSA has issues with that.
Tested-by: Andrew Lunn
Thanks
Andrew
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Mon, Oct 06, 2014 at 10:28:09PM -0700, Guenter Roeck wrote:
> Replace reference to pm_power_off (which is an implementation detail)
> and replace it with a more generic description of the driver's functionality.
Acked-by: Andrew Lunn
Thanks
Andrew
>
> Cc: Rob Her
On Mon, Oct 06, 2014 at 10:28:08PM -0700, Guenter Roeck wrote:
> pm_power_off is an implementation detail. Replace it with a more generic
> description of the driver's functionality.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Signed-off-by: Guenter Roe
say last resort, this is how it is designed to work. There
is no way to turn the power off from with linux, it is designed that
u-boot will put the hardware into minimal power consumption until the
"power" button is pressed.
Other than that,
Acked-by: Andrew Lunn
Thanks
Andrew
already been registered when the driver is loaded.
>
> Cc: Sebastian Reichel
> Cc: Dmitry Eremin-Solenikov
> Cc: David Woodhouse
> Signed-off-by: Guenter Roeck
Acked-by: Andrew Lunn
Thanks
Andrew
> ---
> drivers/power/reset/qnap-poweroff.c | 28 ++---
; power off the system. There may be other poweroff handlers.
I would prefer to keep the warning traceback. We found on some
hardware the GPIO transitions were too fast and it failed to power
off. Seeing the traceback gives an idea where to go look for the
problem.
Other than that,
Acked-by: And
> > Why are you not keen on this? It seems like normal device driver
> > practice, that is what the data field of of_device_id is typically
> > used for..
>
> I'm not keen on it because we don't have a document saying "All kirkwood
> SoCs need PSC1 set to X after reset." We know it, but have we t
On Tue, May 21, 2013 at 06:41:38PM +0200, Sebastian Hesselbarth wrote:
> This patch set picks up work by Florian Fainelli bringing full DT
> support to mv643xx_eth and Marvell SoCs using it.
Hi Sebastian
I tested on my QNAP and topkick. Works great.
Tested-by: Andrew Lunn
per-board
> basis.
>
> Signed-off-by: Sebastian Hesselbarth
> ---
> Changelog:
> v3->v4:
> - convert to new device tree binding
>
> Cc: David Miller
> Cc: Lennert Buytenhek
> Cc: Jason Cooper
> Cc: Andrew Lunn
> Cc: Benjamin Herrenschmid
100 matches
Mail list logo
