Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

Hi Wolfram, On Tue, May 20, 2025 at 11:15:21AM +0200, Wolfram Sang wrote: > > > I took this patch in i2c/i2c-host. Please let me know if you want > > me to take also the others. > > To avoid the dependency with your PR, is it okay if you drop it and I > take this patch via my tree? yes, sure! I

Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

Hi Wolfram, On Mon, May 19, 2025 at 01:13:12PM +0200, Wolfram Sang wrote: > 'of_node' in i2c_boardinfo is deprecated in favor of 'fwnode'. The I2C > core handles them equally, so simply convert this driver to fwnode. > > Signed-off-by: Wolfram Sang I took this patch in i2c/i2c-host. Please let

Re: [PATCH v3 0/4] Apple/PASemi i2c error recovery fixes

Hi Sven, > Hector Martin (3): > i2c: pasemi: Enable the unjam machine > i2c: pasemi: Improve error recovery > i2c: pasemi: Log bus reset causes > > Sven Peter (1): > i2c: pasemi: Improve timeout handling merged to i2c/i2c-host. Thanks, Andi

Re: [PATCH v2 4/6] i2c: pasemi: Improve error recovery

Hi Sven, Hector, ... > +/* > + * The hardware (supposedly) has a 25ms timeout for clock stretching, thus > + * use 100ms here which should be plenty. > + */ > +#define TRANSFER_TIMEOUT_MS 100 Please use the PASEMI prefix here. TRANSFER_TIMEOUT_MS it's not a naming belonging to this driver. 100

Re: [PATCH v2 0/6] Apple/PASemi i2c error recovery fixes

Hi Sven, > Hector Martin (3): > i2c: pasemi: Improve error recovery > i2c: pasemi: Enable the unjam machine > i2c: pasemi: Log bus reset causes > > Sven Peter (3): > i2c: pasemi: Use correct bits.h include > i2c: pasemi: Sort includes alphabetically I applied in i2c

Re: [PATCH v2 6/6] i2c: pasemi: Log bus reset causes

Hi Sven, ... > static int pasemi_smb_clear(struct pasemi_smbus *smbus) > { > - unsigned int status; > + unsigned int status, xfstatus; Let's declare the variables in the innermost scope where they are used. Andi > int ret; > > /* First wait for the bus to go idle */ > @

Re: [PATCH v2 3/6] i2c: pasemi: Improve timeout handling

Hi Sven, > static int pasemi_smb_waitready(struct pasemi_smbus *smbus) > { > int timeout = 100; > + int ret; can you please declare this "ret" inside the if() statement below? > unsigned int status; > > if (smbus->use_irq) { > reinit_completion(&smbus->irq

Re: [PATCH 2/4] i2c: pasemi: Improve error recovery

Hi Sven, On Sat, Feb 22, 2025 at 01:38:34PM +, Sven Peter via B4 Relay wrote: > The hardware (supposedly) has a 25ms timeout for clock stretching > and the driver uses 100ms which should be plenty. Can we add this lines as a comment to the define you are adding? > The error > reocvery itself

Re: [PATCH 1/4] i2c: pasemi: Add registers bits and switch to BIT()

Hi Sven, On Sat, Feb 22, 2025 at 01:38:33PM +, Sven Peter via B4 Relay wrote: > From: Sven Peter > > Add the missing register bits to the defines and also switch > those to use the BIT macro which is much more readable than > using hardcoded masks > > Co-developed-by: Hector Martin > Signe

Re: [PATCH] of/irq: handle irq_of_parse_and_map() errors

On Tue, Sep 03, 2024 at 06:56:41PM GMT, Christophe Leroy wrote: > Le 30/08/2024 à 16:21, Ma Ke a écrit : > > Zero and negative number is not a valid IRQ for in-kernel code and the > > irq_of_parse_and_map() function returns zero on error. So this check for > > valid IRQs should only accept values

Re: [PATCH v2 00/60] i2c: reword first drivers according to newest specification

Hi Wolfram, pushed in i2c/i2c-host. Thanks for this big work, at the end it turned out quite nice and I'm happy of the outcome! Thanks Andi On Sat, Jul 06, 2024 at 01:20:00PM GMT, Wolfram Sang wrote: > Start changing the wording of the I2C main header wrt. the newest I2C > v7 and SMBus 3.2 spec

Re: [PATCH v2 39/60] i2c: powermac: reword according to newest specification

t i2c_msg *msgs, > + int num) and we get a nice free cleanup here :-) Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH v2 37/60] i2c: pasemi: reword according to newest specification

Hi Wolfram, On Sat, Jul 06, 2024 at 01:20:37PM GMT, Wolfram Sang wrote: > Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 > specifications and replace "master/slave" with more appropriate terms. > > Signed-off-by: Wolfram Sang Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH v2 35/60] i2c: opal: reword according to newest specification

Hi Wolfram, On Sat, Jul 06, 2024 at 01:20:35PM GMT, Wolfram Sang wrote: > Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 > specifications and replace "master/slave" with more appropriate terms. > > Signed-off-by: Wolfram Sang Reviewed-by: Andi Shyti Thanks, Andi

Re: [Patch v4 10/10] i2x: pnx: Use threaded irq to fix warning from del_timer_sync()

Hi Piotr, On Fri, Jun 21, 2024 at 02:08:03PM GMT, Piotr Wojtaszczyk wrote: > On Fri, Jun 21, 2024 at 12:57 AM Andi Shyti wrote: > > On Thu, Jun 20, 2024 at 07:56:41PM GMT, Piotr Wojtaszczyk wrote: > > > When del_timer_sync() is called in an interrupt context it throw

Re: [Patch v4 10/10] i2x: pnx: Use threaded irq to fix warning from del_timer_sync()

Hi Piotr, On Thu, Jun 20, 2024 at 07:56:41PM GMT, Piotr Wojtaszczyk wrote: > When del_timer_sync() is called in an interrupt context it throws a warning > because of potential deadlock. Threaded irq handler fixes the potential > problem. > > Signed-off-by: Piotr Wojtaszczyk did you run into a l

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

Hi Andy, On Sun, Jun 02, 2024 at 06:57:12PM +0300, Andy Shevchenko wrote: > Make two APIs look similar. Hence convert match_string() to be > a 2-argument macro. In order to avoid unneeded churn, convert > all users as well. There is no functional change intended. > > Signed-off-by: Andy Shevchenk

Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup

On Tue, Apr 16, 2024 at 04:07:48PM +0200, Andi Shyti wrote: > On Tue, Apr 16, 2024 at 03:59:13AM +, Chris Packham wrote: > > On 16/04/24 08:54, Andi Shyti wrote: > > >> /* Enable I2C interrupts for mpc5121 */ > > >> -node_ctrl = o

Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup

Hi Chris, On Tue, Apr 16, 2024 at 03:59:13AM +, Chris Packham wrote: > On 16/04/24 08:54, Andi Shyti wrote: > >>/* Enable I2C interrupts for mpc5121 */ > >> - node_ctrl = of_find_compatible_node(NULL, NULL, > >> -

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

> > > out_8(&cpm->i2c_reg->i2mod, 0x00); > > > - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > > > + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Host mode */ > > > > I2COM_MASTER might be coming from the datasheet. > > Maybe we can just drop the comment? The value w

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

; + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Host mode */ I2COM_MASTER might be coming from the datasheet. Reviewed-by: Andi Shyti Thanks,

Re: [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification

Hi Wolfram, > > @Andi: are you okay with this approach? It means you'd need to merge > > -rc2 into your for-next branch. Or rebase if all fails. > > I think it's a good plan, I'll try to support you with it. Do you feel more comfortable if I take the patches as soon as they are reviewd? So far

Re: [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification

Hi Wolfram, On Fri, Mar 22, 2024 at 02:24:53PM +0100, Wolfram Sang wrote: > Okay, we need to begin somewhere... > > Start changing the wording of the I2C main header wrt. the newest I2C > v7, SMBus 3.2, I3C specifications and replace "master/slave" with more > appropriate terms. This first step r

Re: [PATCH] i2c: pasemi: split driver into two separate modules

Hi On Mon, 12 Feb 2024 12:19:04 +0100, Arnd Bergmann wrote: > On powerpc, it is possible to compile test both the new apple (arm) and > old pasemi (powerpc) drivers for the i2c hardware at the same time, > which leads to a warning about linking the same object file twice: > > scripts/Makefile.bui

Re: [PATCH v2] i2c: cpm: Remove linux,i2c-index conversion from be32

@@ -658,7 +658,7 @@ static int cpm_i2c_probe(struct platform_device *ofdev) > /* register new adapter to i2c module... */ > > data = of_get_property(ofdev->dev.of_node, "linux,i2c-index", &len); > - cpm->adap.nr = (data && len == 4) ? be32_to_cpup(data) : -1; > + cpm->adap.nr = (data && len == 4) ? *data : -1; thanks! Reviewed-by: Andi Shyti Andi

Re: [PATCH] i2c: cpm: Fix data type

Hi Christophe, On Tue, Dec 05, 2023 at 07:16:53PM +0100, Christophe Leroy wrote: > sparse reports an error on some data that gets converted from be32. > > That's because that data is typed u32 instead of __be32. > > Fix it. the reason for this sparse error is that the data variables is then par

Re: [PATCH v2 03/10] i2c: pasemi: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON

clare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. > It's one step towards getting rid of I2C_CLASS_SPD mid-term. > > Series was created supported by Coccinelle and its splitpatch. > > Signed-off-by: Heiner Kallweit Acked-by: Andi Shyti Thanks, Andi

Re: [PATCH] I2C: Explicitly include correct DT includes

ers need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring I went through all of the changes and they look fine to me. Reviewed-by: Andi Shyti Thanks, Andi