Re: [PATCH v2 1/6] i2c: pasemi: Use correct bits.h include

2025-04-15 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Le Tue , Apr 15, 2025 at 03:36:55PM +, Sven Peter via B4 Relay a écrit : > From: Sven Peter > > When changing the #defines to use BIT and GENMASK the bitfield.h include > was added instead of the correct bits.h include. > > Reported-b

Re: [PATCH v2 2/6] i2c: pasemi: Sort includes alphabetically

2025-04-15 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Le Tue , Apr 15, 2025 at 03:36:56PM +, Sven Peter via B4 Relay a écrit : > From: Sven Peter > > No functional changes. > > Signed-off-by: Sven Peter > --- > drivers/i2c/busses/i2c-pasemi-core.c | 10 +- > drivers/i2c/busse

Re: [PATCH v2 4/6] i2c: pasemi: Improve error recovery

2025-04-15 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Le Tue , Apr 15, 2025 at 03:36:58PM +, Sven Peter via B4 Relay a écrit : > From: Hector Martin > > The hardware (supposedly) has a 25ms timeout for clock stretching > and the driver uses 100ms which should be plenty. The error > reocvery it

Re: [PATCH v2 3/6] i2c: pasemi: Improve timeout handling

2025-04-15 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Le Tue , Apr 15, 2025 at 03:36:57PM +, Sven Peter via B4 Relay a écrit : > From: Sven Peter > > Add proper timeout handling for the interrupt path. > Previously, this was only correctly done for the polling path. > Note that we drop reg_write(s

Re: [PATCH 0/4] Apple/PASemi i2c error recovery fixes

2025-02-24 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Le Sat , Feb 22, 2025 at 01:38:32PM +, Sven Peter via B4 Relay a écrit : > Hi, > > This series adds a few fixes/improvements to the error recovery for > Apple/PASemi i2c controllers. > The patches have been in our downstream tree and were origi