Re: [PATCH v2 1/7] powerpc: properly negate error in syscall_set_return_value()

2025-01-24 Thread Alexey Gladkov
On Fri, Jan 24, 2025 at 01:43:22AM +0200, Dmitry V. Levin wrote: > On Thu, Jan 23, 2025 at 08:28:15PM +0200, Dmitry V. Levin wrote: > > On Mon, Jan 20, 2025 at 02:51:38PM +0100, Christophe Leroy wrote: > > > Le 14/01/2025 à 18:04, Dmitry V. Levin a écrit : > > > > On Mon, Jan 13, 2025 at 06:34:44PM

Re: [PATCH v2 1/7] powerpc: properly negate error in syscall_set_return_value()

2025-01-14 Thread Alexey Gladkov
On Tue, Jan 14, 2025 at 03:48:44PM +0200, Dmitry V. Levin wrote: > On Tue, Jan 14, 2025 at 02:00:16PM +0100, Alexey Gladkov wrote: > > On Mon, Jan 13, 2025 at 07:10:54PM +0200, Dmitry V. Levin wrote: > > > Bring syscall_set_return_value() in sync with syscall_get_error(), >

Re: [PATCH v2 1/7] powerpc: properly negate error in syscall_set_return_value()

2025-01-14 Thread Alexey Gladkov
On Mon, Jan 13, 2025 at 07:10:54PM +0200, Dmitry V. Levin wrote: > Bring syscall_set_return_value() in sync with syscall_get_error(), > and let upcoming ptrace/set_syscall_info selftest pass on powerpc. > > This reverts commit 1b1a3702a65c ("powerpc: Don't negate error in > syscall_set_return_valu

Re: [PATCH v4 2/5] fs: Add fchmodat2()

2023-07-26 Thread Alexey Gladkov
On Wed, Jul 26, 2023 at 02:36:25AM +1000, Aleksa Sarai wrote: > On 2023-07-11, Alexey Gladkov wrote: > > On the userspace side fchmodat(3) is implemented as a wrapper > > function which implements the POSIX-specified interface. This > > interface differs from the underlyi

Re: [PATCH v3 0/5] Add a new fchmodat4() syscall

2023-07-25 Thread Alexey Gladkov
On Tue, Jul 11, 2023 at 05:14:24PM +0200, Christian Brauner wrote: > On Tue, Jul 11, 2023 at 02:24:51PM +0200, Florian Weimer wrote: > > * Alexey Gladkov: > > > > > This patch set adds fchmodat4(), a new syscall. The actual > > > implementation is super simple:

Re: [PATCH v3 2/5] fs: Add fchmodat4()

2023-07-11 Thread Alexey Gladkov
On Tue, Jul 11, 2023 at 04:01:03PM +0200, Christian Brauner wrote: > On Tue, Jul 11, 2023 at 02:51:01PM +0200, Alexey Gladkov wrote: > > On Tue, Jul 11, 2023 at 01:52:01PM +0200, Christian Brauner wrote: > > > On Tue, Jul 11, 2023 at 01:42:19PM +0200, Arnd Bergmann wrote: >

Re: [PATCH v3 5/5] selftests: add fchmodat4(2) selftest

2023-07-11 Thread Alexey Gladkov
On Tue, Jul 11, 2023 at 02:10:58PM +0200, Florian Weimer wrote: > * Alexey Gladkov: > > > The test marks as skipped if a syscall with the AT_SYMLINK_NOFOLLOW flag > > fails. This is because not all filesystems support changing the mode > > bits of symlinks properly. The

Re: [PATCH v3 2/5] fs: Add fchmodat4()

2023-07-11 Thread Alexey Gladkov
On Tue, Jul 11, 2023 at 01:52:01PM +0200, Christian Brauner wrote: > On Tue, Jul 11, 2023 at 01:42:19PM +0200, Arnd Bergmann wrote: > > On Tue, Jul 11, 2023, at 13:25, Alexey Gladkov wrote: > > > From: Palmer Dabbelt > > > > > > On the userspace side fch

Re: [PATCH v3 2/5] fs: Add fchmodat4()

2023-07-11 Thread Alexey Gladkov
On Tue, Jul 11, 2023 at 01:28:04PM +0100, Matthew Wilcox wrote: > On Tue, Jul 11, 2023 at 01:25:43PM +0200, Alexey Gladkov wrote: > > -static int do_fchmodat(int dfd, const char __user *filename, umode_t mode) > > +static int do_fchmodat4(int dfd, const char __user *filename, um

Re: [PATCH v4 4/5] tools headers UAPI: Sync files changed by new fchmodat2 syscall

2023-07-11 Thread Alexey Gladkov
On Tue, Jul 11, 2023 at 10:19:35AM -0700, Namhyung Kim wrote: > Hello, > > On Tue, Jul 11, 2023 at 9:18 AM Alexey Gladkov wrote: > > > > From: Palmer Dabbelt > > > > That add support for this new syscall in tools such as 'perf trace'. > > >

[PATCH v4 4/5] tools headers UAPI: Sync files changed by new fchmodat2 syscall

2023-07-11 Thread Alexey Gladkov
From: Palmer Dabbelt That add support for this new syscall in tools such as 'perf trace'. Signed-off-by: Palmer Dabbelt Signed-off-by: Alexey Gladkov --- tools/include/uapi/asm-generic/unistd.h | 5 - tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl | 2 ++ tools

[PATCH v4 5/5] selftests: Add fchmodat2 selftest

2023-07-11 Thread Alexey Gladkov
/ksft-fchmodat2.3NCqlE/symlink -> regfile Size: 7 Blocks: 0 IO Block: 4096 symbolic link Device: 7,0 Inode: 133 Links: 1 Access: (0600/lrw---) Uid: (0/root) Gid: (0/root) Signed-off-by: Alexey Gladkov --- tools/testing/self

[PATCH v4 3/5] arch: Register fchmodat2, usually as syscall 452

2023-07-11 Thread Alexey Gladkov
From: Palmer Dabbelt This registers the new fchmodat2 syscall in most places as nuber 452, with alpha being the exception where it's 562. I found all these sites by grepping for fspick, which I assume has found me everything. Signed-off-by: Palmer Dabbelt Signed-off-by: Alexey Gl

[PATCH v4 2/5] fs: Add fchmodat2()

2023-07-11 Thread Alexey Gladkov
t.c;h=17eca54051ee28ba1ec3f9aed170a62630959143;hb=a492b1e5ef7ab50c6fdd4e4e9879ea5569ab0a6c#l35 [2] https://git.musl-libc.org/cgit/musl/tree/src/stat/fchmodat.c?id=718f363bc2067b6487900eddc9180c84e7739f80#n28 Co-developed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt Signed-off-by: Alexey Gladkov

[PATCH v4 1/5] Non-functional cleanup of a "__user * filename"

2023-07-11 Thread Alexey Gladkov
From: Palmer Dabbelt The next patch defines a very similar interface, which I copied from this definition. Since I'm touching it anyway I don't see any reason not to just go fix this one up. Signed-off-by: Palmer Dabbelt Acked-by: Arnd Bergmann --- include/linux/syscalls.h | 2 +- 1 file cha

[PATCH v4 0/5] Add a new fchmodat2() syscall

2023-07-11 Thread Alexey Gladkov
are now supported, which support squashed into a single patch. * The do_fchmodat() helper function has been removed, in favor of directly calling do_fchmodat4(). * The patches are based on 5.2 instead of 5.1. --- Alexey Gladkov (2): fs: Add fchmodat2() selftests: Add fchmodat2 selftest

[PATCH v3 5/5] selftests: add fchmodat4(2) selftest

2023-07-11 Thread Alexey Gladkov
le: /tmp/ksft-fchmodat4.3NCqlE/symlink -> regfile Size: 7 Blocks: 0 IO Block: 4096 symbolic link Device: 7,0 Inode: 133 Links: 1 Access: (0600/lrw---) Uid: (0/root) Gid: (0/root) Signed-off-by: Alexey Gladkov --- tools/testing/self

[PATCH v3 4/5] tools headers UAPI: Sync files changed by new fchmodat4 syscall

2023-07-11 Thread Alexey Gladkov
From: Palmer Dabbelt That add support for this new syscall in tools such as 'perf trace'. Signed-off-by: Palmer Dabbelt Signed-off-by: Alexey Gladkov --- tools/include/uapi/asm-generic/unistd.h | 5 - tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl | 1 + tools

[PATCH v3 1/5] Non-functional cleanup of a "__user * filename"

2023-07-11 Thread Alexey Gladkov
From: Palmer Dabbelt The next patch defines a very similar interface, which I copied from this definition. Since I'm touching it anyway I don't see any reason not to just go fix this one up. Signed-off-by: Palmer Dabbelt --- include/linux/syscalls.h | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v3 2/5] fs: Add fchmodat4()

2023-07-11 Thread Alexey Gladkov
/sysv/linux/fchmodat.c;h=17eca54051ee28ba1ec3f9aed170a62630959143;hb=a492b1e5ef7ab50c6fdd4e4e9879ea5569ab0a6c#l35 [2] https://git.musl-libc.org/cgit/musl/tree/src/stat/fchmodat.c?id=718f363bc2067b6487900eddc9180c84e7739f80#n28 Signed-off-by: Palmer Dabbelt Signed-off-by: Alexey Gladkov --- fs/o

[PATCH v3 3/5] arch: Register fchmodat4, usually as syscall 451

2023-07-11 Thread Alexey Gladkov
From: Palmer Dabbelt This registers the new fchmodat4 syscall in most places as nuber 451, with alpha being the exception where it's 561. I found all these sites by grepping for fspick, which I assume has found me everything. Signed-off-by: Palmer Dabbelt Signed-off-by: Alexey Gl

[PATCH v3 0/5] Add a new fchmodat4() syscall

2023-07-11 Thread Alexey Gladkov
o. * Selftest added. Changes since v1 [20190531191204.4044-1-pal...@sifive.com]: * All architectures are now supported, which support squashed into a single patch. * The do_fchmodat() helper function has been removed, in favor of directly calling do_fchmodat4(). * The patches are based on 5.2