On 27.10.2015 05:22, Vinod Koul wrote:
> On Thu, Oct 22, 2015 at 01:15:03AM +0300, Alexander Popov wrote:
>> On 12.10.2015 00:08, Alexander Popov wrote:
>>> This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC
>>> in the Reference Manual) allows Dir
On 12.10.2015 00:08, Alexander Popov wrote:
> This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC
> in the Reference Manual) allows Direct Memory Access transfers
> between RAM and peripheral devices on LocalPlus Bus.
> Changes in v4:
> - the race condition is fix
Add a device tree binding for Freescale MPC512x LocalPlus Bus FIFO and
introduce the document describing that binding.
Signed-off-by: Alexander Popov
---
.../bindings/powerpc/fsl/mpc512x_lpbfifo.txt| 21 +
arch/powerpc/boot/dts/mpc5121.dtsi | 11
This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC
in the Reference Manual) allows Direct Memory Access transfers
between RAM and peripheral devices on LocalPlus Bus.
Signed-off-by: Alexander Popov
---
arch/powerpc/configs/mpc512x_defconfig| 1 +
arch/powerpc/include
"a13xp0p0...@gmail.com" is changed to a more pleasant
alias "alex.po...@linux.com".
Changes in v4:
- the race condition is fixed;
- plenty of style fixes are made;
- devm_* functions and EPROBE_DEFER are used in probe().
Alexander Popov (2):
powerpc/512x: add LocalPlus Bus FIF
On 07.10.2015 17:17, Vinod Koul wrote:
> On Thu, Sep 24, 2015 at 08:28:57PM +0300, Alexander Popov wrote:
>> Initialize Freescale MPC512x DMA driver with subsys_initcall()
>> to allow the depending drivers to call dma_request_slave_channel()
>> during their probe.
>
&g
On 01.10.2015 20:11, Timur Tabi wrote:
> On 09/30/2015 04:24 PM, Alexander Popov wrote:
>>> Driver code that has to parse #address-cells or #size-cells
>>> is usually wrong.
>>
>> I would not call it "parsing", I just check whether the dts-file is good.
Hello Timur, thanks again for your review.
On 25.09.2015 04:01, Timur Tabi wrote:
> Alexander Popov wrote:
>> +
>> +for (i = 0; i < lpbfifo.cs_n; i++) {
>> +phys_addr_t cs_start;
>> +phys_addr_t cs_end;
>> +
>> +cs_start = lpb
On 28.09.2015 16:26, Timur Tabi wrote:
> Alexander Popov wrote:
>> I've just followed devicetree/bindings/dma/dma.txt...
>> This "rx-tx" doesn't mean much but it could show that LocalPlus Bus FIFO
>> uses a single DMA read-write channel. Should I really dr
On 28.09.2015 16:18, Timur Tabi wrote:
> Alexander Popov wrote:
>> The only question I have: why calling dma_unmap_single() from within
>> a spinlock is a bad practice?
>
> I don't know, but usually functions that allocate or free memory cannot be
> called from wi
On 25.09.2015 03:18, Timur Tabi wrote:
> Alexander Popov wrote:
>> +- dma-names: should be "rx-tx";
>
> Why bother, if it can only be one value?
I've just followed devicetree/bindings/dma/dma.txt...
This "rx-tx" doesn't mean much but it could show t
On 25.09.2015 03:16, Timur Tabi wrote:
> Alexander Popov wrote:
>> Initialize Freescale MPC512x DMA driver with subsys_initcall()
>> to allow the depending drivers to call dma_request_slave_channel()
>> during their probe.
>>
>> Signed-off-by: Alexander Popov
Hello, Timur, thanks a lot for your review.
I'll fix all the issues you pointed at and return with v4.
The only question I have: why calling dma_unmap_single() from within
a spinlock is a bad practice?
Best regards,
Alexander
___
Linuxppc-dev mailing li
Initialize Freescale MPC512x DMA driver with subsys_initcall()
to allow the depending drivers to call dma_request_slave_channel()
during their probe.
Signed-off-by: Alexander Popov
---
drivers/dma/mpc512x_dma.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a
Add a device tree binding for Freescale MPC512x LocalPlus Bus FIFO and
introduce the document describing that binding.
Signed-off-by: Alexander Popov
---
.../bindings/powerpc/fsl/mpc512x_lpbfifo.txt| 21 +
arch/powerpc/boot/dts/mpc5121.dtsi | 11
This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC
in the Reference Manual) allows Direct Memory Access transfers
between RAM and peripheral devices on LocalPlus Bus.
Signed-off-by: Alexander Popov
---
arch/powerpc/configs/mpc512x_defconfig| 1 +
arch/powerpc/include
"a13xp0p0...@gmail.com" is changed to a more pleasant
alias "alex.po...@linux.com";
Alexander Popov (3):
powerpc/512x: add LocalPlus Bus FIFO device driver
powerpc/512x: add a device tree binding for LocalPlus Bus FIFO
dmaengine: mpc512x: initialize with subsys_initcal
_skb_align_workaround() and use
skb_linearize() in it.
Signed-off-by: Alexander Popov
---
.../net/ethernet/freescale/fs_enet/fs_enet-main.c | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
b
10.06.2015 03:14, David Miller пишет:
From: Alexander Popov
Date: Wed, 10 Jun 2015 02:57:42 +0300
skb_copy_from_linear_data() which doesn't work well for non-linear sk_buff:
The correct fix is to use an SKB copy routine which can
handle non-linear data.
Thanks, David.
I'll p
cale MPC5121 might be better than handling
improper alignment for sk_buff.data and all the fragments.
Signed-off-by: Alexander Popov
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-
Hello Matteo,
sorry for such a long delay in replying, now I have my board back again.
19.12.2014 12:38, Matteo Facchinetti пишет:
On 16/12/2014 13:00, Alexander Popov wrote:
In fact clk_ignore_unused bootparam helps to avoid disabling NFC clock.
The board crash is reproduced again if I
02.12.2014 13:47, Matteo Facchinetti пишет:
On 26/11/2014 12:49, Alexander Popov wrote:
Hello.
Hi.
Thanks for your reply, Matteo.
I've looked deeper and have more information about the crash.
My Freescale TWR-MPC5125 board instantly reboots if I touch
any physical address on the Loca
Hello.
My Freescale TWR-MPC5125 board instantly reboots if I touch
any physical address on the LocalPlus Bus (LPB) for the first time
when Linux has already booted.
This effect is reproduced by using /dev/mem or loading a kernel module
which works with any peripherals on LPB.
It took me some ti
Hello!
2014-06-25 14:52 GMT+04:00 Alexander Popov :
> This patch series introduces a device tree binding document for
> the MPC512x DMA controller and adds device tree based DMA channel lookup
> for it.
>
> This version contains the improved device tree binding document:
> #d
Register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Alexander Popov
---
arch/powerpc/boot/dts/mpc5121.dtsi | 1 +
d
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
Introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Alexander Popov
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 29 ++
1 file changed, 29 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dma/mpc512x-dma.txt
.
Alexander Popov (3):
dmaengine: mpc512x: add device tree binding document
dmaengine: of: add common xlate function for matching by channel id
dmaengine: mpc512x: register for device tree channel lookup
.../devicetree/bindings/dma/mpc512x-dma.txt| 29 ++
arch/powerpc
2014-06-18 18:56 GMT+04:00 Alexander Popov :
> 2014-06-18 17:37 GMT+04:00 Mark Rutland :
>> On Wed, Jun 18, 2014 at 11:48:10AM +0100, Alexander Popov wrote:
>>> Introduce a device tree binding document for the MPC512x DMA controller
>>> +Optional properties:
>>&
Hello Mark, thanks for your reply!
2014-06-18 17:37 GMT+04:00 Mark Rutland :
> On Wed, Jun 18, 2014 at 11:48:10AM +0100, Alexander Popov wrote:
>> Introduce a device tree binding document for the MPC512x DMA controller
>>
>> Signed-off-by: Alexander Popov
>> ---
>
Register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Alexander Popov
---
arch/powerpc/boot/dts/mpc5121.dtsi | 1 +
d
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
Introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Alexander Popov
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 31 ++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dma/mpc512x-dma.txt
This patch series introduces a device tree binding document for
the MPC512x DMA controller and adds device tree based DMA channel lookup
for it.
This version has improved device tree binding document.
Alexander Popov (3):
dmaengine: mpc512x: add device tree binding document
dmaengine: of
2014-05-24 13:33 GMT+04:00 Alexander Popov :
> This patch series introduces a device tree binding document for
> the MPC512x DMA controller and adds device tree based DMA channel lookup
> for it.
Hello, excuse me, could I have a feedback?
Should I fix anything?
Thanks a lot!
Register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Alexander Popov
---
arch/powerpc/boot/dts/mpc5121.dtsi | 1 +
d
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
Introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Alexander Popov
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 40 ++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dma/mpc512x-dma.txt
This patch series introduces a device tree binding document for
the MPC512x DMA controller and adds device tree based DMA channel lookup
for it.
Alexander Popov (3):
dmaengine: mpc512x: add device tree binding document
dmaengine: of: add common xlate function for matching by channel id
Thank you, Vinod
2014-05-22 9:10 GMT+04:00 Vinod Koul :
> On Thu, May 15, 2014 at 06:15:30PM +0400, Alexander Popov wrote:
>> Changes in v13:
>> A new patch (part 1/5) is added to this series.
>> Part 2/5:
>> - fix style issue;
>> - improve comments;
>
Register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Alexander Popov
---
arch/powerpc/boot/dts/mpc5121.dtsi | 1 +
d
Introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Alexander Popov
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 40 ++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dma/mpc512x-dma.txt
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
Introduce support for slave s/g transfer preparation and the associated
device control callback in the MPC512x DMA controller driver, which adds
support for data transfers between memory and peripheral I/O to the
previously supported mem-to-mem transfers.
Signed-off-by: Alexander Popov
Fix comment typo.
Signed-off-by: Alexander Popov
---
include/linux/dmaengine.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 8300fb8..cbb168e 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
's yet to get confirmed whether MPC8308 can use slave support or
>whether the DMA controller's driver shall actively reject it, the
>information that's available so far suggests that peripheral transfers
>to IP bus attached I/O is useful and shall not get blocke
Hello, Vinod.
Thanks for your feedback.
2014-05-02 21:03 GMT+04:00 Vinod Koul :
> On Wed, Apr 23, 2014 at 05:53:25PM +0400, Alexander Popov wrote:
>> +static struct dma_async_tx_descriptor *
>> +mpc_dma_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
>> +
Hello
2014-04-23 17:53 GMT+04:00 Alexander Popov :
> Changes in v12:
> A new patch (part 2/7) is added to this series.
> Part 6/7:
> - change the description of 'compatible' property according part 2/7;
> - improve the document according Gerhard's feedback;
C
ntroller's driver shall actively reject it, the
>information that's available so far suggests that peripheral transfers
>to IP bus attached I/O is useful and shall not get blocked right away
- adding support for transfers which don't increment the RAM address or
Register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Alexander Popov
---
arch/powerpc/boot/dts/mpc5121.dtsi | 1 +
d
Introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Alexander Popov
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 40 ++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dma/mpc512x-dma.txt
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly.
Signed-off-by: Alexander Popov
---
drivers/dma/mpc512x_dma.c | 55 ---
1 file changed, 38 insertions(+), 17 deletions(-)
diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c
index
Introduce support for slave s/g transfer preparation and the associated
device control callback in the MPC512x DMA controller driver, which adds
support for data transfers between memory and peripheral I/O to the
previously supported mem-to-mem transfers.
Signed-off-by: Alexander Popov
MPC512x and MPC8308 have similar DMA controllers, but are independent SoCs.
DMA controller driver should have separate 'compatible' values for these SoCs.
Signed-off-by: Alexander Popov
---
arch/powerpc/boot/dts/mpc8308_p1m.dts | 2 +-
arch/powerpc/boot/dts/mpc8308rdb.dts | 2 +-
d
Concentrate the specific code for MPC8308 in the 'if' branch
and handle MPC512x in the 'else' branch.
This modification only reorders instructions but doesn't change behaviour.
Signed-off-by: Alexander Popov
Acked-by: Anatolij Gustschin
---
drive
Thanks for your reply, Gerhard
2014-04-17 0:44 GMT+04:00 Gerhard Sittig :
> On Tue, 2014-04-15 at 14:54 +0400, Alexander Popov wrote:
>>
>> Introduce a device tree binding document for the MPC512x DMA controller
>>
>> Signed-off-by: Gerhard Sittig
>> Signed-off
Register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Gerhard Sittig
Signed-off-by: Alexander Popov
---
arch/powerp
Introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Gerhard Sittig
Signed-off-by: Alexander Popov
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 51 ++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/devicetree
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly.
Signed-off-by: Alexander Popov
---
drivers/dma/mpc512x_dma.c | 55 ---
1 file changed, 38 insertions(+), 17 deletions(-)
diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c
index
Concentrate the specific code for MPC8308 in the 'if' branch
and handle MPC512x in the 'else' branch.
This modification only reorders instructions but doesn't change behaviour.
Signed-off-by: Alexander Popov
Acked-by: Anatolij Gustschin
Acked-by: Gerhard Sittig
---
Introduce support for slave s/g transfer preparation and the associated
device control callback in the MPC512x DMA controller driver, which adds
support for data transfers between memory and peripheral I/O to the
previously supported mem-to-mem transfers.
Signed-off-by: Alexander Popov
adding support for transfers which don't increment the RAM address or
do increment the peripheral "port's" address is easy with
this implementation; but which options of the common API
should be used for specifying such transfers?
Alexander Popov (6):
dma: mpc512x:
Hello,
2014-03-20 18:47 GMT+04:00 Alexander Popov :
> Changes in v10:
> Part 2/6:
> - don't use direction field of dma_slave_config in mpc_dma_device_control()
> but store settings in mpc_dma_chan for both DMA_DEV_TO_MEM and
> DMA_MEM_TO_DEV cases; then retrieve
Hello
20.03.2014 18:48 "Alexander Popov" wrote:
> Changes in v10:
> Part 2/6:
> - don't use direction field of dma_slave_config in
mpc_dma_device_control()
> but store settings in mpc_dma_chan for both DMA_DEV_TO_MEM and
> DMA_MEM_TO_DEV cases; then
Register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Gerhard Sittig
Signed-off-by: Alexander Popov
---
arch/powerp
From: Gerhard Sittig
introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Gerhard Sittig
[ a13xp0p0...@gmail.com: turn this into a separate patch ]
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 55 ++
1 file changed, 55 insertion
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly.
Signed-off-by: Alexander Popov
---
drivers/dma/mpc512x_dma.c | 55 ---
1 file changed, 38 insertions(+), 17 deletions(-)
diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c
index
Introduce support for slave s/g transfer preparation and the associated
device control callback in the MPC512x DMA controller driver, which adds
support for data transfers between memory and peripheral I/O to the
previously supported mem-to-mem transfers.
Signed-off-by: Alexander Popov
Concentrate the specific code for MPC8308 in the 'if' branch
and handle MPC512x in the 'else' branch.
This modification only reorders instructions but doesn't change behaviour.
Signed-off-by: Alexander Popov
Acked-by: Anatolij Gustschin
Acked-by: Gerhard Sittig
---
gt;binding, which should be stated.
> - The Linux implementation currently has no OF based channel
>lookup support, so '#dma-cells' is "a future feature". I guess
>the binding can and should already discuss the feature,
>regardless of whether all implemen
Hello Andy
2014-03-14 13:47 GMT+04:00 Andy Shevchenko :
> On Wed, 2014-03-12 at 15:47 +0400, Alexander Popov wrote:
>> + case DMA_SLAVE_CONFIG:
>> + /* Constraints:
>> + * - only transfers between a peripheral device and
>> +
Register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Gerhard Sittig
Signed-off-by: Alexander Popov
---
arch/powerp
From: Gerhard Sittig
introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Gerhard Sittig
[ a13xp0p0...@gmail.com: turn this into a separate patch ]
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 55 ++
1 file changed, 55 insertion
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
Replace devm_request_irq() with request_irq() since there is no need
to use it because the original code always frees IRQ manually with
devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly.
Signed-off-by: Alexander Popov
---
drivers/dma/mpc512x_dma.c | 11 +--
1 file
Introduce support for slave s/g transfer preparation and the associated
device control callback in the MPC512x DMA controller driver, which adds
support for data transfers between memory and peripheral I/O to the
previously supported mem-to-mem transfers.
Signed-off-by: Alexander Popov
Concentrate the specific code for MPC8308 in the 'if' branch
and handle MPC512x in the 'else' branch.
This modification only reorders instructions but doesn't change behaviour.
Signed-off-by: Alexander Popov
Acked-by: Anatolij Gustschin
Acked-by: Gerhard Sittig
---
PC8308 hardware is similar and can re-use the MPC512x
>binding, which should be stated.
> - The Linux implementation currently has no OF based channel
>lookup support, so '#dma-cells' is "a future feature". I guess
>the binding can and should already discus
Hello Andy.
2014-02-24 17:08 GMT+04:00 Andy Shevchenko :
> On Mon, 2014-02-24 at 15:09 +0400, Alexander Popov wrote:
>> @@ -1018,11 +1019,23 @@ static int mpc_dma_probe(struct platform_device *op)
>> /* Register DMA engine */
>> dev_set_drvdata(dev, m
Hello Andy.
2014-02-24 17:03 GMT+04:00 Andy Shevchenko :
> On Mon, 2014-02-24 at 15:09 +0400, Alexander Popov wrote:
>> Introduce support for slave s/g transfer preparation and the associated
>> device control callback in the MPC512x DMA controller driver, which adds
>> suppo
From: Gerhard Sittig
register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Gerhard Sittig
[ a13xp0p0...@gmail.com: resolve little p
From: Gerhard Sittig
introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Gerhard Sittig
[ a13xp0p0...@gmail.com: turn this into a separate patch ]
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 55 ++
1 file changed, 55 insertion
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
Introduce support for slave s/g transfer preparation and the associated
device control callback in the MPC512x DMA controller driver, which adds
support for data transfers between memory and peripheral I/O to the
previously supported mem-to-mem transfers.
Signed-off-by: Alexander Popov
of the common API
should be used for specifying such transfers?
2014/02/13 Gerhard Sittig :
> - The MPC512x DMA completely lacks a binding document, so one
>should get added.
> - The MPC8308 hardware is similar and can re-use the MPC512x
>binding, which should be stated.
>
Concentrate the specific code for MPC8308 in the 'if' branch
and handle MPC512x in the 'else' branch.
This modification only reorders instructions but doesn't change behaviour.
Signed-off-by: Alexander Popov
Acked-by: Anatolij Gustschin
Acked-by: Gerhard Sittig
---
[ adding dmaengine ML to Cc: ]
Thanks for your feedback, Gerhard
2014-02-13 4:07 GMT+04:00 Gerhard Sittig :
> On Wed, Feb 12, 2014 at 17:25 +0400, Alexander Popov wrote:
>> /*
>> - * This is initial version of MPC5121 DMA driver. Only memory to memory
>> - * transfers
Hello, Gerhard
2014-02-13 4:32 GMT+04:00 Gerhard Sittig :
> For some reason you have kept the DMA maintainers, but dropped
> the dmaengine ML from Cc: -- was this intentional, given that the
> series is specifically about DMA and you want to get feedback?
No, it was not done by intention, I'll fix
From: Gerhard Sittig
Q&D HACK to enable SD card support without correct COMMON_CLK support,
best viewed with 'git diff -w -b', NOT acceptable for mainline (NAKed)
Signed-off-by: Gerhard Sittig
[ a13xp0p0...@gmail.com: resolve little patch conflict ]
---
drivers/mmc/host/mxcmmc.c | 42 +
From: Gerhard Sittig
register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees) and
provide the '#dma-cells' property in the shared mpc5121.dtsi file
Signed-off-by: Gerhard Sittig
[ a13xp0p0...@gmail.com: resolve little p
From: Gerhard Sittig
introduce a device tree binding document for the MPC512x DMA controller
Signed-off-by: Gerhard Sittig
[ a13xp0p0...@gmail.com: turn this into a separate patch ]
---
.../devicetree/bindings/dma/mpc512x-dma.txt| 55 ++
1 file changed, 55 insertion
ff-by: Alexander Popov
---
drivers/dma/of-dma.c | 35 +++
include/linux/of_dma.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index e8fe9dc..d5fbeaa 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -
Introduce support for slave s/g transfer preparation and the associated
device control callback in the MPC512x DMA controller driver, which adds
support for data transfers between memory and peripheral I/O to the
previously supported mem-to-mem transfers.
Signed-off-by: Alexander Popov
g support for transfers which don't increment the RAM address or
do increment the peripheral "port's" address is easy with
this implementation; but which options of the common API
should be used for specifying such transfers?
- device tree binding document for the MPC51
Concentrate the specific code for MPC8308 in the 'if' branch
and handle MPC512x in the 'else' branch.
This modification only reorders instructions but doesn't change behaviour.
Signed-off-by: Alexander Popov
Acked-by: Anatolij Gustschin
Acked-by: Gerhard Sittig
---
tween mem and some slave peripheral
(only one DMA channel is fully dedicated to DDR).
All DMA channels of MPC512x DMA controller belong to one dma_device.
So we _don't_ need setting DMA_PRIVATE flag for this dma_device at all, do we?
>> On Sat, Jan 04, 2014 at 00:54 +0400, Alexander Popo
Hello Gerhard.
Thanks for your review.
2013/12/26 Gerhard Sittig :
> [ dropping devicetree, we're DMA specific here ]
>
> On Tue, Dec 24, 2013 at 16:06 +0400, Alexander Popov wrote:
>>
>> --- a/drivers/dma/mpc512x_dma.c
>> +++ b/drivers/dma/mpc512x_dma.c
>>
1 - 100 of 142 matches
Mail list logo
