Hi,
Please use this Tested-by instead of the previous one i sent:
Tested-by: Aditya Gupta
Thanks,
- Aditya G
On 02/01/25 11:07, Aditya Gupta wrote:
Looks good to me. Did boot test and reading the /sys files works.
Linux-ci tests [0] are also good (the failing tests are broken from
some
-test-branch-23431++
Tested-by: Aditya Gupta
Thanks,
- Aditya G
On 24/12/28 09:43AM, Thomas Weißschuh wrote:
> Most users use this function through the BIN_ATTR_SIMPLE* macros,
> they can handle the switch transparently.
> Also adapt the two non-macro users in the same change.
>
>
> > Reverting this patch allows kdump to save vmcore file correctly.
> >
> > Does this change require any corresponding changes to makedumpfile?
>
> Right. The change intends the tools to use VMALLOC_START exported via
> vmcoreinfo instead of vmap_area_list. I don't see the corresponding
> makedumpfile change submitted upstream yet though.
>
> Aditya, can you help with this..
Sure hari, I will into it. Thanks for the explanation, that will help.
Thanks,
Aditya Gupta
>
> - Hari
in brackets {} solved the error for me.
Rest of the code looks good to me. I will also try to test the patch
series later.
Thanks,
Aditya Gupta
+
+ fadump_conf->cpu_state_dest_vaddr = (u64)__va(addr);
+ /*
+* Start addres
On Fri, Oct 27, 2023 at 08:59:56PM +1100, Michael Ellerman wrote:
> On Mon, 23 Oct 2023 12:56:12 +0530, Aditya Gupta wrote:
> > Since below commit, address mapping for vmemmap has changed for Radix
> > MMU, where address mapping is stored in kernel page table itself,
> > in
On Fri, Oct 27, 2023 at 08:59:56PM +1100, Michael Ellerman wrote:
> On Mon, 23 Oct 2023 12:56:12 +0530, Aditya Gupta wrote:
> > Since below commit, address mapping for vmemmap has changed for Radix
> > MMU, where address mapping is stored in kernel page table itself,
> > in
uld be:
/*
* fadump version less than zero indicates that fadump crash info header
* is corrupted.
*/
Or:
/*
* Negative fadump version indicates that fadump crash info header
* is corrupted.
*/
Thanks,
Aditya Gupta
MU)=0')
Fixes: 368a0590d954 ("powerpc/book3s64/vmemmap: switch radix to use a different
vmemmap handling function")
Reported-by: Sachin Sant
Signed-off-by: Aditya Gupta
---
arch/powerpc/kexec/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/kexec/core.c b/arch
On Thu, Sep 21, 2023 at 07:30:00PM +1000, Michael Ellerman wrote:
> On Mon, 11 Sep 2023 14:44:09 +0530, Aditya Gupta wrote:
> > Presently, while reading a vmcore, makedumpfile uses
> > `cur_cpu_spec.mmu_features` to decide whether the crashed system had
> > RADIX MMU or no
On Wed, Sep 20, 2023 at 05:45:36PM +0530, Aneesh Kumar K.V wrote:
> Aditya Gupta writes:
>
> > Since below commit, address mapping for vmemmap has changed for Radix
> > MMU, where address mapping is stored in kernel page table itself,
> > instead of ea
On Tue, Sep 19, 2023 at 08:07:15PM +1000, Michael Ellerman wrote:
> Aditya Gupta writes:
> > On Thu, Sep 14, 2023 at 11:22:01PM +1000, Michael Ellerman wrote:
> >> Aditya Gupta writes:
> >> > Presently, while reading a vmcore, makedumpfile uses
> >>
n Sant
Tested-by: Sachin Sant
Signed-off-by: Aditya Gupta
---
Corresponding makedumpfile patches to fix address translation, in Radix
MMU case:
Link:
https://lore.kernel.org/kexec/b5f0f00e-f2b1-47d7-a143-5683d10dc...@linux.ibm.com/T/#t
---
---
arch/powerpc/kexec/core.c | 2 ++
1 file changed,
CPU features can be determined in makedumpfile, using
'cur_cpu_spec.cpu_features'.
This provides more data to makedumpfile about the crashed system, and
can help in filtering the vmcore accordingly.
Signed-off-by: Aditya Gupta
---
arch/powerpc/kexec/core.c | 1 +
1 file changed, 1
On Thu, Sep 14, 2023 at 11:22:01PM +1000, Michael Ellerman wrote:
> Aditya Gupta writes:
> > Presently, while reading a vmcore, makedumpfile uses
> > `cur_cpu_spec.mmu_features` to decide whether the crashed system had
> > RADIX MMU or not.
> >
> > Current
Hello mpe,
On Fri, Sep 15, 2023 at 11:16:08AM +1000, Michael Ellerman wrote:
> Sachin Sant writes:
> >> On 14-Sep-2023, at 6:52 PM, Michael Ellerman wrote:
> >>
> >> Sachin Sant writes:
> >>>> On 11-Sep-2023, at 2:44 PM, Aditya Gupta wrote:
>
Hello Sachin,
On Wed, Sep 13, 2023 at 06:19:11PM +0530, Sachin Sant wrote:
>
>
> > On 11-Sep-2023, at 2:44 PM, Aditya Gupta wrote:
> >
> > Presently, while reading a vmcore, makedumpfile uses
> > `cur_cpu_spec.mmu_features` to decide whether the crashed s
shifts (such as pgd_offset_l4) incorrecly considering
MMU to be hash MMU.
Add `cur_cpu_spec` symbol and offset of `mmu_features` in the
`cpu_spec` struct, to VMCOREINFO, so that the symbol address and offset
is accessible to makedumpfile, without needing the vmlinux file
Signed-off-by: Aditya
Hello Namhyung,
On Fri, Aug 25, 2023 at 10:07:28AM -0700, Namhyung Kim wrote:
> On Thu, Aug 24, 2023 at 11:11 PM Aditya Gupta wrote:
> >
> > The Problem
> > ===
> >
> > Currently the presence of a feature is checked with a combination of
> > perf
Hello,
On Fri, Aug 25, 2023 at 10:07:28AM -0700, Namhyung Kim wrote:
> Hello,
>
> On Thu, Aug 24, 2023 at 11:11 PM Aditya Gupta wrote:
> >
> > <...>
> >
> > Proposed solution
> > =
> >
> > As suggested by cont
y new feature can be added at
one place, in the 'supported_features' array
Signed-off-by: Aditya Gupta
---
tools/perf/builtin-version.c | 39
1 file changed, 8 insertions(+), 31 deletions(-)
diff --git a/tools/perf/builtin-version.c b/tools/perf/builti
From: Athira Rajeev
In probe_vfs_getname.sh, current we use "perf record --dry-run"
to check for libtraceevent and skip the test if perf is not
build with libtraceevent. Change the check to use "perf build --has"
option
Signed-off-by: Athira Rajeev
---
tools/perf/tests/shell/lib/probe_vfs_getn
* x86_64
* ppc64le
Git tree
Git tree with this patch series applied for testing:
https://github.com/adi-g15-ibm/linux/tree/perf-build-has
Aditya Gupta (3):
perf build: introduce build subcommand
perf version: update --build-options to use 'supported_features' arra
raceevent support.
Signed-off-by: Aditya Gupta
---
tools/perf/tests/shell/test_task_analyzer.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/shell/test_task_analyzer.sh
b/tools/perf/tests/shell/test_task_analyzer.sh
index 92d15154ba79..b4803e373fe5 10075
ther commands like 'perf version --build-options', so that
new features can be added in one place, with the array
Signed-off-by: Aditya Gupta
---
tools/perf/Build | 1 +
tools/perf/builtin-build.c | 94 ++
tools/perf/builtin.h | 47 ++
On Thu, Aug 03, 2023 at 12:52:50PM +0530, Athira Rajeev wrote:
>
>
> > On 03-Aug-2023, at 8:33 AM, Aditya Gupta wrote:
> >
> > Hi Arnaldo,
> > I am working on a patch for 'perf version --has', and will send a patch next
>
> Hi Aditya,
>
>
Hi Arnaldo,
I am working on a patch for 'perf version --has', and will send a patch next
week using that instead of 'perf version --build-options'.
You can skip this patch if not needed.
Thanks,
- Aditya G
On Fri, Jul 28, 2023 at 11:54:11AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu:
> > Currently we depend on output of 'perf record -e "sched:sched_switch"', to
> > check whether perf was built with libt
raceevent,
'perf version --build-options' outputs:
...
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
...
Suggested-by: Ian Rogers
Signed-off-by: Aditya Gupta
---
tools/perf/tests/shell/test_task_analyzer.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tool
Hello Ian,
On Wed, Jul 12, 2023 at 06:16:28PM -0700, Ian Rogers wrote:
> On Tue, Jun 13, 2023 at 10:04 AM Athira Rajeev
> wrote:
> >
> > From: Aditya Gupta
> >
> > Test "perf script task-analyzer tests" fails in environment with missing
> > libtrac
Hello Namhyung,
On 23/06/23 04:55, Namhyung Kim wrote:
Ok, I found two problems.
...
The first one is related to this message. It couldn't find the script
(task-analyzer.py) because PERF_EXEC_PATH is not set.
Running with --exec-path=$PWD was ok, but I got a segfault.
The other problem is in
Hello Namhyung,
On 23/06/23 04:55, Namhyung Kim wrote:
Ok, I found two problems.
...
The first one is related to this message. It couldn't find the script
(task-analyzer.py) because PERF_EXEC_PATH is not set.
Running with --exec-path=$PWD was ok, but I got a segfault.
The other problem is in
Hello, Namhyung,
On 23/06/23 04:55, Namhyung Kim wrote:
Ok, I found two problems.
...
The first one is related to this message. It couldn't find the script
(task-analyzer.py) because PERF_EXEC_PATH is not set.
Running with --exec-path=$PWD was ok, but I got a segfault.
The other problem is i
Hello Namhyung,
On 21/06/23 20:53, Namhyung Kim wrote:
Hello Aditya,
On Wed, Jun 21, 2023 at 3:05 AM Aditya Gupta wrote:
Hello Namhyung,
On 21/06/23 06:18, Namhyung Kim wrote:
...
$ sudo ./perf test -v task
114: perf script task-analyzer tests :
--- start
ff-by: Athira Rajeev
Signed-off-by: Kajol Jain
Signed-off-by: Aditya Gupta
---
I'm seeing a different error even after this fix.
Can you please take a look?
Thanks,
Namhyung
$ sudo ./perf test -v task
114: perf script task-analyzer tests :
--- start -
ove ppc_save_regs()")
Reviewed-by: Nicholas Piggin
Signed-off-by: Aditya Gupta
---
More information:
This problem with gdb backtrace was discovered while working on a crash
tool enhancement to improve crash analysis using gdb passthrough to be
able print function arguments and local variab
On 15/06/23 17:40, Nicholas Piggin wrote:
On Thu Jun 15, 2023 at 7:10 PM AEST, Aditya Gupta wrote:
ppc_save_regs() skips one stack frame while saving the CPU register states.
Instead of saving current R1, it pulls the previous stack frame pointer.
...
So this now saves regs as though it was
at fs/read_write.c:637
#10 0xc002ea2c in system_call_exception (regs=0xc670be80,
r0=)
at arch/powerpc/kernel/syscall.c:171
#11 0xc000c270 in system_call_vectored_common ()
at arch/powerpc/kernel/interrupt_64.S:192
----
Signed-off-by: Aditya Gupta
---
More inf
)
at fs/read_write.c:637
#10 0xc002ea2c in system_call_exception (regs=0xc670be80,
r0=)
at arch/powerpc/kernel/syscall.c:171
#11 0xc000c270 in system_call_vectored_common ()
at arch/powerpc/kernel/interrupt_64.S:192
----
Signed-off-by: Aditya Gupta
---
Mor
38 matches
Mail list logo
