Re: [PATCH v2 0/9] lib/crypto: move arch/$(ARCH)/lib/crypto/ to lib/crypto/$(ARCH)/

2025-06-20 Thread Martin K. Petersen
Eric, > This series moves the contents of arch/$(ARCH)/lib/crypto/ into > lib/crypto/$(ARCH)/. LGTM. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH 1/3] mm: change vm_get_page_prot() to accept vm_flags_t argument

2025-06-20 Thread Pedro Falcato
On Thu, Jun 19, 2025 at 09:49:03AM +0100, Lorenzo Stoakes wrote: > On Thu, Jun 19, 2025 at 10:42:14AM +0200, Christian Brauner wrote: > > If you change vm_flags_t to u64 you probably want to compile with some > > of these integer truncation options when you're doing the conversion. > > Because othe

Re: [PATCH 2/3] mm: update core kernel code to use vm_flags_t consistently

2025-06-20 Thread Pedro Falcato
On Wed, Jun 18, 2025 at 08:42:53PM +0100, Lorenzo Stoakes wrote: > The core kernel code is currently very inconsistent in its use of > vm_flags_t vs. unsigned long. This prevents us from changing the type of > vm_flags_t in the future and is simply not correct, so correct this. > > While this resu

Re: [PATCH 3/3] mm: update architecture and driver code to use vm_flags_t

2025-06-20 Thread Pedro Falcato
On Wed, Jun 18, 2025 at 08:42:54PM +0100, Lorenzo Stoakes wrote: > In future we intend to change the vm_flags_t type, so it isn't correct for > architecture and driver code to assume it is unsigned long. Correct this > assumption across the board. > > Overall, this patch does not introduce any fun

Re: [PATCH 1/3] mm: change vm_get_page_prot() to accept vm_flags_t argument

2025-06-20 Thread Pedro Falcato
On Wed, Jun 18, 2025 at 08:42:52PM +0100, Lorenzo Stoakes wrote: > We abstract the type of the VMA flags to vm_flags_t, however in may places > it is simply assumed this is unsigned long, which is simply incorrect. > > At the moment this is simply an incongruity, however in future we plan to > cha

Re: [PATCH v2 0/9] lib/crypto: move arch/$(ARCH)/lib/crypto/ to lib/crypto/$(ARCH)/

2025-06-20 Thread Sohil Mehta
On 6/19/2025 12:18 PM, Eric Biggers wrote: > Eric Biggers (9): > lib/crypto: arm: move arch/arm/lib/crypto/ into lib/crypto/ > lib/crypto: arm64: move arch/arm64/lib/crypto/ into lib/crypto/ > lib/crypto: mips: move arch/mips/lib/crypto/ into lib/crypto/ > lib/crypto: powerpc: move arch/po

Re: [PATCH v2 0/9] lib/crypto: move arch/$(ARCH)/lib/crypto/ to lib/crypto/$(ARCH)/

2025-06-20 Thread Ard Biesheuvel
On Thu, 19 Jun 2025 at 21:22, Eric Biggers wrote: > > This series applies on top of > https://lore.kernel.org/r/20250616014019.415791-1-ebigg...@kernel.org/ > and is also available in git at: > > git fetch > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git > arch-to-lib-cry

Re: [PATCH v2 0/9] lib/crypto: move arch/$(ARCH)/lib/crypto/ to lib/crypto/$(ARCH)/

2025-06-20 Thread Eric Biggers
On Thu, Jun 19, 2025 at 12:18:59PM -0700, Eric Biggers wrote: > This series applies on top of > https://lore.kernel.org/r/20250616014019.415791-1-ebigg...@kernel.org/ > and is also available in git at: > > git fetch > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git > arch-

Re: [PATCH RFC 19/29] mm: stop storing migration_ops in page->mapping

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:40, David Hildenbrand wrote: > ... instead, look them up statically based on the page type. Maybe in the > future we want a registration interface? At least for now, it can be > easily handled using the two page types that actually support page > migration. > > The remaining

Re: [PATCH RFC 18/29] mm: remove __folio_test_movable()

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:40, David Hildenbrand wrote: > Convert to page_has_movable_ops(). While at it, cleanup relevant code > a bit. > > The data_race() in migrate_folio_unmap() is questionable: we already > hold a page reference, and concurrent modifications can no longer > happen (iow: __ClearPag

Re: [PATCH RFC 17/29] mm/page_isolation: drop __folio_test_movable() check for large folios

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:40, David Hildenbrand wrote: > Currently, we only support migration of individual non-folio pages, so > we can not run into that. > > Signed-off-by: David Hildenbrand > --- > mm/page_isolation.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Zi Yan

Re: [PATCH RFC 16/29] mm: rename __PageMovable() to page_has_movable_ops()

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > Let's make it clearer that we are talking about movable_ops pages. > > Signed-off-by: David Hildenbrand > --- > include/linux/migrate.h| 2 +- > include/linux/page-flags.h | 2 +- > mm/compaction.c| 7 ++- > mm/memory-fa

Re: [PATCH RFC 15/29] mm/migration: remove PageMovable()

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > As __ClearPageMovable() is gone that would have only made > PageMovable()==false but still __PageMovable()==true, now > PageMovable() == __PageMovable(). > > So we can replace PageMovable() checks by __PageMovable(). In fact, > __PageMovable() c

Re: [PATCH RFC 14/29] mm/migrate: remove __ClearPageMovable()

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > Unused, let's remove it. > > The Chinese docs in Documentation/translations/zh_CN/mm/page_migration.rst > still mention it, but that whole docs is destined to get outdated and > updated by somebody that actually speaks that language. > > Signed-

Re: [PATCH RFC 11/29] mm/migrate: move movable_ops page handling out of move_to_new_folio()

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > Let's move that handling directly into migrate_folio_move(), so we can > simplify move_to_new_folio(). While at it, fixup the documentation a > bit. > > Note that unmap_and_move_huge_page() does not care, because it only > deals with actual foli

Re: [PATCH RFC 10/29] mm/migrate: remove folio_test_movable() and folio_movable_ops()

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > Folios will have nothing to do with movable_ops page migration. These > functions are now unused, so let's remove them. > > Signed-off-by: David Hildenbrand > --- > include/linux/migrate.h | 14 -- > 1 file changed, 14 deletions(-)

Re: [PATCH RFC 09/29] mm/migrate: factor out movable_ops page handling into migrate_movable_ops_page()

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > Let's factor it out, simplifying the calling code. > > The assumption is that flush_dcache_page() is not required for > movable_ops pages: as documented for flush_dcache_folio(), it really > only applies when the kernel wrote to pagecache pages

[PATCH v6 2/4] tpm: support devices with synchronous send()

2025-06-20 Thread Stefano Garzarella
From: Stefano Garzarella Some devices do not support interrupts and provide a single synchronous operation to send the command and receive the response on the same buffer. Currently, these types of drivers must use an internal buffer where they temporarily store the response between .send() and

[PATCH v6 0/4] tpm: add support for sync send() and use it in ftpm and svsm drivers

2025-06-20 Thread Stefano Garzarella
The content of this version is the same of v5, but rebased on current linux-tpmdd/next (`git range-diff` on v5 is empty) after the merge window since tpm-svsm patches were merged with another tree, so we agreed on postpone this series, see https://lore.kernel.org/linux-integrity/adcb-wkhgolq-...@

[PATCH] misc: ocxl: Replace scnprintf() with sysfs_emit() in sysfs show functions

2025-06-20 Thread Ankit Chauhan
Replace scnprintf() with sysfs_emit() in sysfs show functions. These helpers are preferred in sysfs callbacks because they automatically handle buffer size and improve safety and readability. Signed-off-by: Ankit Chauhan --- drivers/misc/ocxl/sysfs.c | 12 ++-- 1 file changed, 6 insertio

Re: [PATCH v2 2/6] pci/hotplug/pnv_php: Work around switches with broken

2025-06-20 Thread Timothy Pearson
- Original Message - > From: "Lukas Wunner" > To: "Timothy Pearson" > Cc: "Bjorn Helgaas" , "linuxppc-dev" > , "linux-kernel" > , "linux-pci" , > "Madhavan Srinivasan" , > "Michael Ellerman" , "christophe leroy" > , "Naveen N Rao" > , "Bjorn Helgaas" , "Shawn Anastasio" > > Sent:

[PATCH v6 4/4] tpm/tpm_svsm: support TPM_CHIP_FLAG_SYNC

2025-06-20 Thread Stefano Garzarella
From: Stefano Garzarella This driver does not support interrupts, and receiving the response is synchronous with sending the command. Enable synchronous send() with TPM_CHIP_FLAG_SYNC, which implies that ->send() already fills the provided buffer with a response, and ->recv() is not implemented.

[PATCH v6 3/4] tpm/tpm_ftpm_tee: support TPM_CHIP_FLAG_SYNC

2025-06-20 Thread Stefano Garzarella
From: Stefano Garzarella This driver does not support interrupts, and receiving the response is synchronous with sending the command. Enable synchronous send() with TPM_CHIP_FLAG_SYNC, which implies that ->send() already fills the provided buffer with a response, and ->recv() is not implemented.

[PATCH v6 1/4] tpm: add bufsiz parameter in the .send callback

2025-06-20 Thread Stefano Garzarella
From: Stefano Garzarella Add a new `bufsiz` parameter to the `.send` callback in `tpm_class_ops`. This parameter will allow drivers to differentiate between the actual command length to send and the total buffer size. Currently `bufsiz` is not used, but it will be used to implement devices with s

Re: [PATCH v2] powerpc: floppy: Add missing checks after DMA map

2025-06-20 Thread Christophe Leroy
Le 20/06/2025 à 09:55, Thomas Fourier a écrit : [Vous ne recevez pas souvent de courriers de fourier.tho...@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] The DMA map functions can fail and should be tested for errors. Signed-off-by: Thom

Re: [PATCH v2 6/6] pci/hotplug/pnv_php: Enable third attention indicator

2025-06-20 Thread Krishna Kumar
Shawn, Timothy: Thanks for posting the series of patch. Few things I wanted to do better understand Raptor problem - 1. Last time my two patches solved all the hotunplug operation and Kernel crash issue except nvme case. It did not work with     NVME since dpc support was not there. I was not

Re: [PATCH] misc: ocxl: Replace scnprintf() with sysfs_emit() in sysfs show functions

2025-06-20 Thread Andrew Donnellan
On Fri, 2025-06-20 at 08:17 +0530, Ankit Chauhan wrote: > Replace scnprintf() with sysfs_emit() in sysfs show functions. > These helpers are preferred in sysfs callbacks because they > automatically > handle buffer size and improve safety and readability. > > Signed-off-by: Ankit Chauhan Thanks

Re: [PATCH v2 2/6] pci/hotplug/pnv_php: Work around switches with broken

2025-06-20 Thread Lukas Wunner
On Thu, Jun 19, 2025 at 02:29:33PM -0500, Timothy Pearson wrote: > To be perfectly frank the existing code quality in this driver > (and the associated EEH driver) is not the best, and it's been > a frustrating experience trying to hack it into semi-stable > operation. > > I would vastly prefer to

Re: [PATCH v2] powerpc: floppy: Add missing checks after DMA map

2025-06-20 Thread LEROY Christophe
Le 20/06/2025 à 09:55, Thomas Fourier a écrit : > [Vous ne recevez pas souvent de courriers de fourier.tho...@gmail.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > The DMA map functions can fail and should be tested for errors. > > Signed-o

[PATCH v2] powerpc: floppy: Add missing checks after DMA map

2025-06-20 Thread Thomas Fourier
The DMA map functions can fail and should be tested for errors. Signed-off-by: Thomas Fourier --- arch/powerpc/include/asm/floppy.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/floppy.h b/arch/powerpc/include/asm/floppy.h index f8ce178b43b7..3

Re: [PATCH] powerpc: floppy: Add missing checks after DMA map

2025-06-20 Thread Christophe Leroy
Hi Thomas, Le 19/06/2025 à 13:07, Thomas Fourier a écrit : [Vous ne recevez pas souvent de courriers de fourier.tho...@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] The DMA map functions can fail and should be tested for errors. Signed-off