Re: [PATCH v4 4/5] PCI: host-common: Add link down handling for host bridges

2025-05-29 Thread Manivannan Sadhasivam
On Wed, May 28, 2025 at 05:35:00PM -0500, Bjorn Helgaas wrote: > On Thu, May 08, 2025 at 12:40:33PM +0530, Manivannan Sadhasivam wrote: > > The PCI link, when down, needs to be recovered to bring it back. But that > > cannot be done in a generic way as link recovery procedure is specific to > > hos

Re: [PATCH v4 08/13] crypto: s390/sha256 - implement library instead of shash

2025-05-29 Thread Eric Biggers
On Thu, May 29, 2025 at 04:54:34PM -0700, Linus Torvalds wrote: > On Thu, 29 May 2025 at 14:16, Eric Biggers wrote: > > > > So using crc32c() + ext4 + x86 as an example (but SHA-256 would be very > > similar), the current behavior is that ext4.ko depends on the crc32c_arch() > > symbol. > > Yes,

Re: [PATCH v4 08/13] crypto: s390/sha256 - implement library instead of shash

2025-05-29 Thread Linus Torvalds
On Thu, 29 May 2025 at 14:16, Eric Biggers wrote: > > So using crc32c() + ext4 + x86 as an example (but SHA-256 would be very > similar), the current behavior is that ext4.ko depends on the crc32c_arch() > symbol. Yes, I think that's a good example. I think it's an example of something that "wor

Re: linux-next: build warning after merge of the powerpc tree

2025-05-29 Thread Stephen Rothwell
Hi all, On Tue, 13 May 2025 20:28:09 +1000 Stephen Rothwell wrote: > > After merging the powerpc tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/arch/powerpc/htm.rst: WARNING: document isn't included in any > toctree > > Introduced by commit > > ab1456c

Re: [PATCH v4 08/13] crypto: s390/sha256 - implement library instead of shash

2025-05-29 Thread Eric Biggers
On Thu, May 29, 2025 at 01:14:31PM -0700, Linus Torvalds wrote: > On Thu, 29 May 2025 at 10:37, Eric Biggers wrote: > > > > Long-term, I'd like to find a clean way to consolidate the library code for > > each > > algorithm into a single module. > > No, while I think the current situation isn't g

Re: [PATCH v4 08/13] crypto: s390/sha256 - implement library instead of shash

2025-05-29 Thread Linus Torvalds
On Thu, 29 May 2025 at 10:37, Eric Biggers wrote: > > Long-term, I'd like to find a clean way to consolidate the library code for > each > algorithm into a single module. No, while I think the current situation isn't great, I think the "make it one single module" is even worse. For most archite

Re: [PATCH v4 08/13] crypto: s390/sha256 - implement library instead of shash

2025-05-29 Thread Eric Biggers
On Thu, May 29, 2025 at 05:37:02PM +, Eric Biggers wrote: > On Thu, May 29, 2025 at 11:05:26AM -0600, Alex Williamson wrote: > > On Mon, 28 Apr 2025 10:00:33 -0700 > > Eric Biggers wrote: > > > > > From: Eric Biggers > > > > > > Instead of providing crypto_shash algorithms for the arch-opti

Re: [PATCH v2 1/3] powerpc/pseries: Correct secvar format representation for static key management

2025-05-29 Thread Srish Srinivasan
On 5/23/25 11:27 AM, Andrew Donnellan wrote: On Wed, 2025-05-21 at 16:27 +0530, Srish Srinivasan wrote: On a PLPKS enabled PowerVM LPAR, the secvar format property for static key management is misrepresented as "ibm,plpks-sb-unknown", creating reason for confusion. Static key management mode

Re: [PATCH v4 08/13] crypto: s390/sha256 - implement library instead of shash

2025-05-29 Thread Eric Biggers
On Thu, May 29, 2025 at 11:05:26AM -0600, Alex Williamson wrote: > On Mon, 28 Apr 2025 10:00:33 -0700 > Eric Biggers wrote: > > > From: Eric Biggers > > > > Instead of providing crypto_shash algorithms for the arch-optimized > > SHA-256 code, instead implement the SHA-256 library. This is much

Re: [PATCH v2 2/3] powerpc/secvar: Expose secvars relevant to the key management mode

2025-05-29 Thread Srish Srinivasan
On 5/23/25 11:49 AM, Michal Suchánek wrote: Hello, On Wed, May 21, 2025 at 04:27:58PM +0530, Srish Srinivasan wrote: The PLPKS enabled PowerVM LPAR sysfs exposes all of the secure boot secvars irrespective of the key management mode. The PowerVM LPAR supports static and dynamic key managemen

Re: [PATCH v4 08/13] crypto: s390/sha256 - implement library instead of shash

2025-05-29 Thread Alex Williamson
On Mon, 28 Apr 2025 10:00:33 -0700 Eric Biggers wrote: > From: Eric Biggers > > Instead of providing crypto_shash algorithms for the arch-optimized > SHA-256 code, instead implement the SHA-256 library. This is much > simpler, it makes the SHA-256 library functions be arch-optimized, and > it

Re: [PATCH 07/12] mm: Remove redundant pXd_devmap calls

2025-05-29 Thread Jonathan Cameron
On Thu, 29 May 2025 16:32:08 +1000 Alistair Popple wrote: > DAX was the only thing that created pmd_devmap and pud_devmap entries > however it no longer does as DAX pages are now refcounted normally and > pXd_trans_huge() returns true for those. Therefore checking both pXd_devmap > and pXd_trans_

Re: [PATCH 01/12] mm: Remove PFN_MAP, PFN_SG_CHAIN and PFN_SG_LAST

2025-05-29 Thread Jonathan Cameron
On Thu, 29 May 2025 16:32:02 +1000 Alistair Popple wrote: > The PFN_MAP flag is no longer used for anything, so remove it. The > PFN_SG_CHAIN and PFN_SG_LAST flags never appear to have been used so > also remove them. Superficial thing but you seem to be be removing PFN_SPECIAL as well and this

Re: [PATCH 3/8] ASoC: codecs: wcd9335: Drop unused sido_input_src field

2025-05-29 Thread Srinivas Kandagatla
On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote: > Member wcd9335_codec.sido_input_src is not read anywhere after > assignment, so it can be safely dropped. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Srinivas Kandagatla --srini > sound/soc/codecs/wcd9335.c | 5 - > 1 fi

Re: [PATCH 5/8] ASoC: codecs: wcd937x: Drop unused 'struct wcd937x_priv' fields

2025-05-29 Thread Srinivas Kandagatla
On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote: > 'wcd_regmap_irq_chip' and 'jack' in 'struct wcd937x_priv' are not used > at all. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Srinivas Kandagatla --srini > sound/soc/codecs/wcd937x.c | 2 -- > 1 file changed, 2 deletions(-) >

Re: [PATCH 0/8] ASoC: codecs: More const and unused member cleanups

2025-05-29 Thread Srinivas Kandagatla
On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote: > Make static data const for code safety and drop some unused fields in > structs. > > This is based on for-v6.16 branch in ASoC tree for context in wcd938x > driver. > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (8): > ASoC:

Re: [PATCH 8/8] ASoC: codecs: wcd939x: Drop unused 'struct wcd939x_priv' fields

2025-05-29 Thread Srinivas Kandagatla
On 5/28/25 9:00 PM, Krzysztof Kozlowski wrote: > 'wcd_regmap_irq_chip' and 'jack' in 'struct wcd939x_priv' are not used > at all. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Srinivas Kandagatla --srini > sound/soc/codecs/wcd939x.c | 2 -- > 1 file changed, 2 deletions(-) >

Re: [PATCH 7/8] ASoC: codecs: wcd938x: Drop unused variant field

2025-05-29 Thread Srinivas Kandagatla
On 5/28/25 9:00 PM, Krzysztof Kozlowski wrote: > Member wcd938x_priv.variant is assigned in probe() function and used > immediately thereafter, thus it can be just a local variable for less > variables stored in 'struct wcd938x_priv' device-wide state. > > Signed-off-by: Krzysztof Kozlowski >

Re: [PATCH 6/8] ASoC: codecs: wcd938x: Drop unused 'struct wcd938x_priv' fields

2025-05-29 Thread Srinivas Kandagatla
On 5/28/25 9:00 PM, Krzysztof Kozlowski wrote: > 'wcd_regmap_irq_chip' and 'jack' in 'struct wcd938x_priv' are not used > at all. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Srinivas Kandagatla --srini > sound/soc/codecs/wcd938x.c | 2 -- > 1 file changed, 2 deletions(-) >

Re: [PATCH 4/8] ASoC: codecs: wcd934x: Drop unused num_rx_port/num_tx_port fields

2025-05-29 Thread Srinivas Kandagatla
On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote: > Members wcd934x_codec.num_rx_port and num_tx_port are not read anywhere > after assignment, so they can be safely dropped. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Srinivas Kandagatla --srini > sound/soc/codecs/wcd934x.c | 4

Re: [PATCH 1/8] ASoC: codecs: Constify regmap configuration static variables

2025-05-29 Thread Srinivas Kandagatla
On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote: > Static arrays/structs for regmap configuration like 'struct > reg_default', 'struct reg_sequence' and others are not modified so can > be changed to const for more safety. > > Signed-off-by: Krzysztof Kozlowski > --- > sound/soc/codecs/cs35l36.

Re: [PATCH 1/8] ASoC: codecs: Constify regmap configuration static variables

2025-05-29 Thread Charles Keepax
On Wed, May 28, 2025 at 09:59:55PM +0200, Krzysztof Kozlowski wrote: > Static arrays/structs for regmap configuration like 'struct > reg_default', 'struct reg_sequence' and others are not modified so can > be changed to const for more safety. > > Signed-off-by: Krzysztof Kozlowski > --- > sound/

Re: [PATCH 0/8] ASoC: codecs: More const and unused member cleanups

2025-05-29 Thread Krzysztof Kozlowski
On 29/05/2025 11:33, Srinivas Kandagatla wrote: > > > On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote: >> Make static data const for code safety and drop some unused fields in >> structs. >> >> This is based on for-v6.16 branch in ASoC tree for context in wcd938x >> driver. >> >> Best regards, >> K

[PATCH 05/12] mm: Remove remaining uses of PFN_DEV

2025-05-29 Thread Alistair Popple
PFN_DEV was used by callers of dax_direct_access() to figure out if the returned PFN is associated with a page using pfn_t_has_page() or not. However all DAX PFNs now require an assoicated ZONE_DEVICE page so can assume a page exists. Other users of PFN_DEV were setting it before calling vmf_inser