Re: [kvm-unit-tests PATCH v3 16/16] scripts: Enable kvmtool

2025-05-20 Thread Shaoqin Huang
On 5/7/25 11:12 PM, Alexandru Elisei wrote: Everything is in place to run the tests using kvmtool: $ ./configure --target=kvmtool $ make clean && make $ KVMTOOL= ./run_tests.sh so enable it, and remove ERRATA_FORCE=y when configuring for kvmtool, because the runner will generate and pass the

Re: [kvm-unit-tests PATCH v3 14/16] scripts/mkstandalone: Export $TARGET

2025-05-20 Thread Shaoqin Huang
On 5/7/25 11:12 PM, Alexandru Elisei wrote: $TARGET is needed for the test runner to decide if it should use qemu or kvmtool, so export it. Reviewed-by: Andrew Jones Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- scripts/mkstandalone.sh | 1 + 1 file changed, 1 inser

Re: [kvm-unit-tests PATCH v3 13/16] scripts: Do not probe for maximum number of VCPUs when using kvmtool

2025-05-20 Thread Shaoqin Huang
On 5/7/25 11:12 PM, Alexandru Elisei wrote: The --probe-maxsmp parameter updates MAX_SMP with the maximum number of VCPUs that the host supports. Qemu will exit with an error when creating a virtual machine if the number of VCPUs is exceeded. kvmtool behaves differently: it will automatically

Re: [kvm-unit-tests PATCH v3 12/16] scripts: Detect kvmtool failure in premature_failure()

2025-05-20 Thread Shaoqin Huang
On 5/7/25 11:12 PM, Alexandru Elisei wrote: kvm-unit-tests assumes that if the VMM is able to get to where it tries to load the kernel, then the VMM and the configuration parameters will also work for running the test. All of this is done in premature_failure(). Teach premature_failure() abou

Re: [PATCH] MAINTAINERS: powerpc: Remove myself as a reviewer

2025-05-20 Thread Madhavan Srinivasan
On Sun, 20 Apr 2025 22:02:48 +0530, Naveen N Rao (AMD) wrote: > I haven't been able to participate and help with this as much as I had > hoped, and it doesn't look like I will be able to spend time on powerpc > going forward. > > Applied to powerpc/next. [1/1] MAINTAINERS: powerpc: Remove mysel

Re: [kvm-unit-tests PATCH v3 10/16] scripts: Add default arguments for kvmtool

2025-05-20 Thread Shaoqin Huang
On 5/7/25 11:12 PM, Alexandru Elisei wrote: kvmtool, unless told otherwise, will do its best to make sure that a kernel successfully boots in a virtual machine. It does things like automatically creating a rootfs and adding extra parameters to the kernel command line. This is actively harmful

Re: [PATCH v7 15/17] PCI/AER: Ratelimit correctable and non-fatal error logging

2025-05-20 Thread Sathyanarayanan Kuppuswamy
On 5/20/25 2:50 PM, Bjorn Helgaas wrote: From: Jon Pan-Doh Spammy devices can flood kernel logs with AER errors and slow/stall execution. Add per-device ratelimits for AER correctable and non-fatal uncorrectable errors that use the kernel defaults (10 per 5s). Logging of fatal errors is not

Re: [PATCH v7 17/17] PCI/AER: Add sysfs attributes for log ratelimits

2025-05-20 Thread Sathyanarayanan Kuppuswamy
On 5/20/25 2:50 PM, Bjorn Helgaas wrote: From: Jon Pan-Doh Allow userspace to read/write log ratelimits per device (including enable/disable). Create aer/ sysfs directory to store them and any future aer configs. Update AER sysfs ABI filename to reflect the broader scope of AER sysfs attribu

Re: [PATCH v7 09/17] PCI/AER: Simplify pci_print_aer()

2025-05-20 Thread Sathyanarayanan Kuppuswamy
On 5/20/25 2:50 PM, Bjorn Helgaas wrote: From: Bjorn Helgaas Simplify pci_print_aer() by initializing the struct aer_err_info "info" with a designated initializer list (it was previously initialized with memset()) and using pci_name(). Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilcz

Re: [PATCH v7 04/17] PCI/AER: Consolidate Error Source ID logging in aer_isr_one_error_type()

2025-05-20 Thread Sathyanarayanan Kuppuswamy

Re: [PATCH v7 03/17] PCI/AER: Factor COR/UNCOR error handling out from aer_isr_one_error()

2025-05-20 Thread Sathyanarayanan Kuppuswamy
On 5/20/25 2:50 PM, Bjorn Helgaas wrote: From: Bjorn Helgaas aer_isr_one_error() duplicates the Error Source ID logging and AER error processing for Correctable Errors and Uncorrectable Errors. Factor out the duplicated code to aer_isr_one_error_type(). aer_isr_one_error() doesn't need the

[PATCH v7 17/17] PCI/AER: Add sysfs attributes for log ratelimits

2025-05-20 Thread Bjorn Helgaas
From: Jon Pan-Doh Allow userspace to read/write log ratelimits per device (including enable/disable). Create aer/ sysfs directory to store them and any future aer configs. Update AER sysfs ABI filename to reflect the broader scope of AER sysfs attributes (e.g. stats and ratelimits). Documenta

[PATCH v7 13/17] PCI/AER: Make all pci_print_aer() log levels depend on error type

2025-05-20 Thread Bjorn Helgaas
From: Karolina Stolarek Some existing logs in pci_print_aer() log with error severity by default. Convert them to depend on error type (consistent with rest of AER logging). Signed-off-by: Karolina Stolarek Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Reviewed-by: Kuppuswamy S

[PATCH v7 11/17] PCI/AER: Combine trace_aer_event() with statistics updates

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas As with the AER statistics, we always want to emit trace events, even if the actual dmesg logging is rate limited. Call trace_aer_event() directly from pci_dev_aer_stats_incr(), where we update the statistics. Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Re

[PATCH v7 06/17] PCI/AER: Rename aer_print_port_info() to aer_print_source()

2025-05-20 Thread Bjorn Helgaas
From: Jon Pan-Doh Rename aer_print_port_info() to aer_print_source() to be more descriptive. This logs the Error Source ID logged by a Root Port or Root Complex Event Collector when it receives an ERR_COR, ERR_NONFATAL, or ERR_FATAL Message. [bhelgaas: aer_print_rp_info() -> aer_print_source()]

[PATCH v7 14/17] PCI/AER: Rename struct aer_stats to aer_info

2025-05-20 Thread Bjorn Helgaas
From: Karolina Stolarek Update name to reflect the broader definition of structs/variables that are stored (e.g. ratelimits). This is a preparatory patch for adding rate limit support. [bhelgaas: "aer_report" -> "aer_info"] Signed-off-by: Karolina Stolarek Signed-off-by: Bjorn Helgaas Tested-b

[PATCH v7 16/17] PCI/AER: Add ratelimits to PCI AER Documentation

2025-05-20 Thread Bjorn Helgaas
From: Jon Pan-Doh Add ratelimits section for rationale and defaults. [bhelgaas: note fatal errors are not ratelimited] Signed-off-by: Karolina Stolarek Signed-off-by: Jon Pan-Doh Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Reviewed-by: Kuppuswamy Sathyanarayanan Acked-by:

[PATCH v7 15/17] PCI/AER: Ratelimit correctable and non-fatal error logging

2025-05-20 Thread Bjorn Helgaas
From: Jon Pan-Doh Spammy devices can flood kernel logs with AER errors and slow/stall execution. Add per-device ratelimits for AER correctable and non-fatal uncorrectable errors that use the kernel defaults (10 per 5s). Logging of fatal errors is not ratelimited. There are two AER logging entry

[PATCH v7 12/17] PCI/AER: Check log level once and remember it

2025-05-20 Thread Bjorn Helgaas
From: Karolina Stolarek When reporting an AER error, we check its type multiple times to determine the log level for each message. Do this check only in the top-level functions (aer_isr_one_error(), pci_print_aer()) and save the level in struct aer_err_info. [bhelgaas: save log level in struct a

[PATCH v7 08/17] PCI/AER: Initialize aer_err_info before using it

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas Previously the struct aer_err_info "e_info" was allocated on the stack without being initialized, so it contained junk except for the fields we explicitly set later. Initialize "e_info" at declaration with a designated initializer list, which initializes the other members to

[PATCH v7 10/17] PCI/AER: Update statistics early in logging

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas There are two AER logging entry points: - aer_print_error() is used by DPC (dpc_process_error()) and native AER handling (aer_process_err_devices()). - pci_print_aer() is used by GHES (aer_recover_work_func()) and CXL (cxl_handle_rdport_errors()) Both use __aer_

[PATCH v7 07/17] PCI/AER: Move aer_print_source() earlier in file

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas Move aer_print_source() earlier in the file so a future change can use it from aer_print_error(), where it's easier to rate limit it. Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Reviewed-by: Kuppuswamy Sathyanarayanan Reviewed-by: Ilpo Järvinen --- driv

[PATCH v7 09/17] PCI/AER: Simplify pci_print_aer()

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas Simplify pci_print_aer() by initializing the struct aer_err_info "info" with a designated initializer list (it was previously initialized with memset()) and using pci_name(). Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Reviewed-by: Ilpo Järvinen --- drive

[PATCH v7 05/17] PCI/AER: Extract bus/dev/fn in aer_print_port_info() with PCI_BUS_NUM(), etc

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas Use PCI_BUS_NUM(), PCI_SLOT(), PCI_FUNC() to extract the bus number, device, and function number directly from the Error Source ID. There's no need to shift and mask it explicitly. Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Reviewed-by: Kuppuswamy Sathyan

[PATCH v7 04/17] PCI/AER: Consolidate Error Source ID logging in aer_isr_one_error_type()

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas Previously we decoded the AER Error Source ID in aer_isr_one_error_type(), then again in find_source_device() if we didn't find any devices with errors logged in their AER Capabilities. Consolidate this so we only decode and log the Error Source ID once in aer_isr_one_error_t

[PATCH v7 01/17] PCI/DPC: Initialize aer_err_info before using it

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas Previously the struct aer_err_info "info" was allocated on the stack without being initialized, so it contained junk except for the fields we explicitly set later. Initialize "info" at declaration so it starts as all zeros. Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof

[PATCH v7 03/17] PCI/AER: Factor COR/UNCOR error handling out from aer_isr_one_error()

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas aer_isr_one_error() duplicates the Error Source ID logging and AER error processing for Correctable Errors and Uncorrectable Errors. Factor out the duplicated code to aer_isr_one_error_type(). aer_isr_one_error() doesn't need the struct aer_rpc pointer, so pass it the Root P

[PATCH v7 02/17] PCI/DPC: Log Error Source ID only when valid

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas DPC Error Source ID is only valid when the DPC Trigger Reason indicates that DPC was triggered due to reception of an ERR_NONFATAL or ERR_FATAL Message (PCIe r6.0, sec 7.9.14.5). When DPC was triggered by ERR_NONFATAL (PCI_EXP_DPC_STATUS_TRIGGER_RSN_NFE) or ERR_FATAL (PCI_EXP

[PATCH v7 00/17] Rate limit AER logs

2025-05-20 Thread Bjorn Helgaas
From: Bjorn Helgaas This work is mostly due to Jon Pan-Doh and Karolina Stolarek. I rebased this to v6.15-rc1, factored out some of the trace and statistics updates, and added some minor cleanups. I'm sorry to post a v7 so soon after v6, but I really want to get this in v6.16 so it needs to get

Re: [PATCH 4/6] ASoC: meson: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ai-Chao/ASoC-ppc-Use-helper-function-for_each_child_of_node_scope

Re: [PATCH v6 13/16] PCI/AER: Rename struct aer_stats to aer_report

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 08:30:09PM -0700, Sathyanarayanan Kuppuswamy wrote: > > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > From: Karolina Stolarek > > > > Update name to reflect the broader definition of structs/variables that are > > stored (e.g. ratelimits). This is a preparatory patch for a

Re: [PATCH 0/3] i2c: remove 'of_node' from i2c_board_info

2025-05-20 Thread Wolfram Sang
On Mon, May 19, 2025 at 01:13:11PM +0200, Wolfram Sang wrote: > I promised Andy to support him in his cleanup efforts, and here is the > outcome for tidying up i2c_board_info. It seems it was easier than > anticipated. But my scanning scripts (awk, coccinelle) didn't find any > more occurences and

Re: [PATCH v6 15/16] PCI/AER: Add ratelimits to PCI AER Documentation

2025-05-20 Thread Sathyanarayanan Kuppuswamy
On 5/20/25 12:48 PM, Bjorn Helgaas wrote: On Mon, May 19, 2025 at 10:01:09PM -0700, Sathyanarayanan Kuppuswamy wrote: On 5/19/25 2:35 PM, Bjorn Helgaas wrote: From: Jon Pan-Doh Add ratelimits section for rationale and defaults. +AER Ratelimits +-- + +Since error messages can be

Re: [PATCH v5 4/4] tpm/tpm_svsm: support TPM_CHIP_FLAG_SYNC

2025-05-20 Thread Jarkko Sakkinen
On Tue, May 20, 2025 at 06:06:50PM +0200, Stefano Garzarella wrote: > On Thu, 15 May 2025 at 03:45, Jarkko Sakkinen wrote: > > > > On Wed, May 14, 2025 at 03:46:30PM +0200, Stefano Garzarella wrote: > > > From: Stefano Garzarella > > > > > > This driver does not support interrupts, and receiving

Re: [PATCH v6 15/16] PCI/AER: Add ratelimits to PCI AER Documentation

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 10:01:09PM -0700, Sathyanarayanan Kuppuswamy wrote: > > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > From: Jon Pan-Doh > > > > Add ratelimits section for rationale and defaults. > > +AER Ratelimits > > +-- > > + > > +Since error messages can be generated for

Re: [PATCH v6 14/16] PCI/AER: Introduce ratelimit for error logs

2025-05-20 Thread Bjorn Helgaas
On Tue, May 20, 2025 at 02:55:32PM +0300, Ilpo Järvinen wrote: > On Mon, 19 May 2025, Bjorn Helgaas wrote: > > > From: Jon Pan-Doh > > > > Spammy devices can flood kernel logs with AER errors and slow/stall > > execution. Add per-device ratelimits for AER correctable and uncorrectable > > errors

Re: [PATCH v6 14/16] PCI/AER: Introduce ratelimit for error logs

2025-05-20 Thread Sathyanarayanan Kuppuswamy
On 5/20/25 11:31 AM, Bjorn Helgaas wrote: On Mon, May 19, 2025 at 09:59:29PM -0700, Sathyanarayanan Kuppuswamy wrote: On 5/19/25 2:35 PM, Bjorn Helgaas wrote: From: Jon Pan-Doh Spammy devices can flood kernel logs with AER errors and slow/stall execution. Add per-device ratelimits for AER c

Re: [PATCH v6 14/16] PCI/AER: Introduce ratelimit for error logs

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 09:59:29PM -0700, Sathyanarayanan Kuppuswamy wrote: > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > From: Jon Pan-Doh > > > > Spammy devices can flood kernel logs with AER errors and slow/stall > > execution. Add per-device ratelimits for AER correctable and uncorrectable >

[PATCH V4 06/16] powerpc/perf: Remove driver-specific throttle support

2025-05-20 Thread kan . liang
From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by:

Re: [PATCH v6 16/16] PCI/AER: Add sysfs attributes for log ratelimits

2025-05-20 Thread Bjorn Helgaas
On Tue, May 20, 2025 at 03:02:06PM +0300, Ilpo Järvinen wrote: > On Mon, 19 May 2025, Bjorn Helgaas wrote: > > > From: Jon Pan-Doh > > > > Allow userspace to read/write log ratelimits per device (including > > enable/disable). Create aer/ sysfs directory to store them and any > > future aer conf

Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-20 Thread Sathyanarayanan Kuppuswamy
On 5/19/25 7:41 AM, Hans Zhang wrote: On 2025/5/19 22:21, Hans Zhang wrote: On 2025/5/17 02:10, Sathyanarayanan Kuppuswamy wrote: On 5/16/25 9:55 AM, Hans Zhang wrote: The following series introduces a new kernel command-line option aer_panic to enhance error handling for PCIe Advanced

Re: [PATCH v5 4/4] tpm/tpm_svsm: support TPM_CHIP_FLAG_SYNC

2025-05-20 Thread Stefano Garzarella
On Thu, 15 May 2025 at 03:45, Jarkko Sakkinen wrote: > > On Wed, May 14, 2025 at 03:46:30PM +0200, Stefano Garzarella wrote: > > From: Stefano Garzarella > > > > This driver does not support interrupts, and receiving the response is > > synchronous with sending the command. > > > > Enable synchro

Re: [PATCH 0/4] pci: implement "pci=aer_panic"

2025-05-20 Thread Hans Zhang
On 2025/5/20 06:03, Bjorn Helgaas wrote: On Sat, May 17, 2025 at 12:55:14AM +0800, Hans Zhang wrote: The following series introduces a new kernel command-line option aer_panic to enhance error handling for PCIe Advanced Error Reporting (AER) in mission-critical environments. This feature ensu

Re: [PATCH v6 12/16] PCI/AER: Make all pci_print_aer() log levels depend on error type

2025-05-20 Thread Bjorn Helgaas
On Tue, May 20, 2025 at 02:37:33PM +0300, Ilpo Järvinen wrote: > On Mon, 19 May 2025, Bjorn Helgaas wrote: > > > From: Karolina Stolarek > > > > Some existing logs in pci_print_aer() log with error severity by default. > > Convert them to depend on error type (consistent with rest of AER logging

Re: [PATCH v6 11/16] PCI/AER: Check log level once and remember it

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 11:17:28PM +, Weinan Liu wrote: > > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c > > index 315bf2bfd570..34af0ea45c0d 100644 > > --- a/drivers/pci/pcie/dpc.c > > +++ b/drivers/pci/pcie/dpc.c > > @@ -252,6 +252,7 @@ static int dpc_get_aer_uncorrect_severit

Re: [PATCH v6 08/16] PCI/AER: Simplify pci_print_aer()

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 05:02:28PM -0700, Sathyanarayanan Kuppuswamy wrote: > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Simplify pci_print_aer() by initializing the struct aer_err_info "info" > > with a designated initializer list (it was previously initialized with

Re: [PATCH v6 07/16] PCI/AER: Initialize aer_err_info before using it

2025-05-20 Thread Bjorn Helgaas
On Tue, May 20, 2025 at 01:39:06PM +0300, Ilpo Järvinen wrote: > On Mon, 19 May 2025, Bjorn Helgaas wrote: > > > From: Bjorn Helgaas > > > > Previously the struct aer_err_info "e_info" was allocated on the stack > > without being initialized, so it contained junk except for the fields we > > exp

Re: [PATCH v6 03/16] PCI/AER: Consolidate Error Source ID logging in aer_print_port_info()

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 04:39:19PM -0700, Sathyanarayanan Kuppuswamy wrote: > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Previously we decoded the AER Error Source ID in two places. Consolidate > > them so both places use aer_print_port_info(). Add a "details" para

Re: [PATCH v6 02/16] PCI/DPC: Log Error Source ID only when valid

2025-05-20 Thread Ilpo Järvinen
On Tue, 20 May 2025, Bjorn Helgaas wrote: > On Mon, May 19, 2025 at 04:15:56PM -0700, Sathyanarayanan Kuppuswamy wrote: > > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > > From: Bjorn Helgaas > > > > > > DPC Error Source ID is only valid when the DPC Trigger Reason indicates > > > that DPC was tr

Re: [PATCH v6 02/16] PCI/DPC: Log Error Source ID only when valid

2025-05-20 Thread Bjorn Helgaas
On Tue, May 20, 2025 at 01:28:02PM +0300, Ilpo Järvinen wrote: > On Mon, 19 May 2025, Bjorn Helgaas wrote: > > DPC Error Source ID is only valid when the DPC Trigger Reason indicates > > that DPC was triggered due to reception of an ERR_NONFATAL or ERR_FATAL > > Message (PCIe r6.0, sec 7.9.14.5). >

Re: [PATCH v6 01/16] PCI/DPC: Initialize aer_err_info before using it

2025-05-20 Thread Bjorn Helgaas
On Tue, May 20, 2025 at 12:39:18PM +0300, Ilpo Järvinen wrote: > On Mon, 19 May 2025, Bjorn Helgaas wrote: > > > From: Bjorn Helgaas > > > > Previously the struct aer_err_info "info" was allocated on the stack > > without being initialized, so it contained junk except for the fields we > > expli

Re: [PATCH v6 02/16] PCI/DPC: Log Error Source ID only when valid

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 04:15:56PM -0700, Sathyanarayanan Kuppuswamy wrote: > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > DPC Error Source ID is only valid when the DPC Trigger Reason indicates > > that DPC was triggered due to reception of an ERR_NONFATAL or ERR_FATA

Re: [PATCH v6 01/16] PCI/DPC: Initialize aer_err_info before using it

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 03:41:50PM -0700, Sathyanarayanan Kuppuswamy wrote: > Hi, > > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Previously the struct aer_err_info "info" was allocated on the stack > > /s/Previously/Currently ? I prefer "previously" here because i

[PATCH v6 11/16] PCI/AER: Check log level once and remember it

2025-05-20 Thread Weinan Liu
> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c > index 315bf2bfd570..34af0ea45c0d 100644 > --- a/drivers/pci/pcie/dpc.c > +++ b/drivers/pci/pcie/dpc.c > @@ -252,6 +252,7 @@ static int dpc_get_aer_uncorrect_severity(struct pci_dev > *dev, > else > info->severity = AER_NONFATAL

Re: [PATCH v6 03/16] PCI/AER: Consolidate Error Source ID logging in aer_print_port_info()

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Previously we decoded the AER Error Source ID in two places. Consolidate > them so both places use aer_print_port_info(). Add a "details" parameter > so we can add a note when we didn't find any downstream devices with errors

Re: [PATCH v6 16/16] PCI/AER: Add sysfs attributes for log ratelimits

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Jon Pan-Doh > > Allow userspace to read/write log ratelimits per device (including > enable/disable). Create aer/ sysfs directory to store them and any > future aer configs. > > Update AER sysfs ABI filename to reflect the broader scope of AER s

Re: [PATCH v6 14/16] PCI/AER: Introduce ratelimit for error logs

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Jon Pan-Doh > > Spammy devices can flood kernel logs with AER errors and slow/stall > execution. Add per-device ratelimits for AER correctable and uncorrectable > errors that use the kernel defaults (10 per 5s). > > There are two AER logging ent

[PATCH 0/6] Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Ai Chao
This patch series introduces wrapper functions for_each_child_of_node_scoped(). The for_each_child_of_node_scoped() helper provides a scope-based clean-up functionality to put the device_node automatically, and as such, there is no need to call of_node_put() directly. Thus, use this helper to si

Re: [PATCH v6 02/16] PCI/DPC: Log Error Source ID only when valid

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > DPC Error Source ID is only valid when the DPC Trigger Reason indicates > that DPC was triggered due to reception of an ERR_NONFATAL or ERR_FATAL > Message (PCIe r6.0, sec 7.9.14.5). > > When DPC was triggered by ERR_NONFATAL (

Re: [PATCH v6 13/16] PCI/AER: Rename struct aer_stats to aer_report

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Karolina Stolarek > > Update name to reflect the broader definition of structs/variables that are > stored (e.g. ratelimits). This is a preparatory patch for adding rate limit > support. > > Link: https://lore.kernel.org/r/20250321015806.954866-

Re: [PATCH 6/6] ASoC: qcom: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Krzysztof Kozlowski
On 20/05/2025 11:11, Ai Chao wrote: > The for_each_child_of_node_scoped() helper provides a scope-based > clean-up functionality to put the device_node automatically, and > as such, there is no need to call of_node_put() directly. I do not see any of_node_put() there, so I don't understand what i

Re: [PATCH 2/4 v2] PCI/AER: Modify pci_print_aer() to take log level

2025-05-20 Thread Jonathan Cameron
On Tue, 29 Apr 2025 19:21:07 +0200 "Fabio M. De Francesco" wrote: > Modify pci_print_aer() to take a printk() log level in preparation of a > patch that logs PCIe Components and Link errors from ELOG. > > Cc: Dan Williams > Acked-by: Bjorn Helgaas > Signed-off-by: Fabio M. De Francesco Fair e

[PATCH 4/6] ASoC: meson: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Ai Chao
The for_each_child_of_node_scoped() helper provides a scope-based clean-up functionality to put the device_node automatically, and as such, there is no need to call of_node_put() directly. Thus, use this helper to simplify the code. Signed-off-by: Ai Chao --- sound/soc/meson/axg-card.c

Re: [PATCH v6 12/16] PCI/AER: Make all pci_print_aer() log levels depend on error type

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Karolina Stolarek > > Some existing logs in pci_print_aer() log with error severity by default. > Convert them to depend on error type (consistent with rest of AER logging). > > Link: https://lore.kernel.org/r/20250321015806.954866-3-pan...@goog

Re: [PATCH 1/4 v2] ACPI: extlog: Trace CPER Non-standard Section Body

2025-05-20 Thread Jonathan Cameron
On Tue, 29 Apr 2025 19:21:06 +0200 "Fabio M. De Francesco" wrote: > ghes_do_proc() has a catch-all for unknown or unhandled CPER formats > (UEFI v2.10 Appendix N 2.3), extlog_print() does not. This gap was > noticed by a RAS test that injected CXL protocol errors which were > notified to extlog_p

Re: [PATCH v6 11/16] PCI/AER: Check log level once and remember it

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Karolina Stolarek > > When reporting an AER error, we check its type multiple times to determine > the log level for each message. Do this check only in the top-level > functions (aer_isr_one_error(), pci_print_aer()) and save the level in > stru

[PATCH 5/6] ASoC: imx-card: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Ai Chao
The for_each_child_of_node_scoped() helper provides a scope-based clean-up functionality to put the device_node automatically, and as such, there is no need to call of_node_put() directly. Thus, use this helper to simplify the code. Signed-off-by: Ai Chao --- sound/soc/fsl/imx-card.c | 13 +

Re: [PATCH v6 10/16] PCI/AER: Combine trace_aer_event() with statistics updates

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > As with the AER statistics, we always want to emit trace events, even if > the actual dmesg logging is rate limited. > > Call trace_aer_event() directly from pci_dev_aer_stats_incr(), where we > update the statistics. > > Sign

[PATCH 3/6] ASoC: renesas: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Ai Chao
The for_each_child_of_node_scoped() helper provides a scope-based clean-up functionality to put the device_node automatically, and as such, there is no need to call of_node_put() directly. Thus, use this helper to simplify the code. Signed-off-by: Ai Chao --- sound/soc/renesas/rcar/core.c | 39

Re: [PATCH v6 09/16] PCI/AER: Update statistics early in logging

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > There are two AER logging entry points: > > - aer_print_error() is used by DPC (dpc_process_error()) and native AER > handling (aer_process_err_devices()). > > - pci_print_aer() is used by GHES (aer_recover_work_func()

Re: [PATCH v2] powerpc: Fix struct termio related ioctl macros

2025-05-20 Thread Michael Ellerman
Madhavan Srinivasan writes: > Since termio interface is now obsolete, include/uapi/asm/ioctls.h > has some constant macros referring to "struct termio", this caused > build failure at userspace. > > In file included from /usr/include/asm/ioctl.h:12, > from /usr/include/asm/ioctls.

Re: [PATCH] Documentation: embargoed-hardware-issues.rst: Remove myself

2025-05-20 Thread Greg KH
On Tue, May 20, 2025 at 08:28:55PM +1000, Michael Ellerman wrote: > I'm no longer able to perform this role since I left IBM. > > Signed-off-by: Michael Ellerman > --- > Documentation/process/embargoed-hardware-issues.rst | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/pro

[PATCH 1/6] ASoC: ppc: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Ai Chao
The for_each_child_of_node_scoped() helper provides a scope-based clean-up functionality to put the device_node automatically, and as such, there is no need to call of_node_put() directly. Thus, use this helper to simplify the code. Signed-off-by: Ai Chao --- sound/ppc/tumbler.c | 5 ++--- 1 fi

[PATCH 2/6] ASoC: aoa: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Ai Chao
The for_each_child_of_node_scoped() helper provides a scope-based clean-up functionality to put the device_node automatically, and as such, there is no need to call of_node_put() directly. Thus, use this helper to simplify the code. Signed-off-by: Ai Chao --- sound/aoa/soundbus/i2sbus/core.c |

[PATCH 6/6] ASoC: qcom: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Ai Chao
The for_each_child_of_node_scoped() helper provides a scope-based clean-up functionality to put the device_node automatically, and as such, there is no need to call of_node_put() directly. Thus, use this helper to simplify the code. Signed-off-by: Ai Chao --- sound/soc/qcom/lpass-cpu.c |

Re: [PATCH v6 06/16] PCI/AER: Move aer_print_source() earlier in file

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Move aer_print_source() earlier in the file so a future change can use it > from aer_print_error(), where it's easier to rate limit it. > > Signed-off-by: Bjorn Helgaas > --- > drivers/pci/pcie/aer.c | 24

Re: [PATCH v6 08/16] PCI/AER: Simplify pci_print_aer()

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Simplify pci_print_aer() by initializing the struct aer_err_info "info" > with a designated initializer list (it was previously initialized with > memset()) and using pci_name(). > > Signed-off-by: Bjorn Helgaas > --- > drive

Re: [PATCH v6 04/16] PCI/AER: Extract bus/dev/fn in aer_print_port_info() with PCI_BUS_NUM(), etc

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Use PCI_BUS_NUM(), PCI_SLOT(), PCI_FUNC() to extract the bus number, > device, and function number directly from the Error Source ID. There's no > need to shift and mask it explicitly. > > Signed-off-by: Bjorn Helgaas > --- >

Re: [PATCH v6 07/16] PCI/AER: Initialize aer_err_info before using it

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Previously the struct aer_err_info "e_info" was allocated on the stack > without being initialized, so it contained junk except for the fields we > explicitly set later. > > Initialize "e_info" at declaration with a designated

Re: [PATCH v6 05/16] PCI/AER: Rename aer_print_port_info() to aer_print_source()

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Jon Pan-Doh > > Rename aer_print_port_info() to aer_print_source() to be more descriptive. > This logs the Error Source ID logged by a Root Port or Root Complex Event > Collector when it receives an ERR_COR, ERR_NONFATAL, or ERR_FATAL Message. >

[PATCH] Documentation: embargoed-hardware-issues.rst: Remove myself

2025-05-20 Thread Michael Ellerman
I'm no longer able to perform this role since I left IBM. Signed-off-by: Michael Ellerman --- Documentation/process/embargoed-hardware-issues.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/process/embargoed-hardware-issues.rst b/Documentation/process/embargoed-hardware-iss

Re: [PATCH v6 01/16] PCI/DPC: Initialize aer_err_info before using it

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Previously the struct aer_err_info "info" was allocated on the stack > without being initialized, so it contained junk except for the fields we > explicitly set later. > > Initialize "info" at declaration so it starts as all ze

Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

2025-05-20 Thread Andi Shyti
Hi Wolfram, On Tue, May 20, 2025 at 11:15:21AM +0200, Wolfram Sang wrote: > > > I took this patch in i2c/i2c-host. Please let me know if you want > > me to take also the others. > > To avoid the dependency with your PR, is it okay if you drop it and I > take this patch via my tree? yes, sure! I

Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

2025-05-20 Thread Wolfram Sang
> I took this patch in i2c/i2c-host. Please let me know if you want > me to take also the others. To avoid the dependency with your PR, is it okay if you drop it and I take this patch via my tree? signature.asc Description: PGP signature

Re: [PATCH v6 00/16] Rate limit AER logs

2025-05-20 Thread Krzysztof Wilczyński
Hello, > This work is mostly due to Jon Pan-Doh and Karolina Stolarek. I rebased > this to v6.15-rc1, factored out some of the trace and statistics updates, > and added some minor cleanups. > > Proposal > > > When using native AER, spammy devices can flood kernel logs with AER errors >