Re: [PATCH v4 1/5] PCI/ERR: Remove misleading TODO regarding kernel panic

2025-05-08 Thread Manivannan Sadhasivam
On Fri, May 09, 2025 at 02:11:00PM +0800, Ethan Zhao wrote: > > > On 5/8/2025 3:10 PM, Manivannan Sadhasivam wrote: > > A PCI device is just another peripheral in a system. So failure to > > recover it, must not result in a kernel panic. So remove the TODO which > > is quite misleading. > > > Co

Re: [PATCH v4 1/5] PCI/ERR: Remove misleading TODO regarding kernel panic

2025-05-08 Thread Wilfred Mallawa
On Thu, 2025-05-08 at 12:40 +0530, Manivannan Sadhasivam wrote: > A PCI device is just another peripheral in a system. So failure to > recover it, must not result in a kernel panic. So remove the TODO > which > is quite misleading. > > Signed-off-by: Manivannan Sadhasivam > Reviewed-by: Wilfred M

Re: [PATCH v4 2/5] PCI/ERR: Add support for resetting the slots in a platform specific way

2025-05-08 Thread Wilfred Mallawa
On Thu, 2025-05-08 at 12:40 +0530, Manivannan Sadhasivam wrote: > Some host bridge devices require resetting the slots in a platform > specific > way to recover them from error conditions such as Fatal AER errors, > Link > Down etc... So introduce pci_host_bridge::reset_slot callback and > call it

Re: [PATCH v7 net-next 00/14] Add more features for ENETC v4 - round 2

2025-05-08 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 6 May 2025 16:07:21 +0800 you wrote: > This patch set adds the following features. > 1. Compared with ENETC v1, the formats of tables and command BD of ENETC > v4 have changed significantly, and the two are

Re: [PATCH v3 1/4] tpm: add buf_size parameter in the .send callback

2025-05-08 Thread Jarkko Sakkinen
On Tue, May 06, 2025 at 02:56:54PM +0200, Stefano Garzarella wrote: > On Wed, Apr 30, 2025 at 06:39:58PM +0300, Jarkko Sakkinen wrote: > > On Mon, Apr 14, 2025 at 04:56:50PM +0200, Stefano Garzarella wrote: > > > From: Stefano Garzarella > > > > > > In preparation for the next commit, add a new `

Re: [PATCH v4 07/13] crypto: riscv/sha256 - implement library instead of shash

2025-05-08 Thread Eric Biggers
On Thu, May 08, 2025 at 10:45:39AM -0700, Palmer Dabbelt wrote: > > Acked-by: Palmer Dabbelt > > I assume you want to keep these all together somewhere, so I'm going to > drop it from the RISC-V patchwork. Thanks! Yes, this series was already applied to "cryptodev" (https://git.kernel.org/pub

Re: [PATCH v4 07/13] crypto: riscv/sha256 - implement library instead of shash

2025-05-08 Thread Palmer Dabbelt
On Mon, 28 Apr 2025 10:00:32 PDT (-0700), ebigg...@kernel.org wrote: > From: Eric Biggers > > Instead of providing crypto_shash algorithms for the arch-optimized > SHA-256 code, instead implement the SHA-256 library. This is much > simpler, it makes the SHA-256 library functions be arch-optimized

Re: [kvm-unit-tests PATCH v3 08/16] scripts: Add 'kvmtool_params' to test definition

2025-05-08 Thread Alexandru Elisei
Hi Drew, On Wed, May 07, 2025 at 06:28:04PM +0200, Andrew Jones wrote: > On Wed, May 07, 2025 at 04:12:48PM +0100, Alexandru Elisei wrote: > > arm/arm64 supports running tests under kvmtool, but kvmtool's syntax for > > running and configuring a virtual machine is different to qemu. To run > > tes

Re: [PATCH] dt-bindings: soc: fsl,qman-fqd: Fix reserved-memory.yaml reference

2025-05-08 Thread Conor Dooley
On Wed, May 07, 2025 at 10:42:31AM -0500, Rob Herring (Arm) wrote: > The reserved-memory.yaml reference needs the full path. No warnings were > generated because the example has the wrong compatible string, so fix > that too. > > Fixes: 304a90c4f75d ("dt-bindings: soc: fsl: Convert q(b)man-* to ya

[PATCH v4 3/6] iio: fix potential out-of-bound write

2025-05-08 Thread Markus Burri
The buffer is set to 20 characters. If a caller write more characters, count is truncated to the max available space in "simple_write_to_buffer". To protect from OoB access, check that the input size fit into buffer and add a zero terminator after copy to the end of the copied data. Signed-off-by:

[PATCH v4 6/6] powerpc/eeh-powernv: fix potential OoB

2025-05-08 Thread Markus Burri
The buffer is set to 50 characters. If a caller write more characters, count is truncated to the max available space in "simple_write_to_buffer". To protect from OoB access, check that the input size fit into buffer and add a zero terminator after copy to the end of the copied data. Signed-off-by:

[PATCH v4 4/6] gpio: fix potential out-of-bound write

2025-05-08 Thread Markus Burri
Check that the input size does not exceed the buffer size. If a caller write more characters, count is truncated to the max available space in "simple_write_to_buffer". Write a zero termination afterwards. Signed-off-by: Markus Burri --- drivers/gpio/gpio-virtuser.c | 12 ++-- 1 file cha

[PATCH v4 2/6] accel/ivpu: Use effective buffer size for zero terminator

2025-05-08 Thread Markus Burri
Use the effective written size instead of original size as index for zero termination. If the input from user-space is to larger and the input is truncated, the original size is out-of-bound. Since there is an upfront size check here, the change is for consistency. Signed-off-by: Markus Burri ---

[PATCH v4 0/6] Fix potential out-of-bounds error in some drivers

2025-05-08 Thread Markus Burri
Several drivers are using debugfs and follow the same pattern. A buffer is created on the stack with a limited size to copy the given data from user space. The copy is performed using simple_write_to_buffer. This function limits the input according to the specified buffer size, but it does not wri

[PATCH v4 5/6] powerpc/eeh: fix potential OoB

2025-05-08 Thread Markus Burri
The buffer is set to 20 characters. If a caller write more characters, count is truncated to the max available space in "simple_write_to_buffer". To protect from OoB access, check that the input size fit into buffer and add a zero terminator after copy to the end of the copied data. Signed-off-by:

[PATCH v4 1/6] iio: backend: fix out-of-bound write

2025-05-08 Thread Markus Burri
The buffer is set to 80 character. If a caller write more characters, count is truncated to the max available space in "simple_write_to_buffer". But afterwards a string terminator is written to the buffer at offset count without boundary check. The zero termination is written OUT-OF-BOUND. Add a c

Re: [linux-next-20250320][btrfs] Kernel OOPs while running btrfs/108

2025-05-08 Thread Venkat Rao Bagalkote
On 07/05/25 7:44 pm, David Sterba wrote: On Wed, May 07, 2025 at 02:04:47PM +0100, Filipe Manana wrote: On Wed, May 7, 2025 at 10:02 AM Venkat wrote: +Disha, Hello Qu, I still see this failure on next-20250505. May I know, when will this be fixed. The two patches pointed out before by Qu

Re: [kvm-unit-tests PATCH v3 03/16] configure: Export TARGET unconditionally

2025-05-08 Thread Andrew Jones
On Thu, May 08, 2025 at 11:05:32AM +0100, Alexandru Elisei wrote: > Hi Drew, > > On Thu, May 08, 2025 at 11:39:54AM +0200, Andrew Jones wrote: > > On Thu, May 08, 2025 at 09:52:38AM +0100, Alexandru Elisei wrote: > > > Hi Drew, > > > > > > On Wed, May 07, 2025 at 06:02:31PM +0200, Andrew Jones wr

Re: [kvm-unit-tests PATCH v3 03/16] configure: Export TARGET unconditionally

2025-05-08 Thread Alexandru Elisei
Hi Drew, On Thu, May 08, 2025 at 11:39:54AM +0200, Andrew Jones wrote: > On Thu, May 08, 2025 at 09:52:38AM +0100, Alexandru Elisei wrote: > > Hi Drew, > > > > On Wed, May 07, 2025 at 06:02:31PM +0200, Andrew Jones wrote: > > > On Wed, May 07, 2025 at 04:12:43PM +0100, Alexandru Elisei wrote: > >

Re: [kvm-unit-tests PATCH v3 03/16] configure: Export TARGET unconditionally

2025-05-08 Thread Andrew Jones
On Thu, May 08, 2025 at 09:52:38AM +0100, Alexandru Elisei wrote: > Hi Drew, > > On Wed, May 07, 2025 at 06:02:31PM +0200, Andrew Jones wrote: > > On Wed, May 07, 2025 at 04:12:43PM +0100, Alexandru Elisei wrote: > > > Only arm and arm64 are allowed to set --target to kvmtool; the rest of the > >

Re: [kvm-unit-tests PATCH v3 03/16] configure: Export TARGET unconditionally

2025-05-08 Thread Alexandru Elisei
Hi Drew, On Wed, May 07, 2025 at 06:02:31PM +0200, Andrew Jones wrote: > On Wed, May 07, 2025 at 04:12:43PM +0100, Alexandru Elisei wrote: > > Only arm and arm64 are allowed to set --target to kvmtool; the rest of the > > architectures can only set --target to 'qemu', which is also the default. >

Re: [PATCH v3 5/5] PCI: qcom: Add support for resetting the slot due to link down event

2025-05-08 Thread Manivannan Sadhasivam
On Thu, Apr 24, 2025 at 10:31:00AM +0530, Manivannan Sadhasivam wrote: > On Fri, Apr 18, 2025 at 08:11:47AM +0530, Krishna Chaitanya Chundru wrote: > > > > > > On 4/17/2025 10:46 PM, Manivannan Sadhasivam via B4 Relay wrote: > > > From: Manivannan Sadhasivam > > > > > > The PCIe link can go dow

Re: [PATCH v3 0/9] module: Introduce hash-based integrity checking

2025-05-08 Thread Fabian Grünbichler
On May 7, 2025 6:41 pm, James Bottomley wrote: > On Wed, 2025-05-07 at 09:47 +0200, Arnout Engelen wrote: >> On Tue, May 6, 2025, at 15:24, James Bottomley wrote: >> > I'll repeat the key point again: all modern hermetic build systems >> > come with provenance which is usually a signature. >> >> I

Re: [PATCH v4 2/5] PCI/ERR: Add support for resetting the slots in a platform specific way

2025-05-08 Thread Lukas Wunner
On Thu, May 08, 2025 at 12:40:31PM +0530, Manivannan Sadhasivam wrote: > Some host bridge devices require resetting the slots in a platform specific > way to recover them from error conditions such as Fatal AER errors, Link > Down etc... So introduce pci_host_bridge::reset_slot callback and call it

[PATCH v4 1/5] PCI/ERR: Remove misleading TODO regarding kernel panic

2025-05-08 Thread Manivannan Sadhasivam
A PCI device is just another peripheral in a system. So failure to recover it, must not result in a kernel panic. So remove the TODO which is quite misleading. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/pcie/err.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pcie/err.

[PATCH v4 5/5] PCI: qcom: Add support for resetting the slot due to link down event

2025-05-08 Thread Manivannan Sadhasivam
The PCIe link can go down under circumstances such as the device firmware crash, link instability, etc... When that happens, the PCIe slot needs to be reset to make it operational again. Currently, the driver is not handling the link down event, due to which the users have to restart the machine to

[PATCH v4 4/5] PCI: host-common: Add link down handling for host bridges

2025-05-08 Thread Manivannan Sadhasivam
The PCI link, when down, needs to be recovered to bring it back. But that cannot be done in a generic way as link recovery procedure is specific to host bridges. So add a new API pci_host_handle_link_down() that could be called by the host bridge drivers when the link goes down. The API will itera

[PATCH v4 0/5] PCI: Add support for resetting the slots in a platform specific way

2025-05-08 Thread Manivannan Sadhasivam
Hi, Currently, in the event of AER/DPC, PCI core will try to reset the slot and its subordinate devices by invoking bridge control reset and FLR. But in some cases like AER Fatal error, it might be necessary to reset the slots using the PCI host bridge drivers in a platform specific way (as indica

[PATCH v4 3/5] PCI: host-common: Make the driver as a common library for host controller drivers

2025-05-08 Thread Manivannan Sadhasivam
This common library will be used as a placeholder for helper functions shared by the host controller drivers. This avoids placing the host controller drivers specific helpers in drivers/pci/*.c, to avoid enlarging the kernel Image on platforms that do not use host controller drivers at all (like x8

[PATCH v4 2/5] PCI/ERR: Add support for resetting the slots in a platform specific way

2025-05-08 Thread Manivannan Sadhasivam
Some host bridge devices require resetting the slots in a platform specific way to recover them from error conditions such as Fatal AER errors, Link Down etc... So introduce pci_host_bridge::reset_slot callback and call it from pcibios_reset_secondary_bus() if available. The 'reset_slot' callback

[PATCH v1] powerpc/eeh: Fix missing PE bridge reconfiguration during VFIO EEH recovery

2025-05-08 Thread Narayana Murty N
VFIO EEH recovery for PCI passthrough devices fails on PowerNV and pseries platforms due to missing host-side PE bridge reconfiguration. In the current implementation, eeh_pe_configure() only performs RTAS or OPAL-based bridge reconfiguration for native host devices, but skips it entirely for PEs m