Re: [PATCH] dt-bindings: soc: fsl,ls1028a-reset: Drop extra "/" in $id

2025-05-07 Thread Krzysztof Kozlowski
On Wed, May 07, 2025 at 04:59:02PM GMT, Rob Herring (Arm) wrote: > The $id value has a double "//". Drop it. > > Signed-off-by: Rob Herring (Arm) Fixes: 9ca5a7d9d2e0 ("dt-bindings: soc: fsl: Add fsl,ls1028a-reset for reset syscon node") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 3/6] powerpc: fadump: use lock guard for mutex

2025-05-07 Thread Sourabh Jain
On 05/05/25 13:23, Shrikanth Hegde wrote: use scoped_guard for scope based resource management of mutex. This would make the code simpler and easier to maintain. More details on lock guards can be found at https://lore.kernel.org/all/20230612093537.614161...@infradead.org/T/#u Reviewed-by: S

[powerpc:next] BUILD SUCCESS 03c9d1a5a30d93bff31b4eb0a52f030b4c7f73ea

2025-05-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next branch HEAD: 03c9d1a5a30d93bff31b4eb0a52f030b4c7f73ea Documentation: Fix description format for powerpc RTAS ioctls elapsed time: 8636m configs tested: 217 configs skipped: 3 The following configs have been bu

Re: [PATCH net-next] net: ibmveth: Refactored veth_pool_store for better maintainability

2025-05-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 6 May 2025 11:00:04 -0500 you wrote: > Make veth_pool_store detect requested pool changes, close device if > necessary, update pool, and reopen device. > > Signed-off-by: Dave Marquardt > --- > drivers/net

[powerpc:merge] BUILD SUCCESS ee74be3b5209b3ad646793c099499c528c57b241

2025-05-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git merge branch HEAD: ee74be3b5209b3ad646793c099499c528c57b241 Automatic merge of 'next' into merge (2025-05-04 08:44) elapsed time: 4157m configs tested: 106 configs skipped: 1 The following configs have been built s

Re: [PATCH] dt-bindings: soc: fsl,ls1028a-reset: Drop extra "/" in $id

2025-05-07 Thread Rob Herring (Arm)
On Wed, 07 May 2025 16:59:02 -0500, Rob Herring (Arm) wrote: > The $id value has a double "//". Drop it. > > Signed-off-by: Rob Herring (Arm) > --- > .../devicetree/bindings/soc/fsl/fsl,ls1028a-reset.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > My bot found errors

[PATCH] dt-bindings: soc: fsl,ls1028a-reset: Drop extra "/" in $id

2025-05-07 Thread Rob Herring (Arm)
The $id value has a double "//". Drop it. Signed-off-by: Rob Herring (Arm) --- .../devicetree/bindings/soc/fsl/fsl,ls1028a-reset.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/soc/fsl/fsl,ls1028a-reset.yaml b/Documentation/dev

Re: [next-20250506][btrfs] Kernel OOPS while btrfs/001 TC

2025-05-07 Thread Al Viro
On Wed, May 07, 2025 at 09:05:42PM +0530, Venkat Rao Bagalkote wrote: > > I am observing kernel OOPS, while running btrfs/001 TC, from xfstests > > suite. > > > > > > This issue is introduced in next-20250506. This issue is not seen on > > next-20250505 kernel. Braino in fs/btrfs/super.c patch

Re: [linux-next-20250320][btrfs] Kernel OOPs while running btrfs/108

2025-05-07 Thread Filipe Manana
On Wed, May 7, 2025 at 10:02 AM Venkat wrote: > > +Disha, > > Hello Qu, > > I still see this failure on next-20250505. > > May I know, when will this be fixed. The two patches pointed out before by Qu are still being added to linux-next. Qu reported this on the thread for the patches: https://lo

Re: [PATCH v3 0/9] module: Introduce hash-based integrity checking

2025-05-07 Thread James Bottomley
On Wed, 2025-05-07 at 09:47 +0200, Arnout Engelen wrote: > On Tue, May 6, 2025, at 15:24, James Bottomley wrote: > > I'll repeat the key point again: all modern hermetic build systems > > come with provenance which is usually a signature. > > I'm not sure the 'hermetic build' parallel is so applic

Re: [next-20250506][btrfs] Kernel OOPS while btrfs/001 TC

2025-05-07 Thread David Sterba
On Wed, May 07, 2025 at 02:14:34PM +0530, Venkat Rao Bagalkote wrote: > Hello, > > > I am observing kernel OOPS, while running btrfs/001 TC, from xfstests suite. > > > This issue is introduced in next-20250506. This issue is not seen on > next-20250505 kernel. Thanks for the report, the patch

Re: [kvm-unit-tests PATCH v3 16/16] scripts: Enable kvmtool

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:56PM +0100, Alexandru Elisei wrote: > Everything is in place to run the tests using kvmtool: > > $ ./configure --target=kvmtool > $ make clean && make > $ KVMTOOL= ./run_tests.sh > > so enable it, and remove ERRATA_FORCE=y when configuring for kvmtool, > because the

Re: [kvm-unit-tests PATCH v3 15/16] scripts: Add 'disabled_if' test definition parameter for kvmtool to use

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:55PM +0100, Alexandru Elisei wrote: > The pci-test is qemu specific. Other tests perform migration, which > isn't supported by kvmtool. In general, kvmtool is not as feature-rich > as qemu, so add a new unittest parameter, 'disabled_if', that causes a > test to be skip

Re: [kvm-unit-tests PATCH v3 13/16] scripts: Do not probe for maximum number of VCPUs when using kvmtool

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:53PM +0100, Alexandru Elisei wrote: > The --probe-maxsmp parameter updates MAX_SMP with the maximum number of > VCPUs that the host supports. Qemu will exit with an error when creating a > virtual machine if the number of VCPUs is exceeded. > > kvmtool behaves differe

Re: [kvm-unit-tests PATCH v3 12/16] scripts: Detect kvmtool failure in premature_failure()

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:52PM +0100, Alexandru Elisei wrote: > kvm-unit-tests assumes that if the VMM is able to get to where it tries to > load the kernel, then the VMM and the configuration parameters will also > work for running the test. All of this is done in premature_failure(). > > Tea

Re: [kvm-unit-tests PATCH v3 11/16] scripts: Add KVMTOOL environment variable for kvmtool binary path

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:51PM +0100, Alexandru Elisei wrote: > kvmtool is often used for prototyping new features, and a developer might > not want to install it system-wide. Add a KVMTOOL environment variable to > make it easier for tests to use a binary not in $PATH. > > Signed-off-by: Alex

Re: [kvm-unit-tests PATCH v3 10/16] scripts: Add default arguments for kvmtool

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:50PM +0100, Alexandru Elisei wrote: > kvmtool, unless told otherwise, will do its best to make sure that a kernel > successfully boots in a virtual machine. It does things like automatically > creating a rootfs and adding extra parameters to the kernel command line. >

Re: [kvm-unit-tests PATCH v3 09/16] scripts: Add support for kvmtool

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:49PM +0100, Alexandru Elisei wrote: > Teach the arm runner to use kvmtool when kvm-unit-tests has been configured > appropriately. > > The test is ran using run_test_status(), and a 0 return code (which means > success) is converted to 1, because kvmtool does not have

[PATCH] dt-bindings: soc: fsl,qman-fqd: Fix reserved-memory.yaml reference

2025-05-07 Thread Rob Herring (Arm)
The reserved-memory.yaml reference needs the full path. No warnings were generated because the example has the wrong compatible string, so fix that too. Fixes: 304a90c4f75d ("dt-bindings: soc: fsl: Convert q(b)man-* to yaml format") Signed-off-by: Rob Herring (Arm) --- Documentation/devicetree/b

Re: [kvm-unit-tests PATCH v3 08/16] scripts: Add 'kvmtool_params' to test definition

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:48PM +0100, Alexandru Elisei wrote: > arm/arm64 supports running tests under kvmtool, but kvmtool's syntax for > running and configuring a virtual machine is different to qemu. To run > tests using the automated test infrastructure, add a new test parameter, > 'kvmtool

Re: [kvm-unit-tests PATCH v3 07/16] scripts: Use an associative array for qemu argument names

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:47PM +0100, Alexandru Elisei wrote: > Move away from hardcoded qemu arguments and use instead an associative > array to get the needed arguments. This paves the way for adding kvmtool > support to the scripts, which has a different syntax for the same VM > configuratio

Re: [kvm-unit-tests PATCH v3 06/16] scripts: Refuse to run the tests if not configured for qemu

2025-05-07 Thread Alexandru Elisei
Hi Drew, On Wed, May 07, 2025 at 06:10:08PM +0200, Andrew Jones wrote: > On Wed, May 07, 2025 at 04:12:46PM +0100, Alexandru Elisei wrote: > > Arm and arm64 support running the tests under kvmtool. kvmtool has a > > different command line syntax for configuring and running a virtual > > machine, a

Re: [kvm-unit-tests PATCH v3 06/16] scripts: Refuse to run the tests if not configured for qemu

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:46PM +0100, Alexandru Elisei wrote: > Arm and arm64 support running the tests under kvmtool. kvmtool has a > different command line syntax for configuring and running a virtual > machine, and the automated scripts know only how to use qemu. > > One issue with that is

Re: [kvm-unit-tests PATCH v3 02/16] scripts: Add 'test_args' test definition parameter

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:42PM +0100, Alexandru Elisei wrote: ... > # FPU/SIMD test > @@ -276,17 +291,20 @@ arch = arm64 > [mte-sync] > file = mte.flat > groups = mte > -qemu_params = -machine mte=on -append 'sync' > +test_args=sync add spaces around = > +qemu_params = -machine mte=on >

Re: [kvm-unit-tests PATCH v3 03/16] configure: Export TARGET unconditionally

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:43PM +0100, Alexandru Elisei wrote: > Only arm and arm64 are allowed to set --target to kvmtool; the rest of the > architectures can only set --target to 'qemu', which is also the default. > > Needed to make the changes necessary to add support for kvmtool to the test

[kvm-unit-tests PATCH v3 10/16] scripts: Add default arguments for kvmtool

2025-05-07 Thread Alexandru Elisei
kvmtool, unless told otherwise, will do its best to make sure that a kernel successfully boots in a virtual machine. It does things like automatically creating a rootfs and adding extra parameters to the kernel command line. This is actively harmful to kvm-unit-tests, because some tests parse the k

Re: [PATCH 1/3] powerpc/pseries: Correct secvar format representation for static key management

2025-05-07 Thread Srish Srinivasan
On 5/7/25 11:47 AM, Andrew Donnellan wrote: On Wed, 2025-05-07 at 00:29 +0530, Srish Srinivasan wrote: + rc = plpks_read_fw_var(&var); + if (rc) { + pr_info("Error %ld reading SB_VERSION from firmware\n", rc); We need to check for -ENOENT, otherwise this message is g

Re: [kvm-unit-tests PATCH v3 01/16] scripts: unittests.cfg: Rename 'extra_params' to 'qemu_params'

2025-05-07 Thread Andrew Jones
On Wed, May 07, 2025 at 04:12:41PM +0100, Alexandru Elisei wrote: > The arm and arm64 architectures can also be run with kvmtool, and work is > under way to have it supported by the run_tests.sh test runner. Not > suprisingly, kvmtool's syntax for running a virtual machine is different to > qemu's.

Re: [next-20250506][btrfs] Kernel OOPS while btrfs/001 TC

2025-05-07 Thread Venkat Rao Bagalkote
On 07/05/25 2:14 pm, Venkat Rao Bagalkote wrote: Hello, I am observing kernel OOPS, while running btrfs/001 TC, from xfstests suite. This issue is introduced in next-20250506. This issue is not seen on next-20250505 kernel. Steps to repro: 1. git clone git://git.kernel.org/pub/scm/f

[kvm-unit-tests PATCH v3 13/16] scripts: Do not probe for maximum number of VCPUs when using kvmtool

2025-05-07 Thread Alexandru Elisei
The --probe-maxsmp parameter updates MAX_SMP with the maximum number of VCPUs that the host supports. Qemu will exit with an error when creating a virtual machine if the number of VCPUs is exceeded. kvmtool behaves differently: it will automatically limit the number of VCPUs to the what KVM suppor

[kvm-unit-tests PATCH v3 04/16] run_tests.sh: Document --probe-maxsmp argument

2025-05-07 Thread Alexandru Elisei
Commit 5dd20ec76ea63 ("runtime: Update MAX_SMP probe") added the --probe-maxmp argument, but the help message for run_tests.sh wasn't updated. Document --probe-maxsmp. Reviewed-by: Andrew Jones Signed-off-by: Alexandru Elisei --- run_tests.sh | 17 + 1 file changed, 9 insertions

[kvm-unit-tests PATCH v3 12/16] scripts: Detect kvmtool failure in premature_failure()

2025-05-07 Thread Alexandru Elisei
kvm-unit-tests assumes that if the VMM is able to get to where it tries to load the kernel, then the VMM and the configuration parameters will also work for running the test. All of this is done in premature_failure(). Teach premature_failure() about the kvmtool's error message when it fails to lo

[kvm-unit-tests PATCH v3 00/16] arm/arm64: Add kvmtool to the runner script

2025-05-07 Thread Alexandru Elisei
v2 can be found here [1]. To goal is to allow the user to do: $ ./configure --target=kvmtool $ make clean && make $ ./run_tests.sh to run all the tests automatically with kvmtool. Reasons to use kvmtool: * kvmtool is smaller and a lot easier to hack than qemu, which means developers may prefer

[kvm-unit-tests PATCH v3 01/16] scripts: unittests.cfg: Rename 'extra_params' to 'qemu_params'

2025-05-07 Thread Alexandru Elisei
The arm and arm64 architectures can also be run with kvmtool, and work is under way to have it supported by the run_tests.sh test runner. Not suprisingly, kvmtool's syntax for running a virtual machine is different to qemu's. Add a new unittest parameter, 'qemu_params', with the goal to add a simi

[kvm-unit-tests PATCH v3 08/16] scripts: Add 'kvmtool_params' to test definition

2025-05-07 Thread Alexandru Elisei
arm/arm64 supports running tests under kvmtool, but kvmtool's syntax for running and configuring a virtual machine is different to qemu. To run tests using the automated test infrastructure, add a new test parameter, 'kvmtool_params'. The parameter serves the exact purpose as 'qemu_params', but usi

[kvm-unit-tests PATCH v3 15/16] scripts: Add 'disabled_if' test definition parameter for kvmtool to use

2025-05-07 Thread Alexandru Elisei
The pci-test is qemu specific. Other tests perform migration, which isn't supported by kvmtool. In general, kvmtool is not as feature-rich as qemu, so add a new unittest parameter, 'disabled_if', that causes a test to be skipped if the condition evaluates to true. Signed-off-by: Alexandru Elisei

[kvm-unit-tests PATCH v3 14/16] scripts/mkstandalone: Export $TARGET

2025-05-07 Thread Alexandru Elisei
$TARGET is needed for the test runner to decide if it should use qemu or kvmtool, so export it. Reviewed-by: Andrew Jones Signed-off-by: Alexandru Elisei --- scripts/mkstandalone.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh index 4f666

[kvm-unit-tests PATCH v3 09/16] scripts: Add support for kvmtool

2025-05-07 Thread Alexandru Elisei
Teach the arm runner to use kvmtool when kvm-unit-tests has been configured appropriately. The test is ran using run_test_status(), and a 0 return code (which means success) is converted to 1, because kvmtool does not have a testdev device to return the test exit code, so kvm-unit-tests must alway

[kvm-unit-tests PATCH v3 11/16] scripts: Add KVMTOOL environment variable for kvmtool binary path

2025-05-07 Thread Alexandru Elisei
kvmtool is often used for prototyping new features, and a developer might not want to install it system-wide. Add a KVMTOOL environment variable to make it easier for tests to use a binary not in $PATH. Signed-off-by: Alexandru Elisei --- run_tests.sh | 1 + scripts/arch-run.bash | 3 ++

[kvm-unit-tests PATCH v3 16/16] scripts: Enable kvmtool

2025-05-07 Thread Alexandru Elisei
Everything is in place to run the tests using kvmtool: $ ./configure --target=kvmtool $ make clean && make $ KVMTOOL= ./run_tests.sh so enable it, and remove ERRATA_FORCE=y when configuring for kvmtool, because the runner will generate and pass the correct environment to kvmtool. Missing is supp

[kvm-unit-tests PATCH v3 07/16] scripts: Use an associative array for qemu argument names

2025-05-07 Thread Alexandru Elisei
Move away from hardcoded qemu arguments and use instead an associative array to get the needed arguments. This paves the way for adding kvmtool support to the scripts, which has a different syntax for the same VM configuration parameters. Suggested-by: Andrew Jones Signed-off-by: Alexandru Elisei

[kvm-unit-tests PATCH v3 06/16] scripts: Refuse to run the tests if not configured for qemu

2025-05-07 Thread Alexandru Elisei
Arm and arm64 support running the tests under kvmtool. kvmtool has a different command line syntax for configuring and running a virtual machine, and the automated scripts know only how to use qemu. One issue with that is even though the tests have been configured for kvmtool (with ./configure --t

[kvm-unit-tests PATCH v3 05/16] scripts: Document environment variables

2025-05-07 Thread Alexandru Elisei
Document the environment variables that influence how a test is executed by the run_tests.sh test runner. Suggested-by: Andrew Jones Reviewed-by: Andrew Jones Signed-off-by: Alexandru Elisei --- docs/unittests.txt | 5 - run_tests.sh | 12 +--- 2 files changed, 13 insertions

[kvm-unit-tests PATCH v3 03/16] configure: Export TARGET unconditionally

2025-05-07 Thread Alexandru Elisei
Only arm and arm64 are allowed to set --target to kvmtool; the rest of the architectures can only set --target to 'qemu', which is also the default. Needed to make the changes necessary to add support for kvmtool to the test runner. kvmtool also supports running the riscv tests, so it's not outsi

[kvm-unit-tests PATCH v3 02/16] scripts: Add 'test_args' test definition parameter

2025-05-07 Thread Alexandru Elisei
kvm-unit-tests, on arm and arm64, is getting ready to support running all the test automatically under kvmtool. kvmtool has a different syntax for configuring and running a virtual machine, but what is common between kvmtool and qemu, and any other virtual machine manager that kvm-unit-tests might

Re: [linux-next-20250320][btrfs] Kernel OOPs while running btrfs/108

2025-05-07 Thread David Sterba
On Wed, May 07, 2025 at 02:04:47PM +0100, Filipe Manana wrote: > On Wed, May 7, 2025 at 10:02 AM Venkat wrote: > > > > +Disha, > > > > Hello Qu, > > > > I still see this failure on next-20250505. > > > > May I know, when will this be fixed. > > The two patches pointed out before by Qu are still b

Re: [PATCH] powerpc/pseries/iommu: memory notifier incorrectly adds TCEs for pmemory

2025-05-07 Thread Michal Suchánek
Hello, On Wed, May 07, 2025 at 02:36:57PM +0530, Amit Machhiwal wrote: > Hi Michal, > > I can recreate this issue on sles16 distro kernel but I don't observe this > issue > with upstream Linux 6.15-rc5 on the **same** sles16 guest. > > Note: the commit 6aa989ab2bd0 ("powerpc/pseries/iommu: memo

Re: [PATCH 3/6] powerpc/perf:make isa207_pmu_format_group struct static

2025-05-07 Thread kernel test robot
Hi Madhavan, kernel test robot noticed the following build warnings: [auto build test WARNING on powerpc/next] [also build test WARNING on powerpc/fixes powerpc/topic/ppc-kvm linus/master v6.15-rc5 next-20250507] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3 0/9] module: Introduce hash-based integrity checking

2025-05-07 Thread Arnout Engelen
On Tue, May 6, 2025, at 15:24, James Bottomley wrote: > I'll repeat the key point again: all modern hermetic build systems come > with provenance which is usually a signature. I'm not sure the 'hermetic build' parallel is so applicable here: typically a hermetic build will produce an artifact and

Re: [PATCH 4/6] powerpc: fix sparse warnings

2025-05-07 Thread kernel test robot
Hi Madhavan, kernel test robot noticed the following build warnings: [auto build test WARNING on powerpc/next] [also build test WARNING on powerpc/fixes powerpc/topic/ppc-kvm linus/master v6.15-rc5 next-20250507] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH] powerpc/pseries/iommu: memory notifier incorrectly adds TCEs for pmemory

2025-05-07 Thread Amit Machhiwal
Hi Michal, I can recreate this issue on sles16 distro kernel but I don't observe this issue with upstream Linux 6.15-rc5 on the **same** sles16 guest. Note: the commit 6aa989ab2bd0 ("powerpc/pseries/iommu: memory notifier incorrectly adds TCEs for pmemory") was included since Linux 6.15-rc1. I t

Re: [linux-next-20250320][btrfs] Kernel OOPs while running btrfs/108

2025-05-07 Thread Venkat
+Disha, Hello Qu, I still see this failure on next-20250505. May I know, when will this be fixed. Same traces are seen, while running other Tests also. Disha, Can you please share the details of Test and the traces. Regards, Venkat.

[next-20250506][btrfs] Kernel OOPS while btrfs/001 TC

2025-05-07 Thread Venkat Rao Bagalkote
Hello, I am observing kernel OOPS, while running btrfs/001 TC, from xfstests suite. This issue is introduced in next-20250506. This issue is not seen on next-20250505 kernel. Steps to repro: 1. git clone git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git 2. cd xfstests-dev/ 3. mkdir /m