Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls

On Fri, Feb 21, 2025 at 10:08 AM Mickaël Salaün wrote: > > It looks security checks are missing. With IOCTL commands, file > permissions are checked at open time, but with these syscalls the path > is only resolved but no specific access seems to be checked (except > inode_owner_or_capable via vf

[RFC kvm-unit-tests PATCH] lib: Use __ASSEMBLER__ instead of __ASSEMBLY__

Convert all non-x86 #ifdefs from __ASSEMBLY__ to __ASSEMBLER__, and remove all manual __ASSEMBLY__ #defines. __ASSEMBLY_ was inherited blindly from the Linux kernel, and must be manually defined, e.g. through build rules or with the aforementioned explicit #defines in assembly code. __ASSEMBLER__

Re: [PATCH v2 0/2] PCI: Add support for logging Flit Mode TLPs (PCIe6)

On Fri, Feb 07, 2025 at 06:18:34PM +0200, Ilpo Järvinen wrote: > This series adds support for Flit Mode (PCIe6). > > v2: > - Rebased > > Ilpo Järvinen (2): > PCI: Track Flit Mode Status & print it with link status > PCI: Handle TLP Log in Flit mode > > drivers/pci/hotplug/pciehp_hpc.c | 5

Re: [PATCH v2 1/2] PCI: Track Flit Mode Status & print it with link status

On Fri, Feb 21, 2025 at 10:29:48AM -0500, Yazen Ghannam wrote: > On Fri, Feb 07, 2025 at 06:18:35PM +0200, Ilpo Järvinen wrote: > > PCIe r6.0 added Flit mode that mainly alters HW behavior but some OS > > visible changes are also because of it. The OS visible changes include > > The first sentence

Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls

On Feb 21, 2025, at 11:11 AM, Darrick J. Wong wrote: > > On Tue, Feb 11, 2025 at 06:22:47PM +0100, Andrey Albershteyn wrote: >> From: Andrey Albershteyn >> >> Introduce getfsxattrat and setfsxattrat syscalls to manipulate inode >> extended attributes/flags. The syscalls take parent directory fd

[PATCH v5 3/3] printf: implicate test line in failure messages

This improves the failure output by pointing to the failing line at the top level of the test, e.g.: # test_number: EXPECTATION FAILED at lib/printf_kunit.c:103 lib/printf_kunit.c:167: vsnprintf(buf, 256, "%#-12x", ...) wrote '0x1234abcd ', expected '0x1234abce ' # test_number: EXP

[PATCH v5 1/3] printf: convert self-test to KUnit

Convert the printf() self-test to a KUnit test. In the interest of keeping the patch reasonably-sized this doesn't refactor the tests into proper parameterized tests - it's all one big test case. Signed-off-by: Tamir Duberstein --- Documentation/core-api/printk-formats.rst | 4 +- MAINTAINE

[PATCH v5 2/3] printf: break kunit into test cases

Move all tests into `printf_test_cases`. This gives us nicer output in the event of a failure. Combine `plain_format` and `plain_hash` into `hash_pointer` since they're testing the same scenario. Signed-off-by: Tamir Duberstein --- lib/tests/printf_kunit.c | 331 +---

[PATCH v5 0/3] printf: convert self-test to KUnit

This is one of just 3 remaining "Test Module" kselftests (the others being bitmap and scanf), the rest having been converted to KUnit. I tested this using: $ tools/testing/kunit/kunit.py run --arch arm64 --make_options LLVM=1 printf I have also sent out a series converting scanf[0]. Link: http

Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls

On Fri, Feb 21, 2025 at 7:13 PM Darrick J. Wong wrote: > > On Tue, Feb 11, 2025 at 06:22:47PM +0100, Andrey Albershteyn wrote: > > From: Andrey Albershteyn > > > > Introduce getfsxattrat and setfsxattrat syscalls to manipulate inode > > extended attributes/flags. The syscalls take parent director

Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls

On Tue, Feb 11, 2025 at 06:22:47PM +0100, Andrey Albershteyn wrote: > From: Andrey Albershteyn > > Introduce getfsxattrat and setfsxattrat syscalls to manipulate inode > extended attributes/flags. The syscalls take parent directory fd and > path to the child together with struct fsxattr. > > Thi

Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls

It looks security checks are missing. With IOCTL commands, file permissions are checked at open time, but with these syscalls the path is only resolved but no specific access seems to be checked (except inode_owner_or_capable via vfs_fileattr_set). On Tue, Feb 11, 2025 at 06:22:47PM +0100, Andrey

Re: [PATCH v2 2/2] PCI: Handle TLP Log in Flit mode

On Fri, Feb 07, 2025 at 06:18:36PM +0200, Ilpo Järvinen wrote: > Flit mode introduced in PCIe r6.0 alters how the TLP Header Log is > presented through AER and DPC Capability registers. The TLP Prefix Log > Register is not present with Flit mode and the register becomes > extension for TLP Header L

Re: [PATCH v2 1/2] PCI: Track Flit Mode Status & print it with link status

On Fri, Feb 07, 2025 at 06:18:35PM +0200, Ilpo Järvinen wrote: > PCIe r6.0 added Flit mode that mainly alters HW behavior but some OS > visible changes are also because of it. The OS visible changes include The first sentence reads oddly. Maybe a slight change? "...but there are some OS visible c

Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern

Hi Josh, Thanks for the review. On 2/21/25 1:29 AM, Josh Poimboeuf wrote: On Wed, Feb 19, 2025 at 09:50:14PM +0530, Sathvika Vasireddy wrote: Architectures like PowerPC use a pattern where the compiler generates a branch-and-link (bl) instruction that targets the very next instruction, followed