Re: [PATCH v2 06/12] dt-bindings: pci: Convert fsl,mpc83xx-pcie to YAML

2025-02-08 Thread J . Neuschäfer
On Fri, Feb 07, 2025 at 10:30:23PM +0100, J. Neuschäfer via B4 Relay wrote: > From: "J. Neuschäfer" > > Formalise the binding for the PCI controllers in the Freescale MPC8xxx > chip family. Information about PCI-X-specific properties was taken from > fsl,pci.txt. The examples were taken from mpc8

[PATCH net-next] net: phy: remove unused PHY_INIT_TIMEOUT definitions

2025-02-08 Thread Heiner Kallweit
Both identical definitions of PHY_INIT_TIMEOUT aren't used, so remove them. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/freescale/ucc_geth.h | 1 - include/linux/phy.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.h

Re: [PATCH 0/3] bitmap: convert self-test to KUnit

2025-02-08 Thread Tamir Duberstein
On Sat, Feb 8, 2025 at 12:53 PM Yury Norov wrote: > > [...] > > Take over means that you'd at least add the Co-developed-by tag. I didn't use their code - the thing being "taken over" is the work of having these debates with the maintainers. > [...] > > KUNIT is disabled in defconfig, at least o

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-08 Thread Christophe Leroy
Le 08/02/2025 à 14:42, Shrikanth Hegde a écrit : On 2/8/25 18:25, Christophe Leroy wrote: Le 08/02/2025 à 08:35, Shrikanth Hegde a écrit : On 2/4/25 13:52, Sebastian Andrzej Siewior wrote: Use preempt_model_str() instead of manually conducting the preemption model. Use pr_emerg() inst

Re: [PATCH 1/3] bitmap: remove _check_eq_u32_array

2025-02-08 Thread Yury Norov
On Fri, Feb 07, 2025 at 03:14:02PM -0500, Tamir Duberstein wrote: > This has been unused since commit 3aa56885e516 ("bitmap: replace > bitmap_{from,to}_u32array") in 2018. Remove it to avoid the need to port > it to KUnit in this series. > > Signed-off-by: Tamir Duberstein OK, 7 years is enough

Re: [PATCH 0/3] bitmap: convert self-test to KUnit

2025-02-08 Thread Yury Norov
On Fri, Feb 07, 2025 at 03:14:01PM -0500, Tamir Duberstein wrote: > This is one of just 3 remaining "Test Module" kselftests (the others > being printf and scanf), the rest having been converted to KUnit. > > I tested this using: > > $ tools/testing/kunit/kunit.py run --arch arm64 --make_options

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-08 Thread Shrikanth Hegde
On 2/8/25 18:25, Christophe Leroy wrote: Le 08/02/2025 à 08:35, Shrikanth Hegde a écrit : On 2/4/25 13:52, Sebastian Andrzej Siewior wrote: Use preempt_model_str() instead of manually conducting the preemption model. Use pr_emerg() instead of printk() to pass a loglevel. even on powerp

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-08 Thread Christophe Leroy
Le 08/02/2025 à 08:35, Shrikanth Hegde a écrit : On 2/4/25 13:52, Sebastian Andrzej Siewior wrote: Use preempt_model_str() instead of manually conducting the preemption model. Use pr_emerg() instead of printk() to pass a loglevel. even on powerpc, i see __die ends up calling show_regs_pri

Re: [PATCH 3/3] bitmap: break kunit into test cases

2025-02-08 Thread Tamir Duberstein
On Sat, Feb 8, 2025 at 4:07 AM David Gow wrote: > > On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein wrote: > > > > Move some tests into `bitmap_test_cases` and parameterize > > `test_bitmap_print_buf`. This gives us nicer output in the event of a > > failure. > > > > Signed-off-by: Tamir Duberstein

Re: [PATCH 3/3] bitmap: break kunit into test cases

2025-02-08 Thread David Gow
On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein wrote: > > Move some tests into `bitmap_test_cases` and parameterize > `test_bitmap_print_buf`. This gives us nicer output in the event of a > failure. > > Signed-off-by: Tamir Duberstein > --- I very much like this cleanup: the static global 'kunitt

Re: [PATCH 2/3] bitmap: convert self-test to KUnit

2025-02-08 Thread David Gow
On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein wrote: > > Convert the bitmap() self-test to a KUnit test. > > In the interest of keeping the patch reasonably-sized this doesn't > refactor the tests into proper parameterized tests - it's all one big > test case. > > Signed-off-by: Tamir Duberstein

Re: [PATCH 1/3] bitmap: remove _check_eq_u32_array

2025-02-08 Thread David Gow
On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein wrote: > > This has been unused since commit 3aa56885e516 ("bitmap: replace > bitmap_{from,to}_u32array") in 2018. Remove it to avoid the need to port > it to KUnit in this series. > > Signed-off-by: Tamir Duberstein > --- Makes sense. Reviewed-by:

Re: [PATCH 0/3] bitmap: convert self-test to KUnit

2025-02-08 Thread David Gow
On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein wrote: > > This is one of just 3 remaining "Test Module" kselftests (the others > being printf and scanf), the rest having been converted to KUnit. Thanks a lot, Tamir: these are great! > > I tested this using: > > $ tools/testing/kunit/kunit.py run