Re: [PATCH v3 2/2] kexec: Prevent redundant IRQ masking by checking state before shutdown

2024-11-28 Thread kernel test robot
Hi Eliav, kernel test robot noticed the following build errors: [auto build test ERROR on powerpc/next] [also build test ERROR on powerpc/fixes tip/irq/core arm64/for-next/core linus/master v6.12 next-20241128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation

2024-11-28 Thread kernel test robot
Hi Eliav, kernel test robot noticed the following build errors: [auto build test ERROR on powerpc/next] [also build test ERROR on powerpc/fixes tip/irq/core arm64/for-next/core linus/master v6.12 next-20241128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation

2024-11-28 Thread kernel test robot
Hi Eliav, kernel test robot noticed the following build errors: [auto build test ERROR on powerpc/next] [also build test ERROR on powerpc/fixes tip/irq/core arm64/for-next/core linus/master v6.12 next-20241128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v3 0/2] Improve interrupt handling during machine kexec

2024-11-28 Thread Eliav Farber
This patch series focuses on improving the machine_kexec_mask_interrupts() function by consolidating its implementation and optimizing its behavior to avoid redundant interrupt masking. Patch Summary: [PATCH v3 1/2] Move machine_kexec_mask_interrupts() to kexec_core.c, removing dupl

[PATCH v3 2/2] kexec: Prevent redundant IRQ masking by checking state before shutdown

2024-11-28 Thread Eliav Farber
During machine kexec, the function machine_kexec_mask_interrupts() is responsible for disabling or masking all interrupts. While the irq_disable hook ensures that an already-disabled IRQ is not disabled again, the current implementation unconditionally invokes the irq_mask() function for every inte

[PATCH v3 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation

2024-11-28 Thread Eliav Farber
Move the machine_kexec_mask_interrupts function to a common location in kernel/kexec_core.c, removing duplicate implementations from architecture specific files (arch/arm, arch/arm64, arch/powerpc, and arch/riscv). This consolidation reduces code duplication and improves maintainability. The unif

RE: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

2024-11-28 Thread Farber, Eliav
On 11/28/2024 12:39 PM, Thomas Gleixner wrote: > This is just wrong. If the interrupt was torn down, then its state is > deactivated and it was masked already. So the EOI handling and the > mask/disable dance are neither required nor make sense. > > So this whole thing should be: > >

Re: [PATCH 18/22] ceph: Convert timeouts to secs_to_jiffies()

2024-11-28 Thread Alex Markuze
looks good On Fri, Nov 15, 2024 at 11:35 PM Easwar Hariharan wrote: > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-

Re: [PATCH v2 18/21] ceph: Convert timeouts to secs_to_jiffies()

2024-11-28 Thread Alex Markuze
looks good On Sat, Nov 16, 2024 at 12:32 AM Easwar Hariharan wrote: > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-

[PATCH] macintosh: Switch back to struct platform_driver::remove()

2024-11-28 Thread Uwe Kleine-König
After commit 0edb555a65d1 ("platform: Make platform_driver::remove() return void") .remove() is (again) the right callback to implement for platform drivers. Convert all platform drivers below drivers/macintosh to use .remove(), with the eventual goal to drop struct platform_driver::remove_new().

Re: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

2024-11-28 Thread Thomas Gleixner
On Wed, Nov 27 2024 at 15:22, Eliav Farber wrote: As a related note. The subject line is not really matching what the patch does. It want's to be split into a core change and one patch per architecture. > This patch replaces the direct invocation of the irq_mask() and git grep 'This patch' Docum

Re: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

2024-11-28 Thread Thomas Gleixner
On Wed, Nov 27 2024 at 15:22, Eliav Farber wrote: > diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c > index 80ceb5bd2680..54d0bd1bd449 100644 > --- a/arch/arm/kernel/machine_kexec.c > +++ b/arch/arm/kernel/machine_kexec.c > @@ -142,11 +142,8 @@ static void machine_kex