Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le

2024-11-02 Thread Google
On Sat, 2 Nov 2024 00:49:25 +0530 Hari Bathini wrote: > For ppc64le, depending on the kernel configuration used, offset 16 > from function start address can also be considered function entry. > Update the test case to accommodate such configurations. > Hi Hari, so have you met any error on thi

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Milan Broz
On 11/2/24 5:36 PM, Eric Biggers wrote: On Sat, Nov 02, 2024 at 07:08:43PM +0800, Herbert Xu wrote: On Sat, Nov 02, 2024 at 12:05:01PM +0100, Ard Biesheuvel wrote: The only issue resulting from *not* taking this patch is that btrfs may misidentify the CRC32 implementation as being 'slow' and t

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Ard Biesheuvel
On Sat, 2 Nov 2024 at 17:36, Eric Biggers wrote: > > On Sat, Nov 02, 2024 at 07:08:43PM +0800, Herbert Xu wrote: > > On Sat, Nov 02, 2024 at 12:05:01PM +0100, Ard Biesheuvel wrote: > > > > > > The only issue resulting from *not* taking this patch is that btrfs > > > may misidentify the CRC32 imple

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Eric Biggers
On Sat, Nov 02, 2024 at 07:08:43PM +0800, Herbert Xu wrote: > On Sat, Nov 02, 2024 at 12:05:01PM +0100, Ard Biesheuvel wrote: > > > > The only issue resulting from *not* taking this patch is that btrfs > > may misidentify the CRC32 implementation as being 'slow' and take an > > alternative code pat

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Herbert Xu
On Sat, Nov 02, 2024 at 12:05:01PM +0100, Ard Biesheuvel wrote: > > The only issue resulting from *not* taking this patch is that btrfs > may misidentify the CRC32 implementation as being 'slow' and take an > alternative code path, which does not necessarily result in worse > performance. If we we

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Ard Biesheuvel
On Sat, 2 Nov 2024 at 11:46, Ard Biesheuvel wrote: > > On Sat, 2 Nov 2024 at 11:20, Herbert Xu wrote: > > > > On Sat, Nov 02, 2024 at 10:58:53AM +0100, Ard Biesheuvel wrote: > > > > > > At least btrfs supports a variety of checksums/hashes (crc32c, xxhash, > > > sha) via the shash API. > > > > OK

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Ard Biesheuvel
On Sat, 2 Nov 2024 at 11:20, Herbert Xu wrote: > > On Sat, Nov 02, 2024 at 10:58:53AM +0100, Ard Biesheuvel wrote: > > > > At least btrfs supports a variety of checksums/hashes (crc32c, xxhash, > > sha) via the shash API. > > OK, given that btrfs is still doing this, I think we should still > regi

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Herbert Xu
On Sat, Nov 02, 2024 at 10:58:53AM +0100, Ard Biesheuvel wrote: > > At least btrfs supports a variety of checksums/hashes (crc32c, xxhash, > sha) via the shash API. OK, given that btrfs is still doing this, I think we should still register crc32c-arch conditionally. Having it point to crc32c-gene

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Ard Biesheuvel
On Sat, 2 Nov 2024 at 10:45, Herbert Xu wrote: > > Eric Biggers wrote: > > > > While testing this patchset I notice that none of the crypto API drivers for > > crc32 or crc32c even need to be loaded on my system anymore, as everything > > on my > > system that uses those algorithms (such as ext4

Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Herbert Xu
Eric Biggers wrote: > > While testing this patchset I notice that none of the crypto API drivers for > crc32 or crc32c even need to be loaded on my system anymore, as everything on > my > system that uses those algorithms (such as ext4) just uses the library APIs > now. > That makes the "check /