Re: [PATCH v7 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2024-10-31 Thread Yicong Yang
On 2024/10/31 21:33, Thomas Gleixner wrote: > On Thu, Oct 31 2024 at 20:17, Yicong Yang wrote: >> On 2024/10/30 22:55, Thomas Gleixner wrote: +static inline bool topology_is_primary_thread(unsigned int cpu) +{ + /* + * On SMT hotplug the primary thread of the SMT won't be dis

Re: [PATCH net] net: dpaa_eth: print FD status in CPU endianness in dpaa_eth_fd tracepoint

2024-10-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 29 Oct 2024 18:31:05 +0200 you wrote: > Sparse warns: > > note: in included file (through ../include/trace/trace_events.h, > ../include/trace/define_trace.h, > ../drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace

RE: [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers

2024-10-31 Thread Kiyanovski, Arthur
On 10/30/24 17:23, Caleb Sander Mateos wrote: > Make the start and end arguments to dim_calc_stats() const pointers to > clarify that the function does not modify their values. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Arthur Kiyanovski Thanks, Arthur

RE: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Kiyanovski, Arthur
> -Original Message- > From: Caleb Sander Mateos > Sent: Wednesday, October 30, 2024 5:23 PM > > net_dim() is currently passed a struct dim_sample argument by value. > struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 passes > it > on the stack. All callers have alrea

Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Nelson, Shannon
On 10/30/2024 5:23 PM, Caleb Sander Mateos wrote: net_dim() is currently passed a struct dim_sample argument by value. struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 passes it on the stack. All callers have already initialized dim_sample on the stack, so passing it by valu

Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Louis Peens
On Wed, Oct 30, 2024 at 06:23:26PM -0600, Caleb Sander Mateos wrote: > net_dim() is currently passed a struct dim_sample argument by value. > struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 > passes it on the stack. All callers have already initialized dim_sample > on the stac

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-10-31 Thread Matthew Maurer
> The question is, if only extended moversions are used, what new tooling > requirements are there? Can you test using only extended modversions? > > Luis I'm not sure precisely what you're asking for. Do you want: 1. A kconfig that suppresses the emission of today's MODVERSIONS format? This wou

Re: [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers

2024-10-31 Thread Florian Fainelli
On 10/30/24 17:23, Caleb Sander Mateos wrote: Make the start and end arguments to dim_calc_stats() const pointers to clarify that the function does not modify their values. Signed-off-by: Caleb Sander Mateos Reviewed-by: Florian Fainelli -- Florian

Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Caleb Sander
On Thu, Oct 31, 2024 at 5:49 AM Louis Peens wrote: > > On Wed, Oct 30, 2024 at 06:23:26PM -0600, Caleb Sander Mateos wrote: > > net_dim() is currently passed a struct dim_sample argument by value. > > struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 > > passes it on the stack.

Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Florian Fainelli
On 10/30/24 17:23, Caleb Sander Mateos wrote: net_dim() is currently passed a struct dim_sample argument by value. struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 passes it on the stack. All callers have already initialized dim_sample on the stack, so passing it by value req

Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Vladimir Oltean
On Wed, Oct 30, 2024 at 06:23:26PM -0600, Caleb Sander Mateos wrote: > net_dim() is currently passed a struct dim_sample argument by value. > struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 > passes it on the stack. All callers have already initialized dim_sample > on the stac

Re: [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers

2024-10-31 Thread Vladimir Oltean
On Wed, Oct 30, 2024 at 06:23:25PM -0600, Caleb Sander Mateos wrote: > Make the start and end arguments to dim_calc_stats() const pointers > to clarify that the function does not modify their values. > > Signed-off-by: Caleb Sander Mateos > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v7 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2024-10-31 Thread Thomas Gleixner
On Thu, Oct 31 2024 at 20:17, Yicong Yang wrote: > On 2024/10/30 22:55, Thomas Gleixner wrote: >>> +static inline bool topology_is_primary_thread(unsigned int cpu) >>> +{ >>> + /* >>> +* On SMT hotplug the primary thread of the SMT won't be disabled. >>> +* Architectures do have a special

Re: [PATCH v7 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2024-10-31 Thread Yicong Yang
On 2024/10/30 22:55, Thomas Gleixner wrote: > On Wed, Oct 30 2024 at 20:54, Yicong Yang wrote: >> >> +#ifndef topology_is_primary_thread >> +#define topology_is_primary_thread topology_is_primary_thread > > Please do not glue defines and functions together w/o a newline in between. > sure, wil

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-10-31 Thread Luis Chamberlain
On Wed, Oct 30, 2024 at 11:05:03PM +, Matthew Maurer wrote: > diff --git a/kernel/module/Kconfig b/kernel/module/Kconfig > index > e6b2427e5c190aacf7b9c5c1bb57fca39d311564..a31c617cd67d3d66b24d2fba34cbd5cc9c53ab78 > 100644 > --- a/kernel/module/Kconfig > +++ b/kernel/module/Kconfig > @@ -208,

Re: [PATCH v8 1/3] modules: Support extended MODVERSIONS info

2024-10-31 Thread Luis Chamberlain
On Wed, Oct 30, 2024 at 10:06:12PM -0700, Matthew Maurer wrote: > On Wed, Oct 30, 2024 at 9:37 PM Luis Chamberlain wrote: > > > > On Thu, Oct 31, 2024 at 12:22:36PM +1100, Michael Ellerman wrote: > > > Matthew Maurer writes: > > > > Adds a new format for MODVERSIONS which stores each field in a s