Re: [PATCH v2] KVM: PPC: Book3S HV: Mask off LPCR_MER for a vCPU before running it to avoid spurious interrupts

2024-10-24 Thread Ritesh Harjani (IBM)
Gautam Menghani writes: > Mask off the LPCR_MER bit before running a vCPU to ensure that it is not > set if there are no pending interrupts. Running a vCPU with LPCR_MER bit > set and no pending interrupts results in L2 vCPU getting an infinite flood > of spurious interrupts. The 'if check' in kv

Re: [PATCH v2] KVM: PPC: Book3S HV: Mask off LPCR_MER for a vCPU before running it to avoid spurious interrupts

2024-10-24 Thread Michael Ellerman
Hi Gautam, A few comments below ... Gautam Menghani writes: > Mask off the LPCR_MER bit before running a vCPU to ensure that it is not > set if there are no pending interrupts. I would typically leave this until the end of the change log. ie. describe the bug and how it happens first, then the

[PATCH v2] ASoC: fsl_mqs: Support accessing registers by scmi interface

2024-10-24 Thread Shengjiu Wang
On i.MX95, the MQS module in Always-on (AON) domain only can be accessed by System Controller Management Interface (SCMI) MISC Protocol. So define a specific regmap_config for the case. Signed-off-by: Shengjiu Wang --- changes in v2: - fix compile issue when IMX_SCMI_MISC_DRV=m but SND_SOC_FSL_MQ

Re: [PATCH] ASoC: fsl_mqs: Support accessing registers by scmi interface

2024-10-24 Thread Shengjiu Wang
On Sat, Oct 12, 2024 at 2:15 PM Shengjiu Wang wrote: > > On i.MX95, the MQS module in Always-on (AON) domain only can > be accessed by System Controller Management Interface (SCMI) > MISC Protocol. So define a specific regmap_config for the case. > find an issue when IMX_SCMI_MISC_DRV=m but SND_S

Re: [PATCH] powerpc/xmon: symbol lookup length fixed

2024-10-24 Thread Michael Ellerman
Mukesh Kumar Chaurasiya writes: > On Thu, Oct 24, 2024 at 10:42:12AM +0530, Mukesh Kumar Chaurasiya wrote: >> On Thu, Oct 24, 2024 at 12:00:53PM +1100, Michael Ellerman wrote: >> > Mukesh Kumar Chaurasiya writes: >> > > Currently xmon cannot lookup symbol beyond 64 characters in some cases. >> >

Re: [PATCH v7 0/3] Extended MODVERSIONS Support

2024-10-24 Thread Luis Chamberlain
On Thu, Oct 24, 2024 at 11:07:57PM +, Sami Tolvanen wrote: > > Changes in v7: > > - Fix modpost to detect EXTENDED_MODVERSIONS based on a flag > > - Drop patches to fix export_report.pl > > Unless Luis prefers to deal with this separately, perhaps you can > just include a patch to delete expor

Re: [PATCH 10/12] fs/dax: Properly refcount fs dax pages

2024-10-24 Thread Dan Williams
Alistair Popple wrote: [..] >> I'm not really following this scenario, or at least how it relates to > >> the comment above. If the page is pinned for DMA it will have taken a > >> refcount on it and so the page won't be considered free/idle per > >> dax_wait_page_idle() or any of the other mm code

Re: [PATCH 1/7] powerpc/entry: convert to common and generic entry

2024-10-24 Thread Luming Yu
On Thu, Oct 24, 2024 at 04:43:04PM +0800, Luming Yu wrote: > On Wed, Oct 23, 2024 at 12:53:47PM +1100, Michael Ellerman wrote: > > "虞陆铭" writes: > > >>Le 12/10/2024 à 05:56, Luming Yu a écrit : > > >>> convert powerpc entry code in syscall and fault to use syscall_work > > >>> and irqentry_state a

Re: powerpc: clang-nightly: fatal error: error in backend: Trying to obtain a reserved register "r2".

2024-10-24 Thread Nathan Chancellor
Hi Naresh, On Thu, Oct 24, 2024 at 08:35:11PM +0530, Naresh Kamboju wrote: > The powerpc clang-nightly version 20.0.0 build warnings / errors noticed on > the Today's Linux next-20241024 tag. ... > Build errors: > -- > fatal error: error in backend: Trying to obtain

Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-24 Thread Segher Boessenkool
Hi! On Fri, Oct 25, 2024 at 11:29:38AM +1100, Michael Ellerman wrote: > [To += Mathieu] > > "Nysal Jan K.A." writes: > > From: "Nysal Jan K.A" > > > > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > > is not selected, sync_core_before_usermode() is a no-op. > > In membarrier_mm_sync

Re: [PATCH 10/12] fs/dax: Properly refcount fs dax pages

2024-10-24 Thread Alistair Popple
Dan Williams writes: > Alistair Popple wrote: > [..] >> > >> > Was there a discussion I missed about why the conversion to typical >> > folios allows the page->share accounting to be dropped. >> >> The problem with keeping it is we now treat DAX pages as "normal" >> pages according to vm_norma

Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-24 Thread Stephen Rothwell
Hi Michael, On Fri, 25 Oct 2024 11:29:38 +1100 Michael Ellerman wrote: > > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > > index 07bb8d4181d7..042e60ab853a 100644 > > --- a/include/linux/sched/mm.h > > +++ b/include/linux/sched/mm.h > > @@ -540,6 +540,8 @@ enum { > > > >

Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-24 Thread Michael Ellerman
[To += Mathieu] "Nysal Jan K.A." writes: > From: "Nysal Jan K.A" > > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > is not selected, sync_core_before_usermode() is a no-op. > In membarrier_mm_sync_core_before_usermode() the compiler does not > eliminate redundant branches and the lo

Re: [PATCH v7 0/3] Extended MODVERSIONS Support

2024-10-24 Thread Sami Tolvanen
On Wed, Oct 23, 2024 at 02:31:27AM +, Matthew Maurer wrote: > This patch series is intended for use alongside the Implement DWARF > modversions series [1] to enable RUST and MODVERSIONS at the same > time. > > Elsewhere, we've seen a desire for long symbol name support for LTO > symbol names [

Re: [PATCH v7 3/3] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS

2024-10-24 Thread Sami Tolvanen
On Wed, Oct 23, 2024 at 02:31:30AM +, Matthew Maurer wrote: > From: Sami Tolvanen > > Previously, two things stopped Rust from using MODVERSIONS: > 1. Rust symbols are occasionally too long to be represented in the >original versions table > 2. Rust types cannot be properly hashed by the

Re: [PATCH v7 2/3] modpost: Produce extended MODVERSIONS information

2024-10-24 Thread Sami Tolvanen
On Wed, Oct 23, 2024 at 02:31:29AM +, Matthew Maurer wrote: > Generate both the existing modversions format and the new extended one > when running modpost. Presence of this metadata in the final .ko is > guarded by CONFIG_EXTENDED_MODVERSIONS. > > We no longer generate an error on long symbol

Re: [PATCH v7 1/3] modules: Support extended MODVERSIONS info

2024-10-24 Thread Sami Tolvanen
On Wed, Oct 23, 2024 at 02:31:28AM +, Matthew Maurer wrote: > Adds a new format for MODVERSIONS which stores each field in a separate > ELF section. This initially adds support for variable length names, but > could later be used to add additional fields to MODVERSIONS in a > backwards compatib

[PATCH net-next] net: freescale: use ethtool string helpers

2024-10-24 Thread Rosen Penev
The latter is the preferred way to copy ethtool strings. Avoids manually incrementing the pointer. Cleans up the code quite well. Signed-off-by: Rosen Penev --- .../ethernet/freescale/dpaa/dpaa_ethtool.c| 40 ++- .../ethernet/freescale/dpaa2/dpaa2-ethtool.c | 15 +++ ..

Re: [PATCH] powerpc/xmon: symbol lookup length fixed

2024-10-24 Thread Mukesh Kumar Chaurasiya
On Thu, Oct 24, 2024 at 10:42:12AM +0530, Mukesh Kumar Chaurasiya wrote: > On Thu, Oct 24, 2024 at 12:00:53PM +1100, Michael Ellerman wrote: > > Mukesh Kumar Chaurasiya writes: > > > Currently xmon cannot lookup symbol beyond 64 characters in some cases. > > > > Can you mention which commands? It

Re: [PATCH v5 11/17] kbuild: Add generic hook for architectures to use before the final vmlinux link

2024-10-24 Thread Hari Bathini
Hello Masahiro, On 10/10/24 5:07 pm, Masahiro Yamada wrote: On Thu, Oct 10, 2024 at 6:57 PM Hari Bathini wrote: On 09/10/24 8:53 pm, Masahiro Yamada wrote: On Mon, Sep 16, 2024 at 5:58 AM Hari Bathini wrote: From: Naveen N Rao On powerpc, we would like to be able to make a pass on vmli

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-24 Thread Linus Torvalds
On Thu, 24 Oct 2024 at 02:22, David Laight wrote: > > Would it be better to make the 'bogus' constant one that makes > all accesses fail? Well, the bogus constant is actually used for other runtime cases too (well, right now that's only the dentry pointer, but could be more), it's not some kind o

Re: [PATCH net-next] ibmvnic: use ethtool string helpers

2024-10-24 Thread Simon Horman
On Tue, Oct 22, 2024 at 01:32:40PM -0700, Rosen Penev wrote: > They are the prefered way to copy ethtool strings. > > Avoids manually incrementing the data pointer. > > Signed-off-by: Rosen Penev Reviewed-by: Simon Horman

powerpc: clang-nightly: fatal error: error in backend: Trying to obtain a reserved register "r2".

2024-10-24 Thread Naresh Kamboju
The powerpc clang-nightly version 20.0.0 build warnings / errors noticed on the Today's Linux next-20241024 tag. powerpc: build: * clang-nightly-maple_defconfig * clang-nightly-tinyconfig * clang-nightly-tqm8xx_defconfig * clang-nightly-mpc83xx_defconfig * clang-ni

Re: [PATCH RFC v2 0/4] mm: Introduce MAP_BELOW_HINT

2024-10-24 Thread Steven Price
On 23/10/2024 19:10, Liam R. Howlett wrote: > * Steven Price [241023 05:31]: * Box64 seems to have a custom allocator based on reading /proc/self/maps to allocate a block of VA space with a low enough address [1] * PHP has code reading /proc/self/maps - I thi

RE: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-24 Thread David Laight
From: Linus Torvalds > Sent: 23 October 2024 21:08 > > On Wed, 23 Oct 2024 at 12:17, Linus Torvalds > wrote: > > > > NOTE! This is obviously untested and I didn't check that it does the > > cmp/sbb/or the right way around. > > Well, it boots. The code generation (from strncpy_from_user()) seems

Re: [kvm-unit-tests PATCH v3 0/5] Support cross compiling with clang

2024-10-24 Thread Andrew Jones
On Wed, Sep 11, 2024 at 11:14:07AM +0200, Andrew Jones wrote: > Modify configure to allow --cc=clang and a cross-prefix to be specified > together (as well as --cflags). This allows compiling with clang, but > using cross binutils for everything else, including the linker. So far > tested on riscv

Re: [PATCH 1/7] powerpc/entry: convert to common and generic entry

2024-10-24 Thread Luming Yu
On Wed, Oct 23, 2024 at 12:53:47PM +1100, Michael Ellerman wrote: > "虞陆铭" writes: > >>Le 12/10/2024 à 05:56, Luming Yu a écrit : > >>> convert powerpc entry code in syscall and fault to use syscall_work > >>> and irqentry_state as well as common calls implemented in generic > >>> entry infrastruct

Re: [PATCH v6 3/4] arm64: topology: Support SMT control on ACPI based system

2024-10-24 Thread Pierre Gondois
Hello Yicong, On 10/15/24 04:18, Yicong Yang wrote: From: Yicong Yang For ACPI we'll build the topology from PPTT and we cannot directly get the SMT number of each core. Instead using a temporary xarray to record the heterogeneous information (from ACPI_PPTT_ACPI_IDENTICAL) and SMT information

Re: [PATCH 10/12] fs/dax: Properly refcount fs dax pages

2024-10-24 Thread Alistair Popple
Dan Williams writes: > Alistair Popple wrote: [...] >> @@ -318,85 +323,58 @@ static unsigned long dax_end_pfn(void *entry) >> */ >> #define for_each_mapped_pfn(entry, pfn) \ >> for (pfn = dax_to_pfn(entry); \ >> -pfn < dax_end_pfn(entry); pfn++) >> +pfn

Re: [PATCH] powerpc/xmon: symbol lookup length fixed

2024-10-24 Thread Mukesh Kumar Chaurasiya
On Thu, Oct 24, 2024 at 12:00:53PM +1100, Michael Ellerman wrote: > Mukesh Kumar Chaurasiya writes: > > Currently xmon cannot lookup symbol beyond 64 characters in some cases. > > Can you mention which commands? It looks like it's "ls" and "lp". Sure. > > > Fix this by using KSYM_NAME_LEN instea