Re: [PATCH 1/7] powerpc/entry: convert to common and generic entry

2024-10-21 Thread 虞陆铭
>Le 12/10/2024 à 05:56, Luming Yu a écrit : >> convert powerpc entry code in syscall and fault to use syscall_work >> and irqentry_state as well as common calls implemented in generic >> entry infrastructure. >> >> Signed-off-by: Luming Yu >> --- >> arch/powerpc/Kconfig | 1 +

Re: [PATCH v3 01/12] powerpc: mm/fault: Fix kfence page fault reporting

2024-10-21 Thread IBM
Michael Ellerman writes: > Hi Ritesh, > > "Ritesh Harjani (IBM)" writes: >> copy_from_kernel_nofault() can be called when doing read of /proc/kcore. >> /proc/kcore can have some unmapped kfence objects which when read via >> copy_from_kernel_nofault() can cause page faults. Since *_nofault() >>

Re: [PATCH v3 01/12] powerpc: mm/fault: Fix kfence page fault reporting

2024-10-21 Thread Michael Ellerman
Hi Ritesh, "Ritesh Harjani (IBM)" writes: > copy_from_kernel_nofault() can be called when doing read of /proc/kcore. > /proc/kcore can have some unmapped kfence objects which when read via > copy_from_kernel_nofault() can cause page faults. Since *_nofault() > functions define their own fixup tab

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-21 Thread Linus Torvalds
On Mon, 21 Oct 2024 at 03:48, Kirill A. Shutemov wrote: > > LAM brings own speculation issues[1] that is going to be addressed by > LASS[2]. There was a patch[3] to disable LAM until LASS is landed, but it > never got applied for some reason. Bah., I think the reason was that nobody knew what - i

Re: [PATCH v13 51/85] KVM: VMX: Use __kvm_faultin_page() to get APIC access page/pfn

2024-10-21 Thread Yan Zhao
On Mon, Oct 21, 2024 at 11:57:42AM -0700, Sean Christopherson wrote: > On Mon, Oct 21, 2024, Yan Zhao wrote: > > On Thu, Oct 10, 2024 at 11:23:53AM -0700, Sean Christopherson wrote: > > > Use __kvm_faultin_page() get the APIC access page so that KVM can > > > precisely release the refcounted page,

Re: [PATCH v13 34/85] KVM: Get writable mapping for __kvm_vcpu_map() only when necessary

2024-10-21 Thread Yan Zhao
On Mon, Oct 21, 2024 at 11:13:08AM -0700, Sean Christopherson wrote: > On Mon, Oct 21, 2024, Yan Zhao wrote: > > On Thu, Oct 10, 2024 at 11:23:36AM -0700, Sean Christopherson wrote: > > > When creating a memory map for read, don't request a writable pfn from the > > > primary MMU. While creating r

Re: [PATCH v13 19/85] KVM: Introduce kvm_follow_pfn() to eventually replace "gfn_to_pfn" APIs

2024-10-21 Thread Yan Zhao
On Mon, Oct 21, 2024 at 11:08:49AM -0700, Sean Christopherson wrote: > On Mon, Oct 21, 2024, Yan Zhao wrote: > > On Thu, Oct 10, 2024 at 11:23:21AM -0700, Sean Christopherson wrote: > > > --- a/virt/kvm/pfncache.c > > > +++ b/virt/kvm/pfncache.c > > > @@ -159,6 +159,12 @@ static kvm_pfn_t hva_to_pf

Re: [PATCH v13 00/85] KVM: Stop grabbing references to PFNMAP'd pages

2024-10-21 Thread Sean Christopherson
On Thu, Oct 17, 2024, Paolo Bonzini wrote: > On Thu, Oct 10, 2024 at 8:24 PM Sean Christopherson wrote: > > v13: > > - Rebased onto v6.12-rc2 > > - Collect reviews. [Alex and others] > > - Fix a transient bug in arm64 and RISC-V where KVM would leak a page > >refcount. [Oliver] > > - Fix a

Re: [PATCH v6 6/8] x86/module: prepare module loading for ROX allocations of text

2024-10-21 Thread Nathan Chancellor
alid opcode: [#1] PREEMPT SMP NOPTI [0.885434] CPU: 3 UID: 0 PID: 157 Comm: modprobe Tainted: G W 6.12.0-rc3-debug-next-20241021-06324-g63b3ff03d91a #1 291f0fd70f293827edec681d3c5304f5807a3c7b [0.887084] Tainted: [W]=WARN [0.887409] Hardware name: QEMU Standar

Re: [PATCH] char: Switch back to struct platform_driver::remove()

2024-10-21 Thread Eli Billauer
Who am I to object? :) Thanks, Eli Acked-by: Eli Billauer

Re: [PATCH RFC v2 0/4] mm: Introduce MAP_BELOW_HINT

2024-10-21 Thread Steven Price
On 09/09/2024 10:46, Kirill A. Shutemov wrote: > On Thu, Sep 05, 2024 at 10:26:52AM -0700, Charlie Jenkins wrote: >> On Thu, Sep 05, 2024 at 09:47:47AM +0300, Kirill A. Shutemov wrote: >>> On Thu, Aug 29, 2024 at 12:15:57AM -0700, Charlie Jenkins wrote: Some applications rely on placing data i

Re: [PATCH RFC v2 0/4] mm: Introduce MAP_BELOW_HINT

2024-10-21 Thread Liam R. Howlett
* Steven Price [241021 09:23]: > On 09/09/2024 10:46, Kirill A. Shutemov wrote: > > On Thu, Sep 05, 2024 at 10:26:52AM -0700, Charlie Jenkins wrote: > >> On Thu, Sep 05, 2024 at 09:47:47AM +0300, Kirill A. Shutemov wrote: > >>> On Thu, Aug 29, 2024 at 12:15:57AM -0700, Charlie Jenkins wrote: > >>>

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-21 Thread Luis Chamberlain
On Sat, Oct 19, 2024 at 01:45:35PM -0700, Luis Chamberlain wrote: > On Thu, Oct 17, 2024 at 02:08:19PM +0200, Helge Deller wrote: > > Hi Luis, > > > > On 10/17/24 01:21, Luis Chamberlain wrote: > > > That sounds great. Yeah, the above would be great to test. A while ago > > > I wrote a new modules

Re: [PATCH v13 51/85] KVM: VMX: Use __kvm_faultin_page() to get APIC access page/pfn

2024-10-21 Thread Sean Christopherson
On Mon, Oct 21, 2024, Yan Zhao wrote: > On Thu, Oct 10, 2024 at 11:23:53AM -0700, Sean Christopherson wrote: > > Use __kvm_faultin_page() get the APIC access page so that KVM can > > precisely release the refcounted page, i.e. to remove yet another user > > of kvm_pfn_to_refcounted_page(). While t

Re: [PATCH v6 2/5] modules: Support extended MODVERSIONS info

2024-10-21 Thread Luis Chamberlain
On Tue, Oct 15, 2024 at 11:18:57PM +, Matthew Maurer wrote: > Adds a new format for MODVERSIONS which stores each field in a separate > ELF section. This initially adds support for variable length names, but > could later be used to add additional fields to MODVERSIONS in a > backwards compatib

Re: [PATCH v13 34/85] KVM: Get writable mapping for __kvm_vcpu_map() only when necessary

2024-10-21 Thread Sean Christopherson
On Mon, Oct 21, 2024, Yan Zhao wrote: > On Thu, Oct 10, 2024 at 11:23:36AM -0700, Sean Christopherson wrote: > > When creating a memory map for read, don't request a writable pfn from the > > primary MMU. While creating read-only mappings can be theoretically slower, > > as they don't play nice wi

Re: [PATCH v13 19/85] KVM: Introduce kvm_follow_pfn() to eventually replace "gfn_to_pfn" APIs

2024-10-21 Thread Sean Christopherson
On Mon, Oct 21, 2024, Yan Zhao wrote: > On Thu, Oct 10, 2024 at 11:23:21AM -0700, Sean Christopherson wrote: > > --- a/virt/kvm/pfncache.c > > +++ b/virt/kvm/pfncache.c > > @@ -159,6 +159,12 @@ static kvm_pfn_t hva_to_pfn_retry(struct > > gfn_to_pfn_cache *gpc) > > kvm_pfn_t new_pfn = KVM_PFN_

Re: [PATCH 07/15] s390/crc32: expose CRC32 functions through lib

2024-10-21 Thread Eric Biggers
On Mon, Oct 21, 2024 at 12:40:07PM +0200, Heiko Carstens wrote: > What makes sure that all of the code is available automatically if the > CPU supports the instructions like before? I can see that all CRC32 > related config options support also module build options. > > Before this patch, this mod

Re: [PATCH] powerpc/crash: Allow direct printing on kexec

2024-10-21 Thread Ryo Takakura
On 2024-10-21, John Ogness wrote: >On 2024-10-21, Ryo Takakura wrote: >>> Rather than removing the deferring, it would be better to convert the >>> console you are using to the new NBCON API. Then it would be able to >>> print direct and safe during panic. (printk_deferred does not affect >>> NBC

Re: [PATCH] powerpc/crash: Allow direct printing on kexec

2024-10-21 Thread John Ogness
On 2024-10-21, Ryo Takakura wrote: >> Rather than removing the deferring, it would be better to convert the >> console you are using to the new NBCON API. Then it would be able to >> print direct and safe during panic. (printk_deferred does not affect >> NBCON consoles.) What console driver are yo

Re: [PATCH] powerpc/crash: Allow direct printing on kexec

2024-10-21 Thread Ryo Takakura
Hi John! On 2024-10-20, John Ogness wrote: >On 2024-10-20, Ryo Takakura wrote: >> Let legacy consoles print directly so that we can see messages on kexec, as >> the commit b6cf8b3f3312 ("printk: add lockless ringbuffer") turned printk >> ring buffer lockless and there should be no worries panick

Re: [PATCH] x86/uaccess: Avoid barrier_nospec() in copy_from_user()

2024-10-21 Thread Kirill A. Shutemov
On Sun, Oct 20, 2024 at 03:59:25PM -0700, Linus Torvalds wrote: > On Sun, 20 Oct 2024 at 15:44, Josh Poimboeuf wrote: > > > > Anyway, I'd really like to make forward progress on getting rid of the > > LFENCEs in copy_from_user() and __get_user(), so until if/when we hear > > back from both vendors

[PATCH] char: Switch back to struct platform_driver::remove()

2024-10-21 Thread Uwe Kleine-König
After commit 0edb555a65d1 ("platform: Make platform_driver::remove() return void") .remove() is (again) the right callback to implement for platform drivers. Convert all platform drivers matched by the "CHAR and MISC DRIVERS" maintainer's entry to use .remove(), with the eventual goal to drop stru

Re: [PATCH 07/15] s390/crc32: expose CRC32 functions through lib

2024-10-21 Thread Heiko Carstens
On Sun, Oct 20, 2024 at 05:29:27PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Move the s390 CRC32 assembly code into the lib directory and wire it up > to the library interface. This allows it to be used without going > through the crypto API. It remains usable via the crypto API too v

Re: [PATCH v13 51/85] KVM: VMX: Use __kvm_faultin_page() to get APIC access page/pfn

2024-10-21 Thread Yan Zhao
On Thu, Oct 10, 2024 at 11:23:53AM -0700, Sean Christopherson wrote: > Use __kvm_faultin_page() get the APIC access page so that KVM can > precisely release the refcounted page, i.e. to remove yet another user > of kvm_pfn_to_refcounted_page(). While the path isn't handling a guest > page fault, t

Re: [PATCH v13 34/85] KVM: Get writable mapping for __kvm_vcpu_map() only when necessary

2024-10-21 Thread Yan Zhao
On Thu, Oct 10, 2024 at 11:23:36AM -0700, Sean Christopherson wrote: > When creating a memory map for read, don't request a writable pfn from the > primary MMU. While creating read-only mappings can be theoretically slower, > as they don't play nice with fast GUP due to the need to break CoW befor

Re: [PATCH v13 19/85] KVM: Introduce kvm_follow_pfn() to eventually replace "gfn_to_pfn" APIs

2024-10-21 Thread Yan Zhao
On Thu, Oct 10, 2024 at 11:23:21AM -0700, Sean Christopherson wrote: > --- a/virt/kvm/pfncache.c > +++ b/virt/kvm/pfncache.c > @@ -159,6 +159,12 @@ static kvm_pfn_t hva_to_pfn_retry(struct > gfn_to_pfn_cache *gpc) > kvm_pfn_t new_pfn = KVM_PFN_ERR_FAULT; > void *new_khva = NULL; >

Re: [PATCH][next] powerpc/ps3: replace open-coded sysfs_emit function

2024-10-21 Thread Geoff Levand
Hi Paulo, On 10/19/24 11:13, Paulo Miguel Almeida wrote: > sysfs_emit() helper function should be used when formatting the value > to be returned to user space. > > This patch replaces open-coded sysfs_emit() in sysfs .show() callbacks > > Link: https://github.com/KSPP/linux/issues/105 > Signed-

Re: [PATCH][next] powerpc/ps3: replace open-coded sysfs_emit function

2024-10-21 Thread Geert Uytterhoeven
On Sat, Oct 19, 2024 at 4:14 AM Paulo Miguel Almeida wrote: > sysfs_emit() helper function should be used when formatting the value > to be returned to user space. > > This patch replaces open-coded sysfs_emit() in sysfs .show() callbacks > > Link: https://github.com/KSPP/linux/issues/105 > Signed