[PATCH v2] powerpc/xmon: Fix tmpstr length check in scanhex

2024-08-14 Thread Madhavan Srinivasan
If a function name is greater than 63 char long, xmon command may not find them. For example, here is a test that executed an illegal instruction in a kernel function and one of call stack function has name >63 char long, cpu 0x0: Vector: 700 (Program Check) at [ca6577e0] pc: c

Re: [PATCH v3] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-08-14 Thread Michael Ellerman
Bjorn Helgaas writes: > On Sat, Aug 03, 2024 at 12:03:25AM +0530, Amit Machhiwal wrote: >> With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence >> of a PCI device attached to a PCI-bridge causes following kernel Oops on >> a pseries KVM guest: > > What is unique about pseries h

Re: OVERFLOW_KUNIT_TEST fails with BUG: KASAN: stack-out-of-bounds in string_nocheck+0x168/0x1c8 (kernel 6.11-rc2, PowerMac G4 DP)

2024-08-14 Thread Ivan Orlov
On 8/15/24 00:26, Ivan Orlov wrote: As you can see, the device name is defined as a local variable, which means that it doesn't exist out of the 'overflow_allocation_test' function scope. This patch: diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c index f314a0c15a6d..fa7ca8c94eee 10

Re: OVERFLOW_KUNIT_TEST fails with BUG: KASAN: stack-out-of-bounds in string_nocheck+0x168/0x1c8 (kernel 6.11-rc2, PowerMac G4 DP)

2024-08-14 Thread Ivan Orlov
On 8/14/24 21:38, 'Erhard Furtner' via KUnit Development wrote: On Mon, 12 Aug 2024 11:54:11 -0700 Kees Cook wrote: On Fri, Aug 09, 2024 at 11:15:37PM +0200, Erhard Furtner wrote: Greetings! When KASAN is enabled the Overflow KUnit test fails: [...] ok 16 shift_nonsense_test # ove

Re: OVERFLOW_KUNIT_TEST fails with BUG: KASAN: stack-out-of-bounds in string_nocheck+0x168/0x1c8 (kernel 6.11-rc2, PowerMac G4 DP)

2024-08-14 Thread Erhard Furtner
On Mon, 12 Aug 2024 11:54:11 -0700 Kees Cook wrote: > On Fri, Aug 09, 2024 at 11:15:37PM +0200, Erhard Furtner wrote: > > Greetings! > > > > When KASAN is enabled the Overflow KUnit test fails: > > > > [...] > > ok 16 shift_nonsense_test > > # overflow_allocation_test: 11 allocation ove

Re: [RFC v1 10/10] book3s64/hash: Disable kfence if not early init

2024-08-14 Thread Christophe Leroy
Le 31/07/2024 à 09:56, Ritesh Harjani (IBM) a écrit : [Vous ne recevez pas souvent de courriers de ritesh.l...@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Enable kfence on book3s64 hash only when early init is enabled. This is because, k

Re: [RFC v1 09/10] book3s64/radix: Refactoring common kfence related functions

2024-08-14 Thread Christophe Leroy
Le 31/07/2024 à 09:56, Ritesh Harjani (IBM) a écrit : [Vous ne recevez pas souvent de courriers de ritesh.l...@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Both radix and hash on book3s requires to detect if kfence early init is enabled o

Re: [RFC PATCH 00/18] use struct ptdesc to replace pgtable_t

2024-08-14 Thread Matthew Wilcox
On Tue, Jul 30, 2024 at 02:46:54PM +0800, al...@kernel.org wrote: > We have struct ptdesc for page table descriptor a year ago, but it > has no much usages in kernel, while pgtable_t is used widely. Hum, I thought I responded to this to point out the problem, but I don't see the response anywhere,

Re: [RFC v1 01/10] book3s64/hash: Remove kfence support temporarily

2024-08-14 Thread Christophe Leroy
Le 31/07/2024 à 09:56, Ritesh Harjani (IBM) a écrit : [Vous ne recevez pas souvent de courriers de ritesh.l...@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Kfence on book3s Hash on pseries is anyways broken. It fails to boot due to RMA si

Re: [RFC PATCH 00/18] use struct ptdesc to replace pgtable_t

2024-08-14 Thread LEROY Christophe
Hi, Le 30/07/2024 à 08:46, al...@kernel.org a écrit : > From: Alex Shi > > We have struct ptdesc for page table descriptor a year ago, but it > has no much usages in kernel, while pgtable_t is used widely. > > The pgtable_t is typedefed as 'pte_t *' in sparc, s390, powerpc and m68k > except SUN

Re: [PATCH v4 18/29] arm64: add POE signal support

2024-08-14 Thread Catalin Marinas
Hi Joey, On Tue, Aug 06, 2024 at 03:31:03PM +0100, Joey Gouly wrote: > diff --git arch/arm64/kernel/signal.c arch/arm64/kernel/signal.c > index 561986947530..ca7d4e0be275 100644 > --- arch/arm64/kernel/signal.c > +++ arch/arm64/kernel/signal.c > @@ -1024,7 +1025,10 @@ static int setup_sigframe_lay

Re: [RFC PATCH 1/6] ALSA: compress: add Sample Rate Converter codec support

2024-08-14 Thread Jaroslav Kysela
On 14. 08. 24 13:58, Pierre-Louis Bossart wrote: On 8/14/24 13:12, Shengjiu Wang wrote: On Wed, Aug 14, 2024 at 5:40 PM Pierre-Louis Bossart wrote: Yes, to go further, I think we can use SND_AUDIOCODEC_PCM, then the SRC type will be dropped. sounds good. But my understanding of the co

Re: Since 6.10 - kernel oops/panics on G4 macmini due to change in drivers/ata/pata_macio.c

2024-08-14 Thread Niklas Cassel
On Wed, Aug 14, 2024 at 10:20:55PM +1000, Michael Ellerman wrote: > Niklas Cassel writes: > > On Tue, Aug 13, 2024 at 10:32:36PM +1000, Michael Ellerman wrote: > >> Niklas Cassel writes: > >> > On Tue, Aug 13, 2024 at 07:49:34AM +0200, Jonáš Vidra wrote: > ... > >> >> [ cut here ]

[powerpc:topic/ppc-kvm] BUILD SUCCESS 9739ff4887c77a38575c23b12766b0a37c8be13c

2024-08-14 Thread kernel test robot
allmodconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-20240814 gcc-13.2.0 arc randconfig

Re: Since 6.10 - kernel oops/panics on G4 macmini due to change in drivers/ata/pata_macio.c

2024-08-14 Thread Michael Ellerman
Niklas Cassel writes: > On Tue, Aug 13, 2024 at 10:32:36PM +1000, Michael Ellerman wrote: >> Niklas Cassel writes: >> > On Tue, Aug 13, 2024 at 07:49:34AM +0200, Jonáš Vidra wrote: ... >> >> [ cut here ] >> >> kernel BUG at drivers/ata/pata_macio.c:544! >> > >> > https://g

Re: [RFC PATCH 1/6] ALSA: compress: add Sample Rate Converter codec support

2024-08-14 Thread Pierre-Louis Bossart
On 8/14/24 13:12, Shengjiu Wang wrote: > On Wed, Aug 14, 2024 at 5:40 PM Pierre-Louis Bossart > wrote: >> >> >>> Yes, to go further, I think we can use SND_AUDIOCODEC_PCM, then >>> the SRC type will be dropped. >> >> sounds good. >> >>> But my understanding of the control means the .set_metadat

Re: [RFC PATCH 1/6] ALSA: compress: add Sample Rate Converter codec support

2024-08-14 Thread Shengjiu Wang
On Wed, Aug 14, 2024 at 5:40 PM Pierre-Louis Bossart wrote: > > > > Yes, to go further, I think we can use SND_AUDIOCODEC_PCM, then > > the SRC type will be dropped. > > sounds good. > > > But my understanding of the control means the .set_metadata() API, right? > > As I said, the output rate, out

Re: [PATCH] powerpc/xmon: Fix tmpstr length check in scanhex

2024-08-14 Thread Miguel Ojeda
On Wed, Aug 14, 2024 at 12:10 PM Madhavan Srinivasan wrote: > > Reported-by: Miguel Ojeda > Signed-off-by: Madhavan Srinivasan > Link - https://lore.kernel.org/linuxppc-dev/87ilc8ym6v.fsf@mail.lhotse/ Thanks for fixing this! The "Link -" should be a tag, i.e. "Link:". And, in this case, since

Re: [PATCH] powerpc/xmon: Fix tmpstr length check in scanhex

2024-08-14 Thread Madhavan Srinivasan
On 8/14/24 3:53 PM, Miguel Ojeda wrote: On Wed, Aug 14, 2024 at 12:10 PM Madhavan Srinivasan wrote: Reported-by: Miguel Ojeda Signed-off-by: Madhavan Srinivasan Link - https://lore.kernel.org/linuxppc-dev/87ilc8ym6v.fsf@mail.lhotse/ Thanks for fixing this! The "Link -" should be a tag, i.

[PATCH] powerpc/xmon: Fix tmpstr length check in scanhex

2024-08-14 Thread Madhavan Srinivasan
If a function name is greater than 63 char long, xmon command may not find them. For example, here is a test that executed an illegal instruction in a kernel function and one of call stack function has name >63 char long, cpu 0x0: Vector: 700 (Program Check) at [ca6577e0] pc: c

Re: [RFC PATCH 1/6] ALSA: compress: add Sample Rate Converter codec support

2024-08-14 Thread Pierre-Louis Bossart
> Yes, to go further, I think we can use SND_AUDIOCODEC_PCM, then > the SRC type will be dropped. sounds good. > But my understanding of the control means the .set_metadata() API, right? > As I said, the output rate, output format, and ratio modifier are applied to > the instances of ASRC, whi

Re:[PATCH v1] powerpc/powernv/pci: fix PE in re-used pci_dn for pnv_pci_enable_device_hook

2024-08-14 Thread 虞陆铭
Hi, Looks like the latest upstream kernel has sovled the problem: echo 1 > /sys/bus/pci/devices/0001:0d:00.0/remove echo 1 > /sys/bus/pci/rescan [ 230.399969] pci_bus 0001:0d: Configuring PE for bus [ 230.399974] pci 0001:0d : [PE# fb] Secondary bus 0x000d associated with PE