Re: [PATCHv7 4/4] powerpc/setup: alloc extra paca_ptrs to hold boot_cpuid

2023-10-06 Thread Pingfan Liu
On Wed, Oct 4, 2023 at 2:07 AM Mahesh J Salgaonkar wrote: > > On 2023-09-25 15:53:48 Mon, Pingfan Liu wrote: > > paca_ptrs should be large enough to hold the boot_cpuid, hence, its > > lower boundary is set to the bigger one between boot_cpuid+1 and > > nr_cpus. > > > > On the other hand, some ker

Re: [PATCH 5/7] powerpc/pseries/papr-sysparm: expose chardev API to user space

2023-10-06 Thread kernel test robot
: eddc90ea2af5933249ea1a78119f2c8ef8d07156 patch link: https://lore.kernel.org/r/20231006-papr-sys_rtas-vs-lockdown-v1-5-3a36bfb66e2e%40linux.ibm.com patch subject: [PATCH 5/7] powerpc/pseries/papr-sysparm: expose chardev API to user space config: powerpc-allyesconfig (https://download.01.org/0day-ci

Re: [PATCH v7 24/30] net: wan: Add framer framework support

2023-10-06 Thread Jakub Kicinski
On Thu, 28 Sep 2023 09:06:42 +0200 Herve Codina wrote: > +menu "Framer Subsystem" > + > +config GENERIC_FRAMER > + bool "Framer Core" > + help > + Generic Framer support. > + A framer is a component in charge of an E1/T1 line interface. > + Connected usually to a TDM bus,

Re: [PATCH v7 26/30] net: wan: framer: Add support for the Lantiq PEF2256 framer

2023-10-06 Thread Jakub Kicinski
On Thu, 28 Sep 2023 09:06:44 +0200 Herve Codina wrote: > + for (i = 0; i < count; i++) { > + (audio_devs + i)->name = "framer-codec"; > + (audio_devs + i)->of_compatible = compatible; > + (audio_devs + i)->id = i; Why not array notation? > + } > + > +

Re: [PATCH v7 10/30] net: wan: Add support for QMC HDLC

2023-10-06 Thread Jakub Kicinski
On Thu, 28 Sep 2023 09:06:28 +0200 Herve Codina wrote: > +static int qmc_hdlc_close(struct net_device *netdev) > +{ > + struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev); > + struct qmc_hdlc_desc *desc; > + int i; > + > + netif_stop_queue(netdev); > + > + qmc_chan_stop(qmc_

[PATCH] powerpc: fsl_msi: Use device_get_match_data()

2023-10-06 Thread Rob Herring
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring --- arch/powerpc/sysdev/fsl_msi.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

[PATCH 3/7] powerpc/rtas: serialize ibm,get-vpd service with papr-vpd sequences

2023-10-06 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch Take the papr-vpd driver's internal mutex when sys_rtas performs ibm,get-vpd calls. This prevents sys_rtas(ibm,get-vpd) calls from interleaving with sequences performed by the driver, ensuring that such sequences are not disrupted. However, it cannot prevent the driver from in

[PATCH 5/7] powerpc/pseries/papr-sysparm: expose chardev API to user space

2023-10-06 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch Until now the papr_sysparm APIs have been kernel-internal. But user space needs access to PAPR system parameters too. The only method available to user space today to get or set system parameters is using sys_rtas() and /dev/mem to pass RTAS-addressable buffers between user spa

[PATCH 4/7] powerpc/pseries/papr-sysparm: validate buffer object lengths

2023-10-06 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch The ability to get and set system parameters will be exposed to user space, so let's get a little more strict about malformed papr_sysparm_buf objects. * Create accessors for the length field of struct papr_sysparm_buf. The length is always stored in MSB order and this is be

[PATCH 6/7] powerpc/selftests: add test for papr-vpd

2023-10-06 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch Add selftests for /dev/papr-vpd, exercising the common expected use cases: * Retrieve all VPD by passing an empty location code. * Retrieve the "system VPD" by passing a location code derived from DT root node properties, as done by the vpdupdate command. The tests also ver

[PATCH 7/7] powerpc/selftests: add test for papr-sysparm

2023-10-06 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch Consistently testing system parameter access is a bit difficult by nature -- the set of parameters available depends on the model and system configuration, and updating a parameter should be considered a destructive operation reserved for the admin. So we validate some of the

[PATCH 0/7] powerpc/pseries: new character devices for system parameters and VPD

2023-10-06 Thread Nathan Lynch via B4 Relay
Add character devices that expose PAPR-specific system parameters and VPD to user space. The problem: important platform features are enabled on Linux VMs through the powerpc-specific rtas() syscall in combination with writeable mappings of /dev/mem. In typical usage, this is encapsulated behind A

[PATCH 2/7] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-10-06 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch PowerVM LPARs may retrieve Vital Product Data (VPD) for system components using the ibm,get-vpd RTAS function. We can expose this to user space with a /dev/papr-vpd character device, where the programming model is: struct papr_location_code plc = { .str = "", }; /* obtain a

[PATCH 1/7] powerpc/uapi: export papr-miscdev.h header

2023-10-06 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch Allocate one identifying code (the first column of the ioctl-number table) for the collection of PAPR miscdev drivers to share. Signed-off-by: Nathan Lynch --- arch/powerpc/include/uapi/asm/papr-miscdev.h | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/powe

[PATCH v3 3/5] ASoC: da7218: Use i2c_get_match_data()

2023-10-06 Thread Rob Herring
Use preferred i2c_get_match_data() instead of of_match_device() and i2c_match_id() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Avoid using 0 for enum da7218_dev_id so that no match data can be distinguished. Signed-off-by: Rob Herring -

[PATCH v3 4/5] ASoC: qcom/lpass: Constify struct lpass_variant

2023-10-06 Thread Rob Herring
'struct lpass_variant' is used for driver match data which is supposed to be constant. It's not modified anywhere, so it's just a matter of adding 'const' everywhere. Signed-off-by: Rob Herring --- sound/soc/qcom/lpass-apq8016.c | 6 +++--- sound/soc/qcom/lpass-cdc-dma.c | 2 +- sound/soc/qc

[PATCH v3 5/5] ASoC: Use device_get_match_data()

2023-10-06 Thread Rob Herring
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring --- v3: - Move some header changes from patch 1 to here for rockchip_i2s_tdm.c, rockchip_pdm.c,

[PATCH v3 2/5] ASoC: Drop unnecessary of_match_device() calls

2023-10-06 Thread Rob Herring
If probe is reached, we've already matched the device and in the case of DT matching, the struct device_node pointer will be set. Therefore, there is no need to call of_match_device() in probe. Acked-by: Charles Keepax Signed-off-by: Rob Herring --- sound/soc/codecs/ak5386.c | 7 ++- soun

[PATCH v3 1/5] ASoC: Explicitly include correct DT includes

2023-10-06 Thread Rob Herring
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there

[PATCH v3 0/5] ASoC: DT matching and header cleanups

2023-10-06 Thread Rob Herring
(trimmed the recipient list due to bounces on v1) This is a series is part of ongoing clean-ups related to device matching and DT related implicit includes. Essentially of_device.h has a bunch of implicit includes and generally isn't needed any nore except for of_match_device(). As we also gene

Re: [PATCH v5 1/5] powerpc/code-patching: introduce patch_instructions()

2023-10-06 Thread Hari Bathini
Thanks for the review, Song. On 29/09/23 2:38 am, Song Liu wrote: On Thu, Sep 28, 2023 at 12:48 PM Hari Bathini wrote: patch_instruction() entails setting up pte, patching the instruction, clearing the pte and flushing the tlb. If multiple instructions need to be patched, every instruction wo

Re: KUEP broken on FSP2?

2023-10-06 Thread Eddie James
On 10/6/23 10:55, Christophe Leroy wrote: Hi, Le 06/10/2023 à 17:43, Eddie James a écrit : On 10/6/23 00:21, Christophe Leroy wrote: Hi, Le 05/10/2023 à 21:06, Eddie James a écrit : Hi, I'm attempting to run linux 6.1 on my FSP2, but my kernel crashes attempting to get into userspace. The

Re: [PATCH v5 1/5] powerpc/code-patching: introduce patch_instructions()

2023-10-06 Thread Hari Bathini
Hi Christophe, On 29/09/23 2:09 pm, Christophe Leroy wrote: Le 28/09/2023 à 21:48, Hari Bathini a écrit : patch_instruction() entails setting up pte, patching the instruction, clearing the pte and flushing the tlb. If multiple instructions need to be patched, every instruction would have to

Re: KUEP broken on FSP2?

2023-10-06 Thread Christophe Leroy
Hi, Le 06/10/2023 à 17:43, Eddie James a écrit : > > On 10/6/23 00:21, Christophe Leroy wrote: >> Hi, >> >> Le 05/10/2023 à 21:06, Eddie James a écrit : >>> Hi, >>> >>> I'm attempting to run linux 6.1 on my FSP2, but my kernel crashes >>> attempting to get into userspace. The init script works, b

Re: KUEP broken on FSP2?

2023-10-06 Thread Eddie James
On 10/6/23 00:21, Christophe Leroy wrote: Hi, Le 05/10/2023 à 21:06, Eddie James a écrit : Hi, I'm attempting to run linux 6.1 on my FSP2, but my kernel crashes attempting to get into userspace. The init script works, but the first binary (mount) I run results in oops. Can anyone help me to

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2023-10-06 Thread Erhard Furtner
On Fri, 06 Oct 2023 17:38:14 +0530 "Aneesh Kumar K.V" wrote: > Sorry that I shared a change without build testing. Here is the updated > change > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index 3ba9fe411604..e563e13ffd88 100644 > --- a/arch/powerpc/mm/pgtable.c > +

Re: [PATCH] powerpc/iommu: Do not do platform domain attach atctions after probe

2023-10-06 Thread Joerg Roedel
On Thu, Oct 05, 2023 at 10:35:11AM -0300, Jason Gunthorpe wrote: > arch/powerpc/kernel/iommu.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Applied, thanks. -- Jörg Rödel jroe...@suse.de SUSE Software Solutions Germany GmbH Frankenstraße 146 90461 Nürnberg Germany (HRB 3

Re: [Bisected] [commit 2ad56efa80db] [Hotplug] WARNING while performing hotplug operation on 6.6-rc3-next

2023-10-06 Thread Tasmiya Nalatwad
Thanks Jason for confirmation and the fix. On 10/6/23 19:09, Jason Gunthorpe wrote: On Fri, Oct 06, 2023 at 06:50:00PM +0530, Tasmiya Nalatwad wrote: Greetings, Thanks Jason. The fix provided by you works. It is not giving WARNING's but i am seeing below logs. Would you please

Re: [Bisected] [commit 2ad56efa80db] [Hotplug] WARNING while performing hotplug operation on 6.6-rc3-next

2023-10-06 Thread Jason Gunthorpe
On Fri, Oct 06, 2023 at 06:50:00PM +0530, Tasmiya Nalatwad wrote: >Greetings, > >Thanks Jason. > >The fix provided by you works. It is not giving WARNING's but i am >seeing below logs. Would you please confirm on the logs. I don't know anything about your environment but those lo

Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes

2023-10-06 Thread Fuad Tabba
Hi Sean, On Fri, Oct 6, 2023 at 4:21 AM Sean Christopherson wrote: > > On Thu, Oct 05, 2023, Fuad Tabba wrote: > > Hi Sean, > > > > On Tue, Oct 3, 2023 at 9:51 PM Sean Christopherson > > wrote: > > > > Like I said, pKVM doesn't need a userspace ABI for managing > > > > PRIVATE/SHARED, > > > >

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2023-10-06 Thread Aneesh Kumar K.V
Erhard Furtner writes: > On Fri, 06 Oct 2023 11:04:15 +0530 > "Aneesh Kumar K.V" wrote: > >> Can you check this change? >> >> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c >> index 3ba9fe411604..6d144fedd557 100644 > ... >> void unmap_kernel_page(unsigned long va) > > Th

Re: [Bisected] [commit 2ad56efa80db] [Hotplug] WARNING while performing hotplug operation on 6.6-rc3-next

2023-10-06 Thread Jason Gunthorpe
On Fri, Oct 06, 2023 at 01:20:17PM +0530, Tasmiya Nalatwad wrote: > Greetings, > > [linux-next] [6.6.0-rc3-next-20230929] WARNING: CPU: 5 PID: 185612 at > drivers/iommu/iommu.c:3049 iommu_setup_default_domain+0x410/0x680 > > --- Traces --- > > [ 6296.425934] WARNING: CPU: 5 PID: 185612 at driver

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2023-10-06 Thread Erhard Furtner
On Fri, 06 Oct 2023 11:04:15 +0530 "Aneesh Kumar K.V" wrote: > Can you check this change? > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index 3ba9fe411604..6d144fedd557 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -187,8 +187,8 @@ sta

Re: [PATCH] ALSA: aoa: Replace asm/prom.h with explicit includes

2023-10-06 Thread Takashi Iwai
On Tue, 03 Oct 2023 18:32:02 +0200, Rob Herring wrote: > > asm/prom.h should not be included directly as it no longer contains > anything drivers need. Drivers should include of.h and/or other headers > which were getting implicitly included. > > Signed-off-by: Rob Herring Applied now to for-ne

Re: [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures

2023-10-06 Thread Thomas Bogendoerfer
On Thu, Sep 21, 2023 at 07:04:23PM +0800, Baoquan He wrote: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior. So remove the ioremap_uc() definition in architecutures > other than x86 and ia64. These a

Re: [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures

2023-10-06 Thread John Paul Adrian Glaubitz
On Thu, 2023-09-21 at 19:04 +0800, Baoquan He wrote: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior. So remove the ioremap_uc() definition in architecutures > other than x86 and ia64. These architec

[Bisected] [commit 2ad56efa80db] [Hotplug] WARNING while performing hotplug operation on 6.6-rc3-next

2023-10-06 Thread Tasmiya Nalatwad
Greetings, [linux-next] [6.6.0-rc3-next-20230929] WARNING: CPU: 5 PID: 185612 at drivers/iommu/iommu.c:3049 iommu_setup_default_domain+0x410/0x680 --- Traces --- [ 6296.425934] WARNING: CPU: 5 PID: 185612 at drivers/iommu/iommu.c:3049 iommu_setup_default_domain+0x410/0x680 [ 6296.425945] Mod