Re: [PATCH v3] kbuild: Show marked Kconfig fragments in "help"

2023-09-01 Thread Masahiro Yamada
On Sat, Sep 2, 2023 at 4:50 AM Kees Cook wrote: > > On Fri, Sep 01, 2023 at 04:58:37PM +0900, Masahiro Yamada wrote: > > On Fri, Sep 1, 2023 at 4:13 AM Kees Cook wrote: > > > > > > Currently the Kconfig fragments in kernel/configs and arch/*/configs > > > that aren't used internally aren't discov

Re: [PATCH v3] kbuild: Show marked Kconfig fragments in "help"

2023-09-01 Thread Michael Ellerman
Kees Cook writes: > Currently the Kconfig fragments in kernel/configs and arch/*/configs > that aren't used internally aren't discoverable through "make help", > which consists of hard-coded lists of config fragments. Instead, list > all the fragment targets that have a "# Help: " comment prefix s

Re: [PATCH gmem FIXUP] mm, compaction: make testing mapping_unmovable() safe

2023-09-01 Thread kirill . shutemov
On Fri, Sep 01, 2023 at 10:20:26AM +0200, Vlastimil Babka wrote: > As Kirill pointed out, mapping can be removed under us due to > truncation. Test it under folio lock as already done for the async > compaction / dirty folio case. To prevent locking every folio with > mapping to do the test, do it

Re: [PATCH v3] kbuild: Show marked Kconfig fragments in "help"

2023-09-01 Thread Kees Cook
On Fri, Sep 01, 2023 at 04:58:37PM +0900, Masahiro Yamada wrote: > On Fri, Sep 1, 2023 at 4:13 AM Kees Cook wrote: > > > > Currently the Kconfig fragments in kernel/configs and arch/*/configs > > that aren't used internally aren't discoverable through "make help", > > which consists of hard-coded

[PATCH 2/2] powerpc/fadump: make is_kdump_kernel() return false when fadump is active

2023-09-01 Thread Hari Bathini
Currently, is_kdump_kernel() returns true in crash dump capture kernel for both kdump and fadump crash dump capturing methods, as both these methods set elfcorehdr_addr. Some restrictions enforced for crash dump capture kernel, based on is_kdump_kernel(), are specifically meant for kdump case and n

[PATCH 1/2] vmcore: allow alternate dump capturing methods to export vmcore without is_kdump_kernel()

2023-09-01 Thread Hari Bathini
Currently, is_kdump_kernel() returns true when elfcorehdr_addr is set. While elfcorehdr_addr is set for kexec based kernel dump mechanism, alternate dump capturing methods like fadump [1] also set it to export the vmcore. is_kdump_kernel() is used to restrict resources in crash dump capture kernel

Re: [PATCH v2 3/3] kconfig: add dependencies of POWER_RESET for PowerMac

2023-09-01 Thread Yuan Tan
Hi, On 9/1/2023 2:10 PM, Christophe Leroy wrote: Le 01/09/2023 à 04:43, Yuan Tan a écrit : PowerMac's power off depends on ADB_CUDA to work. Enable it when POWER_RESET is set for convenience. Suggested-by: Zhangjin Wu Signed-off-by: Yuan Tan --- arch/powerpc/platforms/powermac/Kconfig |

Re: [PATCH] powerpc/powernv: use appropiate error code

2023-09-01 Thread Immad Mir
On 01/09/23 11:10 pm, Christophe Leroy wrote: Le 01/09/2023 à 19:19, mirim...@outlook.com a écrit : [Vous ne recevez pas souvent de courriers de mirim...@outlook.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] From: Immad Mir -1 is not a valid

Re: [PATCH] powerpc/powernv: use appropiate error code

2023-09-01 Thread Immad Mir
On 01/09/23 11:10 pm, Christophe Leroy wrote: Le 01/09/2023 à 19:19, mirim...@outlook.com a écrit : [Vous ne recevez pas souvent de courriers de mirim...@outlook.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] From: Immad Mir -1 is not a valid

Re: [PATCH] powerpc/powernv: use appropiate error code

2023-09-01 Thread Christophe Leroy
Le 01/09/2023 à 19:19, mirim...@outlook.com a écrit : > [Vous ne recevez pas souvent de courriers de mirim...@outlook.com. Découvrez > pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > From: Immad Mir > > -1 is not a valid error code. This patch replaces it wit

[PATCH] powerpc/powernv: use appropiate error code

2023-09-01 Thread mirimmad
From: Immad Mir -1 is not a valid error code. This patch replaces it with -EPERM. Signed-off-by: Immad Mir --- arch/powerpc/platforms/powernv/opal-xscom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c b/arch/powerpc/platfor

Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-09-01 Thread Ackerley Tng
Binbin Wu writes: > > >> >> I'm not sure whose refcount the folio_put() in kvm_gmem_allocate() is >> dropping though: >> >> + The refcount for the filemap depends on whether this is a hugepage or >>not, but folio_put() strictly drops a refcount of 1. >> + The refcount for the lru list is jus

[PATCH 4/4] fbdev: Replace fb_pgprotect() with fb_pgprot_device()

2023-09-01 Thread Thomas Zimmermann
Rename the fbdev mmap helper fb_pgprotect() to fb_pgprot_device(). The helper sets VMA page-access flags for framebuffers in device I/O memory. The new name follows pgprot_device(), which does the same for arbitrary devices. Also clean up the helper's parameters and return value. Instead of the VM

[PATCH 0/4] ppc, fbdev: Clean up fbdev mmap helper

2023-09-01 Thread Thomas Zimmermann
Refactor fb_pgprotect() in PowerPC to work without struct file. Then clean up and rename fb_pgprotect(). This change has been discussed at [1] in the context of refactoring fbdev's mmap code. The first three patches adapt PowerPC's internal interfaces to provide a phys_mem_access_prot() that works

[PATCH 2/4] arch/powerpc: Remove file parameter from phys_mem_access_prot code

2023-09-01 Thread Thomas Zimmermann
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot and its implementation in pci_phys_mem_access_prot(). The file is not used on PowerPC. By removing it, a later patch can simplify fbdev's mmap code, which uses phys_mem_access_prot() on PowerPC. Signed-off-by: Thomas Zimmermann

[PATCH 3/4] arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code

2023-09-01 Thread Thomas Zimmermann
Call __phys_mem_access_prot() from the fbdev mmap helper fb_pgprotect(). Allows us to avoid the file argument, which can then be removed from fB_pgprotect() entirely. No other architecture uses the parameter. Signed-off-by: Thomas Zimmermann --- arch/powerpc/include/asm/fb.h | 6 +++--- 1 file c

[PATCH 1/4] arch/powerpc: Remove trailing whitespaces

2023-09-01 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- arch/powerpc/include/asm/machdep.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h index 4f6e7d7ee388..933465ed4c4

Re: [PATCH v3] fsl_ucc_hdlc: process the result of hold_open()

2023-09-01 Thread Denis Kirjanov
On 9/1/23 13:48, Александра Дюпина wrote: > Thanks for the review! > > 28.08.2023 22:38, Jakub Kicinski пишет: >> Don't you have to undo all the things done prior to hdlc_open()? > Yes, it looks like I really need to undo everything that was done before > hdlc_open(). > But the question arose

Re: [PATCH v3] fsl_ucc_hdlc: process the result of hold_open()

2023-09-01 Thread Александра Дюпина
Thanks for the review! 28.08.2023 22:38, Jakub Kicinski пишет: Don't you have to undo all the things done prior to hdlc_open()? Yes, it looks like I really need to undo everything that was done before hdlc_open(). But the question arose - would it be enough to call the uhdlc_close(dev) functio

Re: [RFC PATCH v11 10/29] mm: Add AS_UNMOVABLE to mark mapping as completely unmovable

2023-09-01 Thread Vlastimil Babka
On 7/25/23 14:51, Matthew Wilcox wrote: > On Tue, Jul 25, 2023 at 01:24:03PM +0300, Kirill A . Shutemov wrote: >> On Tue, Jul 18, 2023 at 04:44:53PM -0700, Sean Christopherson wrote: >> > diff --git a/mm/compaction.c b/mm/compaction.c >> > index dbc9f86b1934..a3d2b132df52 100644 >> > --- a/mm/compa

[PATCH gmem FIXUP] mm, compaction: make testing mapping_unmovable() safe

2023-09-01 Thread Vlastimil Babka
As Kirill pointed out, mapping can be removed under us due to truncation. Test it under folio lock as already done for the async compaction / dirty folio case. To prevent locking every folio with mapping to do the test, do it only for unevictable folios, as we can expect the unmovable mapping folio

Re: [PATCH v3] kbuild: Show marked Kconfig fragments in "help"

2023-09-01 Thread Masahiro Yamada
On Fri, Sep 1, 2023 at 4:13 AM Kees Cook wrote: > > Currently the Kconfig fragments in kernel/configs and arch/*/configs > that aren't used internally aren't discoverable through "make help", > which consists of hard-coded lists of config fragments. Instead, list > all the fragment targets that ha

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-09-01 Thread Christophe Leroy
Le 01/09/2023 à 00:44, Erhard Furtner a écrit : > On Thu, 31 Aug 2023 05:32:46 + > Christophe Leroy wrote: > >> Ok so there is some corrupted memory somewhere. >> >> Can you try what happens when you remove the call to kasan_init() at the >> start of setup_arch() in arch/powerpc/kernel/setu