Re: [PATCH 2/2] powerpc/xmon: use KSYM_NAME_LEN in array size

2023-05-29 Thread Michael Ellerman
Maninder Singh writes: > kallsyms_lookup which in turn calls for kallsyms_lookup_buildid() > writes on index "KSYM_NAME_LEN - 1". > > Thus array size should be KSYM_NAME_LEN. > > for powerpc it was defined as "128" directly. > and commit '61968dbc2d5d' changed define value to 512, > So both were m

Re: [PATCH] powerpc: Fail build if using recordmcount with binutils v2.37

2023-05-29 Thread Naveen N Rao
Michael Ellerman wrote: Naveen N Rao writes: binutils v2.37 drops unused section symbols, which prevents recordmcount from capturing mcount locations in sections that have no non-weak symbols. This results in a build failure with a message such as: Cannot find symbol for section 12: .te

[PATCH v2] powerpc: Fail build if using recordmcount with binutils v2.37

2023-05-29 Thread Naveen N Rao
binutils v2.37 drops unused section symbols, which prevents recordmcount from capturing mcount locations in sections that have no non-weak symbols. This results in a build failure with a message such as: Cannot find symbol for section 12: .text.perf_callchain_kernel. kernel/events/c

Re: WARNING at fs/btrfs/disk-io.c:275 during xfstests run(4k block)

2023-05-29 Thread Christoph Hellwig
This should be fixed by "btrfs: fix the uptodate assert in btree_csum_one_bio" on the list.

Re: [PATCH] powerpc/crypto: Fix aes-gcm-p10 link errors

2023-05-29 Thread Vishal Chourasia
On 5/25/23 20:35, Michael Ellerman wrote: The recently added P10 AES/GCM code added some files containing CRYPTOGAMS perl-asm code which are near duplicates of the p8 files found in drivers/crypto/vmx. In particular the newly added files produce functions with identical names to the existing cod

Kernel crash with ftrace tests

2023-05-29 Thread Sachin Sant
While running ftrace specific kernel selftests on IBM Power9 server, following crash is observed. I have observed this crash only on Power9. Similar test run on a Power10 server works. [14350.791484] Kernel attempted to read user page (8) - exploit attempt? (uid: 0) [14350.791507] BUG: Kernel NUL

Re: [PATCH] powerpc/crypto: Fix aes-gcm-p10 link errors

2023-05-29 Thread Vishal Chourasia
After applying the patch, I was able to successfully build the Linux kernel v6.4-rc4. I encountered no errors during the build process. The issue pertaining to multiple definitions of certain functions appears to be resolved. λ grep -i CRYPTO_AES_GCM_P10 .config CONFIG_CRYPTO_AES_GCM_P10=y λ g

WARNING at fs/btrfs/disk-io.c:275 during xfstests run(4k block)

2023-05-29 Thread Sachin Sant
While running xfstests against btrfs (with 4k block size) on IBM Power server booted with 6.4.0-rc3-next-20230525, following warning is seen. This warning Is seen several times during the test run. This problem was first seen with 6.4.0-rc2-next-20230516 [ 365.885258] run fstests btrfs/001 at 202

Re: [PATCH] powerpc: Fail build if using recordmcount with binutils v2.37

2023-05-29 Thread Michael Ellerman
Naveen N Rao writes: > binutils v2.37 drops unused section symbols, which prevents recordmcount > from capturing mcount locations in sections that have no non-weak > symbols. This results in a build failure with a message such as: > Cannot find symbol for section 12: .text.perf_callchain_ker

Re: [PATCH 09/12] mm/khugepaged: retract_page_tables() without mmap or vma lock

2023-05-29 Thread Peter Xu
On Sun, May 28, 2023 at 11:25:15PM -0700, Hugh Dickins wrote: > Simplify shmem and file THP collapse's retract_page_tables(), and relax > its locking: to improve its success rate and to lessen impact on others. > > Instead of its MADV_COLLAPSE case doing set_huge_pmd() at target_addr of > target_m

[PATCH] powerpc/kcsan: Properly instrument arch_spin_unlock()

2023-05-29 Thread Christophe Leroy
The following boottime error is encountered with SMP kernel: kcsan: improperly instrumented type=(0): arch_spin_unlock(&arch_spinlock) kcsan: improperly instrumented type=(0): spin_unlock(&test_spinlock) kcsan: improperly instrumented type=(KCSAN_ACCESS_WRITE): arch_spin_unlock(&arch_spinlo

Re: [PATCH 1/1] arch:hexagon/powerpc: use KSYM_NAME_LEN in array size

2023-05-29 Thread Miguel Ojeda
On Mon, May 29, 2023 at 1:08 PM Maninder Singh wrote: > > I Will add co-developed-by` tag. > because this change was identified while we were working on kallsyms some > time back. > https://lore.kernel.org/lkml/yontol4zc4cyt...@infradead.org/t/ > > this patch set is pending and we will start work

Re: [PATCH 05/12] powerpc: add pte_free_defer() for pgtables sharing page

2023-05-29 Thread Hugh Dickins
On Mon, 29 May 2023, Matthew Wilcox wrote: > On Sun, May 28, 2023 at 11:20:21PM -0700, Hugh Dickins wrote: > > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) > > +{ > > + struct page *page; > > + > > + page = virt_to_page(pgtable); > > + call_rcu(&page->rcu_head, pte_free_now);

Re: [PATCH 05/12] powerpc: add pte_free_defer() for pgtables sharing page

2023-05-29 Thread Matthew Wilcox
On Sun, May 28, 2023 at 11:20:21PM -0700, Hugh Dickins wrote: > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) > +{ > + struct page *page; > + > + page = virt_to_page(pgtable); > + call_rcu(&page->rcu_head, pte_free_now); > +} This can't be safe (on ppc). IIRC you might

Re: [PATCH 02/12] mm/pgtable: add PAE safety to __pte_offset_map()

2023-05-29 Thread Matthew Wilcox
On Sun, May 28, 2023 at 11:16:16PM -0700, Hugh Dickins wrote: > +#if defined(CONFIG_GUP_GET_PXX_LOW_HIGH) && \ > + (defined(CONFIG_SMP) || defined(CONFIG_PREEMPT_RCU)) > +/* > + * See the comment above ptep_get_lockless() in include/linux/pgtable.h: > + * the barriers in pmdp_get_lockless() can

[PATCH] powerpc: Fail build if using recordmcount with binutils v2.37

2023-05-29 Thread Naveen N Rao
binutils v2.37 drops unused section symbols, which prevents recordmcount from capturing mcount locations in sections that have no non-weak symbols. This results in a build failure with a message such as: Cannot find symbol for section 12: .text.perf_callchain_kernel. kernel/events/c

[PATCH 2/2] powerpc/xmon: use KSYM_NAME_LEN in array size

2023-05-29 Thread Maninder Singh
kallsyms_lookup which in turn calls for kallsyms_lookup_buildid() writes on index "KSYM_NAME_LEN - 1". Thus array size should be KSYM_NAME_LEN. for powerpc it was defined as "128" directly. and commit '61968dbc2d5d' changed define value to 512, So both were missed to update with new size. Fixes:

[PATCH 1/2] hexagon/traps.c: use KSYM_NAME_LEN in array size

2023-05-29 Thread Maninder Singh
kallsyms_lookup which in turn calls for kallsyms_lookup_buildid() writes on index "KSYM_NAME_LEN - 1". Thus array size should be KSYM_NAME_LEN. for hexagon it was defined as "128" directly. and commit '61968dbc2d5d' changed define value to 512, So both were missed to update with new size. Fixes:

RE: [PATCH 1/1] arch:hexagon/powerpc: use KSYM_NAME_LEN in array size

2023-05-29 Thread Maninder Singh
Hi, >> >> kallsyms_lookup which in turn calls for kallsyms_lookup_buildid() >> writes on index "KSYM_NAME_LEN - 1". >> >> Thus array size should be KSYM_NAME_LEN. >> >> for powerpc and hexagon it was defined as "128" directly. >> and commit '61968dbc2d5d' changed define value to 512, >> So both we

Re: [PATCH 1/1] arch:hexagon/powerpc: use KSYM_NAME_LEN in array size

2023-05-29 Thread Miguel Ojeda
On Mon, May 29, 2023 at 7:44 AM Maninder Singh wrote: > > kallsyms_lookup which in turn calls for kallsyms_lookup_buildid() > writes on index "KSYM_NAME_LEN - 1". > > Thus array size should be KSYM_NAME_LEN. > > for powerpc and hexagon it was defined as "128" directly. > and commit '61968dbc2d5d'

Re: Fwd: ./include/linux/mmzone.h:1735:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE (v6.4-rc3 build regression)

2023-05-29 Thread Bagas Sanjaya
On Wed, May 24, 2023 at 06:13:52PM +0300, Doru Iorgulescu wrote: > Awesome, thanks! tl;dr: see [1]. (Hey, looks like complimenting noise here.) [1]: https://lore.kernel.org/regressions/5df92692-296e-3956-24fa-2bd439337...@gmail.com/ -- An old man doll... just what I always wanted! - Clara s