Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Mike Rapoport
Andrew, On Sun, Feb 12, 2023 at 10:37:15PM -0800, Guenter Roeck wrote: > On 2/12/23 17:26, Mike Rapoport wrote: > > On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: > > > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > > > From: "Mike Rapoport (IBM)" > > > > > >

Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

2023-02-12 Thread Andrew Donnellan
On Mon, 2023-02-13 at 16:26 +1100, Michael Ellerman wrote: > Andrew Donnellan writes: > > On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote: > > > > > +err: > > > > > +    kfree(var.data); > > > > > > > > remove the kfree() > > > > > > Actually don't remove it but it should probably be > >

Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

2023-02-12 Thread Andrew Donnellan
On Fri, 2023-02-10 at 16:23 -0500, Stefan Berger wrote: > > +   memcpy(&flags, data, sizeof(flags)); > > conversion from bytestream to integer: I think in this case it would > be better to use > > flags = cpu_to_be64p((__u64*)data); > > so that the flags always in hypervisor/big endian forma

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Guenter Roeck
On 2/12/23 17:26, Mike Rapoport wrote: On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" Every architecture that supports FLATMEM memory model defines its own version of pfn_valid() that es

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

2023-02-12 Thread Guenter Roeck
On 2/12/23 17:15, Mike Rapoport wrote: Hi, On Sun, Feb 12, 2023 at 09:35:13AM -0800, Guenter Roeck wrote: Hi, On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" The MMU variant uses generic definitions of page_to_pfn() and pfn_to_page(), but !MMU defi

Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

2023-02-12 Thread Michael Ellerman
Andrew Donnellan writes: > On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote: >> > > +err: >> > > +    kfree(var.data); >> > >> > remove the kfree() >> >> Actually don't remove it but it should probably be >> >> if (var.data != &version) >> kfree(var.data); >> > > Argh, thanks for ca

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Mike Rapoport
On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > Every architecture that supports FLATMEM memory model defines its own > > version of pfn_valid() that essentially compares a pfn

[powerpc:next] BUILD SUCCESS 99dcb8a071130d5a5d33d255416debf7f5a92a06

2023-02-12 Thread kernel test robot
successfully. More configs may be tested in the coming days. gcc tested configs: alphaallyesconfig arc randconfig-r043-20230212 arm at91_dt_defconfig arm randconfig-r046-20230212 arm

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

2023-02-12 Thread Mike Rapoport
Hi, On Sun, Feb 12, 2023 at 09:35:13AM -0800, Guenter Roeck wrote: > Hi, > > On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > The MMU variant uses generic definitions of page_to_pfn() and > > pfn_to_page(), but !MMU defines them in include/a

[powerpc:next-test] BUILD SUCCESS 2b42c8057a19768a3f203feee8fe16965ff119b5

2023-02-12 Thread kernel test robot
built successfully. More configs may be tested in the coming days. gcc tested configs: alpha defconfig arc defconfig arc randconfig-r043-20230212 arm allmodconfig arm

Re: linux-next: build failure after merge of the powerpc tree

2023-02-12 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > After merging the powerpc tree, today's linux-next build (powerpc64 > allnoconfig) failed like this: > > arch/powerpc/kernel/setup_64.c: In function 'early_setup': > arch/powerpc/kernel/setup_64.c:400:34: error: 'struct thread_info' has no > member named 'cp

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.2-5 tag

2023-02-12 Thread pr-tracker-bot
The pull request you sent on Sun, 12 Feb 2023 18:05:00 +1100: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-6.2-5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/49a0bdb0a38e222d35c50644468856e2408764f0 Thank you! -- Deet-doot-do

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Guenter Roeck
On 2/12/23 08:26, Mike Rapoport wrote: Hi Guenter, On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" Every architecture that supports FLATMEM memory model defines its own version of pfn_va

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

2023-02-12 Thread Guenter Roeck
Hi, On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The MMU variant uses generic definitions of page_to_pfn() and > pfn_to_page(), but !MMU defines them in include/asm/page_no.h for no > good reason. > > Include asm-generic/memory_model.h in the

Re: [PATCH 04/11] drivers/ps3: Read video= option with fb_get_option()

2023-02-12 Thread Geoff Levand
Hi Thomas, On 2/9/23 05:55, Thomas Zimmermann wrote: > Get the kernel's global video= parameter with fb_get_option(). Done > to unexport the internal fbdev state fb_mode_config. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/ps3/ps3av.c | 11 +-- > 1 file

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Mike Rapoport
Hi Guenter, On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > Every architecture that supports FLATMEM memory model defines its own > > version of pfn_valid() that essentially co

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Guenter Roeck
On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Every architecture that supports FLATMEM memory model defines its own > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > Use mips/powerpc version implemented as static inline

Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

2023-02-12 Thread Andrew Donnellan
On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote: > > > +err: > > > +    kfree(var.data); > > > > remove the kfree() > > Actually don't remove it but it should probably be > > if (var.data != &version) > kfree(var.data); > Argh, thanks for catching this. I don't think the condition

Re: [PATCH v6 21/26] powerpc/pseries: Clarify warning when PLPKS password already set

2023-02-12 Thread Andrew Donnellan
On Fri, 2023-02-10 at 15:47 -0500, Stefan Berger wrote: > > > On 2/10/23 03:03, Andrew Donnellan wrote: > > When the H_PKS_GEN_PASSWORD hcall returns H_IN_USE, operations that > > require > > authentication (i.e. anything other than reading a world-readable > > variable) > > will not work. > > >

[PATCH 2/2] char/agp: introduce asm-generic/agp.h

2023-02-12 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" There are several architectures that duplicate definitions of map_page_into_agp(), unmap_page_from_agp() and flush_agp_cache(). Define those in asm-generic/agp.h and use it instead of duplicated per-architecture headers. Signed-off-by: Mike Rapoport (IBM) --- arch/

[PATCH 1/2] char/agp: consolidate {alloc,free}_gatt_pages()

2023-02-12 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" There is a copy of alloc_gatt_pages() and free_gatt_pages in several architectures in arch/$ARCH/include/asm/agp.h. All the copies do exactly the same: alias alloc_gatt_pages() to __get_free_pages(GFP_KERNEL) and alias free_gatt_pages() to free_pages(). Define alloc_g

[PATCH 0/2] char/agp: consolidate asm/agp.h

2023-02-12 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" Hi, asm/agp.h is duplicated in several architectures, with x86 being the only instance that differs from the rest. Introduce asm-generic/agp.h and use it instead of per-architecture headers for the most cases. I believe that asm-generic is the best tree to pick up t