Re: [PATCH v6 4/8] phy: fsl: Add Lynx 10G SerDes driver

2022-09-23 Thread Vinod Koul
On 20-09-22, 16:23, Sean Anderson wrote: > This adds support for the Lynx 10G "SerDes" devices found on various NXP > QorIQ SoCs. There may be up to four SerDes devices on each SoC, each > supporting up to eight lanes. Protocol support for each SerDes is highly > heterogeneous, with each SoC typica

Re: [PATCH] powerpc/irq: Modernise inline assembly in irq_soft_mask_{set,return}

2022-09-23 Thread Nicholas Piggin
On Sat Sep 24, 2022 at 8:15 AM AEST, Segher Boessenkool wrote: > On Sat, Sep 24, 2022 at 02:26:52AM +1000, Nicholas Piggin wrote: > > I still don't see what clauses guarantees asm("%0" ::"r"(foo)) to give > > 13. It doesn't say access via inline assembly is special, > > But it is. It is for all re

Re: [PATCH] powerpc/pseries: Move vas_migration_handler early during migration

2022-09-23 Thread Nathan Lynch
Haren Myneni writes: > On Thu, 2022-09-22 at 07:14 -0500, Nathan Lynch wrote: >> Haren Myneni writes: >> > When the migration is initiated, the hypervisor changes VAS >> > mappings as part of pre-migration event. Then the OS gets the >> > migration event which closes all VAS windows before the mi

Re: [PATCH] powerpc/irq: Modernise inline assembly in irq_soft_mask_{set,return}

2022-09-23 Thread Segher Boessenkool
On Sat, Sep 24, 2022 at 02:26:52AM +1000, Nicholas Piggin wrote: > I still don't see what clauses guarantees asm("%0" ::"r"(foo)) to give > 13. It doesn't say access via inline assembly is special, But it is. It is for all register variables, local and global. I agree this isn't documented clear

[linux-next:master] BUILD REGRESSION aaa11ce2ffc84166d11c4d2ac88c3fcf75425fbd

2022-09-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: aaa11ce2ffc84166d11c4d2ac88c3fcf75425fbd Add linux-next specific files for 20220923 Error/Warning reports: https://lore.kernel.org/linux-doc/202209231933.vcyettul-...@intel.com https

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-23 Thread Michal Suchánek
Hello, On Fri, Sep 23, 2022 at 03:03:36PM -0400, Mimi Zohar wrote: > On Fri, 2022-09-23 at 19:10 +0200, Michal Suchanek wrote: > > Hello, > > > > this is backport of commit 0d519cadf751 > > ("arm64: kexec_file: use more system keyrings to verify kernel image > > signature") > > to table 5.15 tre

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-23 Thread Mimi Zohar
On Fri, 2022-09-23 at 19:10 +0200, Michal Suchanek wrote: > Hello, > > this is backport of commit 0d519cadf751 > ("arm64: kexec_file: use more system keyrings to verify kernel image > signature") > to table 5.15 tree including the preparatory patches. > > Some patches needed minor adjustment for

Re: [PATCH] Revert "ASoC: fsl_audmix: make clock and output src write only"

2022-09-23 Thread Mark Brown
On Tue, 6 Sep 2022 14:49:21 +0800, Shengjiu Wang wrote: > This reverts commit 944c517b8c838832a166f1c89afbf8724f4a6b49. > > There is error after making clock and output src write only > > $amixer -c imxaudmix cset numid=1 1 > amixer: Cannot read the given element from control sysdefault:3 > > [.

Re: [PATCH 2/2] powerpc/rtas: block error injection when locked down

2022-09-23 Thread Paul Moore
On Fri, Sep 23, 2022 at 11:40 AM Nathan Lynch wrote: > Michael Ellerman writes: > > Paul Moore writes: > >> On Thu, Sep 22, 2022 at 3:38 PM Nathan Lynch wrote: > >>> > >>> The error injection facility on pseries VMs allows corruption of > >>> arbitrary guest memory, potentially enabling a suffi

[PATCH 5.15 3/6] kexec: drop weak attribute from functions

2022-09-23 Thread Michal Suchanek
From: "Naveen N. Rao" commit 0738eceb6201691534df07e0928d0a6168a35787 upstream. Drop __weak attribute from functions in kexec_core.c: - machine_kexec_post_load() - arch_kexec_protect_crashkres() - arch_kexec_unprotect_crashkres() - crash_free_reserved_phys_range() Link: https://lkml.kernel.org

[PATCH 5.15 2/6] kexec_file: drop weak attribute from functions

2022-09-23 Thread Michal Suchanek
From: "Naveen N. Rao" commit 65d9a9a60fd71be964effb2e94747a6acb6e7015 upstream. As requested (http://lkml.kernel.org/r/87ee0q7b92@email.froward.int.ebiederm.org), this series converts weak functions in kexec to use the #ifdef approach. Quoting the 3e35142ef99fe ("kexec_file: drop weak attri

[PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-23 Thread Michal Suchanek
Hello, this is backport of commit 0d519cadf751 ("arm64: kexec_file: use more system keyrings to verify kernel image signature") to table 5.15 tree including the preparatory patches. Some patches needed minor adjustment for context. Thanks Michal Coiby Xu (3): kexec: clean up arch_kexec_kern

Re: [PATCH] ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data()

2022-09-23 Thread Mark Brown
On Fri, 23 Sep 2022 17:03:55 +0800, Gaosheng Cui wrote: > The imx_pcm_dma_params_init_data() are no longer used since > commit c31da0b196f9 ("ASoC: imx-ssi: Remove unused driver"), > and the function is used to initialize some members of > "struct imx_dma_data", it's more readable to assign the val

Re: [PATCH][next] powerpc: Fix fall-through warning for Clang

2022-09-23 Thread Gustavo A. R. Silva
Applied to powerpc/next. Great. :) Thanks, Michael. -- Gustavo

Re: [RFC PATCH 2/2] powerpc: nop trap instruction after WARN_ONCE fires

2022-09-23 Thread Christophe Leroy
Le 23/09/2022 à 17:41, Nicholas Piggin a écrit : > WARN_ONCE and similar are often used in frequently executed code, and > should not crash the system. The program check interrupt caused by > WARN_ON_ONCE can be a significant overhead even when nothing is being > printed. This can cause performan

Re: [PATCH] powerpc/irq: Modernise inline assembly in irq_soft_mask_{set,return}

2022-09-23 Thread Nicholas Piggin
On Fri Sep 23, 2022 at 10:18 PM AEST, Segher Boessenkool wrote: > On Fri, Sep 23, 2022 at 05:08:13PM +1000, Nicholas Piggin wrote: > > On Tue Sep 20, 2022 at 4:41 PM AEST, Christophe Leroy wrote: > > > local_paca is declared as global register asm("r13"), it is therefore > > > garantied to always e

Re: [PATCH 1/2] powerpc/pseries: block untrusted device tree changes when locked down

2022-09-23 Thread Nathan Lynch
Paul Moore writes: >> diff --git a/include/linux/security.h b/include/linux/security.h >> index 7bd0c490703d..1ca8dbacd3cc 100644 >> --- a/include/linux/security.h >> +++ b/include/linux/security.h >> @@ -122,6 +122,7 @@ enum lockdown_reason { >> LOCKDOWN_XMON_WR, >> LOCKDOWN_BPF_W

Re: [RFC PATCH 1/2] powerpc: Don't use extable for WARN

2022-09-23 Thread Christophe Leroy
Le 23/09/2022 à 17:41, Nicholas Piggin a écrit : > extable is used for handling user memory access faults from kernel mode, > as such it is a fast-ish path. Using it in the very slow WARN path > increases the number of extable entries from 1306 to 6516 in a > ppc64le_defconfig vmlinux, increasing

[RFC PATCH 2/2] powerpc: nop trap instruction after WARN_ONCE fires

2022-09-23 Thread Nicholas Piggin
WARN_ONCE and similar are often used in frequently executed code, and should not crash the system. The program check interrupt caused by WARN_ON_ONCE can be a significant overhead even when nothing is being printed. This can cause performance to become unacceptable, having the same effective impact

[RFC PATCH 1/2] powerpc: Don't use extable for WARN

2022-09-23 Thread Nicholas Piggin
extable is used for handling user memory access faults from kernel mode, as such it is a fast-ish path. Using it in the very slow WARN path increases the number of extable entries from 1306 to 6516 in a ppc64le_defconfig vmlinux, increasing the average number of search steps by ~2.3. This patch ad

Re: [PATCH 2/2] powerpc/rtas: block error injection when locked down

2022-09-23 Thread Nathan Lynch
Michael Ellerman writes: > Paul Moore writes: >> On Thu, Sep 22, 2022 at 3:38 PM Nathan Lynch wrote: >>> >>> The error injection facility on pseries VMs allows corruption of >>> arbitrary guest memory, potentially enabling a sufficiently privileged >>> user to disable lockdown or perform other m

Re: [PATCH] Revert "ASoC: fsl_audmix: make clock and output src write only"

2022-09-23 Thread Mark Brown
On Tue, Sep 06, 2022 at 02:49:21PM +0800, Shengjiu Wang wrote: > This reverts commit 944c517b8c838832a166f1c89afbf8724f4a6b49. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commi

Re: [PATCH 1/2] powerpc/64s: Fix GENERIC_CPU build flags for PPC970 / G5

2022-09-23 Thread Segher Boessenkool
On Fri, Sep 23, 2022 at 05:17:45PM +1000, Nicholas Piggin wrote: > On Thu Sep 22, 2022 at 4:50 AM AEST, Segher Boessenkool wrote: > > On Wed, Sep 21, 2022 at 11:41:02AM +1000, Nicholas Piggin wrote: > > > Big-endian GENERIC_CPU supports 970, but builds with -mcpu=power5. > > > POWER5 is ISA v2.02 w

Re: [PATCH] powerpc/irq: Modernise inline assembly in irq_soft_mask_{set,return}

2022-09-23 Thread Segher Boessenkool
On Fri, Sep 23, 2022 at 05:08:13PM +1000, Nicholas Piggin wrote: > On Tue Sep 20, 2022 at 4:41 PM AEST, Christophe Leroy wrote: > > local_paca is declared as global register asm("r13"), it is therefore > > garantied to always ever be r13. > > > > It is therefore not required to opencode r13 in the

Re: [PATCH] powerpc/pasemi: Use of_root in pas_pci_init()

2022-09-23 Thread Michael Ellerman
On Tue, 6 Sep 2022 11:03:13 +1000, Michael Ellerman wrote: > Currently in pas_pci_init() a reference to the root node is leaked due > to a missing of_node_put(). Instead just use of_root directly. > > Note that converting to of_find_compatible_node(NULL, ...) would > not be entirely equivalent, be

Re: [PATCH -next] powerpc/powernv: add missing of_node_put() in opal_export_attrs()

2022-09-23 Thread Michael Ellerman
On Tue, 6 Sep 2022 14:17:03 +, Zheng Yongjun wrote: > After using 'np' returned by of_find_node_by_path(), of_node_put() > need be called to decrease the refcount. > > Applied to powerpc/next. [1/1] powerpc/powernv: add missing of_node_put() in opal_export_attrs() https://git.kernel.o

Re: [PATCH v2] powerpc/64s: add pte_needs_flush and huge_pmd_needs_flush

2022-09-23 Thread Michael Ellerman
On Thu, 1 Sep 2022 21:03:34 +1000, Nicholas Piggin wrote: > Allow PTE changes to avoid flushing the TLB when access permissions are > being relaxed, the dirty bit is being set, and the accessed bit is being > changed. > > Relaxing access permissions and setting dirty and accessed bits do not > req

Re: [PATCH][next] powerpc: Fix fall-through warning for Clang

2022-09-23 Thread Michael Ellerman
On Tue, 6 Sep 2022 22:32:13 +0100, Gustavo A. R. Silva wrote: > Fix the following fallthrough warning: > > arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated > fall-through between switch labels [-Wimplicit-fallthrough] > > Applied to powerpc/next. [1/1] powerpc: Fix fall-t

Re: [PATCH] Revert "powerpc/rtas: Implement reentrant rtas call"

2022-09-23 Thread Michael Ellerman
On Wed, 7 Sep 2022 17:01:11 -0500, Nathan Lynch wrote: > At the time this was submitted by Leonardo, I confirmed -- or thought > I had confirmed -- with PowerVM partition firmware development that > the following RTAS functions: > > - ibm,get-xive > - ibm,int-off > - ibm,int-on > - ibm,set-xive >

Re: [PATCH 0/9] Remove unused declarations for powerpc

2022-09-23 Thread Michael Ellerman
On Tue, 13 Sep 2022 15:50:20 +0800, Gaosheng Cui wrote: > This series contains a few cleanup patches, to remove unused > declarations which have been removed. Thanks! > > Gaosheng Cui (9): > powerpc/xmon: remove unused ppc_parse_cpu() declaration > powerpc/spufs: remove orphan declarations fro

Re: [PATCH v1 3/3] checkpatch: warn on usage of VM_BUG_ON() and other BUG variants

2022-09-23 Thread David Hildenbrand
And I think that "Do not crash" is a stronger statement than "Avoid crashing" so I prefer the original suggestion but it's not a big deal either way. Yes, stronger wording is better. So how about this: "Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recove

Re: [PATCH v1 1/3] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel")

2022-09-23 Thread David Hildenbrand
On 23.09.22 04:26, John Hubbard wrote: On 9/20/22 05:23, David Hildenbrand wrote: [1] https://lkml.kernel.org/r/CAHk-=wiEAH+ojSpAgx_Ep=nkpwhu8ado3v56bxccsu97oyj...@mail.gmail.com [2] https://lore.kernel.org/r/CAHk-=wg40eazofo16eviaj7mfqdhz2gvebvfsmf6gyzsprj...@mail.gmail.com [2] https://lkml.

[RESEND PATCH] Revert "ASoC: fsl_audmix: make clock and output src write only"

2022-09-23 Thread Shengjiu Wang
This reverts commit 944c517b8c838832a166f1c89afbf8724f4a6b49. There is error after making clock and output src write only $amixer -c imxaudmix cset numid=1 1 amixer: Cannot read the given element from control sysdefault:3 Which is worse than before, so let's revert the change. Signed-off-by: Sh

[RESEND PATCH] ASoC: fsl_asrc_dma: fully initialize structs

2022-09-23 Thread Shengjiu Wang
From: Sascha Hauer The driver uses two statically ininitialized struct dma_slave_config, but only one of them is initialized to zero. Initialize config_be to zero as well to make sure that no fields are filled with random values. Let the compiler do this instead of explicitly calling memset() whi

Re: [PATCH v2 1/7] ASoC: dt-bindings: fsl_rpmsg: Add a property to assign the rpmsg channel

2022-09-23 Thread Krzysztof Kozlowski
On 23/09/2022 11:56, Chancel Liu wrote: >>> Add a string property to assign the rpmsg channel this sound card sits >>> on. It also represents the name of ASoC platform driver. This property >>> can be omitted if there is only one sound card and it sits on >>> "rpmsg-audio-channel". >>> >>> Signed-o

RE: Re: [PATCH v2 1/7] ASoC: dt-bindings: fsl_rpmsg: Add a property to assign the rpmsg channel

2022-09-23 Thread Chancel Liu
> > Add a string property to assign the rpmsg channel this sound card sits > > on. It also represents the name of ASoC platform driver. This property > > can be omitted if there is only one sound card and it sits on > > "rpmsg-audio-channel". > > > > Signed-off-by: Chancel Liu > > --- > > .../dev

[PATCH] ASoC: fsl_micfil: Add Hardware Voice Activity Detector support

2022-09-23 Thread Shengjiu Wang
The Hardware Voice Activity Detector (HWVAD) is a block responsible for detect voice activity in a channel selected by the user. It can be configured in Envelope-based or Energy-based mode. There are additional two interrupts for HWVAD, one is event interrupt, another is error interrupt. Enable h

[PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()

2022-09-23 Thread Li Huafei
I found a null pointer reference in arch_prepare_kprobe(): # echo 'p cmdline_proc_show' > kprobe_events # echo 'p cmdline_proc_show+16' >> kprobe_events [ 67.278533][ T122] Kernel attempted to read user page (0) - exploit attempt? (uid: 0) [ 67.279326][ T122] BUG: Kernel NULL pointe

[PATCH] ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data()

2022-09-23 Thread Gaosheng Cui
The imx_pcm_dma_params_init_data() are no longer used since commit c31da0b196f9 ("ASoC: imx-ssi: Remove unused driver"), and the function is used to initialize some members of "struct imx_dma_data", it's more readable to assign the value directly, imx_pcm_dma_params_init_data is useless, so remove

Re: [PATCH] powerpc/pseries: Move vas_migration_handler early during migration

2022-09-23 Thread Haren Myneni
On Thu, 2022-09-22 at 07:14 -0500, Nathan Lynch wrote: > Haren Myneni writes: > > When the migration is initiated, the hypervisor changes VAS > > mappings as part of pre-migration event. Then the OS gets the > > migration event which closes all VAS windows before the migration > > starts. NX gener

Re: [PATCH 16/17] powerpc/qspinlock: allow indefinite spinning on a preempted owner

2022-09-23 Thread Nicholas Piggin
On Fri Sep 23, 2022 at 1:02 AM AEST, Laurent Dufour wrote: > On 28/07/2022 08:31:19, Nicholas Piggin wrote: > > Provide an option that holds off queueing indefinitely while the lock > > owner is preempted. This could reduce queueing latencies for very > > overcommitted vcpu situations. > > > > Thi

Re: [PATCH v6 22/25] powerpc/64s: Clear user GPRs in syscall interrupt entry

2022-09-23 Thread Nicholas Piggin
On Wed Sep 21, 2022 at 4:56 PM AEST, Rohan McLure wrote: > Clear user state in gprs (assign to zero) to reduce the influence of user > registers on speculation within kernel syscall handlers. Clears occur > at the very beginning of the sc and scv 0 interrupt handlers, with > restores occurring foll

Re: [PATCH v6 21/25] powerpc: Provide syscall wrapper

2022-09-23 Thread Nicholas Piggin
On Wed Sep 21, 2022 at 4:56 PM AEST, Rohan McLure wrote: > Implement syscall wrapper as per s390, x86, arm64. When enabled > cause handlers to accept parameters from a stack frame rather than > from user scratch register state. This allows for user registers to be > safely cleared in order to reduc

Re: [PATCH v6 20/25] powerpc: Change system_call_exception calling convention

2022-09-23 Thread Nicholas Piggin
On Wed Sep 21, 2022 at 4:56 PM AEST, Rohan McLure wrote: > Change system_call_exception arguments to pass a pointer to a stack frame > container caller state, as well as the original r0, which determines the > number of the syscall. This has been observed to yield improved performance > to passing

Re: [PATCH v3 1/4] drm/ofdrm: Add ofdrm for Open Firmware framebuffers

2022-09-23 Thread Thomas Zimmermann
Hi Geert Am 23.09.22 um 09:14 schrieb Geert Uytterhoeven: Hi Thomas, On Thu, Sep 22, 2022 at 1:33 PM Thomas Zimmermann wrote: Open Firmware provides basic display output via the 'display' node. DT platform code already provides a device that represents the node's framebuffer. Add a DRM driver

Re: [PATCH v6 19/25] powerpc: Remove high-order word clearing on compat syscall entry

2022-09-23 Thread Nicholas Piggin
On Wed Sep 21, 2022 at 4:55 PM AEST, Rohan McLure wrote: > Remove explicit clearing of the high order-word of user parameters when > handling compatibility syscalls in system_call_exception. The > COMPAT_SYSCALL_DEFINEx macros handle this clearing through an > explicit cast to the signature type of

Re: [RFC PATCH 1/7] powerpc: use 16-bit immediate for STACK_FRAME_REGS_MARKER

2022-09-23 Thread Christophe Leroy
Le 23/09/2022 à 09:32, Michael Ellerman a écrit : > Christophe Leroy writes: >> Le 19/09/2022 à 16:01, Nicholas Piggin a écrit : >>> Using a 16-bit constant for this marker allows it to be loaded with >>> a single 'li' instruction. On 64-bit this avoids a TOC entry and a >>> TOC load that depend

Re: [RFC PATCH 1/7] powerpc: use 16-bit immediate for STACK_FRAME_REGS_MARKER

2022-09-23 Thread Michael Ellerman
Christophe Leroy writes: > Le 19/09/2022 à 16:01, Nicholas Piggin a écrit : >> Using a 16-bit constant for this marker allows it to be loaded with >> a single 'li' instruction. On 64-bit this avoids a TOC entry and a >> TOC load that depends on the r2 value that has just been loaded from >> the PA

Re: [RFC PATCH 5/7] powerpc/64s: update generic cpu option name and compiler flags

2022-09-23 Thread Nicholas Piggin
On Thu Sep 22, 2022 at 1:22 AM AEST, Segher Boessenkool wrote: > Hi! > > On Wed, Sep 21, 2022 at 11:01:18AM +1000, Nicholas Piggin wrote: > > On Wed Sep 21, 2022 at 8:16 AM AEST, Segher Boessenkool wrote: > > > On Tue, Sep 20, 2022 at 12:01:47AM +1000, Nicholas Piggin wrote: > > > > Update the 64s

Re: [PATCH v3 4/4] drm/ofdrm: Support color management

2022-09-23 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Sep 22, 2022 at 1:33 PM Thomas Zimmermann wrote: > Support the CRTC's color-management property and implement each model's > palette support. > > The OF hardware has different methods of setting the palette. The > respective code has been taken from fbdev's offb and refactored

Re: [PATCH 1/2] powerpc/64s: Fix GENERIC_CPU build flags for PPC970 / G5

2022-09-23 Thread Nicholas Piggin
On Thu Sep 22, 2022 at 4:50 AM AEST, Segher Boessenkool wrote: > On Wed, Sep 21, 2022 at 11:41:02AM +1000, Nicholas Piggin wrote: > > Big-endian GENERIC_CPU supports 970, but builds with -mcpu=power5. > > POWER5 is ISA v2.02 whereas 970 is v2.01 plus Altivec. 2.02 added > > the popcntb instruction

Re: [PATCH v3 1/4] drm/ofdrm: Add ofdrm for Open Firmware framebuffers

2022-09-23 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Sep 22, 2022 at 1:33 PM Thomas Zimmermann wrote: > Open Firmware provides basic display output via the 'display' node. > DT platform code already provides a device that represents the node's > framebuffer. Add a DRM driver for the device. The display mode and > color format is

Re: [PATCH 2/2] powerpc/rtas: block error injection when locked down

2022-09-23 Thread Michael Ellerman
Paul Moore writes: > On Thu, Sep 22, 2022 at 3:38 PM Nathan Lynch wrote: >> >> The error injection facility on pseries VMs allows corruption of >> arbitrary guest memory, potentially enabling a sufficiently privileged >> user to disable lockdown or perform other modifications of the running >> ke

Re: [PATCH] powerpc/irq: Modernise inline assembly in irq_soft_mask_{set,return}

2022-09-23 Thread Nicholas Piggin
On Tue Sep 20, 2022 at 4:41 PM AEST, Christophe Leroy wrote: > local_paca is declared as global register asm("r13"), it is therefore > garantied to always ever be r13. > > It is therefore not required to opencode r13 in the assembly, use > a reference to local_paca->irq_soft_mask instead. > > This

Re: [PATCH 1/2] powerpc/pseries: block untrusted device tree changes when locked down

2022-09-23 Thread Michael Ellerman
Paul Moore writes: > On Thu, Sep 22, 2022 at 3:38 PM Nathan Lynch wrote: >> >> The /proc/powerpc/ofdt interface allows the root user to freely alter >> the in-kernel device tree, enabling arbitrary physical address writes >> via drivers that could bind to malicious device nodes, thus making it >>