Re: [PATCH v3 1/3] mm/migrate_device.c: Flush TLB while holding PTL

2022-08-24 Thread Huang, Ying
Alistair Popple writes: > When clearing a PTE the TLB should be flushed whilst still holding the > PTL to avoid a potential race with madvise/munmap/etc. For example > consider the following sequence: > > CPU0 CPU1 > > > migrate_vm

Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-24 Thread Alistair Popple
Alistair Popple writes: > Peter Xu writes: >>> But it's kind of against a pure "optimization" in that if trylock failed, >>> we'll clear the mpfn so the src[i] will be zero at last. Then will we >>> directly give up on this page, or will we try to lock_page() again >>> somewhere? > > That co

Re: [PATCH 2/2] powerpc/rtas: Fix RTAS MSR[HV] handling for Cell

2022-08-24 Thread Jordan Niethe
On Wed, 2022-08-24 at 22:04 +1000, Michael Ellerman wrote: > Jordan Niethe writes: > > On Tue, 2022-08-23 at 21:59 +1000, Michael Ellerman wrote: > > > The semi-recent changes to MSR handling when entering RTAS (firmware) > > > cause crashes on IBM Cell machines. An example trace: > ... > > > diff

Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-24 Thread Alistair Popple
Peter Xu writes: > On Wed, Aug 24, 2022 at 04:25:44PM -0400, Peter Xu wrote: >> On Wed, Aug 24, 2022 at 11:56:25AM +1000, Alistair Popple wrote: >> > >> Still I don't know whether there'll be any side effect of having stall >> > >> tlbs >> > >> in !present ptes because I'm not familiar enough

[Bug 216156] kmemleak: Not scanning unknown object at 0xc00000007f000000

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216156 --- Comment #5 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301654 --> https://bugzilla.kernel.org/attachment.cgi?id=301654&action=edit kernel .config (6.0-rc2, PowerMac G5 11,2) -- You may reply to this email to add a comment.

[Bug 216156] kmemleak: Not scanning unknown object at 0xc00000007f000000

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216156 --- Comment #4 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301653 --> https://bugzilla.kernel.org/attachment.cgi?id=301653&action=edit dmesg (6.0-rc2, PowerMac G5 11,2) Reinvestigating on v6.0-rc2. kmemleak does no longer show

[Bug 216410] WARNING: inconsistent lock state, "inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage" at boot

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216410 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #301650|0 |1 is obsolete|

[Bug 216410] WARNING: inconsistent lock state, "inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage" at boot

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216410 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #301649|0 |1 is obsolete|

[Bug 216410] WARNING: inconsistent lock state, "inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage" at boot

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216410 --- Comment #1 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301650 --> https://bugzilla.kernel.org/attachment.cgi?id=301650&action=edit kernel .config (6.0-rc2, PowerMac G5 11,2) -- You may reply to this email to add a comment.

[Bug 216410] New: WARNING: inconsistent lock state, "inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage" at boot

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216410 Bug ID: 216410 Summary: WARNING: inconsistent lock state, "inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage" at boot Product: Platform Specific/Hardware Version: 2.5 Kernel Ve

Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-24 Thread Peter Xu
On Wed, Aug 24, 2022 at 04:25:44PM -0400, Peter Xu wrote: > On Wed, Aug 24, 2022 at 11:56:25AM +1000, Alistair Popple wrote: > > >> Still I don't know whether there'll be any side effect of having stall > > >> tlbs > > >> in !present ptes because I'm not familiar enough with the private dev > > >

Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-24 Thread Peter Xu
On Wed, Aug 24, 2022 at 11:56:25AM +1000, Alistair Popple wrote: > >> Still I don't know whether there'll be any side effect of having stall tlbs > >> in !present ptes because I'm not familiar enough with the private dev swap > >> migration code. But I think having them will be safe, even if redun

[Bug 216407] OF: unittest fails some tests on ppc and ppc64 (### dt-test ### end of unittest - 266 passed, 6 failed)

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216407 --- Comment #3 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301648 --> https://bugzilla.kernel.org/attachment.cgi?id=301648&action=edit kernel .config (kernel 6.0-rc2, PowerMac G4 DP) -- You may reply to this email to add a com

[Bug 216407] OF: unittest fails some tests on ppc and ppc64 (### dt-test ### end of unittest - 266 passed, 6 failed)

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216407 --- Comment #2 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301647 --> https://bugzilla.kernel.org/attachment.cgi?id=301647&action=edit kernel .config (kernel 6.0-rc2, Talos II) -- You may reply to this email to add a comment.

[Bug 216407] OF: unittest fails some tests on ppc and ppc64 (### dt-test ### end of unittest - 266 passed, 6 failed)

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216407 --- Comment #1 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301646 --> https://bugzilla.kernel.org/attachment.cgi?id=301646&action=edit dmesg (kernel 6.0-rc2, PowerMac G4 DP) -- You may reply to this email to add a comment. Yo

[Bug 216407] New: OF: unittest fails some tests on ppc and ppc64 (### dt-test ### end of unittest - 266 passed, 6 failed)

2022-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216407 Bug ID: 216407 Summary: OF: unittest fails some tests on ppc and ppc64 (### dt-test ### end of unittest - 266 passed, 6 failed) Product: Platform Specific/Hardware Version: 2.5 K

Re: [PATCH v3 2/3] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-24 Thread Peter Xu
On Wed, Aug 24, 2022 at 01:03:38PM +1000, Alistair Popple wrote: > migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that > installs migration entries directly if it can lock the migrating page. > When removing a dirty pte the dirty bit is supposed to be carried over > to the underly

Re: [PATCH 2/2] powerpc/82xx: remove spidev node from mgcoge

2022-08-24 Thread Krzysztof Kozlowski
On 24/08/2022 11:21, Wolfram Sang wrote: > Commit 956b200a846e ("spi: spidev: Warn loudly if instantiated from DT > as "spidev"") states that there should not be spidev nodes in DTs. > Remove this non-HW description. There won't be a regression because it > won't bind since 2015 anyhow. > > Fixes:

Re: [PATCH v3 1/3] mm/migrate_device.c: Flush TLB while holding PTL

2022-08-24 Thread David Hildenbrand
On 24.08.22 14:26, Alistair Popple wrote: > > David Hildenbrand writes: > >> On 24.08.22 05:03, Alistair Popple wrote: >>> When clearing a PTE the TLB should be flushed whilst still holding the >>> PTL to avoid a potential race with madvise/munmap/etc. For example >>> consider the following sequ

Re: [PATCH v3 1/3] mm/migrate_device.c: Flush TLB while holding PTL

2022-08-24 Thread Alistair Popple
David Hildenbrand writes: > On 24.08.22 05:03, Alistair Popple wrote: >> When clearing a PTE the TLB should be flushed whilst still holding the >> PTL to avoid a potential race with madvise/munmap/etc. For example >> consider the following sequence: >> >> CPU0 CPU1 >>

Re: [PATCH 2/2] powerpc/rtas: Fix RTAS MSR[HV] handling for Cell

2022-08-24 Thread Michael Ellerman
Jordan Niethe writes: > On Tue, 2022-08-23 at 21:59 +1000, Michael Ellerman wrote: >> The semi-recent changes to MSR handling when entering RTAS (firmware) >> cause crashes on IBM Cell machines. An example trace: ... >> diff --git a/arch/powerpc/kernel/rtas_entry.S >> b/arch/powerpc/kernel/rtas_e

Re: [PATCH] powerpc/boot: Fix compilation of uImage for e500 platforms

2022-08-24 Thread Pali Rohár
On Tuesday 23 August 2022 16:57:34 Christophe Leroy wrote: > Le 20/08/2022 à 12:52, Pali Rohár a écrit : > > Commit 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU") > > broke compilation of uImage target for mpc85xx platforms by powerpc e500 > > SPE capable cross compilers. After

Re: [PATCH] misc: ocxl: fix possible refcount leak in afu_ioctl()

2022-08-24 Thread Frederic Barrat
On 24/08/2022 10:26, Hangyu Hua wrote: eventfd_ctx_put need to be called to put the refcount that gotten by eventfd_ctx_fdget when ocxl_irq_set_handler fails. Fixes: 060146614643 ("ocxl: move event_fd handling to frontend") Signed-off-by: Hangyu Hua --- Thanks for fixing it! LGTM Acked-b

[PATCH] misc: ocxl: fix possible refcount leak in afu_ioctl()

2022-08-24 Thread Hangyu Hua
eventfd_ctx_put need to be called to put the refcount that gotten by eventfd_ctx_fdget when ocxl_irq_set_handler fails. Fixes: 060146614643 ("ocxl: move event_fd handling to frontend") Signed-off-by: Hangyu Hua --- drivers/misc/ocxl/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dr

Re: [PATCH v3 1/3] mm/migrate_device.c: Flush TLB while holding PTL

2022-08-24 Thread David Hildenbrand
On 24.08.22 05:03, Alistair Popple wrote: > When clearing a PTE the TLB should be flushed whilst still holding the > PTL to avoid a potential race with madvise/munmap/etc. For example > consider the following sequence: > > CPU0 CPU1 >

[PATCH 0/2] spi: remove "spidev" nodes from DTs

2022-08-24 Thread Wolfram Sang
There were two DTs left specifying "spidev" directly. Remove them. Wolfram Sang (2): ARM: dts: stm32: argon: remove spidev node powerpc/82xx: remove spidev node from mgcoge arch/arm/boot/dts/stm32mp157c-emstamp-argon.dtsi | 6 -- arch/powerpc/boot/dts/mgcoge.dts | 7 -

[PATCH 2/2] powerpc/82xx: remove spidev node from mgcoge

2022-08-24 Thread Wolfram Sang
Commit 956b200a846e ("spi: spidev: Warn loudly if instantiated from DT as "spidev"") states that there should not be spidev nodes in DTs. Remove this non-HW description. There won't be a regression because it won't bind since 2015 anyhow. Fixes: 5d1d67e361ea ("powerpc/82xx: add SPI support for mgc