Re: [PATCH v2 05/14] powerpc: Use generic fallocate compatibility syscall

2022-08-07 Thread Rohan McLure
>> --- a/arch/powerpc/kernel/asm-offsets.c >> +++ b/arch/powerpc/kernel/asm-offsets.c >> @@ -9,6 +9,7 @@ >> * #defines from the assembly-language output. >> */ >> >> +#include > > What's this for? Good spot.

Re: [PATCH v2 01/14] powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers

2022-08-07 Thread Rohan McLure
Thanks for reviewing my patches. > I think this patch should be split in two patches. One where you just > change to using SYSCALL_DEFINE and COMPAT_SYSCALL_DEFINE, and a second > patch for everything else. > > The first patch could then be linked to > https://github.com/linuxppc/issues/issues

Re: [PATCH v4 3/8] dt-bindings: clock: Add ids for Lynx 10g PLLs

2022-08-07 Thread Krzysztof Kozlowski
On 05/08/2022 17:17, Sean Anderson wrote: > > > On 8/5/22 2:53 AM, Krzysztof Kozlowski wrote: >> On 05/08/2022 00:05, Sean Anderson wrote: >>> This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used >>> witn assigned-clock* to specify a particular frequency to use. >>> >>> Signed

Re: [PATCH v2 07/14] powerpc: Enable compile-time check for syscall handlers

2022-08-07 Thread Andrew Donnellan
On Mon, 2022-07-25 at 16:28 +1000, Rohan McLure wrote: > The table of syscall handlers and registered compatibility syscall > handlers has in past been produced using assembly, with function > references resolved at link time. This moves link-time errors to > compile-time, by rewriting systbl.S in

Re: [PATCH v2 06/14] powerpc: Include all arch-specific syscall prototypes

2022-08-07 Thread Andrew Donnellan
On Mon, 2022-07-25 at 16:27 +1000, Rohan McLure wrote: > Forward declare all syscall handler prototypes where a generic > prototype > is not provided in either linux/syscalls.h or linux/compat.h in > asm/syscalls.h. This is required for compile-time type-checking for > syscall handlers, which is im

Re: [PATCH v2 13/14] powerpc/64s: Fix comment on interrupt handler prologue

2022-08-07 Thread Andrew Donnellan
On Mon, 2022-07-25 at 16:31 +1000, Rohan McLure wrote: > Interrupt handlers on 64s systems will often need to save register > state > from the interrupted process to make space for loading special > purpose > registers or for internal state. > > Fix a comment documenting a common code path macro i

Re: [PATCH v2 05/14] powerpc: Use generic fallocate compatibility syscall

2022-08-07 Thread Andrew Donnellan
On Mon, 2022-07-25 at 16:26 +1000, Rohan McLure wrote: > The powerpc fallocate compat syscall handler is identical to the > generic implementation provided by commit 59c10c52f573f ("riscv: > compat: syscall: Add compat_sys_call_table implementation"), and as > such can be removed in favour of the g

Re: [PATCH v2 04/14] powerpc/32: Remove powerpc select specialisation

2022-08-07 Thread Andrew Donnellan
On Mon, 2022-07-25 at 16:26 +1000, Rohan McLure wrote: > Syscall #82 has been implemented for 32-bit platforms in a unique way > on > powerpc systems. This hack will in effect guess whether the caller is > expecting new select semantics or old select semantics. It does so > via a > guess, based off

Re: [PATCH v2 03/14] powerpc: Remove direct call to mmap2 syscall handlers

2022-08-07 Thread Andrew Donnellan
On Mon, 2022-07-25 at 16:25 +1000, Rohan McLure wrote: > > diff --git a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > index 54bb5834785f..437066f5c4b2 100644 > --- a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > +++ b/tools/perf/

[PATCH v5 25/32] powerpc: Convert to printbuf

2022-08-07 Thread Matthew Wilcox (Oracle)
From: Kent Overstreet This converts from seq_buf to printbuf. We're using printbuf in external buffer mode, so it's a direct conversion, aside from some trivial refactoring in cpu_show_meltdown() to make the code more consistent. Signed-off-by: Kent Overstreet Cc: linuxppc-dev@lists.ozlabs.org