[PATCH] KVM: PPC: Fix comment typo

2022-07-17 Thread Jason Wang
The double `that' in line 1604 is duplicated, removed one. Signed-off-by: Jason Wang --- arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index 514fd45c1994..73c6db20

Re: [PATCH v2] random: handle archrandom in plural words

2022-07-17 Thread Gabriel Paubert
On Mon, Jul 18, 2022 at 04:31:11PM +1000, Michael Ellerman wrote: > "Jason A. Donenfeld" writes: > > The archrandom interface was originally designed for x86, which supplies > > RDRAND/RDSEED for receiving random words into registers, resulting in > > one function to generate an int and another to

BUG xfs_buf while running tests/xfs/435 (next-20220715)

2022-07-17 Thread Sachin Sant
While running xfstests (specifically xfs/435) on a IBM Power server booted with 5.19.0-rc6-next-20220715 following warnings are seen: [ 110.954136] XFS (sdb2): Unmounting Filesystem [ 110.968860] XFS (sdb1): Unmounting Filesystem [ 111.115807] =

Re: [PATCH v2] random: handle archrandom in plural words

2022-07-17 Thread Michael Ellerman
"Jason A. Donenfeld" writes: > The archrandom interface was originally designed for x86, which supplies > RDRAND/RDSEED for receiving random words into registers, resulting in > one function to generate an int and another to generate a long. However, > other architectures don't follow this. > > On

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Michael Ellerman
Sudip Mukherjee writes: > On Thu, Jul 14, 2022 at 9:55 AM Sudip Mukherjee (Codethink) > wrote: >> >> Hi All, >> >> Not sure if it has been reported before but the latest mainline kernel >> branch fails to build for powerpc allmodconfig with gcc-12 and the error is: >> >> Error: External symbol 'm

Re: [PATCH v2 1/2] asm-generic: Remove pci.h copying remaining code to x86

2022-07-17 Thread Christoph Hellwig
On Sun, Jul 17, 2022 at 12:34:52PM +0900, Stafford Horne wrote: > The generic pci.h header now only provides a definition of > pci_get_legacy_ide_irq which is used by architectures that support PNP. > Of the architectures that use asm-generic/pci.h this is only x86. Please move this into a separat

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Michael Ellerman
Segher Boessenkool writes: > On Sun, Jul 17, 2022 at 07:44:22AM -0700, Linus Torvalds wrote: >> On Sun, Jul 17, 2022 at 2:13 AM Sudip Mukherjee >> wrote: >> > I was trying to check it. With gcc-11 the assembly code generated is >> > not using memset, but using __memset. >> > But with gcc-12, I ca

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Linus Torvalds
On Sun, Jul 17, 2022 at 2:49 PM Segher Boessenkool wrote: > > > I can *kind of* see the logic that when you do a whole struct > > assignment, it turns into a "memcpy" without regard for volatile > > members. You're not actually accessing the volatile members in some > > particular order, so the st

[PATCH v3 1/2] asm-generic: Remove pci.h copying remaining code to x86

2022-07-17 Thread Stafford Horne
The generic pci.h header now only provides a definition of pci_get_legacy_ide_irq which is used by architectures that support PNP. Of the architectures that use asm-generic/pci.h this is only x86. This patch removes the old pci.h in order to make room for a new pci.h to be used by arm64, riscv, op

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-17 Thread Pavel Machek
Hi! > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors a

Re: [PATCH v2 1/2] asm-generic: Remove pci.h copying remaining code to x86

2022-07-17 Thread Stafford Horne
On Sun, Jul 17, 2022, 6:23 PM Geert Uytterhoeven wrote: > Hi Stafford, > > On Sun, Jul 17, 2022 at 5:35 AM Stafford Horne wrote: > > The generic pci.h header now only provides a definition of > > pci_get_legacy_ide_irq which is used by architectures that support PNP. > > Of the architectures tha

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Segher Boessenkool
On Sun, Jul 17, 2022 at 02:11:52PM -0700, Linus Torvalds wrote: > On Sun, Jul 17, 2022 at 2:00 PM Segher Boessenkool > wrote: > > Calling mem* on a volatile object (or a struct containing one) is not > > valid. I opened gcc.gnu.org/PR106335. > > Well, that very quickly got marked as a duplicate

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Linus Torvalds
On Sun, Jul 17, 2022 at 2:00 PM Segher Boessenkool wrote: > > Calling mem* on a volatile object (or a struct containing one) is not > valid. I opened gcc.gnu.org/PR106335. Well, that very quickly got marked as a duplicate of a decade-old bug. So I guess we shouldn't expect this to be fixed any

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Segher Boessenkool
On Sun, Jul 17, 2022 at 01:29:07PM -0700, Linus Torvalds wrote: > On Sun, Jul 17, 2022 at 1:25 PM Sudip Mukherjee > wrote: > > > > And the generated assembly still has the memset for "struct prom_args". > > Strange. That smells like a compiler bug to me. > > But I can't read powerpc assembly cod

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Linus Torvalds
On Sun, Jul 17, 2022 at 1:38 PM Sudip Mukherjee wrote: > > I have also tried adding volatile to all the members of that struct. :( Can you read the code to figure otu what the memcpy is all about? Or maybe there is something that disables 'volatile' with pre-processor hackery. Because a compil

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Sudip Mukherjee
On Sun, Jul 17, 2022 at 9:29 PM Linus Torvalds wrote: > > On Sun, Jul 17, 2022 at 1:25 PM Sudip Mukherjee > wrote: > > > > And the generated assembly still has the memset for "struct prom_args". > > Strange. That smells like a compiler bug to me. Both gcc-12 and clang gives this error. > > But

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Linus Torvalds
On Sun, Jul 17, 2022 at 1:25 PM Sudip Mukherjee wrote: > > And the generated assembly still has the memset for "struct prom_args". Strange. That smells like a compiler bug to me. But I can't read powerpc assembly code - it's been too many years, and even back when I did read it I hated how the r

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Sudip Mukherjee
On Sun, Jul 17, 2022 at 3:44 PM Linus Torvalds wrote: > > On Sun, Jul 17, 2022 at 2:13 AM Sudip Mukherjee > wrote: > > > > I was trying to check it. With gcc-11 the assembly code generated is > > not using memset, but using __memset. > > But with gcc-12, I can see the assembly code is using memse

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Segher Boessenkool
On Sun, Jul 17, 2022 at 07:44:22AM -0700, Linus Torvalds wrote: > On Sun, Jul 17, 2022 at 2:13 AM Sudip Mukherjee > wrote: > > I was trying to check it. With gcc-11 the assembly code generated is > > not using memset, but using __memset. > > But with gcc-12, I can see the assembly code is using me

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Linus Torvalds
On Sun, Jul 17, 2022 at 2:13 AM Sudip Mukherjee wrote: > > I was trying to check it. With gcc-11 the assembly code generated is > not using memset, but using __memset. > But with gcc-12, I can see the assembly code is using memset. One > example from the assembly: You could try making the 'args'

Re: [PATCH v2 1/2] asm-generic: Remove pci.h copying remaining code to x86

2022-07-17 Thread Geert Uytterhoeven
Hi Stafford, On Sun, Jul 17, 2022 at 5:35 AM Stafford Horne wrote: > The generic pci.h header now only provides a definition of > pci_get_legacy_ide_irq which is used by architectures that support PNP. > Of the architectures that use asm-generic/pci.h this is only x86. > > This patch removes the

Re: mainline build failure of powerpc allmodconfig for prom_init_check

2022-07-17 Thread Sudip Mukherjee
On Thu, Jul 14, 2022 at 9:55 AM Sudip Mukherjee (Codethink) wrote: > > Hi All, > > Not sure if it has been reported before but the latest mainline kernel > branch fails to build for powerpc allmodconfig with gcc-12 and the error is: > > Error: External symbol 'memset' referenced from prom_init.c >